- Mar 14, 2023
-
-
Torben Hansen authored
This change cleans up parts of ext:lowlevel by * using constructor property promotion where possible * using typesafe comparison for command option `dry-run` * removing superfluous typehints in doc headers * adding missing typehints in doc headers * using strict comparison where possible * adding function parameter type declaration where suitable * adding missing function return types * fixing a typo in `ProviderRegistry` Resolves: #100158 Releases: main Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: I9a3cbf09652d1fec586f89965569c7d087bc7aa0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78110 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Andreas Fernandez authored
The result container in LiveSearch used to use `TYPO3.Backend` to access the righthand module container of the TYPO3 backend scaffold, which is bad practice as the dependency is defined somewhere. It's better to explicitly import the `Viewport` module, providing the same functionality. Resolves: #100125 Releases: main Change-Id: I139b26370739d568b190ef7375527e491086a694 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78078 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Oliver Klee authored
Function callbacks are declared using the new PHP 8.1 feature "first class callable", which e.g. uses the named `trim(...)` function symbol, instead of the string `'trim'`. see https://www.php.net/manual/en/functions.first_class_callable_syntax.php Resolves: #100144 Releases: main Change-Id: I708f86e022e397f3fcf32596043336b430e9c9ef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78097 Reviewed-by:
-
Christian Kuhn authored
Having an invalid wildcard import to a not existing directory should not raise a "No such file or directory" PHP warning: @import 'EXT:sitepackage/.../NonExistingFolder/*.tsconfig' Resolves: #100121 Releases: main Change-Id: Ice567b27cfd78c166e2de2e61801fc8c02cf8a72 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78125 Tested-by:
-
Torben Hansen authored
Custom TYPO3 authentication services can now directly access the PSR-7 Request object via the $authInfo array, handed over to the initAuth() method of those services. This therefore allows to further reduce usages of PHP super globals and `GeneralUtility::getIndpEnv()`. Resolves: #100116 Releases: main Signed-off-by:
-
Benjamin Kott authored
Releases: main Resolves: #100163 Change-Id: Id4f8d3f871e6b2c2ae02fb6ee6ed114bc5d3da01 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78118 Tested-by:
-
Christoph Lehmann authored
Hand over the overlayed page record from PageRepository::getSubpagesForPages() to the PageLinkBuilder in order to not fetch and overlay the target page twice. This reduces the amount of SQL queries when building menus. Resolves: #99612 Releases: main Change-Id: Ibb4505f9a5bf95594506730bb988dacdc27046ff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77387 Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
-
Chris Müller authored
With the introduction of the new country API and the correspodning Fluid form viewhelper in #99618, is the form framework extendend for a new form element "country select". The form element allows several configuration options and renderes a single select element in the frontend, using the corresponding form viewhelper. Following configuration options are available: - First option: Defines the "empty option", i.e. the first element of the select. - Prioritized countries: Defines a list of countries, which should be listed on top. - Only countries: Defines the countries to be shown in the select list. - Exclude countries: Defines the countries not to be shown in the list. Resolves: #99735 Releases: main Change-Id: I27f135bb38ba727d25fb6bdc684555972f1e8f1b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77623 Tested-by:
-
jakotadesigngroup authored
Resolves: #100131 Releases: main, 11.5 Change-Id: If23bfd25f95b328bee8227003e7983ef17f61dfb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78083 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Chris Müller <typo3@krue.ml> Reviewed-by:
-
Oliver Klee authored
Also add the missing types and correctly use intersection types. Also reorder the type declarations for consistency. Also drop superfluous type annotations. Resolves: #100139 Releases: main Change-Id: I6b5337a0e02f36be84ff28a861c2afa58341093a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78091 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Alexander Schnitzler authored
- Introduce type declarations - Enhance type information for phpstan/psalm - Use modern PHP syntax in some places - Refactor redundancies Releases: main Resolves: #100120 Change-Id: Ia2a018c589b131980b09246ffd3730b322bddc1d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78073 Tested-by:
-
Thomas Hohn authored
The logging in the method set_no_cache should not depend on the calling parameter $internal. Instead it should be notice in both cases. Since it's possible to change the general log level during development or debugging the entries will still be visible, just not on production systems which makes good sense. In addition the variable $internal was renamed to $internalRequest in order to make the purpose clearer. Resolves: #100067 Related: #97815 Releases: main, 11.5 Change-Id: I59af542e22c2a6ad65ad42e0fc3d2c64f0408f76 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78010 Tested-by:
-
Thomas Hohn authored
Added some guards, isset(), to ensure that array keys that aren't defined are accessed and throws PHP warnings. Resolves: #99845 Releases: main, 11.5 Change-Id: I009f5d23a9bf3cd112dc786256d1144983736dd3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78041 Tested-by:
-
Christian Eßl authored
When opening a page in the view module, that belongs to a page tree with no valid site configuration, an exception was thrown, because the ModuleData clean-method was expecting at least one item in the language array. Resolves: #100092 Releases: main Change-Id: I60ae316e29ec87d62ba8728103283bbe0778f0c8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78032 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Oliver Klee authored
Now the parameter names are consistent with those of the other explode-related methods. Resolves: #100145 Releases: main Change-Id: Ibd8fd736741a8f1cdad2e33ae3e777412cd383eb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78098 Reviewed-by:
Josef Glatz <typo3@josefglatz.at> Tested-by:
-
Thomas Hohn authored
The constructor of UnableToLinkException should be strictly typed, since the method getLinkText() is strictly typed. Also make the variable declaration of $linkText strictly typed. It will throw an error if $linkText isn't a string. Added a todo for TYPO3 v13. Resolves: #100119 Related: #100106 Releases: main Change-Id: Ifbb9a3f5b4aa1fd1588eb0596731377f41bc5ffd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78072 Tested-by:
-
Sybille Peters authored
Use alt text "Logo" (instead of "TYPO3 Logo") in the SystemEmail Fluid layout if a custom logo is used. The layout SystemEmail is used by default when sending Fluid emails. It is for example used when sending a test email via the "Environment" module in the install tool or "Admin Tools" in the backend. If an image is configured in the backend Extension Configuration login.loginLogo, this image is used and the text is added as alt text. Previously, "TYPO3 Logo" was always used as alt text, which is awkward if the alt text is displayed instead of the logo, which may happen for several reasons Resolves: #100081 Releases: main, 11.5 Change-Id: Ia7c1d7ab7a008fb6ed2f3851db5e1af171a4af9f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78023 Tested-by:
-
Helmut Hummel authored
Instead of requiring strictly the TYPO3 implementation of a console Application, the property is allowed to hold an instance of the base application class. Releases: main Resolves: #100160 Change-Id: I40934ac7a5534f211021b0ab331ca9903a307243 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78116 Reviewed-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
- Mar 13, 2023
-
-
Torben Hansen authored
This change adds a native type declaration for the property `$contentFields` in `ContentVisibleFieldsTest`. Resolves: #100149 Releases: main Signed-off-by:
-
Stefan Bürk authored
Creating new `ext:reactions` records are broken and emits an sql error message. This happens when it's tried to switch to the core-shipped type. >> 2: SQL error: "Field 'fields' doesn't have a default value" Using a default value on database level does not work with all database backends TYPO3 v12 officially supports, which has been tried with #100088 and mitigated with #100101. So that's not an option here. This change bakes the default value for `json` type fields using TCA default setting again, which has been the way the original `type=user dbType=JSON` variant used with #99226. Resolves: #100154 Related: #100101 Related: #100088 Related: #99226 Related: #99062 Releases: main Change-Id: I07533f36cfbc1f627b14727195bbcbd5c4b1e35c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78107 Tested-by:
Frank Nägler <frank.naegler@typo3.com> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
Torben Hansen authored
This change adds constructor property promotion in ext:opendocs `OpenDocumentController`. Resolves: #100150 Releases: main Signed-off-by:
-
Sybille Peters authored
The PHPDoc block in the ViewHelper source is used to render the ViewHelper documentation. Remove link to Changelog with incorrect formatting in asset.css ViewHelper, which never worked. As the Changelog is from version 10.4, there is little benefit and more risk of linking to outdated information in the future. Resolves: #100151 Releases: main, 11.5, 10.4 Change-Id: I0b11e7ec90ccfa8864ca4ddaa7ca83004fe266c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78105 Tested-by:
-
- Mar 10, 2023
-
-
Oliver Klee authored
Also fix some types as needed. Resolves: #100134 Releases: main Change-Id: I87cebe0a3a7e3cb97a9a1802640ed856d7939f39 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78085 Reviewed-by:
-
Alexander Schnitzler authored
Releases: main Resolves: #100068 Change-Id: Ibc06f9c6b227f956290e02cc9bbd44587bac6f78 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77851 Reviewed-by:
-
Torben Hansen authored
The cookie warning message in ext:felogin depends on conditions which are never met and can not be fixed easily. Additionally, failed authentication in ext:felogin already shows a similar message, so the non-working cookie message can safely be removed. This change removes code affecting the non-working cookie warning message. Resolves: #100135 Related: #99710 Releases: main Signed-off-by:
Oliver Hader <oliver.hader@typo3.org>
-
Christian Eßl authored
Fix a missing type cast, where on creating a site with only a digit number as identifier, both the backend and frontend would throw a type error. Resolves: #100083 Releases: main Change-Id: Ic91d45390449bf7a71779570bd89812fdfd33145 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78025 Tested-by:
-
Alexander Schnitzler authored
Extbase creates class schema objects for classes to gather information for further analysis. One part of that information is property types. In recent TYPO3 and PHP versions, extbase did expect a property to have zero or one type. Due to changes to PHP (Union Types/Intersection Types), extbase's internal behaviour needs to change and detect all declared types. This is especially useful in models whose properties can now be declared as public Entity|LazyLoadingProxy|null $reference = null; Releases: main Resolves: #98132 Change-Id: I36dd8fd3d152e8dbf0443a5a1866c444d6fecbd0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75417 Tested-by:
Stefan Froemken <froemken@gmail.com> Reviewed-by:
-
- Mar 09, 2023
-
-
Oliver Klee authored
This version removes some false positives from the baseline. > composer req --dev phpstan/phpstan:^1.10.6 > composer req --dev phpstan/phpstan-phpunit:^1.3.10 > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #100133 Releases: main, 11.5 Change-Id: I1120a6b808baff1af8993ca700725b09987e76ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78084 Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Andreas Fernandez authored
There was a timing issue related to the LiveSearch form. `Modal.advanced()` invokes an AJAX request, while the event handler for `typo3-modal-shown` expects that the request sent a response. This might not be the case when either the network is slow or animations are disabled as the event is always faster dispatched than the request can send a response. The generic handling is now moved into an `ajaxCallback`, executed when fetching the data finished. To be able to still focus the search field and mark its content, event handlers for 'modal-loaded' and 'typo3-modal-shown' events are installed, as both events may be dispatched in any order. Resolves: #100025 Releases: main Change-Id: I8aca8ba330af55ce915a414dc5a52ba6eb2af1f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77941 Tested-by:
-
Oliver Klee authored
For variable arguments, the type annotation needs to match the type of the single arguments, not an array of the single arguments. Resolves: #100127 Releases: main, 11.5, 10.4 Change-Id: Ic107cff8e08c00b18ced783d61783ed182039fd3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78080 Reviewed-by:
Thomas Hohn <tho@gyldendal.dk> Tested-by:
-
Benjamin Kott authored
We renamed the eslint configuration to follow the recommended standards so developers IDEs will pick up the configuration more easily. The ruleset was adapted to follow a wider range of recommendations. - eslint:recommended - @typescript-eslint/recommended - lit/recommended - wc/recommended In addition we now also force more kinds of spacing rules to avoid IDEs having different opinions on how to format for example includes. The only recommendation we don't want to follow is - @typescript-eslint/no-inferrable-types. We don't want to disallow being explicit. Instead of turning off rules we cannot fully fulfill as of now, we are now changing the configuration to warning. This will help developers spotting mistakes more easy when writing code. Rules that are currently in "warn" mode: - @typescript-eslint/ban-types - @typescript-eslint/no-explicit-any - @typescript-eslint/no-this-alias To only check for errors run in the Build directory: - npx eslint ./Sources/TypeScr...
-
Daniel Hettler authored
When indexing files the FileContentParser collects some metadata e.g. title, description and keywords. For some files these information are not given and the parser breaks in an PHP 8 environment. Resolves: #100122 Releases: main, 11.5 Change-Id: I54b5512c7e30c9719654591d520943733fbfe920 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78076 Reviewed-by:
Albrecht Köhnlein <ak@koehnlein.eu> Tested-by:
-
Christian Eßl authored
Ensure the language of the checked record actually exists in the site, in case orphan records of other languages are present. Resolves: #100111 Releases: main Change-Id: I5cb3d2e09cfc86b5d43eba9e16b3833afe18e6b8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78046 Tested-by:
Kevin Appelt <kevin.appelt@icloud.com> Tested-by:
-
- Mar 08, 2023
-
-
Nikita Hovratov authored
Improve readability of the method by extracting distinct cases into own blocks with early return statements. Case 1: "EXT:" path Case 2: (already) absolute path Case 3: relative public path Resolves: #100094 Releases: main Change-Id: I664c3611ef86c779c0398c7a4f938297eb591a81 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78034 Reviewed-by:
-
Oliver Klee authored
Resolves: #100080 Releases: main, 11.5 Change-Id: If607b7dc6d8f7bdc984751835433dabcc6cad085 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78022 Tested-by:
-
- Mar 07, 2023
-
-
Alexander Schnitzler authored
ObjectMonitoringInterface is a signaling interface for extbase internals to signal that an object state can be monitored. Its main purpose is to tell the persistence manager if an object or an object collection is so called dirty, i.e. if changes need to be persisted or not. This change lets DomainObjectInterface extend ObjectMonitoringInterface instead of AbstractDomainObject. Abstract classes must never be external api, they should just contain boilerplate/repetative code. With this change extbase can perform actions based on implemented interfaces, i.e. guaranteed functionality instead of checking object instances. Releases: main Resolves: #100069 Change-Id: I65548f3fe3f6a51c2b87e67c35642c431e2d7bb2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78012 Tested-by:
-
Alexander Schnitzler authored
This change introduces alternative methods to magic method __call() of extbase's Repository class. The magic method allowed for calling findBy[Property](), findOneBy[Property]() and countBy[Property](). Those methods are now implemented with a slightly different method signature but with type declaration and phpstan support. The naming follows the one of doctrine/orm which is implemented exactly the same. The new methods are: - findBy(array $criteria, ...): QueryResultInterface - findOneBy(array $criteria, ...): object|null - count(array $criteria, ...): int Using the magic methods is deprecated but will only trigger an E_USER_DEPRECATED error as of version 13. Releases: main Resolves: #100071 Change-Id: I1b51dd5b583a225a8a4d6f948810b1e5ef5d2257 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78014 Reviewed-by:
-
Stefan Bürk authored
With #91776 auto-created redirects have been stored with a pid of the page, which the slug has been changed. This was streamlined and changed to use the site rootPageId instead with #99044, which reverted the original use-case. This change implements two new PSR-14 events around each auto-create-redirect: * `ModifyAutoCreateRedirectRecordBeforePersistingEvent`: can be used to modify the redirect record before it is persisted * `AfterAutoCreateRedirectHasBeenPersistedEvent`: can be used to chain further task after the redirect has been persisted to the database. It's kind of a plain notification event. Resolves: #99834 Related: #99802 Related: #99044 Related: #91776 Releases: main Change-Id: I974020b148a3b5eb109624648016a79ed557af3e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76539 Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
-
Andreas Fernandez authored
To ease the usage of `group` fields in the FormEngine like e.g. in the "Insert records" content element, the record overview now shows the path to the location where each assigned record is stored, respectively. Resolves: #100093 Releases: main Change-Id: I1623b506727b46ccc86361e2c061c7e2c705a50f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78033 Reviewed-by:
-
Alexander Schnitzler authored
Inside the extbase context child relations are always ordered by the foreign_sortby field if set or by order of creation. Even if the field foreign_default_sortby is set, it only impacts the order of the backend view. This patch brings the order of extbase results inline with the order of the backend view. Resolves: #64197 Releases: main, 11.5 Change-Id: I582576b5ac3741e2bbc4107664140fd9a2f63a16 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77985 Reviewed-by:
-
