- Jun 15, 2017
-
-
Thorben Nissen authored
Due to the changed link syntax ("t3://...") instead of "<link ...>" the links to files and internal pages are not recognised anymore. Furthermore are external links now written with <a href="..."> and are therefore also not recognized anymore. Rewrite code for detecting "typolink_tags" correctly. When recognizing urls, e.g. from "external url" pages or plain urls in texts, include https and not only http and ftp. Resolves: #80991 Resolves: #80988 Releases: master, 8.7 Change-Id: I5a9267b1d4ab53a6a39efdbd411e610dc9233ead Reviewed-on: https://review.typo3.org/52592 Reviewed-by:Georg Ringer <georg.ringer@gmail.com> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Christer V <cvi@systime.dk> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
- Jun 14, 2017
-
-
Georg Ringer authored
Apply the classes 'btn btn-default' directly to the a tag instead to have the full button area clickable. Resolves: #81579 Releases: master, 8.7 Change-Id: Ib296d8e8e56c45d5d879cb7cb7a749b1c7141b2f Reviewed-on: https://review.typo3.org/53216 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Oliver Hader authored
Complete data-map for a table is handed over in $idValues to DataMapProcessor::fetchDependencies(string $tableName, array $ids), but should only contain the id-values - either integer or string. Resolves: #80239 Releases: master, 8.7 Change-Id: If12562dad839687b7d60855fa99d9ffc21bc1167 Reviewed-on: https://review.typo3.org/53213 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Oliver Hader authored
The current implementation of DataMapProcessor to determine the necessity of synchronizing record localizations is too strict since it expects real persisted database records and cannot resolve new records that have been handed with the very same data-map to the DataHandler. This mentioned constraint is resolved. Besides that, an additional value processing for internal fields is added. This method resolves new record ids to their real persisted UIDs using the famous remap stack. This only is executed, if these fields have not been processed in a relation-aware context and have a meaning to TYPO3 data-structures - for instance this is the case for 'l10n_source' field defined as TCA type 'passthrough'. Change-Id: Id1291910d85b3d314af7203314b8696a337fe364 Resolves: #80239 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52871 Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
Susanne Moog authored
databaseRow should not be set incompletely in a FormDataProvider or controller as subsequent processing may rely on the complete database row being set (for example language fields). Resolves: #80855 Related: #80100 Release: master, 8.7, 7.6 Change-Id: I139b426c6598a93a2012cae088e3cbece4e1a83b Reviewed-on: https://review.typo3.org/52543 Tested-by:
Faton Haliti <fha@systime.dk> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Benni Mack authored
Calling GeneralUtility::devLog() can be called but the method itself should check whether the devlog is enabled, instead of having third-party code rely on checking the option with an if statement. This effectively removes the need for checks on if (TYPO3_DLOG) and the other two constants TYPO3_ERROR_DLOG and TYPO3_EXCEPTION_DLOG in all callers' code. Resolves: #80289 Releases: master, 8.7 Change-Id: Ibaeeca6300bdb37a513a07fb46c2616cfc51c7f2 Reviewed-on: https://review.typo3.org/52751 Tested-by:
-
- Jun 13, 2017
-
-
Benjamin Kott authored
Resolves: #81539 Releases: master, 8.7 Change-Id: I2633df64020e9f6a8e95048ed2d23f84d3013313 Reviewed-on: https://review.typo3.org/53184 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
-
Benni Mack authored
When having an empty Yaml file, the error that is thrown isn't helpful for the developer, and in case of RTE, the RTE is not shown at all. Resolves: #81557 Releases: master, 8.7 Change-Id: Ie435b9f42623962637a9ead0243be6cde15c82c6 Reviewed-on: https://review.typo3.org/53197 Tested-by:
Josef Glatz <josef.glatz@typo3.org> Tested-by:
-
Claus Due authored
Deprecates usage of arguments on render methods and refactors the abstract ViewHelper class to avoid injecting ReflectionService in every ViewHelper, calling on it only when the ViewHelper actually requires it. Safe removal since the DI property is declared private and thus cannot be accessed in ViewHelper classes. Change-Id: I94bb7e9f306b34c25dc31519eb17316c88ea0540 Resolves: #81213 Releases: master Reviewed-on: https://review.typo3.org/52796 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Oliver Hader authored
If edit forms have unsaved changes, changing the IFRAME URL is caught by explicitly sending interaction requests that are handled by individual client components, such as the FormEngine. This feature does not use the Window.beforeunload event, but some custom messaging API instead. Click events on the ExtJS page-tree are caught if those trigger a change request for the content component, however highlighting the clicked page node is not caught due to nested ExtJS event hierarchies. Resolves: #77268 Releases: master Change-Id: I3e2359cf27d95197b17e8d8489759ace403ce1af Reviewed-on: https://review.typo3.org/53075 Tested-by:
Jasmina Ließmann <code@frauliessmann.de> Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
Anders Kostending authored
Updates the version of CKEditor to 4.7. This update fixes 30+ bugs, that can be seen here: http://ckeditor.com/release/CKEditor-4.7.0 In addition there will be simpler tables, better support for CSP, better paste from Excel and Word and so on. Added one fix to the typo3link plugin. Resolves: #81483 Releases: master, 8.7 Change-Id: Id5a023e5bf9ad9bfac5e7c9c103670978ef95d8f Reviewed-on: https://review.typo3.org/53138 Reviewed-by:
Anders Kostending <aha@systime.dk> Tested-by:
-
- Jun 12, 2017
-
-
Claus Due authored
Last pass, touches all remaining ViewHelpers which are capable of conversion to the compilation helper traits from Fluid. Change-Id: I73e32da48b00444b66a568f462ab41ff66969503 Resolves: #81200 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52784 Tested-by:
-
Sascha Egerer authored
The backend query view, used for csv exports and lists, uses a date format where single digit days of a date value are prefixed with a whitespace instead of a 0. This ends up in useless CSV exports that can not be interpreted by tools like Excel. Change-Id: Ie11c5f8a923eb412f014f06df528a2aa0101a0d4 Resolves: #81551 Releases: master,8.7 Reviewed-on: https://review.typo3.org/53189 Tested-by:
Manuel Selbach <manuel_selbach@yahoo.de> Reviewed-by:
-
Christian Kuhn authored
ext:rte_ckeditor declares the default config yml preset pointers of TYPO3_CONF_VARS['RTE'] in its ext_localconf.php file. This file is loaded after LocalConfiguration.php. The patch wraps the declarations in guards to ensure any previously set pointers are not blindly reset. Change-Id: Ic945d988f436aab7453b7f7fba8694bbf3580b1d Resolves: #81537 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53181 Tested-by:
Frans Saris <franssaris@gmail.com> Reviewed-by:
-
Johannes Goslar authored
Remove package from lock file. Resolves: #81493 Releases: master Change-Id: I92e72464a509a5a76a84e28b0044b2e8f6678a21 Reviewed-on: https://review.typo3.org/53186 Tested-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
-
DanielRuf authored
Typecasting with (int) is about 2-3 times faster than using intval(). Change-Id: Ifddcaaf9bf5c1fa77c632df10cba62c82d4614d1 Resolves: #81544 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53183 Reviewed-by:
-
- Jun 10, 2017
-
-
ksjogo authored
Resolves: #81480 Releases: Master Change-Id: I6dddb5504ba9ecd22952c371610c225e700b6100 Reviewed-on: https://review.typo3.org/53137 Tested-by:
-
Frans Saris authored
Resolves: #81499 Release: master, 8.7 Change-Id: I14fbb369de466cc1884bb164bbd3a16ba051e9b0 Reviewed-on: https://review.typo3.org/53151 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
-
- Jun 09, 2017
-
-
Georg Ringer authored
The first form wizard is not there anymore, therefore the CSH must be removed as well. Resolves: #81505 Releases: master, 8.7 Change-Id: If1f37fa26576c85ba1a756cc20b19c23d023054a Reviewed-on: https://review.typo3.org/53160 Tested-by:
-
Markus Sommer authored
After this patch you need no local grunt-cli you can run all task with npm like `npm run build-css` Resolves: #81491 Releases: master, 8.7 Change-Id: I112ec3f2102c23ecfa8a715933905d03ef35e55f Reviewed-on: https://review.typo3.org/53145 Reviewed-by:
-
Georg Ringer authored
As the flash message's title and text are escaped already, remove the htmlspecialchars in DatabaseRecordList. Additionally remove the text "Warning:" from the text as this is already expressed by the flash message itself. Resolves: #81494 Releases: master, 8.7 Change-Id: I557dfb6f1422d2194dcdf83bbbc156a99efb290e Reviewed-on: https://review.typo3.org/53146 Tested-by:
-
Georg Ringer authored
The usergroup selection in the overview view of the permission module must respect the field 'hide_in_lists' as done in the detail view of a page selected in the permission module. Resolves: #81504 Releases: master, 8.7 Change-Id: I23c821af7abd5bdce16d780814d928e956333bb0 Reviewed-on: https://review.typo3.org/53157 Tested-by:
-
Markus Klein authored
This patch solves an issue with time-fields and a couple of inconsistencies for time(sec), date and datetime fields in BE: - BackendUtility::time() is superfluous as gmdate() can be used - Ensure stored data is identical to TYPO3 7 - Only use ISO dates in UTC timezone to communicate with JS (time fields use 1970-01-01 as date) - Only write ISO dates in UTC back to hidden FormEngine fields - Do that for all date/time fields to simplify JS code - Take care of necessary timezone conversion for date(time) fields - Correctly handle manual input - Fix record titles if a date field is the label field - Fix wrong Acceptance tests - Fix wrong Unit tests - Remove superfluous data-date-offset attribute for DateTimePicker - Streamline FormEngineValidation date handling code - Refactor DateTimePicker: fix code duplication, work in UTC only Resolves: #79249 Releases: master, 8.7 Change-Id: I12ef6b6f59f0843182e093f8f274989161820894 Reviewed-on: https://review.typo3.org/51242 Tested-by:
Johannes Kasberger <johannes.kasberger@reelworx.at> Tested-by:
-
Sascha Egerer authored
The default database value for native fields of type datetime must not be 0 but NULL. Resolves: #79304 Releases: master, 8.7 Change-Id: I823a85be2a01ccd8df4997ab2969b2c95ed78cd1 Reviewed-on: https://review.typo3.org/51296 Tested-by:
-
- Jun 08, 2017
-
-
Jasmina Liessmann authored
Since using flexbox for displaying boxes at the same height in module 'About' the jQuery plugin 'matchHeight' is not needed anymore. Resolves: #81493 Releases: master Change-Id: I1f593111804cd34f66beee472cbdd4ac258fc0ab Reviewed-on: https://review.typo3.org/53149 Tested-by:
-
- Jun 07, 2017
-
-
Josef Glatz authored
Remove the last LESS file after the switch to SCSS. Resolves: #81509 Releases: master Change-Id: I24138144497c60e018b5612bce3624b631ac6d0b Reviewed-on: https://review.typo3.org/53165 Reviewed-by:
-
Helmut Hummel authored
While cleanup css with #79998 the background was accidentally removed. Add it again to make the selected crop area more prominent again. Resolves: #81503 Releases: master, 8.7 Change-Id: I197d6c4bb9b7be7d2b9a443ce1b60ab3b4d82bcd Reviewed-on: https://review.typo3.org/53156 Reviewed-by:
Robert Vock <robert.vock@4wdmedia.de> Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
Christian Kuhn authored
The patch adds fixture comparison files for mssql platform on ext:impexp functional tests. Change-Id: I2ff9048b9f6395c555f72a68b16684e9bf22de84 Resolves: #81501 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53153 Tested-by:
Jan Helke <typo3@helke.de> Tested-by:
-
Christian Kuhn authored
MS SQL server is more picky about types than postgres and mysql. This is especially true for LOB columns - even empty strings need a proper cast and specific handling. Various parts of the core deal with arbitrary tables and don't know if a column is int, text or lob, or whatever. Those are blindly updated / inserted, resulting in mssql saying "no". Solution is to fetch column schema and to set proper types based on that schema. This is expensive. We will have to refactor that again, and we will probably end up with a (cache?) entry that knows the entire table schema of an instance. Solving that in a good way would also fix various mysql strict issues we still have in the core. However, this needs more work. Goal of the current patch is to bring mssql to a working state. The solution must be seen as hacky, but is restricted to that platform only and can be relaxed and improved as soon as we take the next steps with schema handling in the TYPO3 core. Change-Id: I9b582a9bde7461cfbcc2414192518fb7b7b1341d Resolves: #81498 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53150 Tested-by:
-
Christian Kuhn authored
mssql does not support FIND_IN_SET(). The patch adds a solution based on LIKE. Since the query fiddling in this area is a bit tricky, this area is now supported by a bunch of functional tests. A postgres bug those new functional tests reveal is fixed along the way. Change-Id: I5e94ad8df7a37a680b457eff1b5b16a0c14dba39 Resolves: #81488 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53141 Reviewed-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Tested-by:
-
- Jun 06, 2017
-
-
Morton Jonuschat authored
Reusing the connection object for the sys_refindex table can fail if the table that is being indexed is actually on another connection. Select the proper connection before attempting to execute the query. Change-Id: I4c031428f7405031aea6ef652c8b6f488f921228 Resolves: #81049 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53131 Tested-by:
Henrik Elsner <helsner@dfau.de> Reviewed-by:
-
Markus Klein authored
Issue correct error message if the renderType (or the type) is unknown. The message now includes also the renderType, if specified. Releases: master, 8.7, 7.6 Resolves: #81485 Change-Id: I44e736a546fc27733a8c8df14089dd25dc172f2b Reviewed-on: https://review.typo3.org/53139 Tested-by:
-
Martin Bless authored
Resolves: #81477 Releases: master, 8.7, 7.6 Change-Id: Ie98fcc81c386fe5704c669f36220827f7cfbd2e5 Reviewed-on: https://review.typo3.org/53133 Reviewed-by:
-
- Jun 05, 2017
-
-
Wouter Wolters authored
The wrong variable is used in a hook exception. Use the correct variable to prevent fatal errors. Resolves: #81472 Releases: master,8.7 Change-Id: I8cf84c2ac84c09bbeecc2111eb6128fdc71be3c7 Reviewed-on: https://review.typo3.org/53122 Tested-by:
-
Michael Oehlhof authored
Resolves: #78355 Releases: master Change-Id: Ibf4966f312124bdab38701e014cd9fd74f768adf Reviewed-on: https://review.typo3.org/51044 Tested-by:
Gianluigi Martino <gmartino27@gmail.com> Tested-by:
-
Elmar Hinz authored
Releases: master Resolves: #81280 Change-Id: Ib67d57b69e9d5cd4f46cd8c7201107ec5945d64c Reviewed-on: https://review.typo3.org/52963 Tested-by:
-
Jasmina Liessmann authored
Page titles are used within several table views. This patch avoids page titles from being displayed outside their columns. Resolves: #81456 Releases: master, 8.7 Change-Id: I38d773ff8b3300027ef815b4f792cc45b0a66aff Reviewed-on: https://review.typo3.org/53106 Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
-
Jasmina Liessmann authored
Move general CSH for 'Pagetree overview' next to form fields. Resolves: #81453 Releases: master, 8.7 Change-Id: I8e5c3a4257d569277f837bee2c641cd1a95dd9a5 Reviewed-on: https://review.typo3.org/53086 Reviewed-by:
-
Johannes Goslar authored
Resolves: #81416 Releases: master, 8.7 Change-Id: If7e3893baa73c1392f3317d5b871be51eeab41b5 Reviewed-on: https://review.typo3.org/53021 Reviewed-by:
-
Nicole Cordes authored
The ImageCropUpdater throws an exception if a non-existing file is tried to be processed. This happens because deleted rows are updated. The patch checks the returned file object before further processing is executed. Resolves: #81470 Releases: master, 8.7 Change-Id: I488994b1ad842e28d928f3b4a2db1c8c007afe3c Reviewed-on: https://review.typo3.org/53120 Tested-by:
-
