Releases: master, 10.4
Resolves: #92506
Change-Id: I292d0220335884f9185a468bdbd50bae41a6ca5b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66072


Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>

With this patch, the header comment of php files is
automatically added by the php-cs-fixer, which guarantees
that its format and place of occurrence remain the same
in all files.

Files that are copied over from other projects are excluded.

Furthermore, files that are kind of inspired by other
projects also get the same header comment but may have
a second, additional comment explaining its origin.

Used command:

    bin/php-cs-fixer fix --config=Build/php-cs-fixer/header-comment.php

Releases: master
Resolves: #91024
Change-Id: I5a040517e0fbde6e5a27d589bf2f222078326dc8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64159


Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>

This change adds two changes
        'blank_line_after_opening_tag' => true,
        'single_trait_insert_per_statement' => true,

to our PHP-CS Fixer configuration, adopting more rules related
to PSR-12.

Resolves: #91020
Releases: master
Change-Id: I180b2cbceb077911bddeb42d9f131e5b32244ed2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64158


Tested-by: Josef Glatz <josefglatz@gmail.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Alexander Schnitzler <git@alexanderschnitzler.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Josef Glatz <josefglatz@gmail.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Alexander Schnitzler <git@alexanderschnitzler.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>

* Add examples to ViewHelpers that did not have any example yet.
* Add cross references between ViewHelpers where a different ViewHelper
  was mentioned.
* Add full stop to end if sentences.
* Fix indentation within examples.
* Add some syntax like code.
* Fix escaping of PHP classes with namespaces by wrapping them with
  :php:`` text role.
* Use https for urls to php.net.
* Remove '/en/' path from urls to php.net. This ensures the current user
  language is auto detected. Not forcing anyone to keep english.

Relates: #88600
Releases: master, 9.5
Change-Id: I2394890a20adba06719fa35990044057346dfb2b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61104


Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>

As this is what its called. This also should make searches easier, as
there is only one way to write it.

Relates: #88600
Releases: master, 9.5
Change-Id: Ib6fcd4402b4a34aeaf0735a40788a18a324587dd
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61103


Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Tom Warwick <tom.warwick@typo3.org>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Claus Due <claus@phpmind.net>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>

Resolves: #88225
Releases: master, 9.5
Change-Id: I58166253bb451c829fe778379d8ada7644d63749
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60569


Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>

* In order to allow proper rendering at docs.typo3.org
* Only migrated HTML to rst, and streamlined structure.

Resolves: #86855
Releases: master, 9.5
Change-Id: Ia617d24b0e70182b8702b23a340ad1f2b536910e
Reviewed-on: https://review.typo3.org/c/58844


Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>

EXT:fluid uses @api and @internal phpDoc annotations. Going with a cleaner
approach with marking code as just @internal, and everything not annotated
as @internal is public, is the way to go, also the way PSR-5 is heading.

For EXT:fluid: Every PHP class that had nothing marked, is now @internal,
everything that was @api is now implicitly part of TYPO3 Core API.

Other areas will follow so the API for TYPO3 v9 LTS is clearer than ever.

Resolves: #86507
Releases: master
Change-Id: I5deba0ba2b868743e7eda8f0e32cda40ef008046
Reviewed-on: https://review.typo3.org/58525


Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>

The ResourceViewHelper had a special handling for returning relative
paths, but should always use getAbsoluteWebPath().

The option "absolute" is there to generate a full URL, so this is no issue at all.

Resolves: #83272
Releases: master
Change-Id: I3705712bf8cc38cc45914e83715b18c268c42bd8
Reviewed-on: https://review.typo3.org/55003


Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>

Resolves: #82414
Releases: master
Change-Id: I375bfd92e0b7eb58aa68f5a50e18b854d8fc6bdb
Reviewed-on: https://review.typo3.org/54946


Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>

The TYPO3 Core currently has no guidline how to handle phpdoc
comments regarding @return annoations related to "void" and "null".

In practice, these annotations have no additional value if no additional
documentation is given.

With this change, the php-cs-fixer will remove any unnecessary linebreaks
within the comments above the @return annotation, as well as remove completely
empty phpdoc comments because the @return annotation is removed.

Please be aware, that once PSR-5 is accepted, this coding standard
within the TYPO3 Core will change again, where there are currently
some further proposal details like inheritance information.

Resolves: #80454
Releases: master
Change-Id: Ie969d720684c0a75919fe5addd1c36ef5b12eb04
Reviewed-on: https://review.typo3.org/51686


Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>

This change implements ViewHelper compiling traits
from the new Fluid 1.1.0 ViewHelperCompiler feature.

The Traits allow removing duplicated render methods
and makes the TemplateCompiler compile the call to
the ViewHelper as a direct call to `renderStatic` for
improved performance in compiled templates.

Change-Id: Ic421f6a5d94ced02944745c4f6c4bf7636f63ca7
Resolves: #78245
Releases: master
Reviewed-on: https://review.typo3.org/50187


Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>

As decided during T3ACME we will use the short
array syntax in master. The 7.6 branch will also be done
to make backporting easier.

Resolves: #77692
Releases: master,7.6
Change-Id: I37e9484b1012fc9161148257a842054c24d162ba
Reviewed-on: https://review.typo3.org/49651


Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>

Move the argument registrations away from the render() method
to initializeArguments(), to prevent any errors with PHP7 and
subclassed ViewHelpers if/when render() method signatures change

Resolves: #77010
Releases: master
Change-Id: I53b08bcf4da1b9b319cbe9411c361db9894e5644
Reviewed-on: https://review.typo3.org/48875


Tested-by: Bamboo TYPO3com <info@typo3.com>
Reviewed-by: Anna Färber <anna.faerber@dkd.de>
Tested-by: Anna Färber <anna.faerber@dkd.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>

Resolves: #75762
Releases: master
Change-Id: I4e409f154abe6fba299a8335b1ec9b5bd64e64d5
Reviewed-on: https://review.typo3.org/47766


Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>

Any class listed in the LegacyClassesForIde file must not be used
by Core anymore.

Resolves: #75376
Releases: master
Change-Id: If69782eb9227270c511a47ecf229ff31c7892fb6
Reviewed-on: https://review.typo3.org/47493


Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>

This change:

* Adds `typo3fluid/fluid` as dependency
* Converts system extension `fluid` to a so-called Fluid adapter
* Adds TYPO3-specific Fluid integrations as compatibility layer
* Turns Fluid's RenderingContext into a very flexible API
* Updates a few templates and core ViewHelpers for compatibility

On a more general level the change allows using a wide array of
new template syntaxes and integration features (see feature
documentation included with this commit in `core` extension).

The breaking changes are minimal; mostly caused by removal of
deprecated code from the `fluid` system extension (rather than
fundamental changes to how Fluid itself works). Custom templates
should work with little or no migration required.

Change-Id: Ib505cb66dabcc711868924d2fab3015ce549fbde
Releases: master
Resolves: #62940
Resolves: #69863
Resolves: #58752
Resolves: #48221
Resolves: #49903
Resolves: #54509
Resolves: #55343
Resolves: #55660
Resolves: #57446
Resolves: #70036
Resolves: #61144
Resolves: #60082
Resolves: #11287
Resolves: #70960
Resolves: #71552
Resolves: #67930
Resolves: #48656
Resolves: #71821
Resolves: #59540
Reviewed-on: https://review.typo3.org/42425


Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Marc Neuhaus <apocalip@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>

In our efforts to achieve a better interoperability
with other PHP projects, the PHP code base of the
TYPO3 Core switches to the PHP coding guideline
standard PSR-2.

See http://www.php-fig.org/psr/psr-2/ for more
information.

Resolves: #70515
Releases: master
Change-Id: I734c0d838af157003decfeb5fc0a11dddcb87bf5
Reviewed-on: http://review.typo3.org/43918


Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>

Using self::renderStatic() in the render method of the viewhelpers
forces extending viewhelpers to copy the render method, which is
useless overhead.

Adjust all viewhelpers to use static::renderStatic() instead to
allow for late static binding.

Resolves: #67420
Releases: master
Change-Id: I12ca42a16365ee2baceeca6a17193e5f6877ed27
Reviewed-on: http://review.typo3.org/40184


Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Manuel Selbach <m.selbach@reply.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>

Releases: master
Resolves: #66748
Change-Id: Id3ebb6bdc3da7d30c651ae178a363d8388d6ce63
Reviewed-on: http://review.typo3.org/39200


Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>

The licence change is no good idea.

This reverts commit 5504a141.

Change-Id: I6d5427a953846d35dc5695f24b673c1c47139c17
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/36599


Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>

Align some files with old copyright headers, mostly in extbase and
fluid sysext which were missed in Task #59535. Also remove some left
@package statements missed in Task #43019.

Resolves: #64689
Releases: master, 6.2
Change-Id: I9838c9be73cb3a310ef2572fcc3843ff53dbf724
Reviewed-on: http://review.typo3.org/36519


Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>

Most of TYPO3's PHP files have an empty line before a class' closing curly
brace. This commit adds this empty line (if it is missing) before a class'
closing curly brace.

This is not part of the TYPO3 CMS CGL but increases consistency in this
area.

This regular expression was used to add the empty lines:

Search:
(}\n)(})

Replace:
$1\n$2

Resolves: #63942
Release: master
Change-Id: Icd6547322ac8b7310956d347fd73c90bde2bbfa7
Reviewed-on: http://review.typo3.org/35527


Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>

Resolves: #62468
Releases: master
Change-Id: I2790ca5817e16cfe0dc1c43151d2587ca796294a
Reviewed-on: http://review.typo3.org/33523


Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>

Avoid having to use the substr/strlen-magic.
Also strlen(PATH_site) can be statically cached.

Change-Id: I0ef942e331e2039e2ece9a55dd740db2a3896e2c
Resolves: #54126
Releases: 6.2
Reviewed-on: https://review.typo3.org/25851
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Change-Id: Iaa92566c53301e49396fc9fb26b0b339c48d567b
Resolves: #52360
Releases: 6.2
Reviewed-on: https://review.typo3.org/24212
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

* whitespaces, tabs and blank line issues
* bool -> boolean
* int -> integer
* fix wrong namespace annotations

Fixes: #43157
Releases: 6.0
Change-Id: I8397948e19248db029d8efd1555ee56e4982742d
Reviewed-on: http://review.typo3.org/16619
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Superfluous brackets in fluid after namespaces move
Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Resolves: #41016
Related: #40095
Releases: 6.0
Change-Id: I64741473cb24eda343f0576ebd1a0f1846dfc3f8
Reviewed-on: http://review.typo3.org/14675
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Change-Id: Ia7432e1c923826ed58206bca15fb94509adbd508

Change-Id: I620d2e61860142cdc89cc83474c95542799961c0

There must be no empty lines after the closing
PHP tag. Empty lines after closing tags break
output compression in PHP and/or result in AJAX
errors.

Change-Id: I0484ca29d8134d0828cf30880d5aafd43ed9d78e
Resolves: #36076
Releases: 6.0
Reviewed-on: http://review.typo3.org/10499
Reviewed-by: Ingo Pfennigstorf
Tested-by: Ingo Pfennigstorf
Reviewed-by: Daniel Lorenz
Tested-by: Daniel Lorenz
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

This backports three recent changes of the TYPO3.Fluid package:
- Remove @license annotation from files (290f4f5)
- Simplify license header in PHP files (14bacba)
- Drop @author tags from source code (9c2e837)

This should not contain any functional change!

Change-Id: I9376dca4af78c4f0f82413011d115b8ad04634dd

Change-Id: I6637620820258b3b5c78b650ee6cd94871b9892b
Resolves: #27446
Reviewed-on: http://review.typo3.org/2739
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

git-svn-id: https://svn.typo3.org/TYPO3v4/Core/trunk@10040 709f56b5-9817-0410-a4d7-c38de5d9e867

Resolves #10908

git-svn-id: https://svn.typo3.org/TYPO3v4/Core/trunk@9705 709f56b5-9817-0410-a4d7-c38de5d9e867

git-svn-id: https://svn.typo3.org/TYPO3v4/Core/trunk@8665 709f56b5-9817-0410-a4d7-c38de5d9e867

[~TASK] Fluid (ViewHelpers): Fixed BE support of the ViewHelpers cObject, format.crop, uri.resource. Relates to #8947
[~TASK] Fluid (ViewHelpers): Added BE support in the ViewHelpers format.html and image. Relates to #8947

[-TASK] Fluid: Removed @version annotation from all Fluid classes to ease the backporting process. Relates to #8835 (backported from Fluid package)