- Feb 25, 2024
-
-
Oliver Bartsch authored
Resolves: #103192 Releases: main, 12.4 Change-Id: I81c0c655b75332790243c05be14f24593c5b9d6a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83098 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
-
- Feb 24, 2024
-
-
Oliver Klee authored
Due to a typo, #103193 downgraded the minimum required phpstan/phpstan-phpunit version. Executed command: composer require --dev \ phpstan/phpstan-phpunit:^1.3.16 Resolves: #103194 Related: #103193 Releases: main, 12.4 Change-Id: Ied12668b57b500a42bdb9f901952094cd48bd1b0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83123 Tested-by:Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Oliver Klee authored
The new version changes the format of a warning. Executed commands: composer require --dev \ phpstan/phpstan:^1.10.59 \ phpstan/phpdoc-parser:^1.26.0 \ phpstan/phpstan-phpunit:^1.2.16 ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #103193 Releases: main, 12.4 Change-Id: I36a6b4f98e03b73dbf076d84ce1ea900c26fcfb2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83121 Tested-by:
-
- Feb 23, 2024
-
-
Oliver Bartsch authored
A couple of places (mostly paginations) are using the action ViewHelpers without providing the `action` argument. Those links will therefore fall back to the default action, which might be wrong e.g. in the backend user group listing. To preserve the current action on paginating, the corresponding action is now always set. Resolves: #103189 Related: #101729 Releases: main, 12.4 Change-Id: I1db9a637a4b320f90aae3a93fe903c939384ea3a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83117 Tested-by:
-
tiggr authored
fixes error introduced by https://review.typo3.org/c/Packages/TYPO3.CMS/+/83080 Releases: main, 12.4 Resolves: #103191 Related: #103181 Change-Id: I4636c5c0f39beff6824ec7fb967993087c2fdbc5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83097 Tested-by:
-
Christian Kuhn authored
phpunit 11 deprecates annotations like `@test` and `@dataProvider` in favor of their attribute counterparts. We'll adapt core main & v12 to keep v12 backports simple. The patch takes care of Tests/Unit and Tests/UnitDeprecated, functional test need some additional quirk for the test splitter to continue to work. > composer req --dev rector/rector > wget https://forge.typo3.org/attachments/download/38273/rector.php > find typo3/ -name \*Test.php | grep Tests/Unit | xargs bin/rector process > rm rector.php > composer rem --dev rector/rector Minor manual adaption in ErrorHandlerTest.php and GeneralUtilityTest.php, and `runTests.sh -s cglGit`. Number of executed unit tests and unitDeprecated tests should stay the same. Change-Id: I63d2be40b8aa022f0918edd8dc1c360017316c46 Resolves: #103180 Releases: main, 12.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83091 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
tiggr authored
To add a custom table to the list of tables, the corresponding TCA field name "table_name" has to be used. Releases: main, 12.4 Resolves: #103181 Change-Id: I1349465f320f882f2cf628a34dd445ceef375f2a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83096 Tested-by:
-
Oliver Bartsch authored
A couple of tests are adding services to a container instance. Since the `ContainerInterface` does not define the used `set()` method, the tests are adjusted to explicitly require the symfony service container, which provides mentioned `set()` method. Resolves: #103183 Releases: main, 12.4 Change-Id: Icdb36a0ea871d79cd2c280d5f17a00569b49cb2b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83088 Tested-by:
-
Oliver Bartsch authored
Resolves: #103182 Releases: main, 12.4 Change-Id: If16e37c638a07e3afbb59d665141cc2ade583f4d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83095 Tested-by:
-
Benjamin Franzke authored
The event provides access to the `$resultArray` and documents that it can be modified to set `javaScriptModules`, but missed to take the resulting data into account. Releases: main, 12.4 Resolves: #103174 Change-Id: I0a53d1fbcdff0a3d57de237b44d3ff68f60c721d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83081 Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
Benjamin Franzke authored
When CKEditor5 `contentsCss` configuration options references multiple CSS, respective `fetch()` requests may finish in non-sequential order, depending on server load and file size, causing intended CSS ordering to break. Ensure sequential ordering by waiting for all promises to be settled via `Promise.allSettled()`. It is guaranteed to return the promise status and values "in the order of the promises passed, regardless of completion order": https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/allSettled#return_value Releases: main, 12.4 Resolves: #103152 Related: #100768 Change-Id: I5954b438cc6b8c6d74c81fda0227e963d7d89cf6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83094 Tested-by:
-
- Feb 22, 2024
-
-
Benjamin Franzke authored
Using timestamps as array keys in form yaml configuration can result in sparse [1] JavaScript arrays which contain "empty slots". Example yaml configuration: templateRootPaths: 1708504268: 'EXT:example/Resources/Private/Emails/Templates' This value is properly serialized into an object by PHP json_encode (as it does not contain sequential integer keys starting at 0), but the FormEditor data model produces arrays from numerical keys during clone operations of such data sets and basically creates sparse arrays like: > const example = [] > example[1708504268] = 'EXT:example/Resources/Private/Emails/Templates' > console.log(example) [ <1708504268 empty items>, 'EXT:forms_extended/Resources/Private/Emails/Templates' ] Some array-looping operations like Array.reduce() will loop through all empty slots [1] and therefore preduce a lot of processing load (1708504269 loops for the example above) that ultimately cause freezes. The array to object copy operation is now replaced by a modern spread operation that is defined to skip empty slots. [1] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Indexed_collections#sparse_arrays Releases: main, 12.4, 11.5 Resolves: #103168 Change-Id: I10b586ff5c5b0fb3698bfbbe28b2f93d932b71a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83079 Reviewed-by: -
Torben Hansen authored
With #103046, `encryptionKey` has been removed from `DefaultConfiguration.php`. This leads to PHP array key warnings in unit tests. The patch sets it for various tests. Resolves: #103148 Related: #103046 Releases: main, 12.4, 11.5 Change-Id: Ife279449c2db569c8d63a0cc19009f1a3ca278d5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83074 Reviewed-by:
-
Stefan Bürk authored
The command dispatch for `-s phpstanGenerateBaseline` is modified to a simple command dispatch instead of the bash expansion - which is not needed in this case. Resolves: #103106 Releases: main, 12.4, 11.5 Change-Id: I771945f2a0751cbf4d350ffe0e8e8f2d78a04d86 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83092 Reviewed-by:
-
- Feb 21, 2024
-
-
Torben Hansen authored
In TYPO3 versions before v9, the mailtest showed the configured sender email address. This has been removed due to a wrong fluid variable usage with #88523 With this change, the sender email address is now shown again in the mailtest. Additionally, a note is added to clarify, that not receiving the test email could be due to spam filters or the sender domain SPF settings. The notice about the `defaultMailFromAddress` has been removed, since it is already checked in `EnvironmentController`, that the value is configured and a valid email address. Finally, the fluid variable `queueIdentifier` introduced with #100084 has been removed, since it is not used in the template. Resolves: #103136 Related: #88523 Related: #100084 Releases: main, 12.4 Change-Id: Ib076934732a05d9c709f6d822526e8316cf87106 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82989 Tested-by:
-
sschreiberten authored
Resolves: #103170 Releases: main, 12.4, 11.5 Change-Id: Ic7f63f6c55b832af27e9e30a0711ba042df42aa3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82987 Tested-by:
-
Sascha Nowak authored
The cache_treelist handling in PageRepository is broken for a long time already: Entries are get() with an expiry time that is not properly set(), so get() is never successful. There is a second bug in getDescendantPageIdsRecursive() cache handling: get() is done without BE user restriction, but set() is only done when no BE user is logged in. This way, non-BE user state could swap into BE user state, *if* the cache would work. The patch avoids reading and writing the cache instead of fixing cache access: We can not risk bugs in v12 if the cache would suddenly start working but has side effects: Issues like that would be hard to find, hard to report, and have severe impact on FE rendering. Note typical use case of the method are the "menu" content elements, plus the extbase 'starting point' logic. So its not the menu rendering in general - we would otherwise have most likely found the broken cache much earlier. The patch effectively increases performance since the get() and set() queries are gone. Resolves: #103139 Releases: main, 12.4 Change-Id: Icc8d13b583f77d6ffc186d391d46d6830ee50889 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83055 Tested-by:
-
- Feb 20, 2024
-
-
Torben Hansen authored
The dataHandler hook implementation `BackendUserPasswordCheck` sets a random password for a new backend user, if the provided password is empty in `$incomingFieldArray`. The generated password is a random HMAC string, which does not fulfill the requirements of the default TYPO3 password policy. As a result, a password policy warning is shown. This change ensures, that the generated random password at least fulfills the default TYPO3 password policy. Resolves: #103138 Releases: main, 12.4 Change-Id: I20ef7c5958d539533cc76ca41c4cc7b5ab07e594 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82986 Tested-by:
-
Andreas Kienast authored
Some modal windows rendered in the workspace management module had hard-coded strings. This commit replaces such usages with translatable locallang keys. Resolves: #103161 Releases: main, 12.4 Change-Id: Id0d6be518abc44b7aab82ebd1312bc159a01898a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83050 Tested-by:
-
Benjamin Franzke authored
Adapt the service provider compiler to perform the same level of optimization as for the array-based callable syntax: We unroll the static closure into its static components (class name and method name). That means the effective generated dependency injection php code is the same as before with the gain of better DX. Note that first class closures can only be used where methods of the current scope are referenced, late state binding is not supported. AbstractServiceProvider therefore keeps using array-based callable syntax to be able to reference method scope of extending classes. Resolves: #103104 Releases: main, 12.4 Change-Id: I2f8ca7a69b1b69c51b1ff6bec384ddafe4492a41 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83033 Tested-by:
-
- Feb 19, 2024
-
-
Oliver Bartsch authored
Drop down menus, used in the docheader (e.g. the language selection in then page module) do no longer get cut off on small screens. This is done by setting a dynamic max-height (viewport height - topbar and docheader height) and by allowing to scroll. Resolves: #103074 Releases: main, 12.4 Change-Id: Icd5f6d9c245f40c55e47e1f18901467a5703bc16 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83037 Tested-by:
-
Benjamin Franzke authored
With #100768 the CKEeditor5 CSS scoping was migrated from server-side SCSS preprocessing to a JavaScript based CSS prefixer. The Feature.rst has not been updated and still referred to limitations caused by the removed SCSS parser. Resolves: #103151 Related: #100768 Releases: main, 12.4 Change-Id: I0f9e7d0c8c88c906b65290c29f2b2cc0e179058a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82985 Reviewed-by:
-
Andreas Kienast authored
Resolves: #103142 Releases: main, 12.4, 11.5 Change-Id: I31e5af71aa0e1a9104f8c154a6f0e34f29c90a77 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82983 Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
-
Johannes Nielsen authored
Add the configuration to the "Full" RTE preset, and also include some modules that missed in Full preset since #102099. npm install --save @ckeditor/ckeditor5-font@41.1.0 npm run build Resolves: #100847 Releases: main, 12.4 Change-Id: Iaa56d48e043397aefb902b6c9a5afbfcc453ae74 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81397 Tested-by:
-
- Feb 17, 2024
-
-
Stefan Bürk authored
New core-testing-* images have been build and published in the TYPO3 testing-infrastructure repository and pulled to the core ci gitlab runner instances. [1] This change modifies `Build/Scripts/runTests.sh` to set new image version to ensure the usage for all changes based on this change. For information what changed in the image see the patches in the testing-infrastrucure repository linked below. * core-testing-php82 => 1.11 * core-testing-php83 => 1.12 [1] https://git.typo3.org/typo3/CI/testing-infrastructure/-/commit/072687df3a90e808143b3eded59176ee593e8112 Resolves: #103143 Releases: main, 13.0, 12.4, 11.5 Change-Id: Ia0ec77beb11e3f24614a0f5b531799494c1af988 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82981 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
-
Benjamin Franzke authored
CKEditor5 renders tablecaptions as figcaption elements, therefore we allow them to be included in RTE and in frontend rendering. Resolves: #101874 Releases: main, 12.4 Change-Id: I0d1c05b2d8a35d765e64713741a0ab05a5aa1a5c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82187 Reviewed-by:
-
- Feb 16, 2024
-
-
Oliver Bartsch authored
Since FileInterface->getPublicUrl() might return `NULL`, corresponding constructor arguments are updated to now expect `?string`. Resolves: #103051 Releases: main, 12.4 Change-Id: I8d16c6b9361694733dc2c5c4b2e69693fe25cff4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82979 Tested-by:
-
Andreas Kienast authored
In v11, extension authors were able to enhance the site configuration "TCA" with richtext fields. Since v12, this is not possible anymore due to the missing `backend.form` imports, required to load necessary JavaScript modules tagged as such. This commit adds the missing instruction, allowing to make use of ckeditor and related modules again. Resolves: #103115 Releases: main, 12.4 Change-Id: I2fb6d6b917ee99d9616593f118daa72d3f3a460b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83017 Tested-by:
-
Oliver Bartsch authored
To allow `BackendUtility::getProcessedValue()` to properly resolve the labels for select options, added via TSconfig, the `pid` is now provided by `StandardContentPreviewRenderer`. Resolves: #103076 Releases: main, 12.4 Change-Id: I20777ae532b66800ea61143e1824c895c7673042 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82978 Tested-by:
-
- Feb 15, 2024
-
-
Christian Kuhn authored
There is no point to substitute GU::trimExplode() of the rather short TCA 'eval' string by substituting it with an md5() operation plus runtime cache object operations. Both things are most likely similarily quick, and the time consumed by queries in DH is multiple orders of magnitude bigger than this simple operation, a difference is not measurable. Let's thus simplify the code a bit. Resolves: #103125 Releases: main, 12.4 Change-Id: I474d3fbe6b503a99a9129856b0f59c777b171844 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82977 Tested-by:
-
Oliver Bartsch authored
The EXT:form "version2" is using bootstrap 5, which requires <select> elements to use the `form-select` class. This is now fixed for corresponding form elements. Resolves: #103117 Releases: main, 12.4 Change-Id: I712cecfa4c5ac8facc84bc3cf0f742867ecc9613 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82976 Reviewed-by:
-
Torben Hansen authored
Install tool suggests to set `$GLOBALS['TYPO3_CONF_VARS']['GFX']['processor_colorspace'] = sRGB` if images appear too dark. In general this is the correct suggestion, but the value must be quoted. This change adds the missing single quotes for the value. Resolves: #103124 Releases: main, 12.4 Change-Id: I2e1fd2ebebf1d67870145df29ec0e40b330a5065 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82975 Tested-by:
-
- Feb 14, 2024
-
-
Oliver Bartsch authored
Due to the previously used pagination, the "items per page" option has been reset when searching in the record list. However, since the "new" pagination is able to handle such filtered list, resetting the "items per page" option is no longer necessary and therefore makes lists with a lot of matched items usable again. Resolves: #103107 Releases: main, 12.4 Change-Id: Ibeb5a65666a3796f98d3dd61c9efc0bd3bfb0c72 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82974 Tested-by:
-
Nikita Hovratov authored
The BootCompletedEvent receives the constructor argument `$cachingEnabled`. However, the variable `$disableCaching` was passed in Bootstrap::init() which is the exact opposite. In fact, the caching is logically always enabled when reaching the dispatched event. Resolves: #103114 Releases: main, 12.4 Change-Id: I81c26027bb8e2cb4009fbfcd0bfd6015bd9c1dec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82973 Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
Oliver Bartsch authored
It's now possible to use a TCA type `group` field as `foreign_selector` together with the `useCombination` functionality. The corresponding "child child table" information is in this case fetched from the `allowed` option. Side note: Using TCA type `group` for a `foreign_selector` field is not really documented, but it's also not forbidden. Actually, it's a valid use case and also working quite well as the new styleguide examples demonstrate. However, the documentation should be adjusted to mention that only one table can be defined in `allowed` for such fields. Resolves: #102904 Releases: main, 12.4 Change-Id: Icdde6a8acb1fb9166da8e6259758f6bf64d6c41f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82994 Tested-by:
-
- Feb 13, 2024
-
-
Andreas Kienast authored
This commit updates ckeditor5 to v41.1. See changelog at https://github.com/ckeditor/ckeditor5/releases/tag/v41.1.0. Executed commands: npm i --save \ @ckeditor/ckeditor5-alignment@^41.1.0 \ @ckeditor/ckeditor5-autoformat@^41.1.0 \ @ckeditor/ckeditor5-basic-styles@^41.1.0 \ @ckeditor/ckeditor5-block-quote@^41.1.0 \ @ckeditor/ckeditor5-clipboard@^41.1.0 \ @ckeditor/ckeditor5-code-block@^41.1.0 \ @ckeditor/ckeditor5-core@^41.1.0 \ @ckeditor/ckeditor5-editor-classic@^41.1.0 \ @ckeditor/ckeditor5-engine@^41.1.0 \ @ckeditor/ckeditor5-essentials@^41.1.0 \ @ckeditor/ckeditor5-find-and-replace@^41.1.0 \ @ckeditor/ckeditor5-heading@^41.1.0 \ @ckeditor/ckeditor5-horizontal-line@^41.1.0 \ @ckeditor/ckeditor5-html-support@^41.1.0 \ @ckeditor/ckeditor5-indent@^41.1.0 \ @ckeditor/ckeditor5-link@^41.1.0 \ @ckeditor/ckeditor5-list@^41.1.0 \ @ckeditor/ckeditor5-paragraph@^41.1.0 \ @ckeditor/ckeditor5-paste-from-office@^41.1.0 \ @ckeditor/ckeditor5-remove-format@^41.1.0 \ @ckeditor/ckeditor5-show-blocks@^41.1.0 \ @ckeditor/ckeditor5-source-editing@^41.1.0 \ @ckeditor/ckeditor5-special-characters@^41.1.0 \ @ckeditor/ckeditor5-style@^41.1.0 \ @ckeditor/ckeditor5-table@^41.1.0 \ @ckeditor/ckeditor5-theme-lark@^41.1.0 \ @ckeditor/ckeditor5-ui@^41.1.0 \ @ckeditor/ckeditor5-undo@^41.1.0 \ @ckeditor/ckeditor5-utils@^41.1.0 \ @ckeditor/ckeditor5-word-count@^41.1.0 npm i --save-dev \ @ckeditor/ckeditor5-dev-utils@^39.6.0 npm run build Resolves: #103069 Releases: main, 12.4 Change-Id: I571ccb8d8531108f99272f6c4cf11c351d3f5692 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82971 Reviewed-by:
-
Stefan Bürk authored
The constant editor has been revamped with #98357 using the new TypoScript parser introduced with TYPO3 v12 under the hood. For category and subCategory handling lower-cased keys have been used, missing to lower-case the custom categories and subcategories names (keys) integrator are able to add since aeons. That leads to a failing match later on, and adding constants to the generic `other` subcategory. The revamped code supports only one category per subCategory sorting value. The documentation say that this **should** be omitted, but it worked in the past and broke with the revamped implementation. This change fixes muliple issues with the constant editor: * Ensure that custom categories and subcategories are read lower-case, otherwise later lookup will fail and sorted into sub-categorie `other`. * Add addtional array level to have `subCategory->items` per second sorting value as array (to avoid overriding). * Add additional item loop to the fluid template to respect the additional array level. Note: In the past it was possible to display a constant in multiple categories/subcategories by adding them again with different category configure comment lines. This is not supported anymore and not considered as bug. Resolves: #103088 Related: #98357 Related: #97816 Releases: main, 12.4 Change-Id: I4403420cc957cdef4bf077365deac0f7af621c71 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82972 Tested-by:
-
Oliver Hader authored
Change-Id: I706b9d7328f06eff3e7f7fb86ae3a3138615bfd4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82966 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Oliver Hader authored
Change-Id: Ibd1ea27ced45de785a6a417758b33a0461a97d97 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82965 Reviewed-by:
-
Oliver Hader authored
Write access to table `sys_file` is denied per default, unless data is being imported. In addition, write access to related FAL entities `sys_file_reference` and `sys_file_metadata` is denied in case a file on legacy storage (uid=0) is used or corresponding user does not have permissions to access a particular file. Resolves: #93969 Releases: main, 13.0, 12.4, 11.5 Change-Id: Ic8ac7132d732bd117aa63f6a33545ceb1d1f421d Security-Bulletin: TYPO3-CORE-SA-2024-006 Security-References: CVE-2024-25121 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82950 Tested-by:
-
