- Jan 15, 2014
-
-
Benjamin Mack authored
The current TYPO3 Core includes different types of caches. There are system-related caches (class loading cache, configuration cache, l10n_cache, extbase_object, extbase_reflection etc.) and frontend-related caches (chash cache, page cache, page section cache). The patch introduces the possibility to group caches. The core uses two groups "pages" with all page-related caches, and "system" that is used for compile-time caches and configuration caches. The new API is now used to be more flexible inside DataHandler clear_cacheCmd without having hooks, as the Cache Manager is used to clear all caches inside one hook. !!! The "Clear all caches" command does not flush caches for system-related caches anymore. Only "Clear Configuration Cache" or inside the install tool in the backend removes all the system caches. A new userTSconfig option is used to non-admins to be allowed to clear the system caches. Resolves: #54991 Releases: 6.2 Change-Id: I...
-
Thomas Blaß authored
When rendering images with CssStyledContent while using the features maxW and equalHeight at the same time, the rendering needs to pre- calculate the target sizes. Doing this the GifBuilder is used to determine the width and height of the file while still relying on the being a locally reachable path. Since the introduction of FAL uids will be present at that point and therefore this calcuation will fail. This change extracts the width and height of the image from the according file object which not only fixes the the mentioned issue but will be way more performant since the values doe not need to be derived from the filesystem. Resolves: #45086 Releases: 6.2 Change-Id: Icb03d337bb84851a5c905a45c4941fc9d9539033 Reviewed-on: https://review.typo3.org/26556 Reviewed-by: Wouter Wolters Reviewed-by: Frans Saris Reviewed-by: Thomas Blaß Tested-by: Thomas Blaß Reviewed-by: Benjamin Mack Tested-by: Benjamin Mack
-
Frans Saris authored
Currently it is only possible to create a temporary file with a given prefix and without any file extension. But for some use-cases you need a file with a certain file extension. This patch introduces a new optional parameter to GeneralUtility::tempnam() to make it possible to add e.g. a specific extension to the created file. In addition the occurrences in core, which can benefit from this, are adapted resulting in less orphaned temporary files in typo3temp. Releases: 6.2 Resolves: #54750 Change-Id: I19383bc8f6b387133bff2f4033f05b28e883d427 Reviewed-on: https://review.typo3.org/26650 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel Reviewed-by: Markus Klein Reviewed-by: Steffen Ritter Tested-by: Steffen Ritter
-
Oliver Hader authored
Resolves: #55026 Releases: 6.2 Change-Id: Ia1d03b4c3db6bb224b920b7252bd68df70053515 Reviewed-on: https://review.typo3.org/26842 Reviewed-by: Oliver Klee Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
Steffen Ritter authored
For most tests in the LocalDriverTest vfsStream is used to emulate the filesystem. This needs PHP filesystem functions to use the stream wrappers. For touch() this has been enabled with PHP 5.4. The reversal conclusion is, that this does not work with PHP 5.3 which causes failing tests there. As a result If the PHP version is 5.3 we skip the two tests. This is a follow-up to https://review.typo3.org/#/c/26520/ Resolves: #54230 Releases: 6.2 Change-Id: I4e92927e1d77f825bab8583318a944a8916051d5 Reviewed-on: https://review.typo3.org/26845 Reviewed-by: Steffen Ritter Tested-by: Steffen Ritter
-
Benjamin Mack authored
The maxitems entry for be_users / be_groups fields db/file mounts was raised in issue #55018. The DB schema of these fields should reflect the changes as well. Releases: 6.2 Followup to: #55018 Resolves: #55025 Change-Id: I475ed18d3210a68e476c1434fa83b0b410937c8a Reviewed-on: https://review.typo3.org/26837 Reviewed-by: Wouter Wolters Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Helmut Hummel authored
The class name needs to be determined through a lookup in the implementation configuration (AKA XCLASS). This runtime cache was removed in favor of a cache in the class loader. But this caching behavior also changed due to the package management API implementation. Releases: 6.2 Resolves: #55024 Change-Id: I8dc101c0c04c88e531907fcfaf82e529af483e01 Reviewed-on: https://review.typo3.org/26821 Reviewed-by: Steffen Ritter Tested-by: Steffen Ritter
-
Steffen Ritter authored
The Driver within the FileAbstractionLayer is the actual abstraction of a concrete file-system meant to unify access to several kind of storage-systems the file data might reside in. For each way of storing files there has to be a driver. Therefore a driver is solely a unique API to interact with an underlying storage system based upon its own identifier system. Opposite to that, the AbstractDriver (defining our Interface) knows about its storage, file- and folder-objects as well as indexes. The methods within the current driver need to implement more FAL-internal logic than one would expect from what the driver is purposed to. As a result only a few drivers are existing by now. In addition it's nearly impossible to change FAL interals without touching every driver out there. This change deals with these problems. In several steps the current driver API has been refactored to have less dependencies and only fullfills it's original purpose: the abstraction of a file storage system. The following things are considered: 1. Change every return value which has been an object to the identifier and adapt the ResourceStorage accordingly. 2. Change every method parameter being FileInterface, File, AbstractFile or Folder objects to a string: the identifier. 3. Get rid of the storage as a member variable, only the uid of the storage is needed at two places. 4. Remove all abstract methods from the AbstractDriver and put them in a newly created DriverInterface. 5. Exchange all references to AbstractDriver to the interface. 6. Remove unused methods, which came to light doing so. 7. Merge addFile/removeFile and *Raw since the do the same if no objects are in place. 8. Unify the creation of folder objects and how information is retrieved (analogue to files now). 9. Unify and simplify the methods for retrieving folder contents (files / folders). 10. Adapt the UnitTests of both classes to the changes. This also leads to the removal of some tests which are superfluous with that change. 11. Make the DriverRegistry check the implementation of the newly created interface. 12. Unify the parameter names in the methods. Releases: 6.2 Resolves: #54230 Resolves: #54231 Change-Id: I4a51572c6a10859e6fd5f12f6cb539950444992e Reviewed-on: https://review.typo3.org/26520 Reviewed-by: Frans Saris Tested-by: Frans Saris Reviewed-by: Benjamin Mack Tested-by: Benjamin Mack
-
Ernesto Baschny authored
Document that in the requirements section of the INSTALL.md. Resolves: #54883 Releases: 6.2 Change-Id: Idd80528493b9920f4488e359f13fe4304ac5fe25 Reviewed-on: https://review.typo3.org/26725 Reviewed-by: Wouter Wolters Reviewed-by: Philipp Gampe Reviewed-by: Aske Ertmann Reviewed-by: Oliver Klee Reviewed-by: Stefan Neufeind Reviewed-by: Michael Stucki Tested-by: Michael Stucki Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Alexander Stehlik authored
Since the mysqli interface recommends setting the charset using the mysqli API the utf8 charset will be initialized when establishing the database connection using mysqli_set_charset(). Additionally [SYS][setDBinit] can now be set to any value or can totally be removed. To make sure the database connection still uses the correct encoding an additional check is added to the database connection process that checks the MySQL character set session variables. Finally the old default value of [SYS][setDBinit] will automatically be removed if it is set to the old default value. Resolves: #41596 Releases: 6.2 Change-Id: I8d0a9eba50495d52accb59627147c1c87b6a9bb5 Reviewed-on: https://review.typo3.org/15369 Reviewed-by: Wouter Wolters Reviewed-by: Alexander Opitz Tested-by: Alexander Opitz Reviewed-by: Michael Stucki Tested-by: Michael Stucki Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Stefan Neufeind authored
* Use __DIR__ instead of dirname(__FILE__) (since PHP 5.3.0) * Use require_once for loading classes ("just once") Resolves: #47203 Releases: 6.2 Change-Id: I4b5d003a0bbabd91dcc7e58081eed41b5314da3f Reviewed-on: https://review.typo3.org/19952 Reviewed-by: Xavier Perseguers Reviewed-by: Oliver Klee Reviewed-by: Alexander Opitz Tested-by: Alexander Opitz Reviewed-by: Pascal Dürsteler Reviewed-by: Stefan Froemken Tested-by: Stefan Froemken Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Steffen Ritter authored
The FrontendContentAdapterService rewrites records so legacy TypoScript is able to work on the files to. To do so it queries the objects regarding the relations and fills the properties of the record new line separated as known from pre-6.x records. This change adds a runtime cache, so already processed records of are not processed again, if the next cObject for the same record is started. Resolves: #54953 Releases: 6.2, 6.1 Change-Id: I1f632f175075c9d85079ea83e343e35867a1fcca Reviewed-on: https://review.typo3.org/26786 Reviewed-by: Oliver Hader Tested-by: Oliver Hader Reviewed-by: Benjamin Mack Tested-by: Benjamin Mack
-
Benjamin Mack authored
In big installations, more than just 25 DB mount points are needed. Solution: Raise the default configuration to 100. Releases: 6.2 Resolves: #55018 Change-Id: I613a90bc6c15b7642f2c6b6b6ca4ec8221838c0b Reviewed-on: https://review.typo3.org/26834 Reviewed-by: Tom Ruether Tested-by: Tom Ruether Reviewed-by: Wouter Wolters Reviewed-by: Georg Ringer Tested-by: Georg Ringer
-
Alexander Stehlik authored
Since the default value of the page properties backend_layout and backend_layout_next_level is an empty string the value in the select item is changed from zero to an empty string for consistency. Additionally the BackendLayoutView will treat an empty string equally as a zero namely as a non set Backend Layout. Resolves: #52596 Releases: 6.2 Change-Id: Ic792f748d005f5749f24a3e979b304c23320c8fa Reviewed-on: https://review.typo3.org/24882 Reviewed-by: Wouter Wolters Reviewed-by: Stefan Neufeind Reviewed-by: Georg Ringer Tested-by: Georg Ringer
-
Ernesto Baschny authored
The API of the fluid image viewhelper had changed. This makes that change less breaking, by respecting the old order of parameters, thus allowing subclasses to continue working as usual. Also adds some comments in phpdoc for the parameters. Related: #53700 Resolves: #54411 Releases: 6.2 Change-Id: I11c8ec06ee263a18abd72a12e77a25899f73b475 Reviewed-on: https://review.typo3.org/26407 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel Reviewed-by: Philipp Gampe Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
Markus Klein authored
The ElementBrowser tries to access array indexes which do not exists. Fix this to prevent PHP warnings. Resolves: #54995 Releases: 6.2, 6.1 Change-Id: Ief660ae535f01bc593617667ce7eb81f8cd78cd3 Reviewed-on: https://review.typo3.org/26824 Reviewed-by: Oliver Klee Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
- Jan 14, 2014
-
-
Steffen Ritter authored
The link generation via typolink needs the domain record as well as the rootline to generate the links correctly. To save superfluous database queries some local caches are introduced. Furthermore the rootline cache does not use all information which is present after the database query. This information is unpacked here, too. As a result less requests to the CacheFrontend need to be done. Resolves: #54959 Releases: 6.2, 6.1 Change-Id: Iea7fff4c6c624a03b75523a7352b5f9736f2d57e Reviewed-on: https://review.typo3.org/26787 Reviewed-by: Jo Hasenau Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Helmut Hummel Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
Aske Ertmann authored
When using the folder tree (file, and folder navigation) popup (browse_links) a JS error occurs when opening new folders. This is due to incorrect handling of scope. This patch fixes the error for both RTE and normal link browser. Change-Id: I25fa0871405e06d6fc084985b3beba6396b872ad Resolves: #53826 Releases: 6.0, 6.1, 6.2 Reviewed-on: https://review.typo3.org/25633 Reviewed-by: Jan-Erik Revsbech Tested-by: Jan-Erik Revsbech Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Peter Niederlag authored
Fixes a problem with the TemplateAnalyzer introduced by #43540 - Always add both defaultTypoScript_setup and defaultTypoScript_constants. - Add information for defaultTypoScript into hierarchyInfo. Change-Id: I15ad5f268eb167d6c8f027e1891409d9ead64539 Resolves: #53352 Releases: 6.2, 6.1, 4.7 Reviewed-on: https://review.typo3.org/26738 Reviewed-by: Markus Klein Reviewed-by: Michiel Roos Tested-by: Michiel Roos Reviewed-by: Stefan Neufeind Reviewed-by: Benjamin Mack Tested-by: Benjamin Mack
-
Ingo Schmitt authored
Added index to original,task_type,configurationsha1 this improves performance for non-cached pages and backend calls Resolves: #54729 Releases: 6.2 Change-Id: I2ecfe62c64b89078da5c04ee708ea3c343d4fc9a Reviewed-on: https://review.typo3.org/26628 Reviewed-by: Oliver Klee Reviewed-by: Steffen Ritter Tested-by: Steffen Ritter Reviewed-by: Benjamin Mack Tested-by: Benjamin Mack
-
Georg Ringer authored
It is possible that PageRepository::getRecordOverlay() returns NULL which throws an exception as ArrayObject::exchangeArray() either needs an array or an (array-)object. The fix adds a small check for the Result of the PageRepository function. Change-Id: I248125154220e6250c4a2a6fdf29759211bf214b Resolves: #54169 Releases: 6.2 Reviewed-on: https://review.typo3.org/25914 Reviewed-by: Steffen Ritter Reviewed-by: Oliver Klee Reviewed-by: Frans Saris Tested-by: Frans Saris Reviewed-by: Georg Ringer Tested-by: Georg Ringer
-
Alexander Opitz authored
At the moment we load the session data to verify authentication and again to verify session existence. This isn't necessary. Also removing the session deletion if we didn't find session data. Resolves: #53598 Releases: 6.2 Change-Id: Ibc3c4ebc5c1bbca970374172f714bddcd37b539a Reviewed-on: https://review.typo3.org/25510 Reviewed-by: Thorsten Kahler Tested-by: Thorsten Kahler Reviewed-by: Wouter Wolters Reviewed-by: Michiel Roos Tested-by: Michiel Roos Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind Reviewed-by: Ernesto Baschny Tested-by: Ernesto Baschny
-
Georg Ringer authored
Due refactoring the property $languageMode is compared but is never filled. The property from the querySettings has to be used. Change-Id: I8f66a10548213513b8cc5a3a90cc219ed5f91918 Resolves: #54182 Releases: 6.2 Reviewed-on: https://review.typo3.org/25932 Reviewed-by: Markus Klein Reviewed-by: Georg Ringer Tested-by: Georg Ringer
-
Georg Ringer authored
Use the proper template mechanism and a toolbar for the cshmanual ext to let it look like all other backend modules. Change-Id: I6b1a4cfe036034d09caa71a8914eed359f2da930 Resolves: #54184 Releases: 6.2 Reviewed-on: https://review.typo3.org/25933 Reviewed-by: Georg Ringer Tested-by: Georg Ringer
-
Stefan Neufeind authored
Change-Id: I1aaf487c43adc7e36fa98aaf972094fa13d1e764 Resolves: #53902 Releases: 6.2 Reviewed-on: https://review.typo3.org/25667 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Georg Ringer Tested-by: Georg Ringer
-
- Jan 13, 2014
-
-
Roland Waldner authored
"textfile" will be replaced by "text file" Resolves: #54893 Releases: 6.2 Change-Id: Ic7ce106a016f242cc47c70539876ff9810954a9b Reviewed-on: https://review.typo3.org/26736 Reviewed-by: Michiel Roos Tested-by: Michiel Roos Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
Torben Hansen authored
Reloads the template menu after the template title has been changed. Resolves: #51805 Releases: 6.2, 6.1 Change-Id: I5d987a3ffc6a11dfa1ebe54480c9c3b69ccc1959 Reviewed-on: https://review.typo3.org/26766 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
Xavier Perseguers authored
array_shift() takes argument by reference. Releases: 6.2 Fixes: #54933 Change-Id: I94c16bc739f36d669640701561ff94aebd63b1f5 Reviewed-on: https://review.typo3.org/26779 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
Markus Klein authored
Resolves: #54963 Releases: 6.2 Change-Id: I58b1f6109872d6eb8059fceb1bec1af7134e84e2 Reviewed-on: https://review.typo3.org/26789 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Thomas Maroschik Tested-by: Thomas Maroschik Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
Tomita Militaru authored
Add check for libxml bug when saving special characters ">><<" in a flexform Resolves: #51271 Releases: 6.2 Change-Id: I5d120cdfeb9538209273c8761d017cb67256617b Reviewed-on: https://review.typo3.org/25089 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Oliver Klee Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
Steffen Ritter authored
The indexing pre-calculates the file hash and stores it in the sys_file table. Sadly the getter of file objects never looks at this again and always recalculates the hash via the driver, which is very slow. Resolves: #54235 Releases: 6.2, 6.1, 6.0 Change-Id: I16bfa2126031f26b8e31da8d8c0b3fc07d0217dc Reviewed-on: https://review.typo3.org/26689 Reviewed-by: Oliver Hader Tested-by: Oliver Hader Reviewed-by: Oliver Klee Reviewed-by: Benjamin Mack Tested-by: Benjamin Mack
-
Helmut Hummel authored
It might happen that activating or deactivating a package throws an exception because other inactive packages are available on the system with broken or not fulfilled dependencies. To solve this issue, only active packages are regarded when resolving dependencies. To remove a side effect from this change, cache clearing in extension manager is moved to a later point (see #54951). This needs a proper fix in another change, but makes this fix work for now. Resolves: #54879 Releases: 6.2 Change-Id: Id81b66b2d2b6f4ba7d1c6ea2d001c271982539b3 Reviewed-on: https://review.typo3.org/26719 Reviewed-by: Thomas Maroschik Reviewed-by: Markus Klein Tested-by: Kasper Ligaard Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
Ingo Schmitt authored
Since sys_file_metadata records are enabled to be translated the file list module is capable of metadata translations, too. In order to directly link to edit or create a new translation depending on wether this language already has been translated for each file the metadata translations are fetched from the database. In order to improve that query this patch adds an index including l10n_parent and sys_language_uid. Resolves: #54927 Releases: 6.2 Change-Id: I6cc5c74505e96647c5ddd7e7ee77518176d2ba0b Reviewed-on: https://review.typo3.org/26774 Reviewed-by: Steffen Ritter Tested-by: Steffen Ritter Reviewed-by: Benjamin Mack Tested-by: Benjamin Mack
-
Ingo Schmitt authored
There are missing indexes as well as a mismatch between the TCA definition (and therefore actual usage) and the SQL definition at database level. This change * adds combined index to deleted / hidden to speedup the query initializing storages in Be_UserAuth * changes SQL definition for field "name" to match their usage in TCA Resolves: #54923 Releases: 6.2 Change-Id: I86f345a941802304ed7fbe29d00ae38130f8e5d2 Reviewed-on: https://review.typo3.org/26768 Reviewed-by: Steffen Ritter Tested-by: Steffen Ritter Reviewed-by: Oliver Klee Reviewed-by: Benjamin Mack Tested-by: Benjamin Mack
-
Ingo Schmitt authored
All page, content and file-records TCEforms render a category tree in order to assign these. The tree building executes the same queries quite often. In order to optimize these queries this change adds * an index "category_parent" to sys_category.parent in order to for the parent category while index "parent" currently indexes the pid the record is stored. * a combined index "category_list" to columns pid, deleted and sys_language_uid. Resolves: #54929 Releases: 6.2 Change-Id: I1d42ba7171dc1213d5d5559ae190092acaa57464 Reviewed-on: https://review.typo3.org/26775 Reviewed-by: Oliver Klee Reviewed-by: Steffen Ritter Tested-by: Steffen Ritter Reviewed-by: Benjamin Mack Tested-by: Benjamin Mack
-
- Jan 12, 2014
-
-
Markus Klein authored
The Indexer of indexed_search tries to insert NULL values into NOT NULL columns of the database. Since #53662 NULL values are passed to the database, hence these insert statements now fail. Resolves: #54917 Releases: 6.2 Change-Id: Ia935abe14b9c3be2062f1b38ec98fb63921a1c2f Reviewed-on: https://review.typo3.org/26757 Reviewed-by: Georg Ringer Tested-by: Georg Ringer
-
- Jan 11, 2014
-
-
Nico de Haen authored
Elements in LazyObjectStorages should not be validated, since the values would be reconstituted from persistence anyway. This patch adds the same behaviour as implemented in Flow and adds the tests found in Flow (and one additional test). Resolves: #53816 Releases: 6.2 Change-Id: I65f62a4ef6777e3678b2fdd06fc58d828bb8cb87 Reviewed-on: https://review.typo3.org/25549 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Steffen Müller Tested-by: Steffen Müller
-
Francois Suter authored
In #54613, usage of parameter $addTofeInterface in method ExtensionManagementUtility::addTCAcolumns() was deprecated. However it is used in a few places of the Core. Those calls must be modified too. Resolves: #54899 Releases: 6.2 Change-Id: I22696cb4655578dc583edcb9cfa4693b69e228c8 Reviewed-on: https://review.typo3.org/26745 Reviewed-by: Oliver Klee Reviewed-by: Eric Chavaillaz Tested-by: Eric Chavaillaz Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Steffen Müller authored
A logger name is mandatory to configure a particular logger. The convention is use __CLASS__ as the logger name when instanciating a new logger using LogManager->getLogger(). Resolves: #54909 Releases: 6.2, 6.1 Change-Id: I5dbda770ec92fd75c3aff9ed89c68c5666669b07 Reviewed-on: https://review.typo3.org/26754 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
- Jan 09, 2014
-
-
Steffen Müller authored
One can limit records in the backend log module to a custom period of time using the "User defined" mode and a start and stop field. Leaving these fields empty is now supported in the corresponding domain model setters by adding default values to the DateTime arguments. Resolves: #53975 Releases: 6.1, 6.2 Change-Id: I944322bb3747a29fab33c3d32e17dd070c7cb6db Reviewed-on: https://review.typo3.org/26723 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-