- Mar 14, 2023
-
-
Thomas Hohn authored
Added some guards, isset(), to ensure that array keys that aren't defined are accessed and throws PHP warnings. Resolves: #99845 Releases: main, 11.5 Change-Id: I009f5d23a9bf3cd112dc786256d1144983736dd3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78041 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de>
-
Christian Eßl authored
When opening a page in the view module, that belongs to a page tree with no valid site configuration, an exception was thrown, because the ModuleData clean-method was expecting at least one item in the language array. Resolves: #100092 Releases: main Change-Id: I60ae316e29ec87d62ba8728103283bbe0778f0c8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78032 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Oliver Klee authored
Now the parameter names are consistent with those of the other explode-related methods. Resolves: #100145 Releases: main Change-Id: Ibd8fd736741a8f1cdad2e33ae3e777412cd383eb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78098 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Josef Glatz <typo3@josefglatz.at> Tested-by:
-
Thomas Hohn authored
The constructor of UnableToLinkException should be strictly typed, since the method getLinkText() is strictly typed. Also make the variable declaration of $linkText strictly typed. It will throw an error if $linkText isn't a string. Added a todo for TYPO3 v13. Resolves: #100119 Related: #100106 Releases: main Change-Id: Ifbb9a3f5b4aa1fd1588eb0596731377f41bc5ffd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78072 Tested-by:
-
Sybille Peters authored
Use alt text "Logo" (instead of "TYPO3 Logo") in the SystemEmail Fluid layout if a custom logo is used. The layout SystemEmail is used by default when sending Fluid emails. It is for example used when sending a test email via the "Environment" module in the install tool or "Admin Tools" in the backend. If an image is configured in the backend Extension Configuration login.loginLogo, this image is used and the text is added as alt text. Previously, "TYPO3 Logo" was always used as alt text, which is awkward if the alt text is displayed instead of the logo, which may happen for several reasons Resolves: #100081 Releases: main, 11.5 Change-Id: Ia7c1d7ab7a008fb6ed2f3851db5e1af171a4af9f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78023 Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
-
Helmut Hummel authored
Instead of requiring strictly the TYPO3 implementation of a console Application, the property is allowed to hold an instance of the base application class. Releases: main Resolves: #100160 Change-Id: I40934ac7a5534f211021b0ab331ca9903a307243 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78116 Reviewed-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
- Mar 13, 2023
-
-
Torben Hansen authored
This change adds a native type declaration for the property `$contentFields` in `ContentVisibleFieldsTest`. Resolves: #100149 Releases: main Signed-off-by:
-
Stefan Bürk authored
Creating new `ext:reactions` records are broken and emits an sql error message. This happens when it's tried to switch to the core-shipped type. >> 2: SQL error: "Field 'fields' doesn't have a default value" Using a default value on database level does not work with all database backends TYPO3 v12 officially supports, which has been tried with #100088 and mitigated with #100101. So that's not an option here. This change bakes the default value for `json` type fields using TCA default setting again, which has been the way the original `type=user dbType=JSON` variant used with #99226. Resolves: #100154 Related: #100101 Related: #100088 Related: #99226 Related: #99062 Releases: main Change-Id: I07533f36cfbc1f627b14727195bbcbd5c4b1e35c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78107 Tested-by:
Frank Nägler <frank.naegler@typo3.com> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
Torben Hansen authored
This change adds constructor property promotion in ext:opendocs `OpenDocumentController`. Resolves: #100150 Releases: main Signed-off-by:
-
Sybille Peters authored
The PHPDoc block in the ViewHelper source is used to render the ViewHelper documentation. Remove link to Changelog with incorrect formatting in asset.css ViewHelper, which never worked. As the Changelog is from version 10.4, there is little benefit and more risk of linking to outdated information in the future. Resolves: #100151 Releases: main, 11.5, 10.4 Change-Id: I0b11e7ec90ccfa8864ca4ddaa7ca83004fe266c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78105 Tested-by:
-
- Mar 10, 2023
-
-
Oliver Klee authored
Also fix some types as needed. Resolves: #100134 Releases: main Change-Id: I87cebe0a3a7e3cb97a9a1802640ed856d7939f39 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78085 Reviewed-by:
-
Alexander Schnitzler authored
Releases: main Resolves: #100068 Change-Id: Ibc06f9c6b227f956290e02cc9bbd44587bac6f78 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77851 Reviewed-by:
-
Torben Hansen authored
The cookie warning message in ext:felogin depends on conditions which are never met and can not be fixed easily. Additionally, failed authentication in ext:felogin already shows a similar message, so the non-working cookie message can safely be removed. This change removes code affecting the non-working cookie warning message. Resolves: #100135 Related: #99710 Releases: main Signed-off-by:
Oliver Hader <oliver.hader@typo3.org>
-
Christian Eßl authored
Fix a missing type cast, where on creating a site with only a digit number as identifier, both the backend and frontend would throw a type error. Resolves: #100083 Releases: main Change-Id: Ic91d45390449bf7a71779570bd89812fdfd33145 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78025 Tested-by:
-
Alexander Schnitzler authored
Extbase creates class schema objects for classes to gather information for further analysis. One part of that information is property types. In recent TYPO3 and PHP versions, extbase did expect a property to have zero or one type. Due to changes to PHP (Union Types/Intersection Types), extbase's internal behaviour needs to change and detect all declared types. This is especially useful in models whose properties can now be declared as public Entity|LazyLoadingProxy|null $reference = null; Releases: main Resolves: #98132 Change-Id: I36dd8fd3d152e8dbf0443a5a1866c444d6fecbd0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75417 Tested-by:
Stefan Froemken <froemken@gmail.com> Reviewed-by:
-
- Mar 09, 2023
-
-
Oliver Klee authored
This version removes some false positives from the baseline. > composer req --dev phpstan/phpstan:^1.10.6 > composer req --dev phpstan/phpstan-phpunit:^1.3.10 > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #100133 Releases: main, 11.5 Change-Id: I1120a6b808baff1af8993ca700725b09987e76ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78084 Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Andreas Fernandez authored
There was a timing issue related to the LiveSearch form. `Modal.advanced()` invokes an AJAX request, while the event handler for `typo3-modal-shown` expects that the request sent a response. This might not be the case when either the network is slow or animations are disabled as the event is always faster dispatched than the request can send a response. The generic handling is now moved into an `ajaxCallback`, executed when fetching the data finished. To be able to still focus the search field and mark its content, event handlers for 'modal-loaded' and 'typo3-modal-shown' events are installed, as both events may be dispatched in any order. Resolves: #100025 Releases: main Change-Id: I8aca8ba330af55ce915a414dc5a52ba6eb2af1f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77941 Tested-by:
-
Oliver Klee authored
For variable arguments, the type annotation needs to match the type of the single arguments, not an array of the single arguments. Resolves: #100127 Releases: main, 11.5, 10.4 Change-Id: Ic107cff8e08c00b18ced783d61783ed182039fd3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78080 Reviewed-by:
Thomas Hohn <tho@gyldendal.dk> Tested-by:
-
Benjamin Kott authored
We renamed the eslint configuration to follow the recommended standards so developers IDEs will pick up the configuration more easily. The ruleset was adapted to follow a wider range of recommendations. - eslint:recommended - @typescript-eslint/recommended - lit/recommended - wc/recommended In addition we now also force more kinds of spacing rules to avoid IDEs having different opinions on how to format for example includes. The only recommendation we don't want to follow is - @typescript-eslint/no-inferrable-types. We don't want to disallow being explicit. Instead of turning off rules we cannot fully fulfill as of now, we are now changing the configuration to warning. This will help developers spotting mistakes more easy when writing code. Rules that are currently in "warn" mode: - @typescript-eslint/ban-types - @typescript-eslint/no-explicit-any - @typescript-eslint/no-this-alias To only check for errors run in the Build directory: - npx eslint ./Sources/TypeScript/ --quiet We are removing the custom member ordering and preferring the default. @typescript-eslint/member-ordering Resolves: #100126 Releases: main Change-Id: I6f09f82c0bdcde1aa3edec66b3b6ab028d5bb242 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78040 Tested-by:
-
Daniel Hettler authored
When indexing files the FileContentParser collects some metadata e.g. title, description and keywords. For some files these information are not given and the parser breaks in an PHP 8 environment. Resolves: #100122 Releases: main, 11.5 Change-Id: I54b5512c7e30c9719654591d520943733fbfe920 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78076 Reviewed-by:
Albrecht Köhnlein <ak@koehnlein.eu> Tested-by:
-
Christian Eßl authored
Ensure the language of the checked record actually exists in the site, in case orphan records of other languages are present. Resolves: #100111 Releases: main Change-Id: I5cb3d2e09cfc86b5d43eba9e16b3833afe18e6b8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78046 Tested-by:
Kevin Appelt <kevin.appelt@icloud.com> Tested-by:
-
- Mar 08, 2023
-
-
Nikita Hovratov authored
Improve readability of the method by extracting distinct cases into own blocks with early return statements. Case 1: "EXT:" path Case 2: (already) absolute path Case 3: relative public path Resolves: #100094 Releases: main Change-Id: I664c3611ef86c779c0398c7a4f938297eb591a81 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78034 Reviewed-by:
-
Oliver Klee authored
Resolves: #100080 Releases: main, 11.5 Change-Id: If607b7dc6d8f7bdc984751835433dabcc6cad085 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78022 Tested-by:
-
- Mar 07, 2023
-
-
Alexander Schnitzler authored
ObjectMonitoringInterface is a signaling interface for extbase internals to signal that an object state can be monitored. Its main purpose is to tell the persistence manager if an object or an object collection is so called dirty, i.e. if changes need to be persisted or not. This change lets DomainObjectInterface extend ObjectMonitoringInterface instead of AbstractDomainObject. Abstract classes must never be external api, they should just contain boilerplate/repetative code. With this change extbase can perform actions based on implemented interfaces, i.e. guaranteed functionality instead of checking object instances. Releases: main Resolves: #100069 Change-Id: I65548f3fe3f6a51c2b87e67c35642c431e2d7bb2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78012 Tested-by:
-
Alexander Schnitzler authored
This change introduces alternative methods to magic method __call() of extbase's Repository class. The magic method allowed for calling findBy[Property](), findOneBy[Property]() and countBy[Property](). Those methods are now implemented with a slightly different method signature but with type declaration and phpstan support. The naming follows the one of doctrine/orm which is implemented exactly the same. The new methods are: - findBy(array $criteria, ...): QueryResultInterface - findOneBy(array $criteria, ...): object|null - count(array $criteria, ...): int Using the magic methods is deprecated but will only trigger an E_USER_DEPRECATED error as of version 13. Releases: main Resolves: #100071 Change-Id: I1b51dd5b583a225a8a4d6f948810b1e5ef5d2257 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78014 Reviewed-by:
-
Stefan Bürk authored
With #91776 auto-created redirects have been stored with a pid of the page, which the slug has been changed. This was streamlined and changed to use the site rootPageId instead with #99044, which reverted the original use-case. This change implements two new PSR-14 events around each auto-create-redirect: * `ModifyAutoCreateRedirectRecordBeforePersistingEvent`: can be used to modify the redirect record before it is persisted * `AfterAutoCreateRedirectHasBeenPersistedEvent`: can be used to chain further task after the redirect has been persisted to the database. It's kind of a plain notification event. Resolves: #99834 Related: #99802 Related: #99044 Related: #91776 Releases: main Change-Id: I974020b148a3b5eb109624648016a79ed557af3e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76539 Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
-
Andreas Fernandez authored
To ease the usage of `group` fields in the FormEngine like e.g. in the "Insert records" content element, the record overview now shows the path to the location where each assigned record is stored, respectively. Resolves: #100093 Releases: main Change-Id: I1623b506727b46ccc86361e2c061c7e2c705a50f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78033 Reviewed-by:
-
Alexander Schnitzler authored
Inside the extbase context child relations are always ordered by the foreign_sortby field if set or by order of creation. Even if the field foreign_default_sortby is set, it only impacts the order of the backend view. This patch brings the order of extbase results inline with the order of the backend view. Resolves: #64197 Releases: main, 11.5 Change-Id: I582576b5ac3741e2bbc4107664140fd9a2f63a16 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77985 Reviewed-by:
-
Torben Hansen authored
This change cleans up middlewares by * using constructor property promotion where possible * strict types where possible * Remove `@throws` annotations for exceptions never thrown * Remove value in function call, if it equals the default Resolves: #100090 Releases: main Signed-off-by:
-
Benni Mack authored
This change splits up * Edit/List/Add view of Scheduler * Check Setup * Available Tasks in each a separate controller + a custom third-level module. This way, it is then possible to separate the main scheduler module into custom actions (via subroutes) making the code a tiny bit more manageable. The previous "system_txschedulerM1" module name is now aliased to "scheduler_manage" (third-level), as the main scheduler module is now solely called "scheduler". The old name is kept for backwards-compatibility reasons. A note for historical fans: "M1" stands for "module 1" within the "tx_scheduler" extension. Resolves: #100104 Releases: main Change-Id: I2ba7c76899853864de42a11f2dc45c40ce699c91 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78038 Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
-
Andreas Fernandez authored
This patch removes jQuery from the shortcut handling. Also, some minor refactorings were done: * use proper events for submit / cancel handling * submit the form as-is instead of building a custom payload Resolves: #100099 Releases: main Change-Id: I25fe414ba7bd8f513f6864a915fec8c75b61a16a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78039 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Stefan Bürk authored
With #100088 the `json` field handling has been changed from TCA `dbType = json` to `type = json` along with automatic db field creation, if not provided by `ext_tables.sql`. `\TYPO3\CMS\Core\Database\Schema\DefaultTcaSchema` has been changed to create a native json field with the default value of '[]' if not manually provided. MariaDB allows setting of default value for `text` and `json`fields, the competitor `MySQL` not. Many developers are not aware of this difference. `doctrine/dbal` does not help to avoid invalid field defaults. This change removes the default value for json field in the `DefaultTcaSchema` to restore cross database compatibility with `MySQL` again. Resolves: #100101 Related: #100088 Releases: main Change-Id: Id49ed0a4212386f68bf92d799abef2307cf32ac3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78043 Reviewed-by:
-
- Mar 06, 2023
-
-
Benjamin Kott authored
The new content element wizard is now a custom element with shadow dom enabled. The reactive component works on the data set assigned. Every element has a state the component respects and acts accordingly. Resolves: #100065 Releases: main Change-Id: I687b2c49e21d043867b6606ad40b7809980e35ec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77983 Reviewed-by:
-
Frank Naegler authored
A new TCA type "json" is introduced, which allows to simplify the configuration when working with fields, containing JSON data. It replaces the previously introduced dbtype=json of TCA type "user" (see: #99226). FormEngine will display the JSON data using codemirror, in case EXT:t3editor is installed and enabled for the field. Otherwise, a standard textarea HTML element is used. Using the new type, corresponding database columns are added automatically. Resolves: #100088 Related: #99226 Releases: main Change-Id: I49ab049966a86696910a7c18a7c45be00c162ca7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77798 Tested-by:
-
Andreas Fernandez authored
The "superglobal" `TYPO3.Utility` TypeScript module was removed in v10 with #87339. However, the related definition in our index.d.ts was forgotten, which is now removed. Resolves: #100095 Related: #87339 Releases: main, 11.5 Change-Id: Iece43a40b93f8ebfd1c312c09566600272bdfe10 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78035 Reviewed-by:
-
Torben Hansen authored
The redirect mode `referer` has been fixed with #91844. The fix is however incomplete, since it always uses the current HTTP_REFERER for redirect evaluation. This is problematic, if the login fails due to wrong credentials. In such a scenario, the user is redirected to the login page, which also overwrites the original HTTP_REFERER and results in the user being redirected to the login page after successful login. This patch ensures, that the original HTTP_REFERER is evaluated in the loginAction and passed as a variable to the login form, where it is used in the hidden field `referer`. This ensures, that the initial evaluated referer is kept in the failed login scenario. Resolves: #99920 Related: #91844 Releases: main, 11.5 Signed-off-by:
-
Torben Hansen authored
The current ContextData DTO contains a fixed set of properties for usage in password policy validators. In order to make the DTO more flexible, the class now internally uses an array to store data as key/value pairs. Additionally, the methods `getData()` and `setData()` have been added, which extension authors can use in upcoming PSR-14 events in order to enrich the object with custom data. Resolves: #99574 Releases: main Signed-off-by:
-
Helmut Hummel authored
The Symfony Expression language is able to evaluate any value from an expression, not only booleans. Open up TYPO3 wrapper API to reflect this, to allow extended usage of our API wrapper. Instead of only allowing boolean returns, the caller of the Resolver API is now responsible for casting the result of the expression to bool, if required. Also allow to pass additional context specific variables to the evaluate function, as it is not always possible to provide those through a global API, when some context is only available at the time of the evaluation of the expression. Resolves: #100073 Releases: main Change-Id: I093fb8ce37ee98f995e5ab707186917ec879d836 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78016 Reviewed-by:
-
Thomas Hohn authored
If the page record could not be resolved by getPage_noCheck, throw a PageAccessFailureReasons exception. Resolves: #99648 Releases: main, 11.5 Change-Id: Iecec94eea65814a695cfce1559f7c96bb0cde1df Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77505 Reviewed-by:
-
- Mar 05, 2023
-
-
Stefan Bürk authored
Due a regression since GitLab runner 15.1,we cannot use the official docker dind image to raise runner version to keep up with the TYPO3 gitlab instance. Because of other issues, using a custom docker dind image with changed expose port for the healthcheck to work around that issue is needed. See: https://gitlab.com/gitlab-org/gitlab-runner/-/issues/29130 After Gitlab has released a proper fix for this, this should be reverted and the official docker dind image used again. Resolves: #100086 Releases: main, 12.1, 11.5, 10.4 Change-Id: I4b433ba7f3a42c718b4d436cf42cdf619b9094ca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78028 Tested-by:
-
