- Jun 09, 2018
-
-
Benni Mack authored
This fixes a functional test in EXT:workspaces, allowing for getting rid of an extra check in the frontend request workflow. Resolves: #85199 Releases: master Change-Id: I642fca3a2873f0fe758164fca3f9261480dbc4da Reviewed-on: https://review.typo3.org/57074 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Frank Naegler authored
This patch prevent putting invalid data into localStorage in the rare case that the AJAX call does not provide icon markup. Resolves: #85184 Releases: master Change-Id: Icddd88232bf9ac5f77e08ed7fbac475af8b469eb Reviewed-on: https://review.typo3.org/57146 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Benni Mack authored
The new functionality introduced in #85160 adds TCA control database fields dynamically. However, newly created extensions add these fields (except "uid" which is a primary column) at the end after the content-related fields. The patch re-orders the columns to be added to move them to the very beginning. Resolves: #85195 Related: #85160 Releases: master Change-Id: Ibcf77ae3fea41f067dca0f247bef50d00bdd014f Reviewed-on: https://review.typo3.org/57155 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
Richard Haeser authored
Move the new SEO fields to EXT:seo and prepare the extension for some basic SEO features. Resolves: #85194 Releases: master Change-Id: I6ec087928080e217ce1824b2e9ad5cf0ca0606c8 Reviewed-on: https://review.typo3.org/57148 Tested-by:
-
Christian Kuhn authored
TYPO3\TestingFramework\Core\FileStreamWrapper belongs to the testing-framework package. The unit test case has been moved to it an can be removed from core. Resolves: #85192 Related: #85096 Releases: master Change-Id: I4d83f92275e34fdad3eac2550db4d3895b141f36 Reviewed-on: https://review.typo3.org/57154 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Christian Kuhn authored
The backend route dispatcher with its different controller incarnations benefits from a basic code coverage. Resolves: #85191 Related: #84196 Releases: master Change-Id: I0ff1efae64c41e7fbeba8fb3569c5601cb005669 Reviewed-on: https://review.typo3.org/56095 Tested-by:
-
- Jun 08, 2018
-
-
Mathias Brodala authored
Resolves: #85119 Releases: master, 8.7 Change-Id: If9c00379c1ac671bd6bb622ace47864866c34446 Reviewed-on: https://review.typo3.org/57091 Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
Christian Kuhn authored
With an upcoming feature to run TYPO3 on sqlite, the database may end up within Web folder depending on system setup. It may later come with additional checks to prevent a direct database download, but it's a good step to deny web access to .sqlite files via default .htaccess already. Resolves: #85188 Releases: master Change-Id: Id382082f13fbce750b7cb3db98ddb1bc41b10f1e Reviewed-on: https://review.typo3.org/57150 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Christian Kuhn authored
typo3/testing-framework 3.7.0 supports sqlite db platform for functional tests. The patch updates the dependency and adds sqlite functional tests in bamboo pre-merge and nightly. composer update typo3/testing-framework typo3DatabaseDriver=pdo_sqlite bin/phpunit -c \ vendor/typo3/testing-framework/Resources/Core/Build/FunctionalTests.xml There are some know issues already, especially the database schema analyzer of the install tool behaves weird. However, this patch is a first step towards sqlite support in the core. Change-Id: I8e8474dabdf4015a32d3c938adc576fba9b5a5bd Resolves: #85187 Releases: master Reviewed-on: https://review.typo3.org/57137 Tested-by:
-
Christian Kuhn authored
Depending on DB platform, empty LOB fields can be returned as NULL value (sqlite) or as empty string (mysql, our postgres setup, mssql). The patch adapts a minor detail in DataHandler since isset(null) is false, but isset('') is true, it uses an array_key_exists() instead for diff check on transOrigDiffSourceField / l10n_diffsource field to align these two possible different db return values. Resolves: #85186 Releases: master Change-Id: I56c87fa519a0c787515eff403d48ac84e513300d Reviewed-on: https://review.typo3.org/57149 Reviewed-by:Daniel Siepmann <daniel.siepmann@typo3.org> Tested-by:
-
Ralf Zimmermann authored
Move the property merge behavior from setOptions() into the related methods (setRenderingOption(), setProperty(), setDefaultValue()). Releases: master Resolves: #85072 Change-Id: I1c002aeb8d889af68d6147d5c588709cd89ebf3c Reviewed-on: https://review.typo3.org/57045 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
Christian Kuhn authored
typo3/cms-styleguide has accidently been made a require instead of a require-dev dependency in composer.json composer require --dev typo3/cms-styleguide ^9.1 Resolves: #85181 Related: #85180 Releases: master Change-Id: Id109894e862ce5ac55a5533eccb8e25a9d8a6049 Reviewed-on: https://review.typo3.org/57145 Tested-by:
-
Christian Kuhn authored
Brings a set of new adaptions to new core functionality. Uses new core feature 'auto-create db fields' to reduce ext_tables.sql. composer require typo3/cms-styleguide ^9.1 Change-Id: I386eec9da50bd3ce7eb5ebb9af8957d3b1c8d9ac Resolves: #85180 Releases: master Reviewed-on: https://review.typo3.org/57144 Tested-by:
-
- Jun 07, 2018
-
-
Christian Kuhn authored
Use a dummy extension and .csv imports from the functional test framework instead of creating tables and records on the fly. Resolves: #85179 Releases: master Change-Id: Ia8f077984e588a2bb142a0e516aad198f914bec9 Reviewed-on: https://review.typo3.org/57143 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Frank Naegler authored
With #85016 the PageTSConfig handling has been changed which broke overloading RTE config by PageTSConfig. This patch removes the obsolete 'properties' check to fix the problem. Resolves: #85173 Related: #85016 Releases: master Change-Id: I85e6d5d9d656ee578451e54f2e226e37cb101fc6 Reviewed-on: https://review.typo3.org/57138 Tested-by:
-
Christian Kuhn authored
The ext:impexp related functional export tests compare with different target .xml file exports depending on the used db engine. This is ugly and pain to maintain. The patch aligns last differences between the generated exports by fixing sorting bugs in fixture db rows and adding an explicit order by at test preparation stage. Additionally, a column type bug in irre_tutorial fixture extension got resolved. The different .xml export file comparison fixtures per db engine are then merged into one and the split logic within tests removed. Change-Id: I429d5127e09c3e3714edae938cb0bf796b3274fd Resolves: #85178 Releases: master Reviewed-on: https://review.typo3.org/57141 Reviewed-by:
-
Christian Kuhn authored
Method BackendUtility::getRecord() returns strings or integer values for number columns like int / bigint. This detail depends on the underlying driver, for instance mysqli returns integers for those fields, while native pdo_mysql and our pdo_pgsql setup return strings for everything. This leads to different xml files when exporting records depending on driver, since GeneralUtility::array2xml() may add type="integer". That's especially nasty for the functional export tests and is one reason we have to maintain dedicated xml fixture files per db driver. During import, the type value does not matter, it needs to be able to cope with both variants anyway. The patch now just forces strings for all to-be-exported row values. Resolves: #85175 Releases: master Change-Id: Ic132d8abd906b34c59279ce025c0bdd65e954672 Reviewed-on: https://review.typo3.org/57140 Reviewed-by:
-
Christian Kuhn authored
Adds a class that auto creates TYPO3 "management" related database columns and indexes based on TCA 'ctrl' information without having them specified in ext_tables.sql. The feature .rst file outlines field details. Goals: * Save extension developers time. * Less copy+paste issues and different general fields definitions. * Reduce number of boilerplate fields in ext_tables.sql. * Bring schema of management fields under core control. Non goals: * No full substitution of ext_tables.sql by TCA: "Business" fields from 'columns' are NOT created automatically. This would require further thoughts and code disentangling. * No new extension API. * No "migration" approach or similar. Notable patch details: * The patch is a revamped version of issue #81234 that has been abandoned. As requested in the review of #81234, the code now hooks in after ext_tables.sql has been parsed into the doctrine schema. * Field defintions of ext_tables.sql take precedence, auto fields are only added if ext_tables.sql does not define a column or index. This makes the patch fully backwards compatible. * No deprecation for obsolete field definitions in ext_tables.sql is logged. * Many core fields are aligned to a central definition and slightly change. For instance "uid" is now always an unsigned int. * Reduce all core's ext_tables.sql files as well as the functional testing related ext_tables.sql files down to the business fields * A relatively huge series of test adaptions: Especially the ext:impexp related functionals now create dumps with differently sorted fields - This is no problem during import. * Field t3_origuid of sys_file_reference has never been registered in TCA as ['ctrl']['origUid'], is thus unused and removed as obsolete. * The extension manager no longer applies possible destructive changes, it only adds missing columns and tables when loading / updating extensions. It however considers *all* ext_tables.sql files, not only the one the extension in question provides. See the important .rst file for details. Change-Id: I640a7c7da3b63bac21a71102f253aa2d1bef4391 Resolves: #85160 Related: #81234 Releases: master Reviewed-on: https://review.typo3.org/57121 Tested-by:
-
Kevin Ditscheid authored
Fix the link browser to not drop the additional link params if editing a link with additional link params set. Resolves: #85040 Releases: master, 8.7 Change-Id: I4c016f701b38e048aa999c4e96365019eae4a237 Reviewed-on: https://review.typo3.org/57009 Tested-by:
Andreas Wolf <andreas.wolf@typo3.org> Tested-by:
-
Christian Kuhn authored
composer updade typo3/testing-framework The update brings a couple of cleanups and bug fixes and an improved functional test case splitter script now used in bamboo. Resolves: #85171 Releases: master Change-Id: I79e30fd4e93e4a1635a74e225d4801dfb1768ad4 Reviewed-on: https://review.typo3.org/57134 Tested-by:
-
Christian Kuhn authored
The various "AbstractActionTestCase" classes of the functional data handling tests only prepare the scenario, while the extending Test classes of ext:core and ext:workspaces then call parent and add assertions. The abstract test preparations thus must not have @test annotations, they would be executed as casual tests without asserting anything useful. The patch removes those obsolete @test annotations and fixes another test case that had wrong wrong naming and was not executed for a while. Resolves: #85170 Releases: master Change-Id: Ibf6f9ef99f7eaeaeba1374962112d4a342c36567 Reviewed-on: https://review.typo3.org/57133 Tested-by:
-
- Jun 06, 2018
-
-
Christian Kuhn authored
phpunit tends to execute test case files even if the file comes with a broken namespace and can't be autoloaded. The patch hopefully fixes all test case files that are positioned in a wrong folder, has an otherwise broken namespace or is not yet registered as psr-4 require-dev. Resolves: #85169 Releases: master Change-Id: Id8da485b14ab65a883dd90e1a11cfd8e74d85780 Reviewed-on: https://review.typo3.org/57132 Tested-by:
-
- Jun 05, 2018
-
-
Nicole Cordes authored
Currently only the DriverInterface cares about applied filters. The ResourceStorage received a new API function to validate a file or folder object against applied filters as well. This ensures proper validation for objects fetched without driver calls. Resolves: #84908 Releases: master, 8.7 Change-Id: I5e8d35215c99aacfb330fe0eb8cfd9259b9a4199 Reviewed-on: https://review.typo3.org/56844 Reviewed-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
-
Richard Haeser authored
The SEO meta tags that can be set in the page properties, will be rendered in frontend. Resolves: #85147 Releases: master Change-Id: I75e6d8e50b7c8616497ee7075fddcb182551bea4 Reviewed-on: https://review.typo3.org/57117 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
Joerg Boesche <typo3@joergboesche.de> Reviewed-by:
Riny van Tiggelen <info@online-gamer.nl> Reviewed-by:
Steffen Frese <steffenf14@gmail.com> Reviewed-by:
-
Andreas Fernandez authored
Resolves: #85155 Related: #85065 Releases: master Change-Id: I0a3d89678dc23318db3cc3a3845c9c7fb3931959 Reviewed-on: https://review.typo3.org/57126 Reviewed-by:
-
- Jun 04, 2018
-
-
Benni Mack authored
The scheduler object cleans up execution arrays on instantiation. Due to the PSR-3 refactoring, the logger is instantiated after the constructor is called - resulting in a fatal error ("Call to member function info() on null") when cleaning up the execution array. The patch manually instantiates a logger if there isn't one already. Resolves: #85148 Releases: master Change-Id: I5ff3a06a2b9d7e511d5d243df545359a48bf84b1 Reviewed-on: https://review.typo3.org/57118 Tested-by:Daniel Gorges <daniel.gorges@b13.de> Tested-by:
-
Christian Kuhn authored
A minor CGL error slipped through with a patch that has been merged based on a +1 from bamboo before the 'declare_equal_normalize' php-cs-fixer rule has been established. The change should make the bamboo nightly builds green again. Resolves: #85152 Related: #84720 Releases: master Change-Id: Iaaf08d429780a12bf38a2865a5ae696a73cfcffb Reviewed-on: https://review.typo3.org/57123 Tested-by:
-
Christian Kuhn authored
Fix a series of core unit test classes to correct namespace. Resolves: #85151 Releases: master Change-Id: Ibfffae113ba3114acf616e65d48d8b508eee9353 Reviewed-on: https://review.typo3.org/57122 Reviewed-by:
Jan Helke <typo3@helke.de> Tested-by:
-
- Jun 03, 2018
-
-
Georg Ringer authored
If a page record is fetched from the database, the PageRepository needs to care about the l18n_cfg setting for this page. Resolves: #85063 Releases: master, 8.7 Change-Id: Ib0338a4725a3b569b91f27baa3a59cabee6fe2fb Reviewed-on: https://review.typo3.org/57038 Reviewed-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Reviewed-by:
-
- Jun 02, 2018
-
-
Richard Haeser authored
The properties within the allowedSubProperties have to be arrays because the AbstractMetaTagManager checks if the property as a key exists in the allowSubProperties. Resolves: #85126 Releases: master Change-Id: Ie57a77f8d4100e0861958de73faa56d80709daad Reviewed-on: https://review.typo3.org/57099 Tested-by:
-
Frederik Holz authored
Menues provided by MenuProcessor will display restricted pages, if the configuration value is set to true. This is the same behavior as known from pure TypoScript provided menues. Resolves: #82755 Releases: master, 8.7 Change-Id: Idf600f3ce151e2accba828c69dc601e26771686c Reviewed-on: https://review.typo3.org/56834 Reviewed-by:
-
Georg Ringer authored
Use the LanguageService for help texts of select items. This can be tested with the element 'select_checkbox_3' of the styleguide extension. Resolves: #78984 Releases: master, 8.7 Change-Id: Idb6e63547ac480b18fcb1ca997d5d07e4bcb4e81 Reviewed-on: https://review.typo3.org/56689 Reviewed-by:
-
- Jun 01, 2018
-
-
Andreas Fernandez authored
To improve the overall performance of the recycler, these things are done: - Improve how permissions are checked for each record Instead of running multiple SQL requests per record, the check now instantly stops if the user is either an admin, or has no permission to modify a certain table. - Drop sorting of records by page tree structure The records get sorted by the page tree structure, to mime the tree in a flat view. However, this feature is rather useless and also considered buggy in a huge record set. Resolves: #84711 Releases: master, 8.7 Change-Id: I0c5177546489ce2a0ba84435fed3879267a5a871 Reviewed-on: https://review.typo3.org/56102 Reviewed-by:
-
Tom Warwick authored
This commit is intented to improve the language used in the Install Tool and each of its modules. [+] Review title,subtitle and description for each action available and update/amend where required. Resolves: #84891 Releases: master Change-Id: I7f71f85ae86c37786870b2c30511673fe28da7c2 Reviewed-on: https://review.typo3.org/56825 Reviewed-by:
-
Mathias Brodala authored
Code which uses enumerations expects a known set of values, adding more values by extending these classes leads to undefined behavior. Since it is now impossible to create a mock of an enumeration also drop a few Enumeration tests and stick to testing of the public API. Resolves: #85025 Releases: master Change-Id: I3d0238c85ae916052dc1aa503f7f8e39c1765ac6 Reviewed-on: https://review.typo3.org/56976 Tested-by:
-
Ralf Zimmermann authored
Only list valid forms within the form manger and the form plugin. Valid forms have an "identifier" and a "type" and the type must be "Form". Resolves: #85132 Releases: master, 8.7 Change-Id: I2f473925b3edf839d5f965136b6b02030671350a Reviewed-on: https://review.typo3.org/57108 Reviewed-by:
-
Benni Mack authored
The method `getPageShortcut()` which is marked as private is moved to PageRepository, as it only requires logic and methods from PageRepository. Resolves: #85130 Releases: master Change-Id: I4c7296e085953377e0937b8d1efad0b97d1fb021 Reviewed-on: https://review.typo3.org/57106 Reviewed-by:
-
Mathias Brodala authored
Resolves: #85139 Releases: master Change-Id: Iadcfdb2bcc5dd0ebf3eeb535171a43c3a54afe47 Reviewed-on: https://review.typo3.org/57110 Tested-by:
-
Susanne Moog authored
Sqlite limits the maximum number of variables allowed in a query. When importing the extension list the chunks are too big (> 999 variables). This has been chunked to enable import on sqlite. Resolves: #85129 Releases: master Change-Id: If65476707946f4078a1b1e55128239aed07f6ed8 Reviewed-on: https://review.typo3.org/57103 Reviewed-by:
-
Benni Mack authored
Since TYPO3 v9.0, all routing in backend is handled unified, thus, the old methods from historical reasons can be deprecated. - BackendUtility::getModuleUrl() - UriBuilder->buildUriFromModule() Instead of guessing the name to a module route, an "id" for the route (like the path) can be explictly given. Resolves: #85113 Releases: master Change-Id: I8cf2b9dc3a938dd7227dcc972e0782619ede4213 Reviewed-on: https://review.typo3.org/57048 Tested-by:
-
