- Jan 21, 2021
-
-
Oliver Bartsch authored
The SysLogErrors widget now links to the belog module using `top.goToModule` to also change the state in the module menu. Resolves: #93333 Releases: master, 10.4 Change-Id: Icc19570585fdf785b296db21311f14955d6e91ae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67496 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Peter Kraume <peter.kraume@gmx.de> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
-
Benni Mack authored
This change sorts out the link selector fields and additional fields, as well as the file selector to streamline the padding/margin between all boxes, cleans up the search box and adds some UX improvements to make the modal less cluttered. Some labels still need to be moved to a XLF file. In addition, some minor PHP cleanups are made to make the dependencies more visible. Resolves: #93322 Releases: master Change-Id: I5f191cefbf1e1fd8dae9e398d3001faf72193cb5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67467 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Benni Mack authored
The popover (when clicking on a "?" icon) now properly sets the styling of the popover-header class. Resolves: #93323 Releases: master Change-Id: I1e89ed15e3823a362c9244187283821ffa8aed0e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67470 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- Jan 20, 2021
-
-
Oliver Bartsch authored
The permissions module previously used a lot of anchor elements without a target defined. To improve accessibility and semantic correctness these selectors are now changed to button tags. Resolves: #93306 Releases: master, 10.4 Change-Id: I181264307294bd84e0896d1602ddd8c9dc313167 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67460 Tested-by:
-
Patrick Schriner authored
Pages with a date visibility outside the current date had their preview link generated incorrectly as the runtime cache was already filled with the data of the current date. If the date aspect is taken into account proper preview links can be generated for future or past pages as well. Resolves: #92944 Releases: master, 10.4, 9.5 Change-Id: Icd5c1f8e1f0ddea07780d1ca1d1d050660443927 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66934 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
Martin Kutschker authored
The module menu implements the keyboard navigation suggested by the ARIA Best Practices 1.1 for roles "menubar" and "menu". The first level menu has a "menubar" role, the second level submenus have a "menu" role. The buttons have the "menuitem" role. Both the "menubar" and the "menu" are oriented vertically for assistive technology matching the visual representation which affects the keyboard navigation. Space/Enter show the module unless the item has a submenu. Space/Enter and Right Arrow open a submenu and move focus to the first item. Up/Down Arrow and Home/End navigate within the current level of the menu. Ctrl + Home/End navigate within the first level of the menu (extension of the ARIA pattern). Left/Right Arrow moves to the parent item's predecessor/successor when on a submodule item. The submenu will not be closed (deviation from the ARIA pattern). Escape moves to the parent item of a submodule item. The submenu will not be closed (deviation from the ARIA pattern). Tab and Shift + Tab move to the next item outside of the module menu. The help menu implements the keyboard navigation suggested by the ARIA Best Practices 1.1 for the role "menu". This is the same as the module menu but limited to a single level. The change detaches again the module menu's event listener from the document as in #91642, but reinitializes the event listeners to handle situations as described in #93008 properly. Resolves: #92704 Resolves: #92634 Resolves: #92613 Releases: master Change-Id: I58ae5caa81882ccebd4e2ae2d944eb99e15a4b18 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66283 Tested-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
-
Richard Haeser authored
When a canonical link is set in the page properties, this page or translation should not get a hreflang link in frontend as this might send conflicting signals to search engines. Resolves: #89878 Releases: master, 10.4 Change-Id: I4a2fb81b474bf155ba0beca5dfa3948f36edf840 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67328 Tested-by:
Martin Kutschker <mkutschker-typo3@yahoo.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Oliver Bartsch authored
In the bootstrap v5 migration the data attribute key which is used in JavaScript to perform actions depending on the toggle state, has changed. Now the correct data attribute key is used again. Resolves: #93320 Releases: master Change-Id: Icd80dc210dfa55176db1b7f1be30ad015783f6be Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67468 Tested-by:
-
- Jan 19, 2021
-
-
Benni Mack authored
This change uses Twitter Bootstrap 5 usages across TYPO3 Backend, and fixes the toggle / icon toggle switch. Now the bootstrap-5 based toggle (form-switch) is used, and can be modified easily with a custom SVG later-on, but is kept as is for now, in order to make sure it is used consistently everywhere. Resolves: #93310 Releases: master Change-Id: If52d06932e1ee087d9c7d76cfb7d0f0c0e92276a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67461 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Kevin Appelt authored
Resolves: #93298 Releases: master Change-Id: Ic93d7e837fc3a19e78211bbe3b7562ac3cd51213 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67454 Tested-by:
-
Andreas Fernandez authored
The Permissions backend module and its JavaScript module now ditch jQuery in favor of native browser API and TYPO3 API. The JavaScript has been refactored a little bit; initially checking the permission checkboxes or writing back the calculcated permission value is now decoupled and executed in the Permission module only. To support for..of with NodeList collections, TypeScript now loads the internal "dom.iterable" library. Additionally, the interim solution to add `editform` to Document has been removed which made another change in LinkPopup necessary. Furthermore, a bug has been fixed, where the value of the first visible select element was used when saving any other select element with a completely different value. Resolves: #93301 Releases: master Change-Id: Iffede862a0eb36e805a5f127d7b19f32c899ce31 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67457 Tested-by:
-
Benni Mack authored
The listing of extensions in the Extension Manager module now properly shows the inactive extensions again. Previous CSS changes didn't apply the inactive extensions again. In addition, if an extension does not have an Extension Icon in the Extension Manager list, it created an <img> tag with a path to the extension folder typo3conf/ext/my_ext/ resulting in an error in the browsers. This is now replaced with an empty icon. Resolves: #93311 Releases: master Change-Id: I723a0d603b36ad799c0c02869829742f19a69b37 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67462 Tested-by:
-
Oliver Bartsch authored
To prevent broken records which reference a renamed folder, the AfterFolderRenamedEvent is now used to synchronize the corresponding relations as soon as such action took place. Furthermore does the AfterFolderRenamedEvent now contain the source folder, which is necessary to find those relations. A flash message informs the user about the synchronization when the action was performed in the backend, e.g. in the file module. Resolves: #78036 Resolves: #83054 Releases: master Change-Id: I9cc8bfbb5c8506c22dc4377fd3041b1113864182 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67441 Tested-by:
-
Uwe Trotzek authored
When a user is editing a complex data structure with IRRE and if he just changes one entry of a structure then all the items will be shown as changed in the workspace module. Most users will wonder why an element is shown as changed even if the user didn't touch this particular entry. This change will hide the "show differences" button in the module for entries where no data was changed except for internal properties. Those items will also have a different color in the list. Now the user can easily identify the records where something was really changed and open the diff to see what has changed. Resolves: #91157 Releases: master Change-Id: Ib5ca5bb50360091813855bd8aef0b9e627e1e826 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64295 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
- Jan 18, 2021
-
-
Johannes Rebhan authored
This adds the ability to wrap the content of an automatically generated typolink link text, e.g. when linking to internal pages, with markup using the typolink options `wrap` and `ATagBeforeWrap`. Resolves: #92338 Releases: master Change-Id: I1ecac8fe52384acef249177850662ebc90497b1a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65758 Tested-by:
-
Guido Schmechel authored
User and group names in the access module are no longer shortened after 20 characters. It is now possible to see the full 50 characters. In addition, a title attribute has been added. Resolves: #93089 Releases: master Change-Id: If37d24235ff445297548a2830e5745cb889d5a32 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67363 Tested-by:
-
Benni Mack authored
The opendocs toolbar item does not have a badge background anymore, this changes re-adds the background and also unifies the badge from the system information toolbar to use the rounded-pill class. Resolves: #93303 Releases: master Change-Id: Ie2ecc99fd5ad4ad8845923af018c051665ac6118 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67459 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
-
- Jan 17, 2021
-
-
Jochen Roth authored
Will set equal height for checked checkbox and the empty button. The first button will now get a border-radius to streamline the buttons according to the action buttons Resolves: #93292 Releases: master Change-Id: I6479c968f77df41ed00d23d68c5ec23363ac64a3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67449 Tested-by:
-
Thomas Löffler authored
When there is no specific preview renderer defined for a given subtype, the type-specific renderer can only be used if it's not an array. Otherwise, the default preview renderer defined in TCA crtl should be used. Releases: master, 10.4 Resolves: #92758 Change-Id: Ia88d262f52ddac174cbe6750c591898c84872a89 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66413 Tested-by:
-
- Jan 16, 2021
-
-
Elias Häußler authored
Using drag and drop, one can create new pages within the page tree. New pages can be created before, after or within existing pages. Currently, one could not provide a page title if the page was created within a page without subpages due to issues with unintended focus change after drag and drop. It is now ensured that a page title can be edited directly after dragging a page into the page tree. Some cases are also covered by acceptance tests now. Resolves: #92380 Releases: master, 10.4 Change-Id: I95391631f11552fc59e9252e904052d8288c5d91 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67316 Tested-by:
-
Markus Klein authored
If some link handlers are hidden with "blindLinkOptions" then we still want to preserve the well-known order of the other tabs. This is solved by defining more dependencies on the link handlers, so that the ordering service still has a clue about the order. Releases: master, 10.4 Resolves: #86312 Change-Id: I60c3c7b1cbcb57b7774663732d7bd3aca9ef15c7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67455 Tested-by:
-
- Jan 13, 2021
-
-
Benni Mack authored
The page module does not throw a fatal error anymore if a content type "text" has a bodytext of value "null" instead of "text". Resolves: #93283 Releases: master Change-Id: I23b5c508d1886dc2277e5d4a2010f8a57fd8bb85 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67443 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
Oliver Bartsch authored
Resolves: #93278 Releases: master Change-Id: Ie4b0e533fda887b92fdbd5c4e870435c12b091ca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67439 Tested-by:
-
Oliver Bartsch authored
The RenameFile JavaScript handles renaming of files and folders. If renaming a folder, some input fields are not available in the form and must therefore be checked for existence, before accessing their value. Furthermore does the file delete modal now display the modal content again. The corresponding data attribute was renamed in the bootstrap v5 migration. Resolves: #93277 Releases: master Change-Id: I4ba6bc625a152d7e97ba6c44612a17b782799d31 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67438 Tested-by:
-
- Jan 12, 2021
-
-
Benjamin Franzke authored
As of #92628, 'loginLogoAlt' is evaluated when a custom backend loginLogo has been set, but it is not taken into account if has not been set at all. Use null coalesce operator to avoid notices and to avoid throwing TypeErrors because trim() cannot handle null values. Resolves: #93275 Related: #92628 Releases: master Change-Id: I1cd2875f9b92b9d1a86e3817e1623acb45922b85 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67437 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Martin Kutschker authored
Due to CSS changes in Boostrap 5 the navigation buttons on the login screen were invisible. This patch makes them visible again. Resolves: #93258 Releases: master Change-Id: Ifdd9dcb88504428303ac7680106c721038181505 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67402 Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Christian Kuhn authored
The reference index can be seen as a 'cache' for consuming application parts other than the DataHandler, which does not rely on it's state but keeps it updated. From this point of view, workspace delete placeholders (t3ver_state=2 records) should not have reference index entries: The delete placeholder is just a marker that a specific live record is slated for deletion upon publish. It does not carry relation information on it's own. The patch changes reference index code to not consider relations for workspace delete placeholder records. Change-Id: I0a1fd490c4133e7ce92a53ebd4413cc7b43b1d58 Resolves: #93274 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67396 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Christian Kuhn authored
Scenario: A live page has a page localization. In workspaces, the page localization is deleted, creating a delete placeholder. After that, the page is moved to a different parent page in workspaces. The delete placeholder of the localization is then turned into a move placeholder. This is wrong since the delete information is lost. The patch suppresses the change of delete placeholders to move placeholders when moving records. This issue is much harder to solve in v10 since v10 has to deal with two move overlay records and v11 with one. The patch is thus slated for v11 only. Change-Id: I233b944b030bba0de6c22d4ec1b6cb862184ddb6 Resolves: #93268 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67400 Tested-by:
-
Richard Haeser authored
By adding the workspace restriction to the RecordsXmlSitemapDataProvider, only records in the live workspace are shown in the XML sitemap. Resolves: #93010 Releases: master, 10.4 Change-Id: Ib46c3ebc925405de81afefda83100ccddb761fad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67392 Tested-by:
-
Oliver Bartsch authored
Some protected properties with single usage are replaced with local variables to reduce complexity. Resolves: #93269 Releases: master Change-Id: I9f34e5a2746988e11f97d923837f49b0435fc6a0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67401 Tested-by:
-
- Jan 11, 2021
-
-
Sebastian Iffland authored
A new TSconfig option `iconOverlay` is introduced, which allows to define an icon overlay for each element within the newContentElementWizard. Releases: master Resolves: #92942 Change-Id: Ib6aa02424e5a1d6411ef8fc9830364c8b2c19a31 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66909 Tested-by:
-
Christian Kuhn authored
The DataHandler delete related methods still handle too many things. This is yet another divide & conquer patch: Move the 'undelete' functionality to dedicated methods, drop handling from 'delete' methods and refactor 'undelete'. The result is a quite straight forward 'undelete' implementation, plus reduced complexity in 'delete'. Change-Id: I6ea2326fa2ad6de03c8cd3bd37184fff116fda06 Resolves: #93253 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67368 Tested-by:
-
Andreas Fernandez authored
If a Flexform section gets deleted, the container must be hidden in DOM and not deleted, as the underlying DataHandler code relies on getting the field submitted. This patch is less intrusive as possible to allow a backport to stable releases. Flexforms needs a major refactoring and should act similar to IRRE, but this can go into the master branch only. Resolves: #93061 Releases: master, 10.4 Change-Id: I69dfdd6f2029547d600939f23e21b03abd45042d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67369 Tested-by:
-
Oliver Bartsch authored
The correct height of the input group is restored by removing unnecessary wrappers around the buttons. See: https://getbootstrap.com/docs/5.0/forms/input-group/#button-addons Resolves: #93262 Releases: master Change-Id: I3e8276f66efbb593480371d3ee26d0ec08ba35d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67399 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Simon Schaufelberger authored
When an error occurs in a DataHandler AJAX call, the error message should only be shown once. Resolves: #93207 Releases: master, 10.4 Change-Id: I8f341d08bfe051af5a485f21628907c74a812490 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67331 Tested-by:
-
- Jan 10, 2021
-
-
Martin Kutschker authored
The translation key login.error.capslock is duplicated. The second instance is now named login.error.capslockStatus as in the referring Fluid template. When there are no loginProviders to be chosen from then the nav region would only be comprised of an empty <ul>. Do not render the tags for this condition. Resolves: #93255 Resolves: #93256 Releases: master Change-Id: I4527eb8863a92366787827b50b82b441512df744 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67370 Tested-by:
-
- Jan 09, 2021
-
-
Andreas Fernandez authored
This patch removes some actions that don't make any sense with pid 0: - toggle visibility in menu via context menu - "View webpage" action in Record List Resolves: #93252 Releases: master, 10.4 Change-Id: I444270a49642240e9a38d3664b05923da16f36e0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67367 Tested-by:
-
Georg Ringer authored
The login logo for the default logo is set to "TYPO3 logo". For custom logos an alt-attribute for the image tag can be configured. In v12 it will be required to configure the alt-text to ensure accessibility. Resolves: #92628 Releases: master Change-Id: Ib35b8fbdbff08e7c9a1e778fc62d8135214d1af0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66222 Tested-by:
-
- Jan 08, 2021
-
-
Oliver Bartsch authored
TYPO3 should blind sensitive configurations options, such as credentials or keys, by default, since the configuration module can usually be accessed by all admins. Integrators always have the possibility to adjust these settings using the modifyBlindedConfigurationOptions hook. Resolves: #93250 Releases: master, 10.4 Change-Id: I8eaefa7b166de54190cee2b4eac5e2dfc1513cc5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67366 Tested-by:
-
Oliver Bartsch authored
Since bootstrap v5 the collapse JavaScript plugin is using `collapse.show` instead of `collapse.in` as the expanded state class. Since TYPO3 added custom styles based on the `.in` class, several modules did not longer work. This is now fixed by using the correct class. Additionally the workspace record collapse state identifier icon now reflects the current state again. Resolves: #93243 Releases: master Change-Id: I471402250520c9c3366d1885b664a8f5fd79e338 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67362 Tested-by:
-
