- Mar 31, 2014
-
-
Alexander Opitz authored
As TBE_EDITOR is defined as object in jsfunc.tbe_editors.js we should change the check here. Otherwise no eval user functions will be called. Resolves: #57296 Releases: 6.2, 6.1 Change-Id: Ie1b701dcbf465827bc336233c2523f4df1dde9ba Reviewed-on: https://review.typo3.org/28810 Reviewed-by: Alexander Opitz Tested-by: Alexander Opitz Reviewed-by: Nicole Cordes Tested-by: Nicole Cordes
-
- Mar 26, 2014
-
-
Markus Klein authored
BackendUtility::thumbCode() tries to retrieve the extension of a file object that might be NULL. Add a check for having a valid file object. Resolves: #54394 Releases: 6.1 Change-Id: Ia97fbb5fd3d9bd53c0d776a93969f9d059eebc4a Reviewed-on: https://review.typo3.org/26446 Reviewed-by: Oliver Klee Reviewed-by: Stefan Neufeind Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Mar 24, 2014
-
-
Xavier Perseguers authored
Fixes: #57238 Releases: 6.2, 6.1, 6.0 Change-Id: Icca7e1637387e2ad31a1368abcd59b1bd443255f Reviewed-on: https://review.typo3.org/28706 Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers
-
- Mar 23, 2014
-
-
Benjamin Mack authored
When rendering the module menu icons, the menu items on the top level (Web, File, User, Admin) don't have an icon, however the getModuleIcon functionality processes them, and checks for getimagesize() even though no image is added. To overcome this, the function needs to be modified slightly to only call getimagesize if there is actually an icon. Releases: 6.2, 6.1 Resolves: #57179 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Stefan Neufeind Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers Change-Id: I1fdede253c00df9c36bb7063edf0b5bf320bb20e Reviewed-on: https://review.typo3.org/28668 Reviewed-by: Benjamin Mack Tested-by: Benjamin Mack
-
Stefan Neufeind authored
Parsetime is output either if config.debug is set or if FE-debug is activated in LocalConfiguration. Allow to explicitly override (set to 0) the debugging in TS for cases where you want to output page-objects like a JSON-page or so where Parsetime leads to problems. Change-Id: Ie5588218694219c13f136b5ac928e697ca472cfb Resolves: #57202 Releases: 6.2, 6.1 Reviewed-on: https://review.typo3.org/28667 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Mar 19, 2014
-
-
Benjamin Rau authored
Fixing several typos and slips of the pen in the PageBrowsing ViewHelper. Without fixing all of them the page browsing ViewHelper is not functional properly, that´s why i want to submit them at once and also supply the fix for it. That are these errors: * Undefined but used class property prefixId * Overwriting instead of appending content to already defined variable * Not using UpperCamelCase for extensionName in Localization Utilty * Accidentally using wrong variables * Defining variable in for-loop which could be defined outside also * Using undefined variable freeIndexUid Resolves: #55340 Releases: 6.2, 6.1 Change-Id: I708a7af4876eba0e69fa666694315e0babcf6800 Reviewed-on: https://review.typo3.org/28539 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Xavier Perseguers authored
When a column is defined as a multivalued static enumeration: 'somecolumn' => array( 'exclude' => 0, 'label' => 'Some label', 'config' => array( 'type' => 'select', 'items' => array( array('Option 1', 1), array('Option 2', 2), array('Option 3', 3), array('Option 4', 4), ), 'size' => 4, 'maxitems' => 4, 'eval' => '' ), ), it is not possible to query the domain model using operation "contains": $value = 2; $query->matching( $query->contains('somecolumn', $value) ); Releases: 6.2, 6.1 Fixes: #56205 Change-Id: If898db7f355ad931d1c8b55febc2f59f19b0f38b Reviewed-on: https://review.typo3.org/27787 Reviewed-by: Alexander Opitz Reviewed-by: Wouter Wolters Reviewed-by: Stefan Froemken Tested-by: Stefan Froemken Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-on: https://review.typo3.org/28471 Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers
-
- Mar 14, 2014
-
-
Christian Reiter authored
Make sure RootlineUtility::enrichWithRelationFields() respects the setting of $TCA[$table]['ctrl']['enablecolumns']['disabled'] when fetching foreign data for the rootline. Otherwise hidden relations from sys_file_reference are added to the rootline and cause exceptions in the frontend, instead of being ignored. Resolves: #56150 Releases: 6.2, 6.1 Change-Id: I21917fec1407a10818058da8ea879b0bb39441a4 Reviewed-on: https://review.typo3.org/28400 Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
- Mar 13, 2014
-
-
Stanislas Rolland authored
Method doLanguageAndWorkspaceOverlay of Extbase\Persistence\Generic\Storage\Typo3DbBackend should not attempt to get a parent record if the overlays are in a separate table (most probably pages_language_overlay) by checking whether $GLOBALS['TCA'][$tableName]['ctrl']['transOrigPointerTable'] is set. Resolves: #56855 Releases: 6.0, 6.1, 6.2 Change-Id: I2cb53bc4733ee626ca0ae92e5dd91073d88ecc9d Reviewed-on: https://review.typo3.org/28362 Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Patrick Broens authored
In the page module using the "Languages" view, the buttons "add a new element at this place" are wrongly aligned. This patch fixes this issue by adding a div which controls this alignment by CSS Change-Id: I9de8a47368682ed0b33c2ebfa0a590402c1ca8ef Resolves: #56720 Releases: 6.1, 6.2 Reviewed-on: https://review.typo3.org/28276 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Markus Klein authored
Add missing checks if type column exists in a row. Resolves: #56830 Releases: 6.2, 6.1 Change-Id: Ifafdb0c51266c76620696c6d94471b3efddba112 Reviewed-on: https://review.typo3.org/28350 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Frans Saris authored
Upload action was taken care of, but the ajax handler can be just for all commands that ExtendedFileUtility->processData can handle. This change checks the result set and flattens data only when needed. Resolves: #56084 Releases: 6.2, 6.1 Change-Id: Ic1a0bd9084b9eb206b9b53960890d22d2a9c56f5 Reviewed-on: https://review.typo3.org/27863 Reviewed-by: Frans Saris Tested-by: Frans Saris Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Mar 12, 2014
-
-
Ludwig Rafelsberger authored
Each entry in the New Content Element wizard is tested to be valid, i.e. the tt_content_defValues defined by that entry must be allowed for the current BE user. Also, an entry may not select values that are removed via TSconfig. Setting TCEFORM.tt_content.[column].keepItems acts as a whitelist of allowed values for *that* column. But the validity checks are done hardcoded against the *CType* column. Resolves: #23864 Releases: 6.2, 6.1 Change-Id: I5b6578f35552bd571fc822ac72f8f5fe12fe11f7 Reviewed-on: https://review.typo3.org/28307 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Mar 10, 2014
-
-
Benjamin Serfhos authored
The DataHandler function checkRecordInsertAccess() does now check the configuration for the root level. Resolves: #52386 Releases: 6.2, 6.1 Change-Id: I1810ea847e631ea6b242346a0271f491fd60fdf9 Reviewed-on: https://review.typo3.org/24164 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Mar 08, 2014
-
-
Lorenz Ulrich authored
If "Stop Page Tree" is set for a page, it is possible to set temporary DB tree mounts in the element browser/link browser. If such a tree mount is set, a notice is displayed right above the tree. This notice is necessary to cancel this temporary mount. Currently the ElementBrowser misses this notice when used for e.g. header_link. Change-Id: I942aad0e54d17ceb793008850f0563bb416503be Fixes: #43885 Releases: 6.2, 6.1, 6.0 Reviewed-on: https://review.typo3.org/28181 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Mar 07, 2014
-
-
Stanislas Rolland authored
Problem: IE raises a syntax error when it encounters html comments in the JavaScript code. The html comments are added by the page renderer. Solution: There is no need for the page renderer to wrap inline javascript as html comments. Resolves: #55457 Releases: 6.2, 6.1 Change-Id: Iae180a73778ca3bb1c9934c887315b969888b10d Reviewed-on: https://review.typo3.org/28130 Reviewed-by: Stanislas Rolland Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Christian Plattner authored
Missing size property on group-type fields causes various problems, like missing controls (move to top and move to bottom) or misbehaving JS. Adding a default size ensures that a forgotten size property does not break everything. Additionally the size property is added to the sys_collection table, since all Core tables should be cleanly defined. Resolves: #23552 Documentation: #56627 Releases: 6.1, 6.2 Change-Id: Idafb1912f9702fddf85b7c2c222f408419e50ecf Reviewed-on: https://review.typo3.org/28129 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Mar 05, 2014
-
-
Stefan Froemken authored
After submitting an invalid form twice, extbase tries to create the related submodel instead of edit. This is because of the missing __identity part for the related submodel Resolves: #46185 Releases: 6.0, 6.1, 6.2 Change-Id: If3ec15b9eff0fc8d9a7dc682518cbfd72bb4665b Reviewed-on: https://review.typo3.org/28051 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Alexander Opitz authored
While initializing the installer it can happen that Exceptions are thrown. As there is no ExceptionHandler initialized yet, we get a white page and the Fatal error will be logged. Mostly it is the problem that typo3conf and/or typo3temp isn't writeable. But it might something else which throws an exception. This patch catches the exception in the initializing process and shows a page in the layout of the installer. It shows the exception message, a first hint for the maybe write permissions problem and a link with the exception number. Resolves: #11771 Releases: 6.1 Change-Id: Ib99860054b727907a9a84bdfd3e35fe3f2eebe00 Reviewed-on: https://review.typo3.org/23219 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
- Mar 03, 2014
-
-
Markus Klein authored
SearchController::compileSingleResultRow() causes double htmlspecialchars() call on $title. This patch removes the general htmlspecialchars() call since $title will be escaped in linkPage() anyway. The only place which requires escaping has the call added now. Resolves: #56262 Releases: 6.2, 6.1, 6.0 Change-Id: Ic94fe7fe7d2145fc539adcdf21faf42c33f5b32e Reviewed-on: https://review.typo3.org/27998 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
- Feb 28, 2014
-
-
Christian Weiske authored
Extbase logged a code smell with a severity of 1320177676 instead of 1 ("notice"). Change-Id: If28c2d66713bdedb3094af22f8f7a00a504d995d Resolves: #56378 Releases: 4.7, 6.0, 6.1, 6.2 Reviewed-on: https://review.typo3.org/27953 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Christian Weiske authored
Adjust the @return documentation of authUser() to match the actual implementation in TYPO3\CMS\Core\Authentication\AbstractUserAuthentication Change-Id: I2d94cdfee6c58de80c7ec2be2b644b5fcd6c9a97 Resolves: #56421 Releases: 6.0, 6.1, 6.2 Reviewed-on: https://review.typo3.org/27943 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Helmut Hummel authored
The security fix introduced a bug that the title is encoded every time the link wizard is opened, leading to multiple encoded strings. Solution is to not encode it centrally but encode it just before using it in the JavaScript context. Fixes: #41413 Releases: 4.5, 4.7, 6.0, 6.1, 6.2 Change-Id: I6b08db290d5457761edc4506105672d79840764d Reviewed-on: https://review.typo3.org/27853 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Feb 27, 2014
-
-
Markus Klein authored
This reverts commit b0c54dca. The 401 header code is used with HTTP based authentication schemes, based on RFC 2617. This is not the case here. Resolves: #55966 Reverts: #51803 Releases: 6.2, 6.1, 6.0, 4.5 Change-Id: I81e0e2bb428a9da69155fc597933bd9f023cf226 Reviewed-on: https://review.typo3.org/27898 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Feb 25, 2014
-
-
Jigal van Hemert authored
The paginator in the extension list from TER is transformed into using Ajax. This fails because this process searches for links inside a class which is used by the frontend paginator widget. Changing it to the id of the backend paginator widget makes the ajax calls work again. Resolves: #56184 Releases: 6.2, 6.1, 6.0 Change-Id: I06c193b2657eb3edae623dc0126b06c240f486c6 Reviewed-on: https://review.typo3.org/27851 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Jigal van Hemert authored
Encoding a few extra character besides the ones according to RFC3986 makes password reset links working again in various mail clients which do not comply to this RFC (and which do not have plans to fix this in the near future). Change-Id: I0b42bef6cb732c5fc6cc2d900407271cb606e301 Fixes: #23984 Releases: 6.2, 6.1, 6.0, 4.7, 4.5 Reviewed-on: https://review.typo3.org/27826 Reviewed-by: Jigal van Hemert Tested-by: Jigal van Hemert
-
- Feb 24, 2014
-
-
Benjamin Kott authored
If a javascript file is forceOnTop the script uses array_unshift() to put the file at the beginning of the section array. If this is the first file that got processed, the array does not exist yet, so the array_unshift function returns NULL and the file will not added to the array. The fix properly initalizes the section sub-array. Resolves: #56242 Releases: 6.2, 6.1 Change-Id: Iadf2b6f2f512929ff5e8598af9972c5337949341 Reviewed-on: https://review.typo3.org/27818 Reviewed-by: Benjamin Mack Tested-by: Benjamin Mack
-
- Feb 21, 2014
-
-
Marc Bastian Heinrichs authored
The count in LazyObjectStorage for relation type HAS_MANY has to use the count on storage items after initialization. Otherwise the wrong count is returned for a not persisted storage. Resolves: #54724 Releases: 6.2, 6.1, 6.0 Change-Id: I817ce86dde11b175e6a5765a8f6518770ba75f28 Reviewed-on: https://review.typo3.org/27443 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Markus Klein authored
The language initialization process is currently split in two main methods (TypoScriptFrontendController->initLLvars and ->settingLanguage). Only settingLanguage contains hooks and sets the "sys_language_uid" property (and "sys_language_content") which determine the displayed records in Frontend. On the opposite, initLLvars is not hookable and sets the "lang" property, which may be used by charset conversion methods. In order to determine display language within hooks, the only way currently is to call initLLvars a second time after determining language, but this method populates the "languageDependencies" property without initializing it. So it is filled two times, which leads to incorrect labels, especially if the displayed language is English and the default language is not English (as "languageDependencies" is already filled with "default language"). The three parts of the patch are: * The initLLvars method now pre-initializes the "languageDependencies" property. * The initLLvars is now called from "settingLanguage" method, right after the "settingLanguage_preProcess" hook to avoid a second call it. * The convPOSTCharset call is now moved after the language initialization, as the language determination done by initLLvars can have some impact on charset handling (multi-charset locallang.php legacy). Change-Id: I6924345931342d5114b13e5d6fab417387559b9a Resolves: #49499 Releases: 6.2, 6.1, 6.0 Reviewed-on: https://review.typo3.org/27664 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Feb 20, 2014
-
-
Alexander Jahn authored
When loading tt_content as an inline record WITHOUT using AJAX, some additional broken fields are rendered. Change-Id: Ia5aaec79d0fb7c3266ea4f3a0c04d65b1af4b201 Fixes: #39048 Releases: 6.2, 6.1 Reviewed-on: https://review.typo3.org/27280 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Markus Klein authored
Setting the forceOnTop property for a JS or CSS file is not observed if concatenateJs/Css is set as well. Resolves: #53116 Resolves: #56019 Releases: 6.2, 6.1 Change-Id: Ica31656bd72f4a0249513206bac45aa16b929761 Reviewed-on: https://review.typo3.org/27672 Reviewed-by: Stefan Neufeind Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Markus Klein authored
In DatabaseConnection::listQuery strpos() is used with wrong parameter order. Resolves: #56135 Releases: 6.2, 6.1, 6.0 Change-Id: Iaa18d46442a2aac21a836216cb61ae376bbb2090 Reviewed-on: https://review.typo3.org/27750 Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
- Feb 19, 2014
-
-
Felix Althaus authored
FileContentParser used to issue a warning trying to index image files with corrupted EXIF data. Suppress these warnings to fail silently. Resolves: #55286 Releases: 6.2, 6.1 Change-Id: I863601f5579ab74a0743ab684cf1d898b633edba Reviewed-on: https://review.typo3.org/27715 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Markus Klein authored
Resolves: #56067 Releases: 6.2, 6.1, 6.0 Change-Id: I6d1e19026afde81bec46cec3dff9060fa6042c43 Reviewed-on: https://review.typo3.org/27706 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Wouter Wolters authored
Resolves: #56057 Releases: 6.2, 6.1 Change-Id: I9c1ec60e7518867d27e99681d3d18957a27c4983 Reviewed-on: https://review.typo3.org/27705 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
- Feb 18, 2014
-
-
Caspar Stuebs authored
Get the labels for the doktypes from TCA Resolves: #52955 Releases: 6.2, 6.1 Change-Id: I6d70c11f1711bf191a4ce14a91796819224649da Reviewed-on: https://review.typo3.org/27704 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Alexey Gafiulov authored
encodeURIComponent is added to escape all special characters in parameters for AJAX call. Resolves: #54304 Releases: 6.2, 6.1, 6.0 Change-Id: I3559104e1a26241b519f40a10000637852a4f114 Reviewed-on: https://review.typo3.org/27674 Reviewed-by: Stefan Neufeind Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Feb 17, 2014
-
-
Tomita Militaru authored
Fixes problem with match on substring when adding a new field using ExtensionManagementUtility::addToAllTCAtypes() Resolves: #52527 Releases: 6.1, 6.0 Change-Id: I8877cdabc00f5ac64f1f7857bf47c275d36aae62 Reviewed-on: https://review.typo3.org/27663 Reviewed-by: Jigal van Hemert Tested-by: Jigal van Hemert Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Frans Saris authored
The thumbnail rendering in filelist clibboard isn't updated to use FAL. And adding folders to clipboard with thumbnails enabled results in a fatal error. This changes makes sure the thumbnail is only rendered for files and updates the thumbnail part so it uses FAL. Resolves: #56037 Releases: 6.2, 6.1 Change-Id: I2a0eccd633f5313fed9ab94b5081c13e08892900 Reviewed-on: https://review.typo3.org/27669 Reviewed-by: Wouter Wolters Reviewed-by: Frans Saris Tested-by: Frans Saris Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Tim Lochmueller authored
Fix a undefined variable and a wrong variable assignment in the ShortcurtToolbarItem. Resolves: #55998 Releases: 6.2, 6.1, 6.0 Change-Id: I0f0ebcc846a9aa56edd05e384d62aad8f0a5b05b Reviewed-on: https://review.typo3.org/27661 Reviewed-by: Markus Klein Tested-by: Markus Klein
-