Skip to content
Snippets Groups Projects
  1. Mar 31, 2014
  2. Mar 26, 2014
    • Markus Klein's avatar
      [BUGFIX] Exception if thumbnail does not exist · 2b5c50e3
      Markus Klein authored
      BackendUtility::thumbCode() tries to retrieve the extension
      of a file object that might be NULL.
      
      Add a check for having a valid file object.
      
      Resolves: #54394
      Releases: 6.1
      Change-Id: Ia97fbb5fd3d9bd53c0d776a93969f9d059eebc4a
      Reviewed-on: https://review.typo3.org/26446
      Reviewed-by: Oliver Klee
      Reviewed-by: Stefan Neufeind
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      2b5c50e3
  3. Mar 24, 2014
  4. Mar 23, 2014
    • Benjamin Mack's avatar
      [BUGFIX] Module Menu throws PHP warning for top level menu items · fc5b7b2a
      Benjamin Mack authored
      When rendering the module menu icons, the menu items
      on the top level (Web, File, User, Admin) don't have an icon,
      however the getModuleIcon functionality processes them,
      and checks for getimagesize() even though no image is added.
      
      To overcome this, the function needs to be modified slightly to
      only call getimagesize if there is actually an icon.
      
      Releases: 6.2, 6.1
      Resolves: #57179
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Stefan Neufeind
      Reviewed-by: Xavier Perseguers
      Tested-by: Xavier Perseguers
      Change-Id: I1fdede253c00df9c36bb7063edf0b5bf320bb20e
      Reviewed-on: https://review.typo3.org/28668
      Reviewed-by: Benjamin Mack
      Tested-by: Benjamin Mack
      fc5b7b2a
    • Stefan Neufeind's avatar
      [BUGFIX] Parsetime: config.debug should override LocalConfiguration · 9b36936f
      Stefan Neufeind authored
      Parsetime is output either if config.debug is set or if FE-debug
      is activated in LocalConfiguration. Allow to explicitly override
      (set to 0) the debugging in TS for cases where you want to output
      page-objects like a JSON-page or so where Parsetime leads to
      problems.
      
      Change-Id: Ie5588218694219c13f136b5ac928e697ca472cfb
      Resolves: #57202
      Releases: 6.2, 6.1
      Reviewed-on: https://review.typo3.org/28667
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      9b36936f
  5. Mar 19, 2014
    • Benjamin Rau's avatar
      [BUGFIX] Several typos in Page Browsing ViewHelper · 819218ad
      Benjamin Rau authored
      Fixing several typos and slips of the pen in the
      PageBrowsing ViewHelper.
      
      Without fixing all of them the page browsing ViewHelper
      is not functional properly, that´s why i want to submit
      them at once and also supply the fix for it.
      
      That are these errors:
      * Undefined but used class property prefixId
      * Overwriting instead of appending content to already defined variable
      * Not using UpperCamelCase for extensionName in Localization Utilty
      * Accidentally using wrong variables
      * Defining variable in for-loop which could be defined outside also
      * Using undefined variable freeIndexUid
      
      Resolves: #55340
      Releases: 6.2, 6.1
      Change-Id: I708a7af4876eba0e69fa666694315e0babcf6800
      Reviewed-on: https://review.typo3.org/28539
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      819218ad
    • Xavier Perseguers's avatar
      [BUGFIX] Cannot use contain with multivalued static enumeration column · f8233c15
      Xavier Perseguers authored
      When a column is defined as a multivalued static enumeration:
      'somecolumn' => array(
          'exclude' => 0,
          'label' => 'Some label',
          'config' => array(
              'type' => 'select',
              'items' => array(
                  array('Option 1', 1),
                  array('Option 2', 2),
                  array('Option 3', 3),
                  array('Option 4', 4),
              ),
              'size' => 4,
              'maxitems' => 4,
              'eval' => ''
          ),
      ),
      it is not possible to query the domain model using operation "contains":
      $value = 2;
      $query->matching(
          $query->contains('somecolumn', $value)
      );
      
      Releases: 6.2, 6.1
      Fixes: #56205
      Change-Id: If898db7f355ad931d1c8b55febc2f59f19b0f38b
      Reviewed-on: https://review.typo3.org/27787
      Reviewed-by: Alexander Opitz
      Reviewed-by: Wouter Wolters
      Reviewed-by: Stefan Froemken
      Tested-by: Stefan Froemken
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-on: https://review.typo3.org/28471
      Reviewed-by: Xavier Perseguers
      Tested-by: Xavier Perseguers
      f8233c15
  6. Mar 14, 2014
    • Christian Reiter's avatar
      [BUGFIX] RootlineUtility does not consider disablefield · d5160a91
      Christian Reiter authored
      Make sure RootlineUtility::enrichWithRelationFields() respects
      the setting of $TCA[$table]['ctrl']['enablecolumns']['disabled'] when
      fetching foreign data for the rootline.
      
      Otherwise hidden relations from sys_file_reference are added to the
      rootline and cause exceptions in the frontend, instead of being ignored.
      
      Resolves: #56150
      Releases: 6.2, 6.1
      Change-Id: I21917fec1407a10818058da8ea879b0bb39441a4
      Reviewed-on: https://review.typo3.org/28400
      Reviewed-by: Anja Leichsenring
      Tested-by: Anja Leichsenring
      d5160a91
  7. Mar 13, 2014
  8. Mar 12, 2014
    • Ludwig Rafelsberger's avatar
      [BUGFIX] Correctly validate New Content Element entries · d405041c
      Ludwig Rafelsberger authored
      Each entry in the New Content Element wizard is tested to be valid,
      i.e. the tt_content_defValues defined by that entry must be allowed
      for the current BE user. Also, an entry may not select values that are
      removed via TSconfig.
      
      Setting TCEFORM.tt_content.[column].keepItems acts as a whitelist of
      allowed values for *that* column. But the validity checks are done
      hardcoded against the *CType* column.
      
      Resolves: #23864
      Releases: 6.2, 6.1
      Change-Id: I5b6578f35552bd571fc822ac72f8f5fe12fe11f7
      Reviewed-on: https://review.typo3.org/28307
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      d405041c
  9. Mar 10, 2014
  10. Mar 08, 2014
    • Lorenz Ulrich's avatar
      [BUGFIX] Temporary DB tree mount notice missing in ElementBrowser · 2df9cb98
      Lorenz Ulrich authored
      If "Stop Page Tree" is set for a page, it is possible to set temporary
      DB tree mounts in the element browser/link browser.
      If such a tree mount is set, a notice is displayed right above the tree.
      
      This notice is necessary to cancel this temporary mount.
      Currently the ElementBrowser misses this notice when used
      for e.g. header_link.
      
      Change-Id: I942aad0e54d17ceb793008850f0563bb416503be
      Fixes: #43885
      Releases: 6.2, 6.1, 6.0
      Reviewed-on: https://review.typo3.org/28181
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      2df9cb98
  11. Mar 07, 2014
    • Stanislas Rolland's avatar
      [BUGFIX] RTE on first new IRRE record keeps loading in IE · 472a2f2c
      Stanislas Rolland authored
      Problem: IE raises a syntax error when it encounters html comments in
      the JavaScript code. The html comments are added by the page renderer.
      Solution: There is no need for the page renderer to wrap inline
      javascript as html comments.
      
      Resolves: #55457
      Releases: 6.2, 6.1
      Change-Id: Iae180a73778ca3bb1c9934c887315b969888b10d
      Reviewed-on: https://review.typo3.org/28130
      Reviewed-by: Stanislas Rolland
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      472a2f2c
    • Christian Plattner's avatar
      [BUGFIX] Default size for group-type fields · e61b2cfa
      Christian Plattner authored
      Missing size property on group-type fields causes various
      problems, like missing controls (move to top and move to
      bottom) or misbehaving JS. Adding a default size ensures
      that a forgotten size property does not break everything.
      
      Additionally the size property is added to the sys_collection
      table, since all Core tables should be cleanly defined.
      
      Resolves: #23552
      Documentation: #56627
      Releases: 6.1, 6.2
      Change-Id: Idafb1912f9702fddf85b7c2c222f408419e50ecf
      Reviewed-on: https://review.typo3.org/28129
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      e61b2cfa
  12. Mar 05, 2014
    • Stefan Froemken's avatar
      [BUGFIX] IdentityProperties were not set · f8c9a77d
      Stefan Froemken authored
      After submitting an invalid form twice, extbase tries to
      create the related submodel instead of edit.
      This is because of the missing __identity part
      for the related submodel
      
      Resolves: #46185
      Releases: 6.0, 6.1, 6.2
      Change-Id: If3ec15b9eff0fc8d9a7dc682518cbfd72bb4665b
      Reviewed-on: https://review.typo3.org/28051
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      f8c9a77d
    • Alexander Opitz's avatar
      [BUGFIX] Catch all errors while starting installer · e7cf5501
      Alexander Opitz authored
      While initializing the installer it can happen that
      Exceptions are thrown. As there is no ExceptionHandler
      initialized yet, we get a white page and the Fatal error
      will be logged.
      
      Mostly it is the problem that typo3conf and/or typo3temp
      isn't writeable. But it might something else which throws
      an exception.
      
      This patch catches the exception in the initializing
      process and shows a page in the layout of the installer.
      It shows the exception message, a first hint for the maybe
      write permissions problem and a link with the exception number.
      
      Resolves: #11771
      Releases: 6.1
      Change-Id: Ib99860054b727907a9a84bdfd3e35fe3f2eebe00
      Reviewed-on: https://review.typo3.org/23219
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      e7cf5501
  13. Mar 03, 2014
    • Markus Klein's avatar
      [BUGFIX] Double escape of title in indexed search · 28d25c9f
      Markus Klein authored
      SearchController::compileSingleResultRow() causes double
      htmlspecialchars() call on $title.
      
      This patch removes the general htmlspecialchars() call since
      $title will be escaped in linkPage() anyway.
      The only place which requires escaping has the call added now.
      
      Resolves: #56262
      Releases: 6.2, 6.1, 6.0
      Change-Id: Ic94fe7fe7d2145fc539adcdf21faf42c33f5b32e
      Reviewed-on: https://review.typo3.org/27998
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      28d25c9f
  14. Feb 28, 2014
  15. Feb 27, 2014
  16. Feb 25, 2014
    • Jigal van Hemert's avatar
      [BUGFIX] Paginator in TER list not using ajax · a5d88930
      Jigal van Hemert authored
      The paginator in the extension list from TER is transformed into
      using Ajax. This fails because this process searches for links inside
      a class which is used by the frontend paginator widget. Changing it to
      the id of the backend paginator widget makes the ajax calls work again.
      
      Resolves: #56184
      Releases: 6.2, 6.1, 6.0
      Change-Id: I06c193b2657eb3edae623dc0126b06c240f486c6
      Reviewed-on: https://review.typo3.org/27851
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      a5d88930
    • Jigal van Hemert's avatar
      [BUGFIX] felogin reset password links not clickable · b4a82355
      Jigal van Hemert authored
      Encoding a few extra character besides the ones according to RFC3986
      makes password reset links working again in various mail clients which
      do not comply to this RFC (and which do not have plans to fix this in
      the near future).
      
      Change-Id: I0b42bef6cb732c5fc6cc2d900407271cb606e301
      Fixes: #23984
      Releases: 6.2, 6.1, 6.0, 4.7, 4.5
      Reviewed-on: https://review.typo3.org/27826
      Reviewed-by: Jigal van Hemert
      Tested-by: Jigal van Hemert
      b4a82355
  17. Feb 24, 2014
    • Benjamin Kott's avatar
      [BUGFIX] Fix JS concat if first file is forced on top · 5da89e21
      Benjamin Kott authored
      If a javascript file is forceOnTop the script uses array_unshift()
      to put the file at the beginning of the section array. If this is
      the first file that got processed, the array does not exist yet,
      so the array_unshift function returns NULL and the file
      will not added to the array.
      
      The fix properly initalizes the section sub-array.
      
      Resolves: #56242
      Releases: 6.2, 6.1
      Change-Id: Iadf2b6f2f512929ff5e8598af9972c5337949341
      Reviewed-on: https://review.typo3.org/27818
      Reviewed-by: Benjamin Mack
      Tested-by: Benjamin Mack
      5da89e21
  18. Feb 21, 2014
    • Marc Bastian Heinrichs's avatar
      [BUGFIX] Use count on storage after initialization of LazyObjectStorage · c47d8c53
      Marc Bastian Heinrichs authored
      The count in LazyObjectStorage for relation type HAS_MANY has
      to use the count on storage items after initialization. Otherwise
      the wrong count is returned for a not persisted storage.
      
      Resolves: #54724
      Releases: 6.2, 6.1, 6.0
      Change-Id: I817ce86dde11b175e6a5765a8f6518770ba75f28
      Reviewed-on: https://review.typo3.org/27443
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      c47d8c53
    • Markus Klein's avatar
      [BUGFIX] Fix possible language handling issue · 6512f653
      Markus Klein authored
      The language initialization process is currently split in two main
      methods (TypoScriptFrontendController->initLLvars and ->settingLanguage).
      
      Only settingLanguage contains hooks and sets the "sys_language_uid"
      property (and "sys_language_content") which determine the displayed
      records in Frontend. On the opposite, initLLvars is not hookable and sets
      the "lang" property, which may be used by charset conversion methods.
      
      In order to determine display language within hooks, the only way
      currently is to call initLLvars a second time after determining language,
      but this method populates the "languageDependencies" property without
      initializing it. So it is filled two times, which leads to incorrect
      labels, especially if the displayed language is English and the
      default language is not English (as "languageDependencies" is already
      filled with "default language").
      
      The three parts of the patch are:
       * The initLLvars method now pre-initializes the "languageDependencies"
         property.
       * The initLLvars is now called from "settingLanguage" method, right
         after the "settingLanguage_preProcess" hook to avoid a second call it.
       * The convPOSTCharset call is now moved after the language
         initialization, as the language determination done by initLLvars
         can have some impact on charset handling (multi-charset locallang.php
         legacy).
      
      Change-Id: I6924345931342d5114b13e5d6fab417387559b9a
      Resolves: #49499
      Releases: 6.2, 6.1, 6.0
      Reviewed-on: https://review.typo3.org/27664
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      6512f653
  19. Feb 20, 2014
  20. Feb 19, 2014
  21. Feb 18, 2014
  22. Feb 17, 2014
    • Tomita Militaru's avatar
      [BUGFIX] addToAllTCAtypes() doesn't add new field · 48eab767
      Tomita Militaru authored
      Fixes problem with match on substring when adding a new field
      using ExtensionManagementUtility::addToAllTCAtypes()
      
      Resolves: #52527
      Releases: 6.1, 6.0
      Change-Id: I8877cdabc00f5ac64f1f7857bf47c275d36aae62
      Reviewed-on: https://review.typo3.org/27663
      Reviewed-by: Jigal van Hemert
      Tested-by: Jigal van Hemert
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      48eab767
    • Frans Saris's avatar
      [BUGFIX] Fix clipboard thumbnail rendering · 63447932
      Frans Saris authored
      The thumbnail rendering in filelist clibboard isn't
      updated to use FAL. And adding folders to clipboard
      with thumbnails enabled results in a fatal error.
      
      This changes makes sure the thumbnail is only rendered
      for files and updates the thumbnail part so it uses FAL.
      
      Resolves: #56037
      Releases: 6.2, 6.1
      Change-Id: I2a0eccd633f5313fed9ab94b5081c13e08892900
      Reviewed-on: https://review.typo3.org/27669
      Reviewed-by: Wouter Wolters
      Reviewed-by: Frans Saris
      Tested-by: Frans Saris
      Reviewed-by: Anja Leichsenring
      Tested-by: Anja Leichsenring
      63447932
    • Tim Lochmueller's avatar
      [BUGFIX] Usage of undefined variables in ShortcutToolbarItem · dc0ec8aa
      Tim Lochmueller authored
      Fix a undefined variable and a wrong variable assignment in the
      ShortcurtToolbarItem.
      
      Resolves: #55998
      Releases: 6.2, 6.1, 6.0
      Change-Id: I0f0ebcc846a9aa56edd05e384d62aad8f0a5b05b
      Reviewed-on: https://review.typo3.org/27661
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      dc0ec8aa