- Mar 09, 2023
-
-
Benjamin Kott authored
We renamed the eslint configuration to follow the recommended standards so developers IDEs will pick up the configuration more easily. The ruleset was adapted to follow a wider range of recommendations. - eslint:recommended - @typescript-eslint/recommended - lit/recommended - wc/recommended In addition we now also force more kinds of spacing rules to avoid IDEs having different opinions on how to format for example includes. The only recommendation we don't want to follow is - @typescript-eslint/no-inferrable-types. We don't want to disallow being explicit. Instead of turning off rules we cannot fully fulfill as of now, we are now changing the configuration to warning. This will help developers spotting mistakes more easy when writing code. Rules that are currently in "warn" mode: - @typescript-eslint/ban-types - @typescript-eslint/no-explicit-any - @typescript-eslint/no-this-alias To only check for errors run in the Build directory: - npx eslint ./Sources/TypeScript/ --quiet We are removing the custom member ordering and preferring the default. @typescript-eslint/member-ordering Resolves: #100126 Releases: main Change-Id: I6f09f82c0bdcde1aa3edec66b3b6ab028d5bb242 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78040 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Daniel Hettler authored
When indexing files the FileContentParser collects some metadata e.g. title, description and keywords. For some files these information are not given and the parser breaks in an PHP 8 environment. Resolves: #100122 Releases: main, 11.5 Change-Id: I54b5512c7e30c9719654591d520943733fbfe920 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78076 Reviewed-by:
Albrecht Köhnlein <ak@koehnlein.eu> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Thomas Hohn <tho@gyldendal.dk> Reviewed-by:
-
Christian Eßl authored
Ensure the language of the checked record actually exists in the site, in case orphan records of other languages are present. Resolves: #100111 Releases: main Change-Id: I5cb3d2e09cfc86b5d43eba9e16b3833afe18e6b8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78046 Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Kevin Appelt <kevin.appelt@icloud.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
- Mar 08, 2023
-
-
Nikita Hovratov authored
Improve readability of the method by extracting distinct cases into own blocks with early return statements. Case 1: "EXT:" path Case 2: (already) absolute path Case 3: relative public path Resolves: #100094 Releases: main Change-Id: I664c3611ef86c779c0398c7a4f938297eb591a81 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78034 Reviewed-by:
-
Oliver Klee authored
Resolves: #100080 Releases: main, 11.5 Change-Id: If607b7dc6d8f7bdc984751835433dabcc6cad085 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78022 Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
-
- Mar 07, 2023
-
-
Alexander Schnitzler authored
ObjectMonitoringInterface is a signaling interface for extbase internals to signal that an object state can be monitored. Its main purpose is to tell the persistence manager if an object or an object collection is so called dirty, i.e. if changes need to be persisted or not. This change lets DomainObjectInterface extend ObjectMonitoringInterface instead of AbstractDomainObject. Abstract classes must never be external api, they should just contain boilerplate/repetative code. With this change extbase can perform actions based on implemented interfaces, i.e. guaranteed functionality instead of checking object instances. Releases: main Resolves: #100069 Change-Id: I65548f3fe3f6a51c2b87e67c35642c431e2d7bb2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78012 Tested-by:
-
Alexander Schnitzler authored
This change introduces alternative methods to magic method __call() of extbase's Repository class. The magic method allowed for calling findBy[Property](), findOneBy[Property]() and countBy[Property](). Those methods are now implemented with a slightly different method signature but with type declaration and phpstan support. The naming follows the one of doctrine/orm which is implemented exactly the same. The new methods are: - findBy(array $criteria, ...): QueryResultInterface - findOneBy(array $criteria, ...): object|null - count(array $criteria, ...): int Using the magic methods is deprecated but will only trigger an E_USER_DEPRECATED error as of version 13. Releases: main Resolves: #100071 Change-Id: I1b51dd5b583a225a8a4d6f948810b1e5ef5d2257 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78014 Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
Stefan Bürk authored
With #91776 auto-created redirects have been stored with a pid of the page, which the slug has been changed. This was streamlined and changed to use the site rootPageId instead with #99044, which reverted the original use-case. This change implements two new PSR-14 events around each auto-create-redirect: * `ModifyAutoCreateRedirectRecordBeforePersistingEvent`: can be used to modify the redirect record before it is persisted * `AfterAutoCreateRedirectHasBeenPersistedEvent`: can be used to chain further task after the redirect has been persisted to the database. It's kind of a plain notification event. Resolves: #99834 Related: #99802 Related: #99044 Related: #91776 Releases: main Change-Id: I974020b148a3b5eb109624648016a79ed557af3e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76539 Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
-
Andreas Fernandez authored
To ease the usage of `group` fields in the FormEngine like e.g. in the "Insert records" content element, the record overview now shows the path to the location where each assigned record is stored, respectively. Resolves: #100093 Releases: main Change-Id: I1623b506727b46ccc86361e2c061c7e2c705a50f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78033 Reviewed-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
-
Alexander Schnitzler authored
Inside the extbase context child relations are always ordered by the foreign_sortby field if set or by order of creation. Even if the field foreign_default_sortby is set, it only impacts the order of the backend view. This patch brings the order of extbase results inline with the order of the backend view. Resolves: #64197 Releases: main, 11.5 Change-Id: I582576b5ac3741e2bbc4107664140fd9a2f63a16 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77985 Reviewed-by:
-
Torben Hansen authored
This change cleans up middlewares by * using constructor property promotion where possible * strict types where possible * Remove `@throws` annotations for exceptions never thrown * Remove value in function call, if it equals the default Resolves: #100090 Releases: main Signed-off-by:
-
Benni Mack authored
This change splits up * Edit/List/Add view of Scheduler * Check Setup * Available Tasks in each a separate controller + a custom third-level module. This way, it is then possible to separate the main scheduler module into custom actions (via subroutes) making the code a tiny bit more manageable. The previous "system_txschedulerM1" module name is now aliased to "scheduler_manage" (third-level), as the main scheduler module is now solely called "scheduler". The old name is kept for backwards-compatibility reasons. A note for historical fans: "M1" stands for "module 1" within the "tx_scheduler" extension. Resolves: #100104 Releases: main Change-Id: I2ba7c76899853864de42a11f2dc45c40ce699c91 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78038 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
-
Andreas Fernandez authored
This patch removes jQuery from the shortcut handling. Also, some minor refactorings were done: * use proper events for submit / cancel handling * submit the form as-is instead of building a custom payload Resolves: #100099 Releases: main Change-Id: I25fe414ba7bd8f513f6864a915fec8c75b61a16a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78039 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Stefan Bürk authored
With #100088 the `json` field handling has been changed from TCA `dbType = json` to `type = json` along with automatic db field creation, if not provided by `ext_tables.sql`. `\TYPO3\CMS\Core\Database\Schema\DefaultTcaSchema` has been changed to create a native json field with the default value of '[]' if not manually provided. MariaDB allows setting of default value for `text` and `json`fields, the competitor `MySQL` not. Many developers are not aware of this difference. `doctrine/dbal` does not help to avoid invalid field defaults. This change removes the default value for json field in the `DefaultTcaSchema` to restore cross database compatibility with `MySQL` again. Resolves: #100101 Related: #100088 Releases: main Change-Id: Id49ed0a4212386f68bf92d799abef2307cf32ac3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78043 Reviewed-by:
-
- Mar 06, 2023
-
-
Benjamin Kott authored
The new content element wizard is now a custom element with shadow dom enabled. The reactive component works on the data set assigned. Every element has a state the component respects and acts accordingly. Resolves: #100065 Releases: main Change-Id: I687b2c49e21d043867b6606ad40b7809980e35ec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77983 Reviewed-by:
-
Frank Naegler authored
A new TCA type "json" is introduced, which allows to simplify the configuration when working with fields, containing JSON data. It replaces the previously introduced dbtype=json of TCA type "user" (see: #99226). FormEngine will display the JSON data using codemirror, in case EXT:t3editor is installed and enabled for the field. Otherwise, a standard textarea HTML element is used. Using the new type, corresponding database columns are added automatically. Resolves: #100088 Related: #99226 Releases: main Change-Id: I49ab049966a86696910a7c18a7c45be00c162ca7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77798 Tested-by:
-
Andreas Fernandez authored
The "superglobal" `TYPO3.Utility` TypeScript module was removed in v10 with #87339. However, the related definition in our index.d.ts was forgotten, which is now removed. Resolves: #100095 Related: #87339 Releases: main, 11.5 Change-Id: Iece43a40b93f8ebfd1c312c09566600272bdfe10 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78035 Reviewed-by:
-
Torben Hansen authored
The redirect mode `referer` has been fixed with #91844. The fix is however incomplete, since it always uses the current HTTP_REFERER for redirect evaluation. This is problematic, if the login fails due to wrong credentials. In such a scenario, the user is redirected to the login page, which also overwrites the original HTTP_REFERER and results in the user being redirected to the login page after successful login. This patch ensures, that the original HTTP_REFERER is evaluated in the loginAction and passed as a variable to the login form, where it is used in the hidden field `referer`. This ensures, that the initial evaluated referer is kept in the failed login scenario. Resolves: #99920 Related: #91844 Releases: main, 11.5 Signed-off-by:
-
Torben Hansen authored
The current ContextData DTO contains a fixed set of properties for usage in password policy validators. In order to make the DTO more flexible, the class now internally uses an array to store data as key/value pairs. Additionally, the methods `getData()` and `setData()` have been added, which extension authors can use in upcoming PSR-14 events in order to enrich the object with custom data. Resolves: #99574 Releases: main Signed-off-by:
-
Helmut Hummel authored
The Symfony Expression language is able to evaluate any value from an expression, not only booleans. Open up TYPO3 wrapper API to reflect this, to allow extended usage of our API wrapper. Instead of only allowing boolean returns, the caller of the Resolver API is now responsible for casting the result of the expression to bool, if required. Also allow to pass additional context specific variables to the evaluate function, as it is not always possible to provide those through a global API, when some context is only available at the time of the evaluation of the expression. Resolves: #100073 Releases: main Change-Id: I093fb8ce37ee98f995e5ab707186917ec879d836 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78016 Reviewed-by:
-
Thomas Hohn authored
If the page record could not be resolved by getPage_noCheck, throw a PageAccessFailureReasons exception. Resolves: #99648 Releases: main, 11.5 Change-Id: Iecec94eea65814a695cfce1559f7c96bb0cde1df Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77505 Reviewed-by:
-
- Mar 05, 2023
-
-
Stefan Bürk authored
Due a regression since GitLab runner 15.1,we cannot use the official docker dind image to raise runner version to keep up with the TYPO3 gitlab instance. Because of other issues, using a custom docker dind image with changed expose port for the healthcheck to work around that issue is needed. See: https://gitlab.com/gitlab-org/gitlab-runner/-/issues/29130 After Gitlab has released a proper fix for this, this should be reverted and the official docker dind image used again. Resolves: #100086 Releases: main, 12.1, 11.5, 10.4 Change-Id: I4b433ba7f3a42c718b4d436cf42cdf619b9094ca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78028 Tested-by:
-
- Mar 04, 2023
-
-
Helmut Hummel authored
During migration to SF 6.2, the adapter was accidentally removed. Add the adapter again as a class, because we currently only require a fixed version of the SF contracts. Resolves: #100059 Related: #98158 Releases: main Change-Id: I96b50ee4e8b5eaf4d621b439a6ee471eca4470e0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77996 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
Torben Hansen authored
This change cleans up ModifyNewContentElementWizardItemsEvent by using constructor property promotion. Resolves: #100079 Releases: main Signed-off-by:
Chris Müller <typo3@krue.ml> Reviewed-by:
-
- Mar 03, 2023
-
-
Christian Kuhn authored
Property public static array $persistenceClasses has been introduced with #87623 in v10 and never been used. It seems this was an accidential left over from a previous version of the patch, or something like that. We remove that unused property without further deprecation since there was never a reason to use it. Change-Id: I4b08186e3c190ef564ce397739a7a53a53727834 Resolves: #100075 Related: #87623 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78018 Reviewed-by:
-
jjebouten authored
Resolves: #100070 Releases: main, 11.5 Change-Id: I1795983f0bf6990868a9f7d2275ddbb97482713d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78013 Reviewed-by:
-
Oliver Bartsch authored
Only apply TCA description override if it actually exists. Resolves: #100062 Releases: main Change-Id: I85a21419b9612e8e7738ea82094b262fc2ebacb3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78009 Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
- Mar 02, 2023
-
-
Torben Hansen authored
This patch adds a missing `col` divider element in the record history element, so the element is correctly positioned in the bootstrap grid system and content does not overflow the viewport. Resolves: #99823 Releases: main, 11.5 Signed-off-by:
-
Christian Kuhn authored
To streamline TypoScript related classes and namespaces, patch for #99120 introduced the new event \TYPO3\CMS\Core\TypoScript\IncludeTree\Event\ModifyLoadedPageTsConfigEvent and dispatching it. The old event with same signature at \TYPO3\CMS\Core\Configuration\Event\ModifyLoadedPageTsConfigEvent was kept, and continued to be dispatched to not introduce a breaking change anymore. The old event was changed to *extend* the new event. It turns out, the ListenerProvider is too clever at this point: When an event extends another event, it finds listeners for both events: When registering listeners for both the old and the new event, dispatching the old event will call listeners of the new event as well. Listeners can't distinguish this. To prepare for easy removal in v13, we now change the old event to no longer *extend* the new event. We continue to dispatch both events, though. The ReST file is adapted towards a better example on how to stay compatible in an extension and prepare for v13 as much as possible at the same time. Resolves: #100060 Related: #97816 Related: #99120 Change-Id: If5813ce2110de6078de33fa84ade57e852985266 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78000 Tested-by:
-
Jasmina Ließmann authored
In viewports with a resolution of less than 1000px, portrait format images are not fully visible in the image manipulation editor. This adjustment ensures that the complete image is visible. Resolves: #99199 Releases: main, 11.5 Change-Id: I4e2d961b889ceb1b2e7ec8e26f53f0c42adf33b1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77920 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Josef Glatz <typo3@josefglatz.at> Reviewed-by:
-
Thomas Hohn authored
Display PHP_VERSION after TYPO3 version number and current Application Context in CLI requests. Resolves: #100019 Releases: main, 11.5 Change-Id: I754b766d7b130409dbb06baffb04213c4635518e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77939 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Thomas Hohn authored
Added null coalescing operator in case $lastImgResourceInfo[3] is not set. Resolves: #99004 Releases: main, 11.5 Change-Id: Ieca6d193db884917785705b2468fcfe3ced623e2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77999 Tested-by:
Ralph Brugger <typo3bugs@public.linkpool.de> Reviewed-by:
-
Torben Hansen authored
The TYPO3 backend currently adds a `X-Frame-Options: SAMEORIGIN` HTTP security header to prevent clickjacking attacks. It is however possible to use several other HTTP security headers for TYPO3 backend requests as well. This change adds the following HTTP security headers by default for TYPO3 backend requests: * `Strict-Transport-Security: max-age=31536000` (only if :php:`$GLOBALS[TYPO3_CONF_VARS][BE][lockSSL]` is active) * `X-Content-Type-Options: nosniff` * `Referrer-Policy: strict-origin-when-cross-origin` Resolves: #100032 Releases: main Signed-off-by:
-
Torben Hansen authored
The migration example code is wrong, since the request object has no method named `getQueryString()`. Instead, `getQueryParams()` must be used. Resolves: #100061 Releases: main Signed-off-by:
-
- Mar 01, 2023
-
-
Oliver Bartsch authored
Resolves: #100054 Releases: main Change-Id: I820853416f953b2d34080e517ada6748ce684143 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77995 Tested-by:
-
Markus Friedrich authored
FrontendRestrictionContainer supports the usage of a local Context, but isn't passing the frontend group settings to the FrontendGroupRestriction. This commit extends the FrontendRestrictionContainer and ensures the frontend groups from the local environment are passed, improving the possibility to use simulated environments. Resolves: #100023 Releases: main, 11.5 Change-Id: Ie43911cce244acd6bbed54dd56d7d74f6fd24466 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77940 Tested-by:
Rafael Kähm <rafael.kaehm@dkd.de> Reviewed-by:
-
Christian Kuhn authored
After just a couple of years streamlining the core request handling, we finally have no non-deprecated usages to GeneralUtility::_GP() anymore and can happily deprecate it. Resolves: #100053 Related: #99615 Related: #99633 Releases: main Change-Id: Ib1acb97b5fd8e66aa3bcc285b01a93f31964c0cb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77990 Tested-by:
-
Thomas Hohn authored
The method getFileContents has return type string. However it contains a call to file_get_contents, that can return a boolean in case of failure. Added a check for if the file is readable and a cast to string when returning the value of the call to file_get_contents. In case of failure it will return the empty string, which will be caught properly in the method loadAndParse. Afterwards the error handling could be improved in loadAndParse to be more specific. Resolves: #100048 Releases: main, 11.5 Change-Id: Icf72332cdc2429318692682bf23e6d230109bdb6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77984 Tested-by:
-
Christian Kuhn authored
The internal property $this->checkSimilar is always true and never set differently. It can be removed from the codebase. Resolves: #100052 Releases: main Change-Id: I8c224d91f8866822d64e5a1b0de136ba256d6072 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77988 Tested-by:
-
Thomas Hohn authored
The method getFileContents has return value string. But since there is no guarantee that the file exists before calling file_get_contents, a call to is_readable has been added. This handles both the PHP Warning and ensures type correctness. Resolves: #99926 Releases: main, 11.5 Change-Id: I9786a6737d7e3b0c3d04272364d868fd4101307c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77978 Reviewed-by:
JAKOTA Design Group GmbH <suchowski@jakota.de>
-
