Skip to content
Snippets Groups Projects
Commit 4742f0d5 authored by Chris Müller's avatar Chris Müller Committed by Georg Ringer
Browse files

[BUGFIX] Make widget group identifier unique

In the "Add widget" dialog the id of the group tab was not unique.
This interfered with other ids in the backend. A prefix was added
to make it unique.

Resolves: #91129
Releases: master
Change-Id: Icf528c6ff8d755470d3158e94b1916a5ce028981
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64248


Tested-by: default avatarTYPO3com <noreply@typo3.com>
Tested-by: default avatarAndreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: default avatarBjörn Jacob <bjoern.jacob@tritum.de>
Tested-by: default avatarOliver Bartsch <bo@cedev.de>
Tested-by: default avatarGeorg Ringer <georg.ringer@gmail.com>
Reviewed-by: default avatarAndreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: default avatarBjörn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: default avatarOliver Bartsch <bo@cedev.de>
Reviewed-by: default avatarGeorg Ringer <georg.ringer@gmail.com>
parent d51e3d08
Branches
Tags
No related merge requests found
...@@ -78,7 +78,7 @@ ...@@ -78,7 +78,7 @@
<f:for each="{widgetGroups}" as="groupConfiguration" iteration="iterator"> <f:for each="{widgetGroups}" as="groupConfiguration" iteration="iterator">
<f:if condition="{groupConfiguration.widgets}"> <f:if condition="{groupConfiguration.widgets}">
<li class="t3js-tabmenu-item {f:if(condition: '{firstGroupActive} == \'false\'', then: 'active')}"> <li class="t3js-tabmenu-item {f:if(condition: '{firstGroupActive} == \'false\'', then: 'active')}">
<a id="tab-{groupConfiguration.identifier}" data-toggle="tab" href="#{groupConfiguration.identifier}" role="tab" aria-controls="{groupConfiguration.identifier}" aria-selected="true">{groupConfiguration.title}</a> <a id="dashboard-widgetgroup-tab-{groupConfiguration.identifier}" data-toggle="tab" href="#dashboard-widgetgroup-{groupConfiguration.identifier}" role="tab" aria-controls="dashboard-widgetgroup-{groupConfiguration.identifier}" aria-selected="true">{groupConfiguration.title}</a>
</li> </li>
<f:variable name="firstGroupActive" value="true" /> <f:variable name="firstGroupActive" value="true" />
</f:if> </f:if>
...@@ -88,7 +88,7 @@ ...@@ -88,7 +88,7 @@
<f:variable name="firstGroupActive" value="false" /> <f:variable name="firstGroupActive" value="false" />
<f:for each="{widgetGroups}" as="groupConfiguration" iteration="iterator"> <f:for each="{widgetGroups}" as="groupConfiguration" iteration="iterator">
<f:if condition="{groupConfiguration.widgets}"> <f:if condition="{groupConfiguration.widgets}">
<div class="tab-pane {f:if(condition: '{firstGroupActive} == \'false\'', then: 'active')}" id="{groupConfiguration.identifier}" role="tabpanel" aria-labelledby="{groupConfiguration.identifier}-tab"> <div class="tab-pane {f:if(condition: '{firstGroupActive} == \'false\'', then: 'active')}" id="dashboard-widgetgroup-{groupConfiguration.identifier}" role="tabpanel" aria-labelledby="dashboard-widgetgroup-{groupConfiguration.identifier}-tab">
<div class="dashboard-modal-items "> <div class="dashboard-modal-items ">
<f:for each="{groupConfiguration.widgets}" as="widgetConfiguration" key="widgetIdentifier"> <f:for each="{groupConfiguration.widgets}" as="widgetConfiguration" key="widgetIdentifier">
<div class="dashboard-modal-item"> <div class="dashboard-modal-item">
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment