From 4742f0d566e6767ee4795aa90e36738d37c45912 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Chris=20M=C3=BCller?= <typo3@krue.ml>
Date: Sun, 19 Apr 2020 17:06:36 +0200
Subject: [PATCH] [BUGFIX] Make widget group identifier unique
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
In the "Add widget" dialog the id of the group tab was not unique.
This interfered with other ids in the backend. A prefix was added
to make it unique.
Resolves: #91129
Releases: master
Change-Id: Icf528c6ff8d755470d3158e94b1916a5ce028981
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64248
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
---
.../dashboard/Resources/Private/Templates/Dashboard/Main.html | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/typo3/sysext/dashboard/Resources/Private/Templates/Dashboard/Main.html b/typo3/sysext/dashboard/Resources/Private/Templates/Dashboard/Main.html
index b5f2ed8e133f..c334b2d8ea31 100644
--- a/typo3/sysext/dashboard/Resources/Private/Templates/Dashboard/Main.html
+++ b/typo3/sysext/dashboard/Resources/Private/Templates/Dashboard/Main.html
@@ -78,7 +78,7 @@
<f:for each="{widgetGroups}" as="groupConfiguration" iteration="iterator">
<f:if condition="{groupConfiguration.widgets}">
<li class="t3js-tabmenu-item {f:if(condition: '{firstGroupActive} == \'false\'', then: 'active')}">
- <a id="tab-{groupConfiguration.identifier}" data-toggle="tab" href="#{groupConfiguration.identifier}" role="tab" aria-controls="{groupConfiguration.identifier}" aria-selected="true">{groupConfiguration.title}</a>
+ <a id="dashboard-widgetgroup-tab-{groupConfiguration.identifier}" data-toggle="tab" href="#dashboard-widgetgroup-{groupConfiguration.identifier}" role="tab" aria-controls="dashboard-widgetgroup-{groupConfiguration.identifier}" aria-selected="true">{groupConfiguration.title}</a>
</li>
<f:variable name="firstGroupActive" value="true" />
</f:if>
@@ -88,7 +88,7 @@
<f:variable name="firstGroupActive" value="false" />
<f:for each="{widgetGroups}" as="groupConfiguration" iteration="iterator">
<f:if condition="{groupConfiguration.widgets}">
- <div class="tab-pane {f:if(condition: '{firstGroupActive} == \'false\'', then: 'active')}" id="{groupConfiguration.identifier}" role="tabpanel" aria-labelledby="{groupConfiguration.identifier}-tab">
+ <div class="tab-pane {f:if(condition: '{firstGroupActive} == \'false\'', then: 'active')}" id="dashboard-widgetgroup-{groupConfiguration.identifier}" role="tabpanel" aria-labelledby="dashboard-widgetgroup-{groupConfiguration.identifier}-tab">
<div class="dashboard-modal-items ">
<f:for each="{groupConfiguration.widgets}" as="widgetConfiguration" key="widgetIdentifier">
<div class="dashboard-modal-item">
--
GitLab