Skip to content
Snippets Groups Projects
  1. Mar 25, 2014
  2. Mar 24, 2014
    • Marc Bastian Heinrichs's avatar
      [BUGFIX] Fix usage of preparedStatement object in $query->statement · 9b3f07e4
      Marc Bastian Heinrichs authored
      This is a follow-up fix for the integration of preparedStatements in
      Extbase. Due to a wrong comparison, an own preparedStatement object
      used in $query->statement() would never be executed.
      
      Resolves: #57254
      Releases: 6.2
      Change-Id: I3176339be309530b50ff89410affa386d7f6f8e8
      Reviewed-on: https://review.typo3.org/28726
      Reviewed-by: Felix Oertel
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      9b3f07e4
    • Jigal van Hemert's avatar
      [TASK] Add warning in Reports module if content adapter is active · fac12e2a
      Jigal van Hemert authored
      The setting [FE][activateContentAdapter] has a large impact on
      performance. A warning in the Reports module will encourage
      integrators to adapt TypoScript to increase performance.
      
      Resolves: #57249
      Releases: 6.2
      Change-Id: I935b86ba701d3b0dbac3b807a1ae9312bff223fc
      Reviewed-on: https://review.typo3.org/28724
      Reviewed-by: Wouter Wolters
      Reviewed-by: Alexander Opitz
      Tested-by: Alexander Opitz
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      fac12e2a
    • Felix Oertel's avatar
      [BUGFIX] FOLLOWUP Queries with NULL don't work · 449c81e4
      Felix Oertel authored
      In https://review.typo3.org/28592 we apparently did not 
      fix the whole problem. This followup will deal with
      the edge-case of using a similar built statement, which
      results in the same hash being generated from the
      QueryParser.
      
      Resolves: #57130
      Related: #55167
      Releases: 6.2
      Change-Id: I02a478fcabb89d11054f8f0a3c800965edfd7844
      Reviewed-on: https://review.typo3.org/28715
      Reviewed-by: Marc Bastian Heinrichs
      Tested-by: Marc Bastian Heinrichs
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      449c81e4
    • Marc Bastian Heinrichs's avatar
      [BUGFIX] Fix operator "in" for cached queries · ff162d36
      Marc Bastian Heinrichs authored
      This a follow up fix for the extbase query cache. On reusing an already
      build query, it was missed to evaluate the multi valued operator and
      provide it as array for resolving the parameter placeholders.
      
      Resolves: #57104
      Releases: 6.2
      Change-Id: I06abbf5279ee05382a7ba314948f7d3f075d84e6
      Reviewed-on: https://review.typo3.org/28695
      Reviewed-by: Alexander Stehlik
      Tested-by: Alexander Stehlik
      Tested-by: Wouter Wolters
      Reviewed-by: Felix Oertel
      Tested-by: Felix Oertel
      ff162d36
    • Ernesto Baschny's avatar
      [TASK] BasicFileUtility::init is not deprecated yet · ab443de2
      Ernesto Baschny authored
      Until we fully remove usage of BasicFileUtility throughout the core
      (i.e. DataHandler, Import/Export module, ElementBrowser and others),
      the core should not pollute the deprecation log with it.
      
      We just individually deprecate methods which are not used anymore.
      Methods which are still used in the core are marked as @deprecated
      (to visualize this in the IDE) but they won't write to the
      deprecation log yet.
      
      Resolves: #57209
      Releases: 6.2
      Change-Id: I41d7f6c8b7c3c4df77791ce3e6f3f69140d1935d
      Reviewed-on: https://review.typo3.org/28674
      Reviewed-by: Xavier Perseguers
      Reviewed-by: Jigal van Hemert
      Tested-by: Jigal van Hemert
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      ab443de2
    • Marc Bastian Heinrichs's avatar
      [TASK] Make section index from hidden headers work again · d222e935
      Marc Bastian Heinrichs authored
      Before version 4.7 you could build up a section index with
      links to content elements with hidden headers.
      Since version 4.7 elements with a hidden header type are sorted
      out for the section index, overriding the extra flag "sectionIndex",
      which is especially integrated for this.
      
      This patch adds a extra flag for menu configuration sectionIndex
      named "includeHiddenHeaders" to make it possible to re-enable
      the behaviour of versions before 4.7.
      
      Resolves: #52928
      Related: #31767
      Documentation: #53699
      Releases: 6.2
      Change-Id: Iee7f20cfc317c2b624dfc440811c5edc0a367a1e
      Reviewed-on: https://review.typo3.org/24876
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Wouter Wolters
      Reviewed-by: Sebastian Fischer
      Reviewed-by: Jigal van Hemert
      Tested-by: Jigal van Hemert
      d222e935
    • Helmut Hummel's avatar
      [BUGFIX] Fix tests according to changes in #57199 · e34562ba
      Helmut Hummel authored
      Unit tests have been forgotten to be adapted,
      so fix them now to make travis happy again.
      
      Also remove the superfluous constructor
      in InstallUtility, as both dependencies
      are injected anyway.
      
      Resolves: #57247
      Related: #57199
      Releases: 6.2
      Change-Id: I40c39705c2db546b38d94936feac2c8757eed8da
      Reviewed-on: https://review.typo3.org/28722
      Reviewed-by: Helmut Hummel
      Tested-by: Helmut Hummel
      e34562ba
    • Benjamin Mack's avatar
      [TASK] Add single view for distributions in EM · 68a0581f
      Benjamin Mack authored
      In order to know what is going to be installed, the
      distribution manager should display more information
      about a single extension, also with a link to configure
      the distribution, if possible.
      
      Releases: 6.2
      Resolves: #57212
      Change-Id: Ia092ec7b2c5162b33f4fce614415de07ffa2ca47
      Reviewed-on: https://review.typo3.org/28677
      Reviewed-by: Xavier Perseguers
      Tested-by: Xavier Perseguers
      Reviewed-by: Helmut Hummel
      Tested-by: Helmut Hummel
      68a0581f
    • Alexander Opitz's avatar
      [TASK] Add Link to wiki page for opcode cache · 5cc88c8d
      Alexander Opitz authored
      Add a link to http://wiki.typo3.org/Opcode_Cache in installers
      system environment check messages.
      
      Resolves: #56526
      Releases: 6.2
      Change-Id: If7314d52426729ce092e281697fbbd67bd6ae9d7
      Reviewed-on: https://review.typo3.org/28712
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Jigal van Hemert
      Tested-by: Jigal van Hemert
      5cc88c8d
    • Helmut Hummel's avatar
      [BUGFIX] Fix extension installation process · 30aa90f0
      Helmut Hummel authored
      The download queue is build recursively, but if an
      extension is marked for download, it is added
      to the queue before its dependencies have been
      resolved, which leads to a wrong download and
      installation order of extensions.
      
      We also need to add dependency resolving when
      marking an extension for installation to fix
      the exact same problem when extensions already
      reside in the system.
      
      Lastly we must take care of flushed class loader
      caches and trigger a rebuild to avoid fatals.
      This is done by introducing a signal and registering
      a method in package manager as slot that set the
      packages for the class loader to trigger a rebuild
      of the caches.
      
      The parts of this patch that fix dependency handling
      should be backported to older 6.x branches.
      
      Resolves: #57199
      Releases: 6.2
      Change-Id: Iab343c544bfe2e3e19cbf4c05090eb4994df57b1
      Reviewed-on: https://review.typo3.org/28660
      Reviewed-by: Sebastian Fischer
      Reviewed-by: Philipp Gampe
      Tested-by: Philipp Gampe
      Reviewed-by: Christian Kuhn
      Reviewed-by: Xavier Perseguers
      Tested-by: Xavier Perseguers
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      30aa90f0
    • Klaas Johan Kooistra's avatar
      [BUGFIX] Queries with NULL don't work anymore · 8326a71f
      Klaas Johan Kooistra authored
      See change: I517c0500cad75cae96fd739f2ff7222db80b42a5
      At the end of the Typo3DbQueryParser::parseComparison() method the updated
      operator for NULL values was no longer passed to the parseDynamicOperand,
      generating = NULL instead of IS NULL.
      
      Solved the issue by adding the operator parameter again.
      
      Change-Id: I13c3cecf0bf4c95789032f31ead192b945794484
      Resolves: #57130
      Related: #55167
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/28592
      Reviewed-by: Markus Klein
      Reviewed-by: Felix Oertel
      Tested-by: Felix Oertel
      8326a71f
    • Helmut Hummel's avatar
      [BUGFIX] Don't access property if subject is scalar · 904dfaaa
      Helmut Hummel authored
      Trying to access a property if the subject is
      a string, causes the class loader to be triggered
      as is_callable is invoked.
      
      We can avoid that by checking if the subject
      is an object or array. We can neglect that
      is_scalar also returns false for resource types
      as this will not really happen in practice.
      
      Resolves: #56993
      Releases: 6.2
      Change-Id: I94754cd919acc857cd9a8b8e486080c0bf567112
      Reviewed-on: https://review.typo3.org/28586
      Reviewed-by: Alexander Opitz
      Tested-by: Alexander Opitz
      Reviewed-by: Christian Weiske
      Tested-by: Christian Weiske
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      904dfaaa
    • Nicole Cordes's avatar
      [TASK] Make show_rechis.php mod.php dispatched · 91187e10
      Nicole Cordes authored
      The patch adds a new module for the record history view. All calls to
      the show_rechis.php script are rewritten to use
      BackendUtility::getModuleUrl() to ensure CSRF protection.
      
      Resolves: #56632
      Releases: 6.2
      Change-Id: I2466c1b08afdd7d987ef38a29500f02641156c07
      Reviewed-on: https://review.typo3.org/28205
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      91187e10
    • Xavier Perseguers's avatar
      [BUGFIX] Typo in Extbase localization file · 3431afb6
      Xavier Perseguers authored
      Fixes: #57238
      Releases: 6.2, 6.1, 6.0
      Change-Id: Icca7e1637387e2ad31a1368abcd59b1bd443255f
      Reviewed-on: https://review.typo3.org/28705
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Xavier Perseguers
      Tested-by: Xavier Perseguers
      3431afb6
    • Alexander Opitz's avatar
      [FEATURE] Add complete opcode cache reset · 423042f1
      Alexander Opitz authored
      This adds the possibility to reset the complete opcode cache in the
      install tool. This functionality may be needed if you update extensions
      not via EM and the cache does not stat the files.
      
      Resolves: #56987
      Releases: 6.2
      Change-Id: I540a31a939fdc6305ad0aff9d39f7e424404925d
      Reviewed-on: https://review.typo3.org/28520
      Reviewed-by: Stefan Neufeind
      Reviewed-by: Ernesto Baschny
      Tested-by: Ernesto Baschny
      Reviewed-by: Xavier Perseguers
      Tested-by: Xavier Perseguers
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      423042f1
    • Oliver Hader's avatar
      [TASK] Reduce JavaScript dependency in workspace module · 92b74a4d
      Oliver Hader authored
      The workspace module in the backend has a check and dependency to
      the page module in the top frame. To ease debugging of this
      backend module in a separate browser process, this dependency is
      encapsulated since JavaScript errors are thrown.
      
      Resolves: #57176
      Releases: 6.2
      Change-Id: I79b4d79ad23d89a70014602d4a04360f709fcab5
      Reviewed-on: https://review.typo3.org/28632
      Reviewed-by: Oliver Hader
      Tested-by: Oliver Hader
      92b74a4d
    • Benjamin Kott's avatar
      [BUGFIX] IRRE bidirectional relation not highlighted · 9b5ad3eb
      Benjamin Kott authored
      Currently the user is not able to recognize that he is working on
      record relations. These records may be used in several places in
      the system and the user should be aware of that specific behaviour.
      
      In previous versions of TYPO3 there has been a wrapper which
      highlighted input fields, but had no explanation. This was removed
      later. To restore the functionality and make it understandable to the
      user why he should edit the fields wisely, the wrapper has been replaced
      by a flash message. This explains to the user what happens when the
      record gets changed.
      
      Resolves: #55553
      Releases: 6.2
      Change-Id: Ic8a41cdb251cfc8d0134e2b53927ff71ddd5e594
      Reviewed-on: https://review.typo3.org/27235
      Reviewed-by: Stefan Froemken
      Tested-by: Stefan Froemken
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      9b5ad3eb
    • Helmut Hummel's avatar
      [BUGFIX] ClassLoader exits early for invalid class names · 0e20f584
      Helmut Hummel authored
      Instead of doing calculations if an invalid
      class name could still be found and implementing
      safeguards that our caching layer does not
      fail with invalid identifiers, we exit early
      if we find an invalid class name.
      
      Maybe PHP will be smart enough at some point
      not calling an autoloader at all if the class name
      is invalid anyway so we could the remove this check.
      
      By doing a comprehensive check upfront, we can
      remove the safeguard code for the caching layer.
      
      The performance impact of this change breaks down
      to be lower than 1ms for a regular TYPO3 request.
      
      Resolves: #57183
      Releases: 6.2
      Change-Id: Id38bea6b85fbfd280417adca325411410cd9fb63
      Reviewed-on: https://review.typo3.org/28553
      Reviewed-by: Thomas Maroschik
      Reviewed-by: Sebastian Fischer
      Reviewed-by: Alexander Stehlik
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Alexander Opitz
      Tested-by: Alexander Opitz
      Reviewed-by: Ernesto Baschny
      Tested-by: Ernesto Baschny
      0e20f584
    • Philipp Gampe's avatar
      [BUGFIX] Invalid argument supplied for foreach in ExtensionModelUtility · 0681f84f
      Philipp Gampe authored
      Dependecies might be given as empty string, e.g.
      array (
      	'depends' =>
      		array (
      			'typo3' => '4.5.0-6.2.99',
      		),
      	'conflicts' => '',
      	'suggests' =>
      		array (
      		),
      ),
      
      This is how the kickstarter used to generate it.
      
      Resolves: #57207
      Releases: 6.2
      Change-Id: I314249f8883ee82fdfa9ee81aca7a526716ccade
      Reviewed-on: https://review.typo3.org/28671
      Reviewed-by: Alexander Opitz
      Tested-by: Alexander Opitz
      Reviewed-by: Ernesto Baschny
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      0681f84f
    • Claus Due's avatar
      [BUGFIX] Unresolvable dependency if composer.json lacks version · f6f96f7c
      Claus Due authored
      This change fixes a problem which occurs under these circumstances:
      
      * Extension A depends on Extension B
      * Extension B is currently installed
      * Extension A is not currently installed
      * Extension B has composer.json file
      * Extension B composer.json file contains no "version" attribute
        or this attribute is empty.
      
      When installing Extension A in this case, EM will fail with an
      error saying "could not resolve dependency for xyz" which is a
      bit too vague to be helpful. This change fixes this murky error
      by throwing a much more specific error saying exactly that the
      error stems from the composer.json file missing a "version" no.
      
      Releases: 6.2
      Resolves: #57216
      Change-Id: I39ab18d6cf35b69600663524827422c732b813cf
      Reviewed-on: https://review.typo3.org/28683
      Reviewed-by: Alexander Opitz
      Tested-by: Alexander Opitz
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      f6f96f7c
    • Markus Klein's avatar
      [CLEANUP] Wrong phpdoc in EnableFileService · c8236cb8
      Markus Klein authored
      Fixing a wrong phpdoc comment in EnableFileService
      
      Resolves: #57226
      Releases: 6.2
      Change-Id: I3531960084bd950f5803bc2212ac36037558cbe3
      Reviewed-on: https://review.typo3.org/28693
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      c8236cb8
    • Christian Weiske's avatar
      [BUGFIX] Use file name to check extension validity · 96210e52
      Christian Weiske authored
      Instead of using a file's identifier, the file's name is used
      to check if it has a valid file extension.
      
      This allows FAL drivers to use non-file name related identifiers.
      
      Change-Id: I5b870e06f60c9259951a5f20fd69660ab19c49c2
      Resolves: #57141
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/28597
      Reviewed-by: Frans Saris
      Tested-by: Frans Saris
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      96210e52
    • Frans Saris's avatar
      [TASK] Add ResourceStorage getEvaluatePermissions() · 0e3910a3
      Frans Saris authored
      #51326 introduced a setEvaluatePermissions() method
      to enable/disable permission checking in the
      ResourceStorage. But a getter is missing so there
      is no way to get the current setting.
      This is needed if you only want to disable the
      checks temporary and you do not know what the
      current state is.
      
      This changes adds a getter for the evaluatePermissions
      value so you can fetch the current value.
      
      Resolves: #57220
      Releases: 6.2
      Change-Id: I3fd22c112fb1f251b85d23fd8fa553091e3e3fc4
      Reviewed-on: https://review.typo3.org/28690
      Reviewed-by: Xavier Perseguers
      Tested-by: Xavier Perseguers
      Reviewed-by: Alexander Opitz
      Tested-by: Alexander Opitz
      Reviewed-by: Frans Saris
      Tested-by: Frans Saris
      0e3910a3
  3. Mar 23, 2014
    • Tymoteusz Motylewski's avatar
      [TASK] Improve clipboard names · 9ddc0500
      Tymoteusz Motylewski authored
      Makes clipboard names more meaningful for editors.
      It also makes "Normal" clipboard name translatable
      and adds titles with additional description to the clipboard links.
      
      Resolves: #57154
      Releases: 6.2
      Change-Id: I218a70648616eb1d2efca0006411af57c3cff96e
      Reviewed-on: https://review.typo3.org/28610
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      9ddc0500
    • Pascal Dürsteler's avatar
      [TASK] Move update functionality to BackendUserSessionRepository · 293b71f8
      Pascal Dürsteler authored
      As annotated in SwitchBackUserHook.php, the update method is moved
      into the BackendUserSessionRepository file.
      
      Resolves: #57012
      Releases: 6.2
      Change-Id: I5e127b8e71585e64bd99ae3175655b058162da83
      Reviewed-on: https://review.typo3.org/28487
      Reviewed-by: Wouter Wolters
      Reviewed-by: Philipp Gampe
      Tested-by: Philipp Gampe
      Reviewed-by: Pascal Dürsteler
      Tested-by: Pascal Dürsteler
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      293b71f8
    • Xavier Perseguers's avatar
      [BUGFIX] preparseQuery wrongly computes cache hash of a query · ed50510a
      Xavier Perseguers authored
      preparseQuery only takes query's parameters to compute its hash but
      not the operators used. As such, those two queries result into the
      same cache hash:
      
      SELECT * FROM fe_groups WHERE uid = :uid
      
      SELECT * FROM fe_groups WHERE uid IN (:uid)
      
      Fixes: #57173
      Releases: 6.2
      Change-Id: I6a65ba0be81da73f55c2e6a73f508728567064c3
      Reviewed-on: https://review.typo3.org/28656
      Reviewed-by: Felix Oertel
      Tested-by: Felix Oertel
      Reviewed-by: Markus Klein
      Reviewed-by: Philipp Gampe
      Tested-by: Philipp Gampe
      ed50510a
    • Markus Klein's avatar
      [TASK] Rename GeneralUtility in Documentation sysext · 4a4c2365
      Markus Klein authored
      Rename the GeneralUtility class in the Documentation sysext to avoid
      confusion with GeneralUtility used in the Core sysext.
      
      Resolves: #57197
      Releases: 6.2
      Change-Id: Iff44c713307c86840d60bc9ef5aee67ae9741fa9
      Reviewed-on: https://review.typo3.org/28655
      Reviewed-by: Xavier Perseguers
      Tested-by: Xavier Perseguers
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      Reviewed-by: Philipp Gampe
      Tested-by: Philipp Gampe
      4a4c2365
    • Francois Suter's avatar
      [BUGFIX] Avoid empty labels in EM configuration · f1c4ce7a
      Francois Suter authored
      Check if a given configuration option in the EM really has both
      a headline and a text, before writing out an empty label.
      
      Resolves: #57205
      Releases: 6.2
      Change-Id: I66c405f255b9bd6ba9b130088732984157cf4152
      Reviewed-on: https://review.typo3.org/28665
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Stefan Neufeind
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      f1c4ce7a
    • Ernesto Baschny's avatar
      [TASK] Styling for the distribution management · 2f75ff1e
      Ernesto Baschny authored
      The distribution management looks ugly. Make it usable
      and not just a raw list.
      
      Resolves: #57139
      Releases: 6.2
      Change-Id: I95eb8dca3cd6b3915839736d18ff3d78e746a30a
      Reviewed-on: https://review.typo3.org/28615
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      2f75ff1e
    • Stefan Neufeind's avatar
      [BUGFIX] Parsetime: config.debug should override LocalConfiguration · b06b67b2
      Stefan Neufeind authored
      Parsetime is output either if config.debug is set or if FE-debug
      is activated in LocalConfiguration. Allow to explicitly override
      (set to 0) the debugging in TS for cases where you want to output
      page-objects like a JSON-page or so where Parsetime leads to
      problems.
      
      Change-Id: Ie5588218694219c13f136b5ac928e697ca472cfb
      Resolves: #57202
      Releases: 6.2, 6.1
      Reviewed-on: https://review.typo3.org/28663
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Stefan Neufeind
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      b06b67b2