- Nov 20, 2017
-
-
Helmut Hummel authored
While fixing #82877 a mistake was introduced which leads to a JavaScript error when filtering the page tree. Problem is that PageTree.select() is called with the filter tree currently active, but this method is only functional for the full page tree since quite a while now. We now avoid calling this method and document the behavior properly in method annotations. Additionally a typo in the variable name is fixed, which lead to a jquery warning when selecting a page. Resolves: #83039 Releases: master, 8.7 Change-Id: I6440fb7f6cfd6ead8b5b29dea7c5081dd688a5c3 Reviewed-on: https://review.typo3.org/54688 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Sebastian Fischer <typo3@evoweb.de> Tested-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
-
Benni Mack authored
Translations of the current page can now be listed and edited through the list module again. This is a follow-up change to the pages_language_overlay removal. Resolves: #83016 Releases: master Change-Id: I38b41ba6b1b3164ab1b9cdfc03bca14780c38c08 Reviewed-on: https://review.typo3.org/54530 Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
- Nov 19, 2017
-
-
Jigal van Hemert authored
The files included in the field tsconfig_includes are now included when collecting the page TSconfig in the TypoScriptFrontendController. Resolves: #82662 Releases: master, 8.7 Change-Id: I226f942045647a3b7c4130b9e5d39b6d982efd1b Reviewed-on: https://review.typo3.org/54276 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
- Nov 17, 2017
-
-
Robert Wildling authored
The link pointing to the positioning of own handlers (a changelog of v7.6) was missing a version paramater after "core/". Releases: master Resolves: #83025 Change-Id: I52d22ad30b4669b2fe59728551a24f761efd423d Reviewed-on: https://review.typo3.org/54673 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
-
Joerg Boesche authored
To modify the display result rows before data is assigned to the fluid view there is a new hook inside the `getDisplayResults()` method called `getDisplayResults_postProc`. Resolves: #82488 Releases: master Change-Id: I2f0ac073692fb28b9c71a18def027c71a418606f Reviewed-on: https://review.typo3.org/54148 Reviewed-by:
-
- Nov 16, 2017
-
-
Benni Mack authored
When working with localizations in a system, the option "Localization view" in the list module is a pre-requisite for all editors, for all installations without languages, the checkbox is not necessary. To streamline this behaviour, the option is removed and the functionality is enabled BY DEFAULT. Resolves: #82991 Releases: master Change-Id: I2005413405d009935e3b7d7d046e4aac284ee013 Reviewed-on: https://review.typo3.org/54633 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Helmut Hummel authored
L10nModeUpdater checks whether fields in translated records are modified, thus not synchronized with the parent record and the new l10n_state for this field is set to "custom" in this case or "parent" if the field is empty. However this is done after the data is synchronized, which leads to wrong data being written by the DataMapProcessor. To fix this, we move setting l10n_state upwards in the code, so that relations and fields from translated records can be updated correctly. Resolves: #83006 Releases: master, 8.7 Change-Id: Ibb06eecb6cf743bd6bba1990ca6f9391c983821f Reviewed-on: https://review.typo3.org/54657 Tested-by:
-
Helmut Hummel authored
TSConfig properties keepItems and removeItems are checked with a weak in_array() test (third argument not set to true), which leads to the situation, that arbitrary string values are treated equal to integer 0 This is now fixed by flipping the array and check for the array index. This works nicely because PHP silently converts strings which look like integer to integer for the keys. Tests are added which cover these cases and demonstrate the failure before the change. Resolves: #82980 Releases: 8.7, master Change-Id: I544a221674fa89d302cb6c1bcca506847c6f7f0f Reviewed-on: https://review.typo3.org/54623 Tested-by:
Joerg Boesche <typo3@joergboesche.de> Reviewed-by:
Henning Liebe <h.liebe@neusta.de> Reviewed-by:
Jan Stockfisch <jan.stockfisch@googlemail.com> Tested-by:
-
Oliver Hader authored
Remove duplicated "image" field definition in test scenario. Related: #69909 Releases: master, 8.7 Change-Id: Ie87e2e62e036fa70fb837f9bd05f2c3ba13019fa Reviewed-on: https://review.typo3.org/54668 Tested-by:
-
Oliver Hader authored
If DataMapProcessor is called with a non-reference id, e.g. zero (0), this submission is considered as a reference. Since there is no database record having UID 0, the synchronization process fails with the following exeception: #1486233164: Child record was not processed To solve this behavior, invalid references (empty/zero) are not considered anymore to compare references. Besides that, values for localized records that are configured to be synchronized are sanitized correctly now. Resolves: #83009 Releases: master, 8.7 Change-Id: Ie370007521c45dac8bca03978a387b4662952b1d Reviewed-on: https://review.typo3.org/54655 Tested-by:
-
Alexander Schnitzler authored
This patch introduces the usage of doctrine annotations. Therefore the AnnotationRegistry is configured during the bootstrap and the annotation "TYPO3\CMS\Extbase\Annotation\Inject" is evaluated when building a ClassSchema for a class. On top of that this patch puts the static variable $ignoredTags into the DocCommentParser class, which saved quite some bytes of RAM when reconstituting the ClassSchema objects from the cache. Resolves: #82869 Releases: master Change-Id: I99d17706395ebc0c308c7f611c59f207fe0b6233 Reviewed-on: https://review.typo3.org/54590 Tested-by:
-
Tymoteusz Motylewski authored
Resolves: #83003 Releases: master, 8.7 Change-Id: Iceaa7ab9bd436322229e591677c0aee16cd69f5c Reviewed-on: https://review.typo3.org/54652 Reviewed-by:
-
Frans Saris authored
Add all pageTS.RTE options to config without dots appended to the key to be able to override the RTE config with pageTS like before. Resolves: #82865 Releases: master, 8,7 Change-Id: Idb7d7d3b39d44ec37be8f93cc9de8b42b9c8a55c Reviewed-on: https://review.typo3.org/54511 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
Benni Mack authored
DataHandlers' newlog() function is a shorthand method that should act as a simple API, which it does, but it also adds a "[newlog()] " info in front of the error message, which is completely useless and only clutters DB and the log module. Resolves: #83012 Releases: master, 8.7 Change-Id: I9e1ea083461de9cdf66fad1a30019e51130a0186 Reviewed-on: https://review.typo3.org/54660 Reviewed-by:
Frans Saris <franssaris@gmail.com> Reviewed-by:
-
Wouter Wolters authored
In QueryBuilder::quoteIdentifiersForSelect the 3rd parameter of trimExplode is inserted. To prevent notices array_pad is added. Resolves: #82995 Releases: master,8.7 Change-Id: If35efcf5c8c3fd5b0360ae8795f9b92ae87250ab Reviewed-on: https://review.typo3.org/54640 Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Tymoteusz Motylewski authored
Resolves: #82921 Releases: master, 8.7 Change-Id: Id26239e65321aa3653de849932a0be7e626bd653 Reviewed-on: https://review.typo3.org/54558 Tested-by:
-
- Nov 15, 2017
-
-
Tymoteusz Motylewski authored
Fixes PHP notices thrown by accessing non existing array key. Resolves: #83004 Releases: master Change-Id: Ib5ff0ace0c9eb9a9987693176c4bee25026e2eb8 Reviewed-on: https://review.typo3.org/54653 Reviewed-by:
-
Claus Due authored
This patch adds a new hook to determine whether a content record is used or not. Since the default decision is fairly basic (only checks if $columns contains $record['colPos']) a hook makes it possible for third party extensions to change the decision and validate on their own. Included rst file shows how to register to the hook and provides example code how to determine the result. Resolves: #82213 Releases: master Change-Id: Id338254dae6575ba7b91141c10a42b99401614c9 Reviewed-on: https://review.typo3.org/53811 Tested-by:
Claus Due <claus@phpmind.net> Reviewed-by:
Nicole Cordes <typo3@cordes.co> Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Thomas Hohn authored
Before the file is processed a extra check is done to be sure the file exists. If the file doesn't exist it's marked as missing. Resolves: #80061 Releases: master, 8.7 Change-Id: Ifda396b75d2ace0ce126057a4e118856b15c05e0 Reviewed-on: https://review.typo3.org/51969 Reviewed-by:
Thomas Hohn <thomas@hohn.dk> Reviewed-by:
-
Tom Novotny authored
Return all fields to ease the work with hooks. Intention is not having to query again in hook $GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['felogin']['forgotPasswordMail'] to change "Hello [username],..." to "Hello [fist_name] [last_name],..." in password forgot mail to user. Change-Id: I18e18845e61d36aadd043758f902dc6627ad5f37 Resolves: #82996 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/54628 Reviewed-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
-
Joshua Westerheide authored
Check for cases where the files array is nested more complex or keywords (e.g. "error") are used as field names. Run `curl -F "d0[]=@d12.txt" -F "d0[d1][d2][d3]=@d12.txt" -F "error=@error_file.txt" localhost:8080` against a custom php script to generate the testing $_FILES array. Resolves: #82976 Releases: master, 8.7, 7.6 Change-Id: I51fb9da7c87871b6bb1e8ac4de317973f307dd49 Reviewed-on: https://review.typo3.org/54619 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Benni Mack authored
When doing translations with pages and inline elements (e.g. pages.media), there is an inconsistency when an additional inline element is added to the TRANSLATED page (e.g. language=1). Current (wrong) when adding a translation to a page - localized IRRE children get pid = default page ID (correct) - localized IRRE children only localization get parentid = default page ID (should be translated page ID) Current (wrong) behaviour when adding a IRRE child only available in a translation: - parentid gets localized page => correct - pid gets set to localized page => must be default language The patch corrects this behaviour by always set - the relation (parentid) to the localized page ID - the page ID (pid) to the default language page ID Additionally, when adding an Inline element (IRRE) via AJAX on page properties, the PID gets resolved correctly to be sent to DataHandler. Resolves: #82983 Releases: master Change-Id: Id8bf39524ee608acf452e2b7103087d4299c1e28 Reviewed-on: https://review.typo3.org/54632 Tested-by:
Daniel Gorges <daniel.gorges@b13.de> Tested-by:
-
- Nov 14, 2017
-
-
Sascha Egerer authored
Exceptions in the ImageViewhelper are currently silently ignored. So you'll get no information if a wrong value has been passed to the src attribute or if there went something wrong. The exception is not rethrown as Fluid viewhelper exception so it will be catched and logged in Production Context by the AbstractViewhelper that calls the render method. Change-Id: I95124ebb945366d260b4351ccb85d61a399c50b5 Resolves: #82918 Releases: master Reviewed-on: https://review.typo3.org/54561 Tested-by:
Manuel Selbach <manuel_selbach@yahoo.de> Reviewed-by:
-
Mathias Schreiber authored
Stabilize the acceptance tests to activate and deactivate a language by checking only for the alerts instead of the enabled/disabled rows. Additionally make the download a language test fail immediately if the language is enabled. Resolves: #82972 Releases: master, 8.7 Change-Id: Ib380b464a24188dbbee37296ddda0f0bb5c44f5e Reviewed-on: https://review.typo3.org/54631 Tested-by:
Stephan Großberndt <stephan@grossberndt.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Susanne Moog authored
OrderBy does not make sense in a count only query and fails on SQL Server, hence it is removed. Change-Id: I676d1913f75c29dd71345dbc0f626e99df0d242f Resolves: #82994 Releases: master Reviewed-on: https://review.typo3.org/54638 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Mathias Brodala authored
Variadic arguments are optional but do not have a default value, thus properly check this. Also render the variadic operator ("...") in the output. Resolves: #82956 Releases: master, 8.7 Change-Id: I10e3528d9cffcdd03ae4711b139898f569ac3775 Reviewed-on: https://review.typo3.org/54600 Tested-by:Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de> Tested-by:
-
Georg Ringer authored
Add the missing label and adopt styling of the additional field which allows to link to a page by providing the page ID. Resolves: #82888 Releases: master, 8.7 Change-Id: I33ab92f235391add5d3da00a0251ee11eb936933 Reviewed-on: https://review.typo3.org/54575 Reviewed-by:
-
Alexander Schnitzler authored
When using private or protected properties for Dependency Injection via `@inject`, Extbase needs to use the object reflection API to make these properties settable from the outside, which is quite slow and cannot be cached in any way. Therefore property injection should only work for public properties. Releases: master Resolves: #82975 Change-Id: Ia9c6eb48c34c46634e626f7cd97a2e743a6aba7b Reviewed-on: https://review.typo3.org/54618 Reviewed-by:
-
- Nov 13, 2017
-
-
Andreas Fernandez authored
With this patch t3editor is now aware of `FLUIDTEMPLATE`, thus supported by code completion. Resolves: #82967 Releases: master, 8.7 Change-Id: I82cc9bd22a5a0829ea634eb5cfda4bc8e589c1cc Reviewed-on: https://review.typo3.org/54614 Tested-by:
-
Christian Kuhn authored
Use latest chromedriver to deal with youngest chrome in acceptance tests. Change-Id: I7d637022fa9e327e771198625943b11b986b5a04 Resolves: #82987 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/54629 Tested-by:
-
Stephan Großberndt authored
Improve performance iterating local files by avoiding multiple calls to SplFileInfo. Releases: master, 8.7 Resolves: #82936 Change-Id: I54b347ad4734d9083b67c7840ff3ab228c07f4bc Reviewed-on: https://review.typo3.org/54576 Tested-by:
-
Daniel Siepmann authored
Do not use frontend inclusion API for private template resource. Instead resolve to full absolute path for inclusion. Releases: master, 8.7 Resolves: #82978 Resolves: #82979 Change-Id: Iadd3a8386b967aeb8b5ffdb28baeb73c2a0f2734 Reviewed-on: https://review.typo3.org/54622 Reviewed-by:
-
- Nov 12, 2017
-
-
Benni Mack authored
An additional SQL index is added to the database. Resolves: #82445 Releases: master Change-Id: I94d1eab5f492b465fafbf3620b0f532e1403be76 Reviewed-on: https://review.typo3.org/54591 Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- Nov 11, 2017
-
-
Oliver Hader authored
If checkbox/radiobox values contain dots, these are falsely evaluated as array lookup paths. Fix this by passing in separate path segments instead which may contain dots. Resolves: #82210 Releases: master, 8.7 Change-Id: Ib3d0d1abbeb4fdf84da427f6bea0d597ba9aade6 Reviewed-on: https://review.typo3.org/54007 Reviewed-by:
Daniel Lorenz <daniel.lorenz@extco.de> Tested-by:
-
- Nov 10, 2017
-
-
Frans Saris authored
Resolves: #82964 Releases: master, 8.7 Change-Id: Iccaae0c2aeefa7c82b3df50956424509acea4233 Reviewed-on: https://review.typo3.org/54612 Reviewed-by:
-
- Nov 09, 2017
-
-
Helmut Hummel authored
Because users have no access to deleted pages, the access check always fails, leading to delete page actions not being shown in the history despite being properly tracked. We now check this case and do a more lightweight check so that we still have the permissions checked, but can show deleted pages without disclosing unwanted information. Resolves: #45056 Releases: 7.6, 8.7, master Change-Id: Id919a24651c18a351f9723e86610b525a4f4726c Reviewed-on: https://review.typo3.org/54580 Reviewed-by:
-
Alexander Opitz authored
Update the lock file to pull in the latest (1.4.5) release. This version is marked as PHP 7.2 compatible. composer command: composer update typo3/cms-composer-installers Releases: 8.7, master Resolves: #82898 Change-Id: I6c491ae7e93f656c01a9ef12d88969057b182ba7 Reviewed-on: https://review.typo3.org/54570 Reviewed-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
Ralf Zimmermann authored
Cache the merged YAML settings into the assets cache to improve the performance. Resolves: #82373 Releases: master, 8.7 Change-Id: I601364d5957f26f1b369b513534936820f72b78e Reviewed-on: https://review.typo3.org/54106 Tested-by:
Bjoern Jacob <bjoern.jacob@tritum.de> Reviewed-by:
-
Benni Mack authored
The TYPO3 Backend PageTree, built in TYPO3 4.5, has some strange quirks resolving DB records, doing a lot of queries for fetching a single page multiple times. This is unnecessary because this can be fetched with one query, which happens anyway. Additionally, the WSOL should only happen when a workspace is selected. Explicitly querying for "-1" pid etc. should be handled via SQL, and not explicitly implemented by the page tree. Bottom line: Remove one SQL-query per page which is loaded. As most of the PHP classes will be restructured with the upcoming ExtJS / ExtDirect removal, the removed methods will be part of the breaking change of ExtJS removal. Resolves: #82945 Releases: master Change-Id: I7b1d79b40d0e9212cc0884c9440e5725e4f74d8e Reviewed-on: https://review.typo3.org/54574 Tested-by:
-
- Nov 08, 2017
-
-
Susanne Moog authored
Several times the install tool was using html() instead of text(). Use text() whenever possible. Resolves: #82949 Releases: master Change-Id: I9a199d33f233a3b6c6b82965d4bc169999a3452a Reviewed-on: https://review.typo3.org/54586 Tested-by:
Michael Oehlhof <typo3@oehlhof.de> Reviewed-by:
-
