- Feb 28, 2018
-
-
Frank Naegler authored
Needs a typo3/testing-framework raise, too. Commands: yarn upgrade jquery composer update typo3/testing-framework Updates: - jquery@3.3.1 Resolves: #84063 Releases: master Change-Id: Iec4e821ebeb42c46da7d379ea081f3c0f25cc112 Reviewed-on: https://review.typo3.org/55921 Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Claus Due authored
This patch adds a try/catch around the call in TSFE to get page and rootline with domain and makes getPageShortcut function set $this->pageNotFound code, then throw error. Change-Id: Id6aae04d7b4c2a8b267b0d949c056471c3a6b01b Releases: master Resolves: #78831 Reviewed-on: https://review.typo3.org/50805 Tested-by:
Christer V <cvi@systime.dk> Reviewed-by:
Joerg Boesche <typo3@joergboesche.de> Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
Wolfgang Klinger <wolfgang@wazum.com> Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Tested-by:
-
Andreas Fernandez authored
Commands: yarn upgrade grunt-contrib-uglify --latest Upgrades: uglify-js 2.7.5 > 3.3.12 Change-Id: I082a92d87ef1616488c0d8ddcf3801617a37eb50 Resolves: #84075 Releases: master Reviewed-on: https://review.typo3.org/55932 Tested-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
Ralf Zimmermann authored
Avoid PHP warnings within ext:form DatePickerViewHelper if the property properties.additionalAttributes.placeholder is not defined within the form definition. Releases: master, 8.7 Resolves: #84065 Change-Id: I49e0bb3a9548f0be402e1a4794c60c1b42744fac Reviewed-on: https://review.typo3.org/55922 Tested-by:
Frans Saris <franssaris@gmail.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Frank Naegler authored
Commands: yarn upgrade chosen-js Updates: - chosen-js@1.8.3 Resolves: #84061 Releases: master Change-Id: Ic22da5e322ac5ad969f72cedfe7593e3976dff4d Reviewed-on: https://review.typo3.org/55920 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Benni Mack authored
The TSFE method "determineId" is hard to read, mostly due to the fact that it first evaluates preview settings from admin panel or logged-in backend users, and then calls "fetch_the_id()" possibly multiple times. In order to increase readability, the preview settings evaluation is moved into a custom protected method within TSFE. Resolves: #84056 Releases: master Change-Id: I9611801b77ab10f0e9407f2c558cbec1867cc560 Reviewed-on: https://review.typo3.org/55913 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
- Feb 27, 2018
-
-
Frank Naegler authored
Commands: yarn upgrade grunt yarn upgrade grunt-sass yarn upgrade jasmine-core Updates: - grunt@1.0.2 - grunt-sass@2.1.0 - jasmine-core@2.99.1 Resolves: #84059 Releases: master Change-Id: I833e2883c49a20cb5d748cb9d96b9e0cfb3f0d79 Reviewed-on: https://review.typo3.org/55918 Tested-by:
-
Frank Naegler authored
Commands: yarn upgrade @types/bootstrap yarn upgrade @types/jasmine yarn upgrade @types/jqueryui Updates: - @types/bootstrap@3.3.38 - @types/jasmine@2.8.6 - @types/jqueryui@1.12.2 Resolves: #84058 Releases: master Change-Id: I0cca00b6acc1cf8b4d9ed5ce1c09b73dc5bcfc07 Reviewed-on: https://review.typo3.org/55917 Tested-by:
-
Frank Naegler authored
Command: yarn upgrade codemirror Updates: - codemirror@5.35.0 Resolves: #84060 Releases: master Change-Id: I5e62d8ba0a7e2e51143a4d0438b7220ef72f80d1 Reviewed-on: https://review.typo3.org/55919 Tested-by:
-
Susanne Moog authored
The admin panel consisted of one big god class that contained the complete rendering. The hook to extend the admin panel only allowed to add content but not to add new modules (with expandable headers). The code has been refactored as a first step for a more flexible admin panel: - All modules are now rendered by a class per module - Modules have an interface - Modules can be registered in ext_localconf (and overwritten) using the dependency ordering service for priority - All new classes are strictly typed Related: #84044 Resolves: #84045 Releases: master Change-Id: I124bb503907dcfcbd4425d6f7178b87562d2fda4 Reviewed-on: https://review.typo3.org/55890 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Markus Klein authored
Add a new test to make sure that identical input arrays also deliver an empty result as difference. Resolves: #84067 Releases: master, 8.7, 7.6 Change-Id: Ia16ca9560094c4ae42eb69cac9e09cd4bef7dc4e Reviewed-on: https://review.typo3.org/55923 Reviewed-by:
Johannes Kasberger <johannes.kasberger@reelworx.at> Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
Andreas Fernandez authored
Change-Id: I3fb32010cbbf319ddc35a9c0e13a771625e9c5be Resolves: #82598 Releases: master Reviewed-on: https://review.typo3.org/55910 Tested-by:
-
Benni Mack authored
Use shortening parameters on places that haven't been touched in a while since PHP 7.0 was a requirement. Fix PHPdoc comments on various places. Use booleans instead of integers on variables clearly defined and evaluated as booleans. Resolves: #84057 Releases: master Change-Id: If0ef1a58622a98f4ae5769f953c4c62121abdc89 Reviewed-on: https://review.typo3.org/55915 Tested-by:
-
- Feb 26, 2018
-
-
Andreas Fernandez authored
Change-Id: I070facc7961d59b2151178810f3b77e6928607e0 Resolves: #82601 Releases: master Reviewed-on: https://review.typo3.org/55902 Tested-by:
-
Andreas Fernandez authored
The SplitButtons module is migrated to TypeScript. Additionally, some parameters of the Icons module are declared as optional. Change-Id: I61f883e8e496e018a45f63c303de66274d071d94 Resolves: #82602 Releases: master Reviewed-on: https://review.typo3.org/55906 Tested-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
-
Andreas Fernandez authored
The arguments `overlayIdentifier`, `state` and `markupIdentifier` are not required most times. This patch declares these arguments as optional. Change-Id: Id6d372be1d814763f2bf432254ac34b6b0d39f54 Resolves: #84048 Releases: master Reviewed-on: https://review.typo3.org/55909 Tested-by:
-
Andreas Fernandez authored
Change-Id: I7783157819cebea7c4ee55a0b0612483daf9cbf3 Resolves: #82582 Releases: master Reviewed-on: https://review.typo3.org/55907 Tested-by:
-
Andreas Fernandez authored
Change-Id: Ic71a3dde434402ad828e2098eefae80f4039475b Resolves: #82596 Releases: master Reviewed-on: https://review.typo3.org/55847 Tested-by:
-
Paweł Rogowicz authored
Additionally add a console warning when doktype doesn't have an icon Releases: master, 8.7 Resolves: #84018 Change-Id: If220a53e1dacf4d5b4fabdfcfc25331e83fe6811 Reviewed-on: https://review.typo3.org/55904 Tested-by:
Josef Glatz <josef.glatz@typo3.org> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Benjamin Franzke authored
There is Bootstrap::getInstance()->getEarlyInstance() and GeneralUtility::makeInstance() to retrieve (global) early instances. Sometimes the former, sometimes the latter is used (e.g. to retrieve the PackageManager). Classes should not know whether something is an early instance or not. Implementation details like that should be abstracted into a singleton container. That (currently) is GeneralUtility::makeInstance(). As there is no obvious reason why different methods are used, we now use GenerallyUtility::makeInstance() to retrieve singletons. Add all early singleton instances to the GeneralUtility singleton array and stop using Bootstrap::getEarlyInstance in classes outside Bootstrap. One exception to this is the composer ClassLoader. That (obviously) does not implement the TYPO3 SingletonInterface. We now push that instance to ClassLoadingInformation during the bootstrap. (similar to how the PackageManager is pushed to the ExtensionManagementUtility). Releases: master Resolves: #83966 Change-Id: Icf3bef5f51a6142d9d1dcdc9b3700a86d7bb7f78 Reviewed-on: https://review.typo3.org/55802 Tested-by:
-
Andreas Fernandez authored
Change-Id: Iab7de8a076a8d0d9249504dd487278e57a6b9ba4 Resolves: #82606 Releases: master Reviewed-on: https://review.typo3.org/55891 Tested-by:
-
Benni Mack authored
Frontend-related hooks are migrated into a PSR-15 compatible middleware to initialize workspace behaviour and previewing functionality. Resolves: #84040 Releases: master Change-Id: I8a86665aad95a84d4d65700949d861b96d006c13 Reviewed-on: https://review.typo3.org/55899 Tested-by:
Daniel Gorges <daniel.gorges@b13.de> Tested-by:
-
Benni Mack authored
The third parameter in PageRepository->getDomainStartPage is not used anymore. Saving an extra call to GeneralUtility to not hand this parameter over to the method in TSFE should be helpful. However, in the future, this method will probably be changed, the third parameter is not deprecated for now. Resolves: #84043 Releases: master Change-Id: I397dd86d703f4fa5778794209e90ffaa82baf872 Reviewed-on: https://review.typo3.org/55901 Tested-by:
-
Benni Mack authored
The PHP code for checking if a backend user is allowed to preview a page should use the Permission bitmask. Additionally, the check extPageReadAccess() is a sub-method of FrontendBackendUserAuthentication object, which checks the webmount and the page permissions, however, "doesUserHaveAccess" also checks for the webmount availability. Resolves: #84042 Releases: master Change-Id: Ibf8795d41bf9e624c64e07ee6ead34d741fb0bc2 Reviewed-on: https://review.typo3.org/55900 Tested-by:
-
Benni Mack authored
Instead of faking an existing backend user, the workspace preview functionality (= from a link) should use an anonymous read-only use which has only access to the workspace and the page, in order to remove the hacks to allow read-access for existing backend users. This way, the hook code is getting cleaner and easier to read, and also easier to debug. Resolves: #84039 Releases: master Change-Id: Ia69d66ce25af48b86104ff724f2a3e877aa3a813 Reviewed-on: https://review.typo3.org/55888 Tested-by:
-
- Feb 25, 2018
-
-
Guido Schmechel authored
Releases: master, 8.7, 7.6 Resolves: #84028 Change-Id: Ia6094c57c976ecf6e89b1d99aca0a1b12684e0b2 Reviewed-on: https://review.typo3.org/55881 Tested-by:
-
Benni Mack authored
Instead of using the public "workspacePreview" parameter in TSFE, which is only set when a sys_preview keyword is used, the parameter from the BE User can be used instead directly (which is used anyways when using the API methods TSFE->whichWorkspace()). The TSFE method doWorkspacePreview() is adapted accordingly to be in line with the rest of the code. Resolves: #84038 Releases: master Change-Id: Ic819e099abf36bda867bb2235d6aa23fbbfe19a4 Reviewed-on: https://review.typo3.org/55895 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Benjamin Franzke authored
Since changeset I3020aa7a9cffd92d4b96afd4d4044979a771db5b the viewpage module is a native PSR-7 controller, therefore GeneralUtility _GP() and getIndpEnv() should no longer be used. Restructure the code to use strict typing (to prevent type casting all over the code), unify naming ($pageId and $languageId), and to prevent calculating $targetUrl twice. Releases: master Resolves: #84015 Related: #83987 Change-Id: I4f2821824a6f811f4eebda7ebdaf09febab5eecc Reviewed-on: https://review.typo3.org/55867 Tested-by:
-
Benni Mack authored
If a workspace is being previewed, the check does not have a kasper'sche boolean value (0,1,2) anymore, as the detection of a workspace is handled via a separate method $this->doWorkspacePreview() anyways. Resolves: #84035 Releases: master Change-Id: Ia169df138ef827ead6bee6d88a78d1543a977941 Reviewed-on: https://review.typo3.org/55887 Tested-by:
-
Benni Mack authored
Due to refactorings in various places, a simple copy/paste mistake was done when showing the preview text of a workspace. Due to the bug, previewing a workspace only showed "PREVIEW", instead of "Preview of Workspace XYZ" and the logout button. Resolves: #84030 Related: #38735 Related: #83158 Releases: master, 8.7 Change-Id: Id4dacd7e5608d75ad52216729011a5234f57fb7a Reviewed-on: https://review.typo3.org/55883 Reviewed-by:
-
- Feb 24, 2018
-
-
Benni Mack authored
The GET parameter "ADMCMD_noBeUser" is handed over to the frontend when a workspace preview is shown, in comparison to a live version. In order to render the "live version", the GET parameter "ADMCMD_noBeUser" is set, and resets BE User permisisons and preview infos. This can be simplified in the PreviewHook to ensure that the live version without a Backend User is used. Resolves: #84032 Releases: master Change-Id: Iee85717dc8f125ae91e1f046b273b7adf895c576 Reviewed-on: https://review.typo3.org/55886 Tested-by:
-
Benni Mack authored
The special workspace preview is now shown again, before it was only shown when a workspace preview was active. Resolves: #84031 Related: #84026 Releases: master Change-Id: I643632ab9c9e2cb1b7c26b2c3203cfec49e5d040 Reviewed-on: https://review.typo3.org/55885 Reviewed-by:
-
Benni Mack authored
The default draft workspace was deprecated with TYPO3 4.4, and removed with TYPO3 4.6, but some parts were still left in TYPO3 Core, and can simply removed now. Default draft workspace was always marked as "-1", where as "0" was the live workspace, and everything greater zero is a regular workspace we use throughout the TYPO3 Core. See https://typo3.org/news/article/bringing-workspaces-up-to-speed/ for more information about the deprecation. Resolves: #84026 Releases: master Change-Id: Ic85425425c4a091bc058091cd483351d84b4d912 Reviewed-on: https://review.typo3.org/55880 Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
Paweł Rogowicz authored
- added trigger for page tree when is visible - changed order of checking page tree height, added this before load nodes - added condition for update height when page is resizing - now it works when page tree is visible Releases: master Resolves: #83320 Change-Id: I1e789b9631282f4463263712e2118c8dea52ccdc Reviewed-on: https://review.typo3.org/55878 Tested-by:
Sybille Peters <sypets@gmx.de> Reviewed-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
Michael Oehlhof <typo3@oehlhof.de> Tested-by:
-
- Feb 23, 2018
-
-
Frank Naegler authored
In the scheduler edit task view, a FontAwesome icon for the date picker was used. This patch uses the IconViewHelper to use the same icon as everywhere in the backend. Resolves: #84024 Releases: master, 8.7 Change-Id: Ie1e8846ba8e3fc2eee4134cd2d97b43345b3c0e6 Reviewed-on: https://review.typo3.org/55875 Reviewed-by:
-
Michael Oehlhof authored
Resolves: #69187 Releases: master Change-Id: I880f476c1df8cc4c92eec099eaa6f5439b5cc359 Reviewed-on: https://review.typo3.org/55234 Tested-by:
-
Reiner Teubner authored
Since https://review.typo3.org/c/51242/ all hidden FormEngine fields work with ISO dates but the QueryGenerator can only handle unix timestamp. This patch fix the query building process for timestamp record fields. Resolves: #83675 Releases: master, 8.7 Change-Id: I79227762c4159984612d86dea640bdfd8b3a2784 Reviewed-on: https://review.typo3.org/55533 Reviewed-by:
Sascha Rademacher <sascha.rademacher+typo3@gmail.com> Reviewed-by:
-
Thomas Deuling authored
Add data attributes in backend toolbar and backend menu components, to have general identifier for binding guided tours popover and more features that can be based on this. Resolves: #80500 Releases: master, 8.7 Change-Id: I2add8b8c28ecd37967b7b23f71392aa71f209da5 Reviewed-on: https://review.typo3.org/52197 Tested-by:
-
steffenk authored
The following TSConfig setting hides columns restricted via mod.SHARED.colPos_list: mod.web_layout.hideRestrictedCols = 1 Resolves: #83460 Releases: master Change-Id: I0ccaa027d9a37530e6362675bf29679edc1d2a3d Reviewed-on: https://review.typo3.org/55259 Tested-by:
-
Benjamin Franzke authored
This is a followup for Icc8a3482edaef1ea329e68638d5ef467548062fc which missed to remove the TYPO3_CONF_VARS repopulation from the installer controller. Now that ExtensionConfiguration::set() updates changed properties, the manual repopulation after calling synchronizeExtConfTemplateWithLocalConfigurationOfAllExtensions() is not needed anymore and should be removed for the same reasons as described in the mentioned change. Change-Id: I3ff24411d2f0807a09c49d19bc021e9a239e6cb0 Releases: master Resolves: #83954 Related: #83958 Reviewed-on: https://review.typo3.org/55778 Tested-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
-
