Skip to content
Snippets Groups Projects
  1. Jun 11, 2024
  2. Jun 10, 2024
    • Oliver Bartsch's avatar
      [BUGFIX] Omit wrong value on inserting record · a3e39c1a
      Oliver Bartsch authored
      When inserting a record via the element
      browser, the value argument needs either
      to be formatted manually or left empty,
      allowing the element browser to format
      the identifier automatically.
      
      By omitting the value in the `PageBrowser`
      module, the value is now correctly formatted
      by the element browser to "pages_<uid>".
      
      This makes the "node-action" usable for
      TCA group fields, which allow more than
      one record type.
      
      The same logic is also used by the
      `BrowseDatabase` module, which also
      omits the value argument.
      
      Resolves: #103700
      Releases: main, 12.4
      Change-Id: I80e2cc696d85b5ec83432c35a263b19f9752b0ef
      Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84553
      
      
      Reviewed-by: default avatarOliver Bartsch <bo@cedev.de>
      Tested-by: default avatarcore-ci <typo3@b13.com>
      Tested-by: default avatarOliver Bartsch <bo@cedev.de>
      a3e39c1a
    • Stefan Bürk's avatar
      [TASK] Mitigate PHPUnit `NameAlreadyInUseException` · 6b067a2d
      Stefan Bürk authored
      PHPUnit changed the way how double creation is handled
      internally and now emits an exception if a manually defined
      `mock class name` should be registered. In some places
      within the unit tests, manual mock class names have been
      used, because the names are needed for cross referencing
      at a later point. For this, different approaches have
      been used, for example hardcoded MD5 hashes as strings
      or creating hashes of static values like `md5('1')`,
      and also reused hashes in different places or in
      tests using data providers. This now leads to an
      exception:
      
          PHPUnit\Framework\MockObject\Generator\NameAlreadyInUseException
      
          The name "b70551b2b2db62b6b15a9bbfcbd50614" is already in use
      
      This change mitigates the issue by using
      `StringUtility::getUniqueId('somePrefix')` as is already done
      in other places.
      
      As a sideeffect, four phpstan baseline entries can be removed.
      
      Used command(s):
      
        Build/Scripts/runTests.sh -s phpstanGenerateBaseline
      
      [1] https://github.com/sebastianbergmann/phpunit/pull/5804
      
      Resolves: #104005
      Releases: main, 12.4
      Change-Id: Icc558844275c9ae9f67a0e7c20daa318f5ad6b41
      Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84531
      
      
      Tested-by: default avatarcore-ci <typo3@b13.com>
      Reviewed-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
      Tested-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
      6b067a2d
  3. Jun 06, 2024
  4. Jun 04, 2024
    • Andreas Kienast's avatar
      [BUGFIX] IRRE: Rewrite stylesheet loading sequence · d41fc91e
      Andreas Kienast authored
      The stylesheet loading process in IRRE was kept for several years and
      moved from version to version. A recent change in #103375 migrated a
      usage of `delete` to `.splice()`, breaking stylesheet loading as the
      original iterated object was modified.
      
      Since the code was quite dated and had other potental bugs, the whole
      loading sequence has been transformed to functional programming style
      to reduce complicated, potentially error-prone, array operations.
      
      Resolves: #103971
      Related: #103375
      Releases: main, 12.4
      Change-Id: I18caafc68ceebce53723b7208270043faafc7458
      Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84488
      
      
      Tested-by: default avatarcore-ci <typo3@b13.com>
      Tested-by: default avatarBenjamin Franzke <ben@bnf.dev>
      Reviewed-by: default avatarBenjamin Franzke <ben@bnf.dev>
      d41fc91e
    • Anja Leichsenring's avatar
      [TASK] Reduce GU::makeInstance calls in Unit Tests · f6fda307
      Anja Leichsenring authored
      Additional potential functionality (DI, XClass resolving, etc.) of
      GU::makeInstance is usually not a wanted behaviour in unit tests.
      For creation of system under test `new` should be used.
      Dependencies, if necessary, should be mocks.
      This patch reduces the obvious cases, more complicated ones will
      be tackled with follow ups.
      
      Resolves: #103902
      Releases: main, 12.4
      Change-Id: I07cbe6f10fe11e1239cdd5f0fe7496948eed5a44
      Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84485
      
      
      Reviewed-by: default avatarBenjamin Franzke <ben@bnf.dev>
      Tested-by: default avatarBenjamin Franzke <ben@bnf.dev>
      Tested-by: default avatarcore-ci <typo3@b13.com>
      f6fda307
    • Andreas Kienast's avatar
      [TASK] Update ckeditor to 41.4 · 5a775b87
      Andreas Kienast authored
      This commit updates ckeditor to 41.4. See changelog at [1].
      
      Executed commands:
      
          # Override ckeditor5 package to avoid pulling in all/too
          # many available packages. See:
          # https://github.com/ckeditor/ckeditor5/issues/16360
          npm --prefix overrides/ckeditor5 version 41.4.2
          npm install --save ./overrides/ckeditor5
      
          npm install --save \
              @ckeditor/ckeditor5-alignment@^41.4.2 \
              @ckeditor/ckeditor5-autoformat@^41.4.2 \
              @ckeditor/ckeditor5-basic-styles@^41.4.2 \
              @ckeditor/ckeditor5-block-quote@^41.4.2 \
              @ckeditor/ckeditor5-clipboard@^41.4.2 \
              @ckeditor/ckeditor5-code-block@^41.4.2 \
              @ckeditor/ckeditor5-core@^41.4.2 \
              @ckeditor/ckeditor5-editor-classic@^41.4.2 \
              @ckeditor/ckeditor5-engine@^41.4.2 \
              @ckeditor/ckeditor5-essentials@^41.4.2 \
              @ckeditor/ckeditor5-find-and-replace@^41.4.2 \
              @ckeditor/ckeditor5-font@^41.4.2 \
              @ckeditor/ckeditor5-heading@^41.4.2 \
              @ckeditor/ckeditor5-horizontal-line@^41.4.2 \
              @ckeditor/ckeditor5-html-support@^41.4.2 \
              @ckeditor/ckeditor5-indent@^41.4.2 \
              @ckeditor/ckeditor5-link@^41.4.2 \
              @ckeditor/ckeditor5-list@^41.4.2 \
              @ckeditor/ckeditor5-paragraph@^41.4.2 \
              @ckeditor/ckeditor5-paste-from-office@^41.4.2 \
              @ckeditor/ckeditor5-remove-format@^41.4.2 \
              @ckeditor/ckeditor5-select-all@41.4.2 \
              @ckeditor/ckeditor5-show-blocks@^41.4.2 \
              @ckeditor/ckeditor5-source-editing@^41.4.2 \
              @ckeditor/ckeditor5-special-characters@^41.4.2 \
              @ckeditor/ckeditor5-style@^41.4.2 \
              @ckeditor/ckeditor5-table@^41.4.2 \
              @ckeditor/ckeditor5-theme-lark@^41.4.2 \
              @ckeditor/ckeditor5-ui@^41.4.2 \
              @ckeditor/ckeditor5-undo@^41.4.2 \
              @ckeditor/ckeditor5-upload@^41.4.2 \
              @ckeditor/ckeditor5-utils@^41.4.2 \
              @ckeditor/ckeditor5-watchdog@^41.4.2 \
              @ckeditor/ckeditor5-word-count@^41.4.2
          npm install --save-dev \
              @ckeditor/ckeditor5-dev-utils@^40.0.0
          npm run build
      
      [1] https://github.com/ckeditor/ckeditor5/releases/tag/v41.4.2
      
      Resolves: #103840
      Releases: main, 12.4
      Change-Id: I46dc33ab8e8cfcc75aa13bfe50d8850fb704f75e
      Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84484
      
      
      Reviewed-by: default avatarAndreas Kienast <a.fernandez@scripting-base.de>
      Tested-by: default avatarcore-ci <typo3@b13.com>
      Tested-by: default avatarAndreas Kienast <a.fernandez@scripting-base.de>
      5a775b87
  5. Jun 03, 2024
  6. Jun 01, 2024
  7. May 26, 2024
  8. May 22, 2024
  9. May 21, 2024
  10. May 17, 2024
  11. May 14, 2024
  12. May 13, 2024
  13. May 10, 2024
  14. May 03, 2024
  15. May 02, 2024
  16. Apr 30, 2024
  17. Apr 29, 2024
  18. Apr 28, 2024
  19. Apr 26, 2024
  20. Apr 25, 2024
  21. Apr 24, 2024
    • Andreas Kienast's avatar
      [TASK] Remove usage of "newer" in grunt build · 4506905b
      Andreas Kienast authored
      The grunt module `grunt-newer` was introduced with #90200 to help
      improving build times on consecutive single builds by running tasks on
      changed files only.
      
      This is nowadays not required anymore in JS build context, as it's
      possible in TypeScript to compile changed files only, which is already
      incorporated for quite a while. Therefore, the usage of `newer` is now
      removed in this context. However, to avoid running `terser` multiple
      times on the same, previously compiled files, the directory
      `Build/JavaScript` now gets removed before each TypeScript compilation.
      
      The postcss calculation is fast enough to not require grunt-newer at
      all, therefore grunt-newer is dropped here as well.
      
      Executed commands:
      
          npm remove grunt-newer
      
      Resolves: #103712
      Releases: main, 12.4
      Change-Id: I1c6b88945a45cb9a394a2beaa2ec8198865880b0
      Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83980
      
      
      Tested-by: default avatarcore-ci <typo3@b13.com>
      Reviewed-by: default avatarAndreas Kienast <a.fernandez@scripting-base.de>
      Tested-by: default avatarAndreas Kienast <a.fernandez@scripting-base.de>
      4506905b
  22. Apr 23, 2024
  23. Apr 22, 2024