- Oct 29, 2022
-
-
Nikita Hovratov authored
Resolves: #98724 Resolves: #98728 Releases: main Change-Id: Id046c240ae4e9d3017dc4b8503e23fd8a6a9b4b8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76258 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Torben Hansen authored
Resolves: #98904 Releases: main Change-Id: I659bad4926656c2d5e3ed3120a13ef8b14a720c9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76330 Reviewed-by:
-
Wouter Wolters authored
composer req --dev phpstan/phpstan-phpunit:^1.2.2 Resolves: #98943 Releases: main, 11.5 Change-Id: Iee2f421546a7be58ada993aa5c331bb914500aad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76318 Reviewed-by:
-
Nikita Hovratov authored
Resolves: #98729 Resolves: #98876 Releases: main Change-Id: I7184afd240dc9d3ebd0dbd92f4b106f2909370b1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76324 Tested-by:
-
Benni Mack authored
This change allows to use the LinkResult object for custom HMENU generation moving HMENU to be more consistent like typolink() has been aligned in TYPO3 v12 as well. The related code pieces are rather internal and hardly relevant to userland code outside of TYPO3 Core. Resolves: #98464 Releases: main Change-Id: I886db8092b3c81cdf4d8d0fa06dde1b473cc1683 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75869 Tested-by:
-
Torben Hansen authored
Resolves: #98907 Releases: main Change-Id: I475b245a83a29e3993dfd47652dfbdb8c0527e0e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76327 Reviewed-by:
-
Torben Hansen authored
Resolves: #98902 Releases: main Change-Id: Icf72d1124c6abec85940d8ff511f6bdff62e9e06 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76328 Reviewed-by:
-
Torben Hansen authored
Resolves: #98903 Releases: main Change-Id: I1de1bb7df01d552b82dd13fea0d287cbe654342a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76329 Tested-by:
-
Torben Hansen authored
Resolves: #98908 Releases: main Change-Id: Ibf9f2f47ed9343d8b91052bf0e06601ccb96d60f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76326 Tested-by:
-
Stefan Bürk authored
With the patch resolving #98931 and #98734 the FileBackendTest has been migrated from unit to a functional test, and thus now operating on real filesystem. Used directory listing does not ensure proper sorting on all systems and used PHP versions, thus the used expectation may be vary depending on the system. This change tightens the test for all systems by ensuring a deterministic test setup, using correct file identifiers for mocked value returns. Adding missing parent tearDown() call is added as a side-change, to ensure full test stack and avoid eventually side-effects in the future. Resolves: #98955 Related: #98931 Related: #98734 Releases: main Change-Id: I668973ae45cf7a4ed07c73e72fd2b2a68dc881ca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76325 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- Oct 28, 2022
-
-
Tomas Norre Mikkelsen authored
This removes an obsolete configuration from the Indexed Search. It was earlier used to use the TYPO3 Crawler for indexing external files. As the TYPO3 Crawler isn't used anymore as a direct dependency of Indexed Search this can be removed. Resolves: #98945 Releases: main Change-Id: I5717e4fc6c081aeb023359ea8b76a3ecaa3b5100 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76320 Tested-by:
-
Torben Hansen authored
Resolves: #98899 Resolves: #98901 Releases: main Change-Id: Ifb188334c1445e3e8847bca476b6c5182bce829c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76323 Tested-by:
-
Torben Hansen authored
Resolves: #98737 Releases: main Change-Id: I12de96341eae97eafb2fa558e8da2f9cc2e40bb6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76322 Tested-by:
-
Andreas Fernandez authored
A new method `getByPrefix()` is added to the module `@typo3/backend/storage/abstract-client-storage`, affecting its implementations * `@typo3/backend/storage/browser-session` * `@typo3/backend/storage/client` A developer is now able to obtain multiple items prefixed by a given key either from `localStorage` or `sessionStorage`. Resolves: #98921 Releases: main Change-Id: I343289cc6fa6fdd57c019a0cdd85eae2b5dbdb81 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76265 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Chris Müller authored
Resolves: #98946 Related: #96517 Releases: main Change-Id: Ibf44b8dad7a1cc79796a5791f194fc7792e9a355 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76321 Tested-by:
-
- Oct 27, 2022
-
-
Oliver Bartsch authored
With #94641 toolbar dropdown menus were made scrollable, since otherwise bookmarks were cut off at the bottom of the screen. With #98307 the corresponding "max-height" option was removed, leading to the same bug as before. This is now fixed by adding the option again. Resolves: #98940 Related: #98307 Related: #94641 Releases: main Change-Id: I1c2fd17f503189d3ed3466f6d80b451b01ff454d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76310 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Nikita Hovratov authored
Resolves: #98725 Releases: main Change-Id: Ia0cac4637e14e7fbe46fa4216022b6e9bcf3406a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76313 Reviewed-by:
-
Torben Hansen authored
Resolves: #98900 Releases: main Change-Id: Ie6f7d98ee293dcc2153a6af191892a7e12c1ea9e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76317 Reviewed-by:
-
Torben Hansen authored
Resolves: #98893 Releases: main Change-Id: Idcf53113f2f4acafe11cd953d9d9dd89f3b3dccb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76316 Reviewed-by:
-
Nikita Hovratov authored
Resolves: #98726 Releases: main Change-Id: I80f4e40c32193aaffd2c99cdbb307018103e971d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76314 Tested-by:
-
Torben Hansen authored
Resolves: #98890 Releases: main Change-Id: If64893018e062ffb1fe83d3b8f68de3d5f2b2289 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76315 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Anja Leichsenring authored
TYPO3 Core Tests no longer use the vfsStream dependency, so it is removed. Resolves: #98939 Related: #97762 Releases: main Change-Id: I19466200b5dd6c1cfcb035b4ebefb6ac08254c4b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76308 Reviewed-by:
-
Christian Kuhn authored
* Make some unit tests functional test * Remove some state * Avoid last usages of vfsStream > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Change-Id: I3c0e4a1bc10aae042c5b850e817e8211918a0458 Resolves: #98740 Related: #97762 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76309 Tested-by:
-
Torben Hansen authored
Resolves: #98888 Releases: main Change-Id: I54c4cb0bb406f9d6a0a6b8d56a330f89630c9ca4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76311 Reviewed-by:
-
Torben Hansen authored
Resolves: #98885 Releases: main Change-Id: Ia51c12a35892c7d9d9f8e332470d5986472f8c67 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76312 Tested-by:
-
Torben Hansen authored
Resolves: #98898 Releases: main Change-Id: I62c2915adb19bc8cc124cab51e4f99782053b4d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76304 Tested-by:
-
Torben Hansen authored
Resolves: #98894 Releases: main Change-Id: I7c1d7cf3622f64666adcabbb3ebf30d7c6189d1b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76306 Reviewed-by:
-
Torben Hansen authored
Resolves: #98896 Releases: main Change-Id: I3c452a229b8a690d3954cfadfa439c9b3b7be30e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76307 Tested-by:
-
Torben Hansen authored
Resolves: #98895 Releases: main Change-Id: Ib1898a11fcb156d08d0f3fd9cfb738038d3d90ca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76305 Tested-by:
-
Benjamin Kott authored
The CKEditor 5 has very limited support for managing links. By default, you only get a simple input field for a string. To bring the known and loved easy-to-use LinkBrowser to CKEditor 5 we need to overwrite the existing linking capabilities. For developers and integrators, this overwrite should be invisible as it was before with the CKEditor 4 integration. Instead of teaching the users that they need to load custom modules to change the link behavior, we are already migrating this in the background for them. A typical developer can just follow the CKEditor 5 guide to configuring the editor to its needs and the Core is already doing the adjustments and replacements of modules for them. We currently overwrite the existing link and unlink commands, but we register the toolbar buttons with a prefix. This makes existing CKEditor configurations incompatible since the linking buttons are missing in the toolbar. To make migrations easier we adjust custom toolbar buttons to match the CKEditor 5 defaults and drop the custom names for the buttons. In addition, we are streamlining the behavior of removing plugins. Since we are already overwriting the "Link" plugin there is no need to remove it if no removePlugin config is passed in the first place. This allows us to better test the behavior and reduces the cases we need to cover in the first place. Resolves: #98925 Releases: main Change-Id: I3d6d158f5ab1b21e73f86471344107a07d71b03e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76267 Tested-by:
-
Wouter Wolters authored
> composer req --dev friendsofphp/php-cs-fixer:^3.12.0 > Build/Scripts/runTests.sh -s cgl -p 8.1 Resolves: #98938 Releases: main, 11.5 Change-Id: I42b247fa4ea51ef20e29fef855c12af1b756d558 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76301 Tested-by:
-
- Oct 26, 2022
-
-
Oliver Klee authored
Resolves: #98937 Related: #98936 Releases: main Change-Id: I55ed2c9546312c8bc9b99ffae2b8d3c8a38b5117 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76300 Tested-by:
-
Christian Kuhn authored
To finally tame the FAL related unit tests, the resource related BaseTestCase is dissolved and merged into consuming classes as first step. This simplifies the construct and allows further refactorings. Resolves: #98936 Releases: main Change-Id: Id8da6b47a5d16d7eb38bfecf91d41d9365d4df7d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76299 Tested-by:
-
Christian Kuhn authored
The vfsStream setup is not used in the tests. Resolves: #98935 Related: #97762 Releases: main Change-Id: I87ec61c1e5aac2bf82e2463e57bc36a81bb211d5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76298 Tested-by:
-
Christian Kuhn authored
We can avoid vfs usages in GeneralUtility tests by creating fixture files and testing these directly. A detail test for mtime is skipped since this is rather obvious in the test subject. Resolves: #98934 Related: #97762 Releases: main Change-Id: I7aecdd2f5dddaf493865f1588b72a30466316541 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76297 Tested-by:
-
Christian Kuhn authored
Testing 'non-writable' directories is flaky in real life since it depends on the user that executes these tests. On gitlab CI, it is useless a-priori, since gitlab runs as root in containers. Establishing a vfs for this does not help us much, especially when it just tests if some exception is thrown, which is done obviously when reading code. This vfsStream usage is simply not worth the dependency. Resolves: #98932 Related: #97762 Releases: main Change-Id: Ifd813d47607e3760e2e617b93a56a59773bc4e62 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76296 Tested-by:
-
Christian Kuhn authored
Moving cache framework related FileBackendTest unit tests to functional tests needs less mocks and avoids vfsStream. > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #98931 Resolves: #98734 Releases: main Change-Id: I0090ae0c0984add6584f3858df35fed5df91ab91 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76295 Tested-by:
-
Christian Kuhn authored
Acceptance test cookie output is less noisy due to a new feature in codeception/module-webdriver 3.2.0 and styleguide avoids deprecated core method calls. > composer req --dev codeception/module-webdriver:^3.2.0 > composer u typo3/testing-framework > composer u typo3/cms-styleguide Change-Id: I02af65e21fc13111302762aa937c95546a4c07c6 Resolves: #98928 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76292 Tested-by:
-
Christian Kuhn authored
This property name is too generic as weak match and throws too many false positives. Resolves: #98926 Release: main, 11.5 Change-Id: I0d39287180bb4d53071efe30d42145a313a98ec8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76270 Reviewed-by:
-
Christian Kuhn authored
There is little reason to fake filesystems details within functional tests that use an isolated instance. Resolves: #98923 Related: #97762 Releases: main Change-Id: I83579eab82655c4cd464050e4fbcd7608ba0062e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76268 Tested-by:
-
