- Sep 01, 2023
-
-
Friedemann Altrock authored
Before this fix, only the first RTE processing configuration would be taken into account when deciding which tags to keep in an HTML snippet. RteHtmlParser is a DI service and as such is treated as a singleton. Using multiple RTE processing configurations with potentially different sets of allowed tags should work as expected. Resolves: #101190 Releases: main, 12.4, 11.5 Change-Id: Ib0227872b542f53b30a16494aa2f979b8f601e07 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80832 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
- Aug 31, 2023
-
-
Stefan Bürk authored
FormEngine sends some information as payload with the suggest wizard ajax request to the `SuggestWizardController` as context. The controller loads the record based on the tableName and the uid to determine the recordType to read the correct TCA field configuration, respecting special overrides like `columnsOverrides`. If a new record is created, there is no record uid available and passed to the controller. Therefore, the recordType is not properly determined. That leads to wrong record suggestions, if for example the `allowed` record table is overriden for specific recordTypes. This change adds the recordTypeValue as additional html data attribute to the suggest search field, reads and sends it along with the context payload in the ajax request to the suggest wizard controller, which now uses the passed value while keeping the record retrievement as fallback for now. Suggest records are now directly searched correctly respecting the full TCA configuration for the type, even for new records. Additionally, uid is send as null instead of the string "NaN". Used command(s): > Build/Scripts/runTests.sh -s buildJavascript Resolves: #101796 Releases: main, 12.4, 11.5 Change-Id: I3b814d37b7d4d3e9674ad6f2af882520c4f91413 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80773 Tested-by:
-
Christian Kuhn authored
To be an example of best practice, this patch changes all usages of "<INCLUDE_TYPOSCRIPT ..." to "@import". Tests are adapted as well, as long as they are not tailored to actually test INCLUDE_TYPOSCRIPT syntax. Resolves: #101813 Related: #97816 Releases: main, 12.4 Change-Id: I01c4eb19dfd0106c5577457cd0e1836865112d6a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80797 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Achim Fritz authored
BackendUtility has a couple of strtotime() calls that may end up as strtotime(null). This emits a PHP E_DEPRECATED error since PHP 8.1. Add a cast. Resolves: #101811 Resolves: #101805 Releases: main, 12.4, 11.5 Change-Id: I5cca1b2fd3bc0d6792f6d61a59bdbc5b4850d15d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80771 Reviewed-by:
-
Oliver Hader authored
Resolves: #101808 Releases: main, 12.4 Change-Id: Iab938e0608a5547838d8b0cbc40c795e7653f929 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80795 Tested-by:
-
Andreas Fernandez authored
When TYPO3 is installed via CLI, the setup command now asks for the webserver being used to be able to copy necessary webserver files, e.g. `.htaccess` for Apache or `web.config` for IIS. Resolves: #100719 Releases: main, 12.4 Change-Id: Ibb97c4cf92b29ceeda85ae848ceeae16afb73359 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80772 Tested-by:
-
- Aug 30, 2023
-
-
Christian Kuhn authored
We can reduce class state by explicitely handing over runtime state to consuming methods in favor of parking them on $this. Resolves: #101804 Releases: main, 12.4 Change-Id: Ic33d619a189625fa9407a3ee36cddf76d0f14d32 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80691 Tested-by:
-
Christian Kuhn authored
Changing stages using the various buttons in workspace preview module fatals server side since the request is incomplete. This is mainly due to the weird ajax dispatching from class AjaxDispatcher to ActionHandler: This area needs a major overhaul. However, patch for issue #100577 already introduced a hack to hand the current request down. The patch re-uses this to fix the issue. Resolves: #101802 Related: #101781 Related: #96904 Related: #100577 Releases: main, 12.4 Change-Id: Ifacf653ed0409891469a168c7bc0c38eaacf183f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80690 Tested-by:
-
Benjamin Serfhos authored
See: https://github.com/ckeditor/ckeditor5/issues/14200#issuecomment-1625171318 This allows similar behaviour as CKEditor 4 with applying styles to block components as DocumentList is preferred over List. Resolves: #100348 Releases: main, 12.4 Change-Id: I155889e37ca1e63b27aed0d01dad2154da5bd37e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80689 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Oliver Hader authored
DataMapProcessor tries to access `$possibleChainedIds[0]` which might not be defined, since that array is the result of a previous `array_intersect` invokation, which keeps the array keys of the original input array. DataHandler tries to access `$this->copyMappingArray[$table][$uid]`, which might not be defined in case the previous copy command could not be executed (e.g. since the record was deleted already). Resolves: #101748 Releases: main, 12.4, 11.5 Change-Id: Ibcbc412c7df62ce17dfa2c0f6fc120ccebb953d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80670 Tested-by:
-
Robert Kärner authored
This patch fixes two issues when generating symlinks to the public extension resources (Public/Resources) into the _assets folder during Composer installation. First, directory symlinks can't be created the same way on Windows as on Unix platforms. The creation requires elevated rights, and the required command is named differently as well. Junctions should be used on Windows instead, because they do not need elevated privileges to be created. When installing a TYPO3 extension via Composer, its Resources/Public folder is getting symlinked to the publicly accessible _assets folder. Until now, this process only used the Unix specific functions provided by Composer. It did not create any symlinks on Windows based installations, without generating any error message. This patch adds the same checks and platform-specific functions used by Composer when symlinking packages from a local path repository. The second issue that has been addressed is the naming of the symlinks themselves. When a Resources/Public directory is symlinked into the _assets folder, the symlink will be named using an md5 hash based on parts of the extension's installation path on the filesystem. During Composer installation, this relative path is derived from the absolute path provided by Composer. As Windows uses a different default path separator (backslash) compared to Unix (forward slash), the relative path will be different between both platforms, resulting in a different md5 hash being generated. Absolute path on Unix: /path/to/typo3/vendor/mycompany/myext Absolute path on Windows: C:\path\to\typo3\vendor/mycompany/myext Relative path to be used for the hash on Unix: /vendor/mycompany/myext Relative path to be used for the hash on Windows: \vendor/mycompany/myext If an uri into the _assets folder is to be generated in either frontend or backend, the md5 hash will be always be generated by using forward slashes, resulting in incorrect links on Windows installations. This difference has been solved by replacing all backslashes in the absolute extension installation path into forward slashes on Windows installations, so the symlink will be named correctly from the beginning. Resolves: #98434 Resolves: #98447 Releases: main, 12.4, 11.5 Change-Id: I221eb538312302a7af4f7c3010c9982922f1c6ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80688 Tested-by:
-
- Aug 29, 2023
-
-
Benjamin Franzke authored
@lezer/common – in contrast to other @lezer modules, is placed in dist/index.js instead of dist/index.es.js. Therefore we add a distinct copy rule. The sortablejs npm package recently changed to provide both, a UMD bundle and a native ESM module. As we actually failed to update the UMD bundle (due to a rename of the build output filename in sortablejs), we switch to the new ESM variant right away. muuri failed to update because dashboardToEs6 was missing in the npmcopy concurrent target. Resolves: #101784 Resolves: #101785 Resolves: #101787 Related: #101783 Releases: main, 12.4 Change-Id: I2ccf69847876edb55f089a4a5142ac388699fb54 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80687 Tested-by:
-
Benjamin Franzke authored
IDEs like PhpSstorm complain about the same thing, so better we have that defined and checked via CI. Commands executed: node_modules/.bin/eslint --fix Sources/TypeScript/ Resolves: #101780 Releases: main, 12.4 Change-Id: I01e0289b671dfd4348319bca90dddaec085fbfe4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80747 Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
Benjamin Franzke authored
This helps to prevent hard-to-discover build failures, that only happen on clean installs (e.g. CI). This is because TypeScript will by default scan the entire source dictionary (Build/ in our case) for possible includes. We previously excluded /Build/composer in #95046, but it is actually much better to explicitly include the actually used source paths to also exclude build output (Build/JavaScript/) from being reinterpreted by subsequential eslint or tsc compile runs. Note that we also refactor the types/ directory in order to be a folder that conforms to the @types/* packages conventions, by being actually usable in the compilerOptions.types property. Note that our custom global type definitions (types/) were previously implicitly loaded as globally available sourcepaths. With the new `include` option we could add them back, but then we wouldn't notice if we do not add proper index.d.ts files (like we did until now). Therefore index.d.ts files...
-
Benjamin Franzke authored
This allows to drop a npm patch that had been applied to the TypeScript @types/jquery before, in order to achieve the same effect. With eslint we can additionally provide a good hint for the developer, what to use instead. For the v12 backport @types/jqueryui is removed additionally, as it conflicts with the bootstrap jquery definitions and was unused. This showed a small adaption that needed to be changed in upgrade-docs, which has already been fixed in main and is reapplied in here. Commands executed: npm remove patch-package npm install npm remove @types/jqueryui Resolves: #101697 Releases: main, 12.4 Change-Id: I77e15a4b4c2a18f8b72ec2a5f41c7e54a7966c30 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80686 Tested-by:
-
Benjamin Franzke authored
Remove unused files that have been forgotten to be removed when there respective TypeScript source files where removed. Resolves: #101786 Related: #101783 Releases: main, 12.4 Change-Id: I75a74996e9dc1f9f30fd3b2f08914e25452df06f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80685 Reviewed-by:
-
Andreas Fernandez authored
The Install Tool router attempts to build URLs manually by wild string replacements and manipulation, which is rather error-prone. This patch changes the approach to use the URL API instead. Resolves: #101789 Releases: main, 12.4 Change-Id: I07ee73764b4fc5167f732d67faf2843fef0db199 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80745 Tested-by:
-
Benjamin Franzke authored
…of a new form element, that has not yet been persisted. Tabbing through an elemenet is considered an "input" by the browser, which is why the "input" even is triggered. The result is an empty input element (as before), but an intent is made to delete the underlying property from the form element object model. When the object model is empty (remeber, it is a new element), and an input field refers to a nested property (e.g. properties.fluidAdditionalAttributes.placeholder) removing an element (e.g. 'placeholder') will fail when the parent has not yet been set (e.g. properties.fluidAdditionalAttributes) Resolves: #101750 Releases: main, 12.4, 11.5 Change-Id: I49a9ead343e671c3d0289bd6d969316b888d05eb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80729 Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
- Aug 28, 2023
-
-
Christian Kuhn authored
The extbase ConfigurationManager is (unfortunately) a stateful singleton that we can not get rid of without a bigger rewrite. While stateful singletons are bad enough, the extbase LocalizationUtility makes this worse by parking an instance of ConfigurationManager in a static property, re-using it as a "cached" singleton. LocalizationUtility does this since it in itself is static, which makes this service just so convenient to use. When it comes to sub requests and similar, static state is doomed and we need to get rid of it, we've had a couple of patches in v12 dealing with similar things. Mid-term, extbase LocalizationUtility needs to vanish anyways, but in the meantime, we have to get rid of static state that kills sub request scope. The patch removes the static $configurationManager property and adapts functional tests that already showed the current solution was a hack. There are various upper and lower cache layers that ensure removing this "cache layer" won't make things more expensive in practice, which allows us to remove this static state without further fallback. In main, this needs a TF update: > composer u typo3/testing-framework In 12.4, this need a TF raise: > composer req --dev typo3/testing-framework:^8.0.3 Resolves: #101779 Releases: main, 12.4 Change-Id: Ie5db07b0475f612a996d369ab3417672b33fbb2d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80737 Reviewed-by:
-
Andreas Fernandez authored
Previously, the `keyup` event was intercepted in "Extension Configuration", which doesn't work with `clearable()`. This patch changes the code to listen to `input` and `change` events instead. Resolves: #101772 Releases: 12.4 Change-Id: I1e90ede6ab1693fd76dcb6aafb1dab0a616b5784 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80714 Reviewed-by:
-
Torben Hansen authored
With #90002, all occurrences of the `list()` function have been migrated to the short list syntax. Our php-cs-fixer configuration does however not check the short list syntax usage, so we have one usage of `list()` in our codebase again. This change extends the php-cs-fixer configuration to ensure, that only the short list syntax is used. The new ruleset has been applied to the codebase and one usage of the `list()` function has been migrated. Resolves: #101777 Related: #90002 Releases: main, 12.4 Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: I30f5822e27a36515c2c77a19089a0754ff6fdcfd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80684 Tested-by:
-
Benjamin Franzke authored
Resolves: #101738 Related: #82577 Releases: main, 12.4 Change-Id: Id857430ae81322cf9197ba6df422780695f59f50 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80728 Tested-by:
-
Benjamin Franzke authored
Resolves: #101737 Related: #82577 Releases: main, 12.4 Change-Id: Ibc8ed8be6a8defc7dba4910e3f1df937809600aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80727 Tested-by:
-
Benjamin Franzke authored
Resolves: #101736 Related: #82577 Releases: main, 12.4 Change-Id: If77dc697ac23b5f1fb3f36dd15fe36cfb369700d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80726 Tested-by:
-
Benjamin Franzke authored
Resolves: #101735 Related: #82577 Releases: main, 12.4 Change-Id: I5584528f69fddba7a5f7f4b3592ca4bf9e83938c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80725 Tested-by:
-
Benjamin Franzke authored
Resolves: #101734 Related: #82577 Releases: main, 12.4 Change-Id: I0619297a3fbf3e2fd18b1aef1a0c82794a5ca714 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80724 Tested-by:
-
Benjamin Franzke authored
Resolves: #101733 Related: #82577 Releases: main, 12.4 Change-Id: I4d9f92287d9a2b69fa4421de2377f7bf9806147c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80723 Reviewed-by:
-
Benjamin Franzke authored
Resolves: #101717 Related: #82577 Releases: main, 12.4 Change-Id: I9e0a42954b387d34ded5ebd1bde533b9feb4e70e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80722 Tested-by:
-
Benjamin Franzke authored
Resolves: #101713 Related: #82577 Releases: main, 12.4 Change-Id: Ic7b41b79552a4c14d7395609e0ac3dda9c47b20f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80721 Tested-by:
-
Benjamin Franzke authored
Resolves: #101712 Related: #82577 Releases: main, 12.4 Change-Id: Id77b6cd93cff41c26220ca0b10b948813c1242be Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80720 Tested-by:
-
Benjamin Franzke authored
Resolves: #101702 Related: #82577 Releases: main, 12.4 Change-Id: I4ec165e645ee367d71404338e83ba6f40cb28494 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80719 Tested-by:
-
Benjamin Franzke authored
Resolves: #101634 Related: #82577 Releases: main, 12.4 Change-Id: Ia9ad4d39e925f671707ec62cd989bfca6dbf32ab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80718 Tested-by:
-
Christian Kuhn authored
Use the new v12 EXTBASEPLUGIN in TS setup to streamline frontend functional tests a bit. Resolves: #101773 Related: #100293 Releases: main, 12.4 Change-Id: I84e3cc93f617e3d8feeb76e6acf2c02bc4070a6d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80683 Tested-by:
-
Andreas Fernandez authored
When resetting the tag filter in "View Upgrade Documentation", the `hidden` class now gets removed, making previously filtered upgrade docs visible again. Resolves: #101771 Releases: main, 12.4 Change-Id: Ie8bc14cc20fed803ae9644308eeb7cf2daa15a09 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80715 Tested-by:
-
Achim Fritz authored
Resolves: #101754 Related: #100307 Releases: main, 12.4 Change-Id: I43c43f1635fd789e3f035e9840d37fb70528cb66 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80682 Reviewed-by:
-
Benjamin Kott authored
The `script` tag is defined to hold executable code or data and not template html markup. We are switching this to the `template` tag that is indended for this usecase. Resolves: #101769 Releases: main, 12.4 Change-Id: I0657e5cbce7e13770ce88918cb9e4137bf017590 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80681 Tested-by:
-
Benjamin Franzke authored
The ajax Icon API is currently not available during first install, therefore neither getIcon nor the icon web component may be used to render an icon. The icon markup is therefore now pre-rendered via fluid for both states and toggled via CSS. Resolves: #101765 Related: #98089 Releases: main, 12.4 Change-Id: Ib72c06e41f083e4dc7392845058fc86aae95af9c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80712 Reviewed-by:
-
Oliver Klee authored
This fixes an issue in the acceptance tests where `null` is passed to `GeneralUtility::xml2array()` (which expects a `string`). Having an early check for an empty string also avoids pointless XML parsing (which should help performance a bit). Resolves: #101757 Releases: main, 12.4, 11.5 Change-Id: Ifc4406536c273baca9acdda7a0af7a91594f57bf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80679 Tested-by:
-
Mathias Bolt Lesniak authored
The constructor of `\TYPO3\CMS\Core\Http\Request` now correctly accepts resources of the type "stream" as $body argument. Resolves: #101764 Related: #97620 Releases: main, 12.4 Change-Id: I2e7000c11ef4a16334f3305142ef8fb7fe6c639f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80710 Reviewed-by:
-
Oliver Klee authored
The new versions find some more possible problems, and also improve performance. > composer req --dev phpstan/phpstan:^1.10.32 > composer req --dev phpstan/phpstan-phpunit:^1.3.14 > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #101756 Releases: main, 12.4, 11.5 Change-Id: I23429a98b25ce340405b8b9dc384869526c6f920 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80707 Reviewed-by:
-
