Skip to content
Snippets Groups Projects
  1. Jul 11, 2013
  2. Jul 10, 2013
    • Francois Suter's avatar
      [BUGFIX] requestUpdate sensitive to spaces · b89d6f23
      Francois Suter authored
      The TCA property "requestUpdate" is sensitive to spaces, although this
      is documented nowhere. Indeed "foo1, foo2" will not work whereas
      "foo1,foo2" does. This patch strips spaces from the "requestUpdate"
      string before testing it.
      
      Resolves: #42789
      Releases: 6.2, 6.1, 6.0, 4.7, 4.5
      Change-Id: I340090e93e7b8645493f8db0c8c374cb1227f684
      Reviewed-on: https://review.typo3.org/22174
      Reviewed-by: Xavier Perseguers
      Tested-by: Xavier Perseguers
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      Reviewed-by: Francois Suter
      Tested-by: Francois Suter
      b89d6f23
    • Georg Ringer's avatar
      [TASK] Make uid,pid selectable by users in list view · 3940786f
      Georg Ringer authored
      There is no reason to hide those 2 fields in list view
      => extended view > fields and make them admin only
      
      Change-Id: I390e2b0ac974098edb53d7e36681d6f3df0124eb
      Resolves: #49810
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/22157
      Reviewed-by: Georg Ringer
      Tested-by: Georg Ringer
      3940786f
    • Wouter Wolters's avatar
      [TASK] Move language include to .xlf · 36b5914f
      Wouter Wolters authored
      Move all old language includes (php,xml) in the core to .xlf
      
      Change-Id: I804b5970a360cbfdc2940736632c55c535ccbd40
      Resolves: #49832
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/22167
      Reviewed-by: Markus Klein
      Reviewed-by: Georg Ringer
      Tested-by: Georg Ringer
      36b5914f
  3. Jul 09, 2013
    • Robert Vock's avatar
      [BUGFIX] Logging PHP errors to sys_log table does not work · 151b56f4
      Robert Vock authored
      Logging PHP errors stopped working after changeset
      3e309294 when the  DatabaseConnection
      class was changed.
      The changed line tries to determine, if a database connection is
      available and only writes the log entry if the connection was
      already established.
      
      Resolves: #49645
      Releases: 6.1, 6.2
      Change-Id: Idee413ed911a8c2d23f034ceadd17c955c98a337
      Reviewed-on: https://review.typo3.org/22166
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Jigal van Hemert
      Tested-by: Jigal van Hemert
      151b56f4
    • Ingo Renner's avatar
      [BUGFIX] Cannot load css_styled_content TS using INCLUDE_TYPOSCRIPT · 5adfc5f4
      Ingo Renner authored
      When installing extensions they may register plugins in ext_localconf.php.
      By doing so some default TypoScript is generated in
      Extensionutility::configurePlugin() that is then added using
      ExtensionManagementUtility::addTypoScript().
      
      Parts of the generated TypoScript are stored in
      $TYPO3_CONF_VARS['FE']['contentRenderingTemplates']* and are loaded later
      during TypoScript parsing after including the content rendering template.
      
      These TS parts are used to resolve which classes and methods to call when
      a plugin needs to be rendered on a page. You can find them in
      tt_content.list.20.*
      
      "content default" used to be the old content rendering template with uid
      43, today we use css_styled_content instead. The part in the TypoScript
      processing chain to load these generated snippets -
      TemplateService::includeStaticTypoScriptSources() - is only executed when
      loading the content rendering templates using the "Include static (from
      extensions)" field in template records.
      
      In return this means if you try to move as much TS to files as possible
      you will still have to include css_styled_content through the Template
      records in the backend. In other words when actually trying to include
      css_styled_content TS from a file, the generated snippets for
      tt_content.list.20.* will not be loaded and thus no plugin can be
      executed.
      
      Resolves: #49461
      Resolves: #44983
      Releases: 6.2, 6.1, 6.0
      Change-Id: I77c0d64759fa0b5b27cac0ae1acd55e9abefe7f8
      Reviewed-on: https://review.typo3.org/21679
      Reviewed-by: Markus Klein
      Reviewed-by: Marc Bastian Heinrichs
      Tested-by: Marc Bastian Heinrichs
      Reviewed-by: Ingo Renner
      Tested-by: Ingo Renner
      5adfc5f4
    • Francois Suter's avatar
      [BUGIFX] Missing update wizard for RTE file links · 6b4d7dc8
      Francois Suter authored
      File links made inside a RTE-enabled field are currently not
      migrated to FAL references. This patch adds such an update
      wizard.
      
      Resolves: #49233
      Releases: 6.1, 6.2
      Change-Id: I12b6d9da87b734c0a9d5f884d5067e3c9b08efc3
      Reviewed-on: https://review.typo3.org/22002
      Reviewed-by: Nico de Haen
      Tested-by: Nico de Haen
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Sebastian Michaelsen
      Tested-by: Sebastian Michaelsen
      Reviewed-by: Francois Suter
      Tested-by: Francois Suter
      6b4d7dc8
  4. Jul 08, 2013
    • Alexander Schnitzler's avatar
      [TASK] Replace inject methods with @inject · e83fa716
      Alexander Schnitzler authored
      Currently we are using inject methods like:
      
      /*
       * @param $foo Foo
       */
      public function injectFoo(Foo $foo) {
      	$this->foo = $foo;
      }
      
      This patch removes these methods and introduces
      property annotations:
      
      /**
       * @var Foo
       * @inject
       */
      protected $foo;
      
      Change-Id: I5b6f1aae29f95c31b9dd69629f05d8451fe30261
      Releases: 6.2
      Resolves: #46598
      Reviewed-on: https://review.typo3.org/22006
      Reviewed-by: Alexander Schnitzler
      Tested-by: Alexander Schnitzler
      Reviewed-by: Marc Bastian Heinrichs
      Tested-by: Marc Bastian Heinrichs
      Reviewed-by: Stefan Neufeind
      Reviewed-by: Anja Leichsenring
      Tested-by: Anja Leichsenring
      e83fa716
    • Andreas Wolf's avatar
      [TASK] Make comments in DataHandler real docblocks · b28734fe
      Andreas Wolf authored
      Change-Id: I8ae556930bd378a3756edbaa9ab86530f159f0da
      Relases: 6.2
      Resolves: #49784
      Reviewed-on: https://review.typo3.org/22119
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      b28734fe
  5. Jul 07, 2013
  6. Jul 06, 2013
    • Stefan Neufeind's avatar
      [BUGFIX] Files with unclean path indexed multiple times · 2219d228
      Stefan Neufeind authored
      When adding a file or requesting a file by an identifier
      cleanup any . and .. in the path before handing off
      to the driver so files are not indexed multiple times.
      
      Change-Id: I324c4637621165a56470fb95864eeff1254f62dc
      Fixes: #46989
      Releases: 6.2, 6.1, 6.0
      Reviewed-on: https://review.typo3.org/19684
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      2219d228
    • Felix Kopp's avatar
      [TASK] Move typo3/stylesheets to EXT: backend · f299f88a
      Felix Kopp authored
      In order to decouple extensions from each other and to
      fasten bonding between files to specific extensions the
      folder typo3/stylesheets should be moved to EXT: backend.
      
      Change-Id: I2ecf68e9c8d412c1c9b097db63743bde518f52b0
      Resolves: #49747
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/22048
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      Reviewed-by: Jigal van Hemert
      Tested-by: Jigal van Hemert
      f299f88a
    • Steffen Ritter's avatar
      [BUGFIX] sys_file record doesn't get flagged as delete · 18bb6574
      Steffen Ritter authored
      File is deleted by driver and deleted property of FileObject is set by
      ResourceStorage but new state is not persisted.
      Update deleted property in updateProperties array in FileObject and
      persist change.
      
      Reintroduced after fixing tests in f3778d8c.
      
      Change-Id: I0784c84af4bfb8021c648139c2feee577f3e9dc1
      Fixes: #48336
      Releases: 6.2, 6.1, 6.0
      Reviewed-on: https://review.typo3.org/22056
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      18bb6574
    • Markus Klein's avatar
      [TASK] Travis: Speedup cloning of repos · c6121d45
      Markus Klein authored
      Make use of the additional parameters of git clone
      to vastly reduce the amount of data transfered when cloning the
      repositories.
      
      Releases: 6.2, 6.1, 6.0, 4.7, 4.5
      Change-Id: Id0c5f3a4ed7ee0bdeb6053c6e0dc606362909d1e
      Reviewed-on: https://review.typo3.org/22054
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      c6121d45
    • Christian Kuhn's avatar
      [BUGFIX] System information looks ugly · 34e9b71d
      Christian Kuhn authored
      Install tool -> important actions -> system information does
      not break correctly on the definition list. Adapt css a bit.
      
      Resolves: #49748
      Related: #49162
      Releases: 6.2
      
      Change-Id: Ia2f1c5e4152c238e9c53fb383588fd12d72df1d8
      Reviewed-on: https://review.typo3.org/22053
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Anja Leichsenring
      Tested-by: Anja Leichsenring
      34e9b71d
    • Steffen Ritter's avatar
      [BUGFIX] Move functional test case to functional folder · fbdbeb76
      Steffen Ritter authored
      ext:core File/ExtendedFileUtilityTest unit test is not really
      a unit test, but more a functional test case since it does no
      mocking at all and writes data directly to database.
      The test case has side effects and is move to the functional
      section for now.
      
      Resolves: #49746
      Releases: 6.2, 6.1, 6.0
      Change-Id: I3f3917f0800a9492b01676bf2b67e81eea1ae16f
      Reviewed-on: https://review.typo3.org/22046
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      fbdbeb76
    • Felix Kopp's avatar
      [TASK] Remove <table> in lowlevel configuration · 09ec6e8a
      Felix Kopp authored
      EXT: lowlevel brings a tree view to display configurations.
      This configuration has been wrapped into a <table> tag in
      order to prohibit wrapping of long lines.
      
      Removes <table> tag and brings nowrap replacement.
      Also moves headline to pole position.
      
      Change-Id: I0358c90cd890101e5e8f7b8d4056d4e8a571d8ee
      Resolves: #49743
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/22042
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Max Roesch
      Tested-by: Max Roesch
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      09ec6e8a
    • Christian Kuhn's avatar
      Revert "[BUGFIX] sys_file record doesn't get flagged as delete" · f3778d8c
      Christian Kuhn authored
      This reverts commit d22cea3b
      
      The patch kills unit tests. We guess there is some incomplete
      mocking in Resource tests but are not able to quickly find
      the root of it. The patch is reverted for now until the tests
      are green again.
      
      Change-Id: I5e7bb6e14187f7179e00b0b00decda644e1c6efe
      Resolves: #48336
      Releases: 6.2, 6.1, 6.0
      Reviewed-on: https://review.typo3.org/22034
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      f3778d8c
    • Tim Spiekerkoetter's avatar
      [BUGFIX] CE:Image - backend preview of image order · e5cbf171
      Tim Spiekerkoetter authored
      The Backend preview does not reflect the sorting of the elements in the
      content element. This patch added the sorting field from the TCA to the
      thumbCode method.
      
      Resolves: #48645
      Releases: 6.2, 6.1, 6.0
      Change-Id: I9dcec1c2baae226aeded9c4c93d368c067c0bad2
      Reviewed-on: https://review.typo3.org/21975
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      e5cbf171
    • Francois Suter's avatar
      [BUGFIX] Add advice to RTEmagic wizard · 22c3cb24
      Francois Suter authored
      The update wizard that migrates RTE magic images relies on
      sys_refindex for finding the magic images. There should be
      a warning in the wizard description that users should be sure
      their reference index is up to date.
      
      Resolves: #49727
      Releases: 6.1, 6.2
      Change-Id: I7301a4a52174424655a76b58c7b7856f5f5209a2
      Reviewed-on: https://review.typo3.org/22007
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      22c3cb24
    • Frans Saris's avatar
      [BUGFIX] sys_file record doesn't get flagged as delete · d22cea3b
      Frans Saris authored
      File is deleted by driver and deleted property of FileObject is set by
      ResourceStorage but new state is not persisted.
      
      Update deleted property in updateProperties array in FileObject and
      persist change.
      
      Fixes: #48336
      Releases: 6.2, 6.1, 6.0
      Change-Id: I6cac106dcf89125e0b98b8b12a03c0b3f56d484f
      Reviewed-on: https://review.typo3.org/20982
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      d22cea3b
    • Helmut Hummel's avatar
      [BUGFIX] Use database name property in admin_get_tables · 30230a66
      Helmut Hummel authored
      The admin_get_tables method in the DatabaseConnection
      uses the constant instead of the class property.
      This delivers wrong results if using multiple
      DatabaseConnection objects.
      
      Use the class property instead.
      
      Change-Id: I93e05fdabb53b170782c61ef4ebfa97190cddfb6
      Resolves: #49738
      Releases: 6.2, 6.1
      Reviewed-on: https://review.typo3.org/22021
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      30230a66
    • Felix Kopp's avatar
      [BUGFIX] Bring back my icons to me, to me · ff6aadab
      Felix Kopp authored
      During icon clean-up regrettably too many were removed.
      
      This patch set reintroduces the missing revert icons.
      Kudos to Mister Wouter.
      
      Change-Id: Ice5fcdee292f968b16c55f8682e87d0dc63e6668
      Resolves: #49594
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/22020
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      ff6aadab
    • Felix Kopp's avatar
      [BUGFIX] Follow-up: Docheader spacious (row1/row2) · 74c987c2
      Felix Kopp authored
      Docheader row1/row2 are kept for former html structures.
      When inner-body paddings were increased before docheader
      row1/row2 fall-back was forgotten.
      
      Follow-up CSS.
      
      Change-Id: I7f0346dbd548b7cdc35514d423f779b792ab633a
      Resolves: #49735
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/22018
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      74c987c2
    • Christian Kuhn's avatar
      [BUGFIX] Cleanup permission settings in factory configuration · c262a79f
      Christian Kuhn authored
      DefaultConfiguration now contains sane values for fileCreateMask
      and folderCreateMask, so the values from FactoryConfiguration
      can be removed.
      
      Resolves: #49732
      Related: #49162
      Releases: 6.2
      
      Change-Id: I7225648cebad697850fd2a728c021ad4ffe80b88
      Reviewed-on: https://review.typo3.org/22012
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      c262a79f
    • Christian Zenker's avatar
      [BUGFIX][Cache] Typo3DbBackend forgets tag entries in flushByTag · 87e07fae
      Christian Zenker authored
      flushByTags removes cache entries tagged with a given tag, but
      if those cache entries have other tags assigned, they are not
      deleted in the tags table.
      The patch fixes this with an additional query.
      
      Resolves: #48984
      Releases: 6.2, 6.1, 6.0
      Change-Id: I7096e63cf823633f0c8a47f698bd475d7d02b83c
      Reviewed-on: https://review.typo3.org/21309
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      87e07fae
    • Steffen Ritter's avatar
      [FEATURE] Add Drag&Drop Upload to file-list · 57bd88c6
      Steffen Ritter authored
      In TYPO3 6.1 the Flash-Uploader has been removed and the
      upload functionality has been reduced to the basic HTML5
      multi-upload field.
      
      In the times of HTML5, CSS3 and modern browser our users
      expect a way more advanced experience.
      
      This patch adds the possibility to just drag files into the file
      list. The dragged files are asynchronously uploaded to the
      currently open folder and an reload of the frame is done.
      
      There are still some minor issues and ideas for a even better
      user experience, which have to be discussed if they should
      be included in the original patch.
      
      Change-Id: I4221f7ff5a06ee11555906f170b37cc08489d875
      Resolves: #47005
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/19714
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      Reviewed-by: Frans Saris
      Tested-by: Frans Saris
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      57bd88c6
    • Stefan Neufeind's avatar
      [TASK] CGL, switch(): Indent "case" correctly; no "break" in default · b5597764
      Stefan Neufeind authored
      * "case" needs to be indented one level more than switch().
      * default-case should not have a break-statement
      
      Change-Id: I8215ba2bdb19b9abbfe6ed45af3905d7e6c688d6
      Resolves: #49527
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/21748
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      b5597764
    • Markus Klein's avatar
      [BUGFIX] Don't show translated categories in parent tree · 2d65ba66
      Markus Klein authored
      The parent category tree should only show categories in default
      language.
      
      Resolves: #44915
      Releases: 6.2, 6.1, 6.0
      Change-Id: I7920cf7ae208ba2db3bd24f7da5439824064c167
      Reviewed-on: https://review.typo3.org/21626
      Reviewed-by: Philipp Gampe
      Tested-by: Philipp Gampe
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      2d65ba66
    • Marc Bastian Heinrichs's avatar
      Revert "[FEATURE] Support @Flow\Inject annotations in Extbase" · 43e046a7
      Marc Bastian Heinrichs authored
      This reverts commit 09bc4929
      
      We should not support this annotation in extbase, because it 
      has no benefit and breaks with the annotation concept in 
      Flow. "Flow" is only an alias for "TYPO3\Flow\Annotations" in 
      Flow and needs to be registered by "use TYPO3\Flow\Annotations as Flow".
      
      Change-Id: Ic0ecdc58754c176b1140db463c2405cb47bf9933
      Reviewed-on: https://review.typo3.org/21997
      Reviewed-by: Marc Bastian Heinrichs
      Tested-by: Marc Bastian Heinrichs
      43e046a7
    • Marc Bastian Heinrichs's avatar
      Revert "[TASK] Replace inject methods with @inject; allow @Flow\Inject" · 0a090c64
      Marc Bastian Heinrichs authored
      This reverts commit ad7219c2
      
      See https://review.typo3.org/#/c/21997/
      
      More notes on this:
      A regex to replace @inject with @Flow\Inject when porting 
      Extbase extensions to Flow is very simple and fast.
      
      Additionally @Flow\Inject makes only sense with using "use 
      TYPO3\Flow\Annotations as Flow". But with a backported 
      annotation parser I expect that we would have annotations 
      in "TYPO3\CMS\Extbase\Annotations". Using them as alias 
      "Flow" is a bad style as the alias should be "Extbase" then.
      
      Change-Id: I2113b5320f2a6f5dd56cfa7b06469fa1628d2645
      Reviewed-on: https://review.typo3.org/22004
      Reviewed-by: Marc Bastian Heinrichs
      Tested-by: Marc Bastian Heinrichs
      0a090c64
    • Patrick Broens's avatar
      [BUGFIX] CSV rendering in CType table not properly done · dc494adf
      Patrick Broens authored
      The CSV rendering in CType table is not done properly in
      css_styled_content method render_table. It uses explode with the
      delimiter, but this character can also be in the cell itself.
      
      This patch uses the PHP function str_getcsv, which is supported from PHP
      version 5.3 >
      
      Change-Id: I5707b006ab1143c108473e5ed7079e6e65cdddca
      Fixes: #47356
      Releases: 6.0, 6.1, 6.2
      Reviewed-on: https://review.typo3.org/20157
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      dc494adf