- Apr 20, 2021
-
-
Daniel Goerz authored
Resolves: #93704 Releases: master Change-Id: I24067c4b705c671b87a9bbdfed30535a39528879 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68359 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Benni Mack authored
This change limits the GET request for the PersistentStorage to only "get" and "getAll", where as the others are only working for "post". Since this logic is encapsulated properly in the Persistent JavaScript API, no other parts are affected. Resolves: #93948 Releases: master Change-Id: I965ea4552671c743cabed10c4cd8ad7275532420 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68715 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Jochen Roth authored
This solves a display white text on white background for the selected size in image cropping tool panel Resolves: #93909 Releases: master Change-Id: Iaa1d62cbb208afe68556eba19b526e13c127bd29 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68769 Tested-by:
-
Benni Mack authored
Various PHP classes, which were previously a specific implementation for various Link Picker / Element Browser renderings for trees are removed. In addition, the so-called "LegacyTree" is removed along with all entry points, also for the "navFrameScript" of the iframe inside the File main module. Modules who previously registered to the iFrame navigation component are now moved to the new file storage component. Since the related code was marked as internal, the files are removed without substitution. Resolves: #93944 Releases: master Change-Id: Ib42c5b32d44c8a697e250f178280f743b0d7e1da Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68799 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Jochen Roth authored
Allow a user to move a folder into a folder on the same level and prevent moving a folder into its child folder. Resolves: #93954 Releases: master Change-Id: I444a87e862075ecd0a3e54ce5afd02314b1931c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68833 Tested-by:
-
- Apr 19, 2021
-
-
Benni Mack authored
The LoginProvider functionality, which was baked into the LoginController is now moved into a separate Resolver class, cleaning up the Controller class and having a dedicated, single responsibility as a separate PHP class. In addition, the Request/Response (PSR-7) functionality is now used, instead of relying on $_COOKIE. Resolves: #93947 Releases: master Change-Id: Ic94361216566ec046160053e2a93c7d6be69584a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68772 Reviewed-by:
-
Benni Mack authored
Only if a site language is enabled, it should be taken into account for redirecting. To keep the interface valid, the 1st site language is returned if no other site language is found. Resolves: #93920 Releases: master, 10.4 Change-Id: I304c845012d3d76cd230e775030ac08a8d003e6b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68775 Tested-by:
-
Xavier Perseguers authored
Resolves: #93864 Releases: master, 10.4 Change-Id: I3ed1b9d33809302d46016f4a7b4f49fdbf131f01 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68717 Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de>
-
Oliver Bartsch authored
Since the reset password logic does not directly relate on the login step, just as MFA, it's now extracted into a dedicated class. This also allows to cover it with functional tests. Next to some code cleanup, the reset password views do now properly respect the common query parameters, like `loginProvider` or `redirect`. This helps to unify the overall authentication process UX as the user does not longer lose these parameters in some views, while they are kept in others. Resolves: #93918 Releases: master Change-Id: If7a21a1129b5289fd575ef9232c476d3c418aa36 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68773 Tested-by:
-
Oliver Bartsch authored
The form to update an already existing link in the LinkBrowser used the same name and id as the form for "Additional Attributes". This now leads to a JavaScript warning being emitted. The issue is fixed by replacing the duplicated name and id attribute. Resolves: #93936 Releases: master, 10.4 Change-Id: I074f46305ff0928f7c303ed28619d79b6fdc943f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68796 Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
-
Georg Ringer authored
Deleted pages must be excluded at content element previews in the page module to avoid exceptions. Resolves: #93938 Related: #93659 Releases: master, 10.4 Change-Id: I8786a6a93eac354684542d54ca1270d58cb05530 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68798 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
-
- Apr 16, 2021
-
-
Nikita Hovratov authored
In case the amount of items, shown in the workspace module, does not exceed the pagination limit - default 30 - the items array was previously filled with invalid items till the limit was reached. This is now fixed by a guard clause which prematurely ends the processing (the corresponding loop) as soon as no more item exists. This guard clause is also implemented in the calculation of the start value. Usually there shouldn't be any invalid items, but as such behaviour can not always be ruled out, especially on multi-user systems, it seems reasonable to add it here, too. Resolves: #93915 Relates: #93645 Releases: master, 10.4 Change-Id: I619c9063f12c3b1d5c446f9ca1a0e35e646f90f7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68779 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
Oliver Bartsch authored
In #35891 a feature was introduced, which allowed to override the icon of select items via Page TSconfig. This feature however did more or less never see the LTS release, since it was almost completely removed in #67006 again. Only SelectMultipleSideBySide provided this feature until https://review.typo3.org/c/Packages/TYPO3.CMS/+/50879/. It's now restored, using the original configuration path. Resolves: #73227 Relates: #35891 Releases: master, 10.4 Change-Id: I40e243a6f62a82ddf373b59977b61d00501777fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68776 Tested-by:
-
Oliver Bartsch authored
The page module is now being reloaded when deleting a content element via the context menu. Side note: Since there are a lot of functionalities in the module, e.g. translation, it isn't sufficient to just remove the element from DOM, like it's done in recordlist. The whole module needs to be reloaded / reinitialized. Resolves: #91394 Releases: master, 10.4 Change-Id: Ibd9dc853ddb356574a0f426244decb6455f54b44 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68727 Tested-by:
-
Oliver Bartsch authored
With #90461 a new option "saveAndClose" was added to the newContentElement wizard. When opening the wizard and selecting a content type with such option set, the new element will directly be created - no FormEngine interaction - and placed at the position (colPos, sorting), the user opened the wizard. This functionality however does not work when the wizard was opened without such page context, for example via the "new record view" in the recordlist. The position must then be defined by the user explicitly in the MultiStep wizard, so no "saveAndClose" functionality is available in such cases. Resolves: #93876 Releases: master, 10.4 Change-Id: I8c7c7b632533a6f2d2bbe01a103a25ce441acf2c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68726 Tested-by:
-
Oliver Bartsch authored
Following improvements are done: * Reduce margin-top of the MFA provider title * The bottom border of card-body is changed to a top border of card-footer to prevent the border from being shown without a card-footer * A new class `card-mfa` is added to the outer card container to allow individual styling of the MFA view Additionally this also fixes the custom styling options, as these were still applied to the `panel` class, which was however replaced by `card` during the bootstrap 5 migration. Resolves: #93913 Releases: master Change-Id: I4e7ff6e30b77f71b0d5823f5202062410ebddf88 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68771 Tested-by:
-
Oliver Bartsch authored
Resolve duplicated `class` declaration which prevented the element from being recognized by the JavaScript endpoint. Add missing `form-check-label-text` class for the checkbox label text. Remove invalid `p` tags from checkbox elements description. Resolves: #93929 Releases: master Change-Id: Ice0fdd1646f27dd8d98f33c8453cfa8ae2ce3b79 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68777 Tested-by:
-
Benni Mack authored
This change adds the SVG-based page tree in the record selector and the Page Link picker, replacing decade-old clumsy HTML code for generating trees. This replacement not only unifies the user experience across the navigation trees and the Element Browser / Link Pickers making the whole look + feel very consistent. It also allows to finally use all the features built in the SVG trees: * A filter across the tree built on the browser and automatic refreshing * collapse + expand and post-loading is now built with the same AJAX endpoints as the navigation components, making the general loading much faster * Temporary Mount Points now look exactly the same as in the navigation area. * Keyboard navigation * The Content Area inside the Record Selector and the Link Pickers is replaced via AJAX calls Especially the last feature makes it a breeze to use the new trees to select items much faster. All existing features, such as directly selecting a page or link to a page within the tree is added as so-called SVG-tree "actions" in the right corner when hovering, avoiding the additional "play" icon in the tree. Custom support for Element Browser "mount points" is also kept and included. The SVG tree is added to the following components: * Database Browser / Record Selector (e.g. choosing storagePid in plugins) * File Browser / Record Selector (e.g. selecting an image in the plugin) * Folder Browser / Record Selector * Link Picker for Pages / Content Elements ("link to a page") * Link Picker for Files ("link to a file") * Link Picker for Folders ("link to a folder") * Link Picker for Records (e.g. news record) All link picker functionality is available for typolink fields (e.g. tt_content.header_link) and when linking inside the Rich Text Editor. Some technical details under-the-hood: * The trees are now built as SVG tree / LIT elements * All Element Browser / Link Picker trees are named "Browsable...Tree" * The AJAX endpoints for fetching data are used * The Page Tree now uses a different configuration URL with a "?readonly=1" parameter, with the main difference to initialize EB mountpoints instead * Within the tree: The SVG tree actions is a separate container for elements on the right-hand of the tree * The GET parameter "contentOnly" represents to only load parts of the HTML (the content area) when fetching from AJAX Resolves: #73176 Resolves: #92430 Releases: master Change-Id: I5ef9534076bd6fa297b51c0ed9e90af91035be80 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67687 Reviewed-by:Benjamin Franzke <bfr@qbus.de> Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
Oliver Bartsch authored
The panel items in the global configuration card (EXT:install) are referencing to a not defined `id` in their `data-bs-parent` attribute. This therefore lead to a JavaScript error within bootstrap and is now fixed by adding the corresponding `id` to the panel group element. Resolves: #93934 Releases: master Change-Id: Ideede21f6e72c6b7dd25ef150cecc9b96b236b45 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68794 Tested-by:
-
Oliver Bartsch authored
In #92206 swapping of elements was removed along with some labels. The missing label for the publish button is now added again. Resolves: #93902 Releases: master Change-Id: I1aaef952b20ca3558b753c40cadccde74b7dc8eb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68761 Tested-by:
-
- Apr 15, 2021
-
-
Markus Klein authored
If an OUTER JOIN is requested, the "disabled" rows of the joined table must be filtered before the join is executed. Therefore the enableFields conditions must be applied in the ON condition of the join. Resolves: #88919 Releases: master, 10.4, 9.5 Change-Id: I996fe4929b2ca9a5dbaa8c5907a4ad6141bd8853 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64937 Tested-by:
Martin Kutschker <mkutschker-typo3@yahoo.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Henrik Elsner <helsner@dfau.de> Reviewed-by:
-
Oliver Bartsch authored
When defining "extendToSubpages" on a page, all subpages inherit the access restriction from this page. Therefore, when generating preview urls, more precisely the ADMCMD query parameters, the corresponding parent page properties are now also used for the preview urls of these subpages. Resolves: #92675 Resolves: #92286 Releases: master, 10.4 Change-Id: Ida7329ea1e12550746527f98674ac86daf68ff13 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68731 Tested-by:
-
- Apr 14, 2021
-
-
Oliver Bartsch authored
Since #93898 no more logging takes place in the LoginController. Therefore, the logger trait as well as the implemented interface can safely be removed. Resolves: #93916 Releases: master Change-Id: I4eec1696720d83eda73b16800fb535a39ffaf178 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68774 Tested-by:
-
- Apr 13, 2021
-
-
Andreas Fernandez authored
This patchs adds a new LitElement that invokes the update request of FormEngine if a field's value with such configuration changes. This replaces the current approach of huge onchange/onclick attributes rendered per affected field. A further patch will cleanup the necessity of TBE_EDITOR.fieldChanged(). Resolves: #93899 Releases: master Change-Id: I79aa5b6ab7cca9b555efaafcadabcc623567af64 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68756 Tested-by:
-
Oliver Bartsch authored
Using backend extension configuration, it's possible to customize the authentication forms, e.g. login and password recovery. Since MFA was added as another part of this process, the corresponding authentication forms must also respect the customized styling. This is achieved by extracting the logic form LoginController and adding it to a dedicated class `AuthenticationStyleInformation`. Resolves: #93898 Releases: master Change-Id: Ia0209017592ac9b168934df3ed3ab8bc08a1913d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68765 Tested-by:
-
- Apr 12, 2021
-
-
Benjamin Franzke authored
* Avoid custom moduleName in EXT:form and add a new moduleClass property for the purpose of custom controller styling * Use correct module name in view module (removing the custom one) * Advertise data-module-name body attribute in installtool modules Releases: master Resolves: #93907 Related: #93885 Change-Id: I662fa2131c5f898d5a327a9eaefff7202f6a9646 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68763 Tested-by:
-
Benni Mack authored
When using older versions with Doctrine DBAL and "pdo_sqlsrv" the "free()" method was already occupied and failed with MSSQL. Instead, we rely on the closeCursor() method which is available in all versions of Doctrine 2. Resolves: #93910 Releases: master, 10.4 Change-Id: I2d40501530ba18579ae610bf83ac7cc111f5b627 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68766 Tested-by:
-
Andreas Fernandez authored
With #89483 some constants to have named DataHandler actions were introduced. Unfortunately, a location in Workspace was forgotten which made it impossible to load comments from a changed record. This patch updates the SELECT query to use the correct action number again. Resolves: #93897 Related: #89483 Releases: master, 10.4 Change-Id: I62c857f1284ffc8577c726dd04c76ebbc96307f0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68758 Tested-by:
Xavier Perseguers <xavier@typo3.org> Reviewed-by:
-
- Apr 09, 2021
-
-
Benni Mack authored
The search box (accessible via the list module in docheader, and also used inside the Record Selector) is now simplified by having a main select field, and additional settings as dropdown available, making the search box - especially in the record selector - much more easier to understand and to use. In addition, the record selector search now looks similar to the File Selector (FAL relations), as the File Selector uses the same markup now as well. The doc header in the list module does not jump anymore when choosing the search box, as this is also now moved into the main document area, as all other modules (belog etc) use it as well. The search box component is also extracted from the DatabaseRecordList class, making it easier to re-use. As the page module does not have the search anymore, and thus, would rely on EXT:recordlist to just show the button, the button (and thus, the jumpyness) is removed there. Resolves: #93892 Releases: master Change-Id: I64259f54a79d0faaeefb45f9528d0a0d0c7b2c59 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68753 Tested-by:
-
Benni Mack authored
This change creates a default toolbar for SVG trees to filter, in order to avoid duplicate code (which will be added via the SVG based trees in the next feature again). Resolves: #93886 Releases: master Change-Id: Idb98bab80ca12fba4bafc5a4e4ac367a16bf6e87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68752 Tested-by:
-
Benni Mack authored
This change adds a new ModuleTemplateFactory, which is built with the Request in the object, allowing to use the current request of the current action. At the same time, all TYPO3 Core controllers use proper DependencyInjection now, making it easier to spot the dependencies and uses PSR-7 Request where possible. Resolves: #93885 Releases: master Change-Id: Ia6594a1e68c5c27375f34e49bffeda4dcbc980d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68729 Tested-by:
-
Benni Mack authored
The lowlevel bindValue() API is re-introduced in a way that supports both Doctrine 3.0 and Doctrine 2.10 (for TYPO3 v10) by checking for the ->getIterator() method on the ForwardCompatibility\Result object. For SQLite support, the use of the positional parameters is needed, as Doctrine DBAL does not support named parameters for manually wired bound values with SQLite3. Resolves: #93852 Related: #93848 Releases: master, 10.4 Change-Id: I7145b8ccd7f43a407ce24cdfea316f563e5410cd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68669 Tested-by:
-
Oliver Bartsch authored
Some cleanup of the SetupModuleController: Remove an unused function for adding Javascript, because it has not been executed since at least 7.6 and there are other ways to add custom Javascript nowadays. For example with an event, introduced in #91132, or directly via PageRenderer. Remove an unused parameter, which has been forgotten in #93093. Remove two superfluous typecasts. Resolves: #93896 Releases: master Change-Id: If4e4eb5352e46936332a687639399b8edeff0abc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68755 Tested-by:
-
- Apr 08, 2021
-
-
Benni Mack authored
This change migrates the ElementBrowser / LinkBrowser HTML Layouts to use the ElementBrowser Layout. In addition, the TypeScript files now work without jQuery. Resolves: #93880 Releases: master Change-Id: Ia9de506ce7a8534fb3ba4757ee6c1980c71c1428 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68725 Tested-by:
Daniel Sattler <sattler@b13.de> Tested-by:
-
Benni Mack authored
This change adds a new Lit-based custom HTML component called "<typo3-backend-navigation-switcher>" which moves the current navigation frame resizable feature in a more flexible re-usable way. All RecordLinkHandlers and ElementBrowsers now have a resizable and collapsible navigation area. In addition, all logic is now decoupled from Viewport.ts All ElementBrowser / RecordHandlers now also define an inline style width to avoid jumping of the navigation area within the modal box. Further optimizations in this area: * Remove the media queries for the CSS classes in the element browser? * The newly introduced LIT element could be built as shadow DOM Resolves: #93857 Releases: master Change-Id: I66724086942e0778e05b9c26dd956bb8417af6d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68692 Tested-by:
-
- Apr 07, 2021
-
-
Benjamin Franzke authored
Migrates backend UI component `LiveSearch` to be based on `lit-html`. In order to avoid string based concatenation which relies on the server side to properly escape html – which might not always work, when HTML is used in different contexts (node vs attributes). Resolves: #93101 Releases: master Change-Id: Idf0d588306ddc666a8ba449f96f58b78566a1c39 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67178 Tested-by:
-
Daniel Goerz authored
Resolves: #91322 Releases: master, 10.4 Change-Id: Ie03d6e120fcd62f9b14922ca28c61d6cd0dc2854 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68552 Tested-by:
-
Oliver Hader authored
When regenerating a slug value via form engine in the backend user interface, changed states are not addressed anymore. Corresponding JavaScript `change` event has to be triggered for the element that is used to trigger changes for form engine validation. Resolves: #93874 Releases: master Change-Id: I7e78f36f4434009c122717eeb92bc463b9daa1a6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68722 Tested-by:
-
Benni Mack authored
This change primarily moves the ModuleTemplate / DocHeader generation out of the DatabaseRecordList class into the actual controller where ModuleTemplate is used. The main controller method is also split up in smaller chunks (such as Clipboard initialization). In addition, several methods and properties are marked as protected if they are only used internally within DatabaseRecordList. Further steps in this area are to separate code from DatabaseRecordList which is not bound to the record listing. Resolves: #93863 Releases: master Change-Id: I901b0acebaec8f53b04426cad93002a3ec74195e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68712 Tested-by:
-
Anja Leichsenring authored
Usage of real instances in tests avoid the awkward situation that the test might not be useful anymore due to refactoring and reworking over time without anyone noticing. Mocks must only be used if necessary. Resolves: #93866 Releases: master, 10.4 Change-Id: I9095f0f6b0fb9b5c387b5c6150d82a9f5f07170f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68718 Tested-by:
-
