- Jun 28, 2024
-
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null tyype to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104238 Releases: main, 12.4, 11.5 Change-Id: I340f35379b74d1ca05527a6950eab5ba66ffaae6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84978 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null tyype to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104237 Releases: main, 12.4, 11.5 Change-Id: Ieb8d05b2e44dc448f7a2142c5ad6a91e68cf98c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84975 Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null tyype to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104236 Releases: main, 12.4, 11.5 Change-Id: Iba5e99b526ca37d7bb36044cd6ee1027b6c5245a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84972 Reviewed-by:
-
- Jun 26, 2024
-
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null tyype to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104210 Releases: main, 12.4, 11.5 Change-Id: Id20216f2b920b5f5c0d665a370536c447590f53c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84917 Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null tyype to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104211 Releases: main, 12.4, 11.5 Change-Id: Ic086fc77872c54f763d774f4118517658d8d52e3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84920 Reviewed-by:
-
Stefan Bürk authored
Since recently upgraded PHP-version the 10mb big xml unit test failes. The `\LIBXML_PARSEHUGE` xml option could be used to mitigate this case but would not explain the change from PHP yet. Thus the decision has been made to disable the failing data set as a temporary solution to avoid disturbance for core contribution until this issue has been investigated and reported to PHP itself. Resolves: #104218 Releases: main, 12.4, 11.5 Change-Id: Ifef4f18818e661312b9e56e013bb8f479146b806 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84850 Tested-by:
-
- Jun 25, 2024
-
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104206 Releases: main, 12.4, 11.5 Change-Id: I0d82e0474143f63870f772002de52d26c6c960fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84908 Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104205 Releases: main, 12.4, 11.5 Change-Id: Iaca12350ce8b28943fd5ce8181d42b91feb471e3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84905 Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] In case of union type the null is added as additional type. This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104203 Releases: main, 12.4, 11.5 Change-Id: I1e264d242e53e4d258abe82831e612ee43234d0d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84900 Reviewed-by:
-
Stefan Bürk authored
This change modifies the `Build/Scripts/runTests.sh` dispatcher script to add new database version. Added versions: * MySQL 8.4 * MariaDB 11.0 * MariaDB 11.1 * MariaDB 11.2 * MariaDB 11.3 * MariaDB 11.4 Note that for TYPO3 v12 and v11 also missing versions up to these are added now. This is not a official supported version statement. [1] https://endoflife.date/mariadb [2] https://endoflife.date/mysql [3] https://endoflife.date/postgresql Resolves: #104200 Releases: main, 12.4, 11.5 Change-Id: I338a7f0973a46fb8bc6a582a5c478c4715a8000e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84895 Tested-by:
-
Stefan Bürk authored
This change modifies the `Build/Script/runTests.sh` command dispatcher to allow passing composer options to the `composer install` subcommand, for example Build/Scripts/runTests.sh -s composerInstall \ -- --prefer-source Note that this is already possible using the generic `-s composer` dispatcher but would resolve some user confusion. This is useful to install dependencies as git checkouts, for example when working on packages like `typo3/testing-framework` changes. Albeit the need to remove the vendor folder first is needed in case of the example. Resolves: #104186 Releases: main, 12.4, 11.5 Change-Id: Id07c90f3b6902ad8866249563eceeb2dafbc919b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84845 Tested-by: -
Stefan Bürk authored
This change adds a `@` silence operator to the usage of `preg_match()` in the `RedirectService`. This prevents errors in case of manually-entered malformed regexp patterns and follows existing similar usages of the service. Additionally, a todo comment is added to evaluate future early pattern evaluation in record creation/editing so that a proper response to invalid patterns can be emitted. Resolves: #102176 Releases: main, 12.4, 11.5 Change-Id: I88687c128986ae6fa1e2b7a3a4bf414ee8f952f0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84843 Reviewed-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104196 Releases: main, 12.4, 11.5 Change-Id: Iec724407eed8edefed48c2e032b2105b42cabc94 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84885 Tested-by:
Fabien Udriot <fudriot@omic.ch> Reviewed-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104197 Releases: main, 12.4, 11.5 Change-Id: Ie2fbd6369e6c59c275939c42daa8c45c22334e48 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84888 Tested-by:
-
- Jun 24, 2024
-
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] This prepares the way towards PHP 8.4 compatibility and unifies towards using `?` nullable operator over union null type when possible. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104185 Releases: main, 12.4, 11.5 Change-Id: I12462595d622efa1bbe2a479f159d68a984bda23 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84869 Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is depreacted and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104184 Releases: main, 12.4, 11.5 Change-Id: I1e1a60a36ae2b5244bbd8c3cf963f2165077dbad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84866 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
- Jun 23, 2024
-
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is depreacted and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] In cases, where are implicitly nullable parameter exists before not-nullable parameters in a method or constructor, making it explicitly nullable will emit a Optional parameter <paramname> declared before required parameter <paramname> is implicitly treated as a required parameter since PHP 8.0 [2]. This change adds the `?` nullable operator [1] and removes the null default value when one or more non-optional argument follows [2] to mitigate both issues. Note that the second case is a edge case in this change. This prepares the way towards PHP 8.4 compatibility and unifies towards using `?` nullable operator over union null type when possible. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated [2] https://php.watch/versions/8.0/deprecate-required-param-after-optional Resolves: #104182 Releases: main, 12.4, 11.5 Change-Id: I68362a89458117eca4f0488c67a0b9ed17e7b929 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84859 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
- Jun 21, 2024
-
-
Sybille Peters authored
The class EditableRestriction is used in EXT:linkvalidator to apply permission restrictions to database queries for current (non-admin) BE user. In case of table sys_file_reference, the value for $GLOBALS['TCA'][$table]['ctrl']['type'] might be "uid_local:type". In that case, the class EditableRestriction tried to access the TCA configuration for this field via $GLOBALS['TCA']['sys_file_reference'] ['columns']['uid_local:type']['config'] when in fact this will be empty (and the type refers to the table sys_file). We now check if the resulting array is empty and skip the check if that is the case. Resolves: #103559 Related: #83835 Releases: main, 12.4, 11.5 Change-Id: Idbe653ef9f1c21c077fcb79c03212e606cc71830 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84829 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Peter Kraume authored
Using constants in the LinkHandler TSConfig does not work in the redirects module. Resolves: #103205 Releases: main, 12.4, 11.5 Change-Id: I29dda248c5e80e077d53c8ecead9fb29fd041f76 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84826 Tested-by:
-
Garvin Hicking authored
When filtering the page tree with characters that have special meaning for a regular expression (for example, ")" or "(" or "?" and some others), the filtering would return a "Page Tree error". JavaScript does not have something like "preg_quote", so this uses the escape string provided by the MDN with fixed special characters. Resolves: #104092 Releases: main, 12.4, 11.5 Change-Id: I4a29c62eaca8b7643c8ef78dda1d8337b3e1e53a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84820 Tested-by:Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
-
- Jun 19, 2024
-
-
Sascha Egerer authored
The ContentObjectRenderer catches \Exception's that occur during the rendering of a content element. However, since PHP 7, there is a \TypeError exception that occurs, for example, if the given type does not match the declared type. Because \TypeError is not a subtype of \Exception, these errors are not caught in the production context, and instead of not rendering a single content element, the whole page is not rendered. Since all types of \Throwable are essentially errors that will interrupt the rendering process, the catch block must accommodate all of these, not just implementations of \Exception. Resolves: #102044 Releases: main, 12.4, 11.5 Change-Id: If6218f013caf21d7fcd2c0d0d5b6b51c3bf9963e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84757 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
- Jun 18, 2024
-
-
Daniel Gohlke authored
The configuration top.TYPO3.settings.ShowItem.moduleUrl must be set so that info-window.js can use it to load the content for the modal. Resolves: #104147 Resolves: #99467 Resolves: #99695 Releases: main, 12.4, 11.5 Change-Id: I9dcf4e04e6c87a965ddfa6d2f3044cd74759a530 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84755 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Benjamin Franzke authored
Improve document-service responsiveness by relying on `DOMContentLoaded` and `document.readyState` >= `interactive`. 1) Handle non-loading state as "ready" to avoid waiting for `complete`. `document.readyState` has three states: * `loading` The document is still loading. * `interactive` The document has finished loading and the document has been parsed but sub-resources such as scripts, images, stylesheets and frames are still loading. The state indicates that the DOMContentLoaded event is about to fire. * `complete` The document and all sub-resources have finished loading. The state indicates that the load event is about to fire. If DocumentService.ready was called in "interactive" state we have been skipping this state as we only considered `complete` to be the "ready" state in this case. This is wrong as we actually wait for the DOMContentLoaded if we are launche... -
Christian Kuhn authored
Argument passing using `--` works well. It's time to remove the previous `-e` solution. Resolves: #104137 Related: #104131 Related: #102769 Releases: main, 12.4, 11.5 Change-Id: I99577a24dda77c4c96813f8ca14c2a27bdf7f2de Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84747 Reviewed-by:
-
Christian Kuhn authored
Inline the 'random seed' option for -s unitRandom, replay a specific seed using: > runTests.sh -s unitRandom -- --random-order-seed=<number> Resolves: #104131 Releases: main, 12.4, 11.5 Change-Id: I84e1cc0a0c57a5132a592a140d1b58ceb6d3b059 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84737 Tested-by:
-
- Jun 14, 2024
-
-
Bingquan Bao authored
The documentation contained a wrong registration code example, which now uses the proper array depth level notation. Releases: main, 12.4, 11.5 Resolves: #104105 Change-Id: Idb3c9b0e723af2f1bb579bc304637497e1272e36 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84646 Tested-by:
Lina Wolf <112@linawolf.de> Tested-by:
-
- Jun 13, 2024
-
-
Georg Ringer authored
The key `record` might not always contain the full record. When using the `FormSlugAjaxController`, the record might just contain a sub-set of fields. Resolves: #94388 Releases: main, 12.4, 11.5 Change-Id: Ie72d6701ebef4da8af8b039e0da056e28b8d0ecb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84692 Tested-by:
-
Garvin Hicking authored
Extbase reserves a couple of keywords for internal use: * action * controller * format (resolving fluid templates for HTML, json, ...) * __trustedProperties * __referrer The notiation "__" (and "@" for sub-arrays) is indiciative of being reserved keywords, however action/controller/format are not. These are now mentioned specifically in the Fluid ViewHelper "arguments" parameter, so that they can show up in the auto-generated documentation. This should help to prevent integrators and developers from advertly using an argument like "format" as a custom variable/property name. Efforts have been made to document this also here: https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-CoreApi/pull/4525 https://github.com/TYPO3-Documentation/TYPO3CMS-Exceptions/pull/155 Resolves: #102246 Releases: main, 12.4, 11.5 Change-Id: I55a306aaa0ba783f9202350d198c9fdf08f5a997 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84674 Reviewed-by:
-
- Jun 12, 2024
-
-
Christian Kuhn authored
> Build/Scripts/runTests.sh Before: Memory: 469.06 MB After: Memory: 373.02 MB Reason: phpunit executes data providers early and keeps data sets in memory. The "xml parser big content" tests create megabytes of data kept in memory. Moving the data generation from data providers to the test execution reduces overall memory usage significantly. Resolves: #104076 Releases: main, 12.4, 11.5 Change-Id: I0ad49824fc1d4c309158b74474853d36af22ffb5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84670 Reviewed-by:
-
- Jun 11, 2024
-
-
Georg Ringer authored
The string "false" is cast to true and therefore 0/1 must be used in examples. Resolves: #99211 Releases: main, 12.4, 11.5 Change-Id: I5519cd1917b81c1dbb90fbb6746541735e4940ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84633 Tested-by:
-
Oliver Hader authored
Change-Id: Ia5b8b0ec65a4d99829ba087011242c7a17937d1a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84598 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Oliver Hader authored
Change-Id: I75c50c5c69438aeaf3d59e818c60610dba859b36 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84597 Tested-by:
-
Andreas Kienast authored
The drag&drop issue reported in #103877 also affects the icons in the page tree, which was not fixed back then. This commit now takes care of the page tree icons as well. Resolves: #104033 Related: #103877 Releases: 12.4, 11.5 Change-Id: I92381a07bfba2d90d7fc1a85097c54f0d4a7b282 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84594 Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
Christian Weiske authored
The mask extension[1] automatically generates column definitions in TCA, and they do not have a 'label' key in the TCA columns definition. In TYPO3 v11.5.37, the link validator report page crashes with the following error: > (1/1) #1476107295 TYPO3\CMS\Core\Error\Exception > PHP Warning: Undefined array key "label" > in [...]/linkvalidator/Classes/Report/LinkValidatorReport.php line 559 In TYPO3 v12 the problem does not occur anymore. This patch simply checks if the label key exists before it is used. [1] https://github.com/Gernott/mask Resolves: #104032 Releases: 11.5 Change-Id: Icca6f102883b09b3fec182158e625b959988db33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84592 Tested-by:
-
- Jun 10, 2024
-
-
Garvin Hicking authored
When the configuration for `mod.web_layout.BackendLayouts` contains column definitions with an empty content, this will make both the list view and the normal page view in the backend fail. This makes using the GUI editing of the 'backend_layout' records impossible to be fixed/addressed. This patch now does a more lax check on the 'columns.' array to prevent PHP error notices on invalid array key access. Resolves: #103425 Releases: main, 12.4, 11.5 Change-Id: I68c9b5a1ee8f0a70e3808338aa9dd2ed6f12c882 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84551 Tested-by:
-
- Jun 07, 2024
-
-
Georg Ringer authored
Backport parts of #102907 to avoid exceptions because of undefined array key access. Resolves: #103997 Releases: 12.4, 11.5 Change-Id: I35e159bd8728fd84a43b58b27dc2a291fd11fe2b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84469 Reviewed-by:
-
Charles Krüger authored
A few minor spelling mistakes and uppercase notation is changed with this patch. Releases: main, 12.4, 11.5 Resolves: #103993 Change-Id: Ie71257dcd94e008bff2fd29ca6152152019eedae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84467 Tested-by:
-
- Jun 06, 2024
-
-
Garvin Hicking authored
The directory to reference removing Documentation-GENERATED-temp breaks out of the current working directory scope and could possibly delete files in a completely unrelated directory. Also, it does not remove the actual temporary files. Resolves: #103989 Releases: main, 12.4, 11.5 Change-Id: I685a398aa0d5abee3177ab3def4e271d493d59ab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84465 Tested-by:
-
Garvin Hicking authored
The use of the backtick operator inside the help output leads to an error message: Build/Scripts/runTests.sh: line 175: --: command not found on macOS (probably others, too). This patch replaces the backticks with normal quotes. Resolves: #103988 Releases: main, 12.4, 11.5 Change-Id: Ib6809dc6943a98e4d45d04f4ec02601e830518cd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84463 Tested-by:
-
Andreas Kienast authored
With Chrome 125, changes in the drag&drop handling were introduced [1] that trigger a text selection when dragging nodes from the page tree toolbar. In the `dragstart` handler, the default action is now prevented. [1] https://developer.chrome.com/release-notes/125#interoperable_mousemove_default_action Resolves: #103877 Releases: 12.4, 11.5 Change-Id: Iad75db78bba3e7b5ad01a568dcab2eb770f1c4a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84509 Tested-by:
-
