- Apr 16, 2024
-
-
Oliver Bartsch authored
While introducing the new module registration API, the previously used page TSconfig options to hide modules has been replaced by an extended user TSconfig option. This change (page TSconfig -> user TSconfig) is now clarified in the corresponding changelog. Resolves: #103627 Releases: main, 12.4 Change-Id: Ic701cf0674c8ff1ed18273ad2629b2217947f7c9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83812 Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Lina Wolf <112@linawolf.de> Tested-by:
Josef Glatz <typo3@josefglatz.at> Tested-by:
core-ci <typo3@b13.com> Tested-by:
-
- Apr 15, 2024
-
-
Oliver Bartsch authored
The search word is now properly kept on switching between advanced and normal search mode in EXT:indexed_search. Resolves: #103633 Releases: main, 12.4 Change-Id: Ic694e40da3a7bdeee3d76be2402fd4bf8e150e3c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83787 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Kevin Appelt authored
Resolves: #103628 Releases: main Change-Id: I5728324bc922682fcccea2ee90a5cb9eb3f77923 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83782 Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Andreas Kienast authored
The "Upgrade Wiards" view automatically checks whether mandatory database changes are pending. In that case, a list of tables, fields and indices are rendered. Before the removal of jQuery, a line break was rendered between the list items. However, the migration was not complete, as the line breaks are now rendered as `<br>`. The commit fixes this by creating real `<br>` elements. Resolves: #103613 Releases: main Change-Id: I6896ceeaed30606f55ac4376002552f92224c878 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83784 Tested-by:
-
Benjamin Franzke authored
An invalid site-set fluid condition was added in #103439 that cause the site-set related label to also be printed for `sys_template` record where a button was to be shown instead. Releases: main Resolves: #103629 Related: #103439 Change-Id: I44b970a5fcc9bd84abe12301b98b6967da92e7dc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83783 Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
- Apr 13, 2024
-
-
Philipp Kitzberger authored
It's now possible to filter the page tree not only by strings and single uids but by comma-separated lists of uids. Resolves: #103220 Releases: main Change-Id: I6cae67676d438dd3ce3992aee8fe160173ad142c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83153 Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
Jasmina Ließmann authored
The patch for #103615 added `resname` attributes to EXT:dashboard locallang files. An attribute was used twice, this is hereby corrected. Resolves: #103620 Related: #103615 Releases: main, 12.4 Change-Id: I4d813f29db0d64f486c1d5593bc8c2b955a8eafb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83777 Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
-
- Apr 12, 2024
-
-
Andreas Kienast authored
The patch for #103615 added `resname` attributes to EXT:dashboard locallang files, but one had a typo. It's fixed now. Resolves: #103616 Related: #103615 Releases: main, 12.4 Change-Id: I2e2ab733e5b7186193cd4f8482b4ff6c0a6e0b28 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83773 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Willi Wehmeier <wwwehmeier@gmail.com> Reviewed-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Ayke Halder <mail@ayke-halder.de> Tested-by:
-
Andreas Kienast authored
Resolves: #103615 Releases: main, 12.4, 11.5 Change-Id: I11f609625051f7dc6418596229bed49f282bc842 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83772 Reviewed-by:
-
Christian Kuhn authored
New version phpdocumentor/reflection-docblock:5.4.0 changed the signature of DocBlockFactory::createInstance(), which now points out a misuse in extbase. The patch changes the instantiation and avoids calling registerTagHandler() since this can and should be hand over to createInstance() directly. Resolves: #103614 Releases: main, 12.4 Change-Id: I344ef7df23dedd950c2775fe2fab93f7bb808786 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83750 Tested-by:
-
Georg Ringer authored
`DateTimeImmutable::setTimestamp()` requires the timestamp to be an integer. Resolves: #103588 Related: #99627 Related: #98045 Releases: main, 12.4, 11.5 Change-Id: I2dba1b3836063872fa04ea38d58b5bd499a8f7d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83742 Reviewed-by:
Rafał Jania <rr.jania@gmail.com> Tested-by:
-
Andreas Kienast authored
This commit replaces the abandoned package `@ronilaukkarinen/stylefmt` with the already installed `stylelint` tool. Please note that this is an intermediate step to give the build toolchain some love it deserves. Executed commands: npm remove @ronilaukkarinen/stylefmt npm install --save-dev \ autoprefixer@^10.4.19 \ postcss-scss@^4.0.9 \ stylelint@^14.16.1 \ stylelint-scss@^5.3.1 Resolves: #103612 Releases: main, 12.4 Change-Id: I1f283d50a1a6504c4c000e674c75a40923f6c7e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83748 Reviewed-by:
-
- Apr 11, 2024
-
-
Stefan Bürk authored
Test covering the SQL file parser has been streamlined and enriched with #103602, adding a disabled test with a todo to enable it when the SuT is fixed. Turns out the parser already handles the case well, the patch just enables the test. Resolves: #103605 Related: #103602 Releases: main, 12.4 Change-Id: I4b39dce5265c2504a9dc5f11a70dfe94702d0451 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83746 Tested-by:
-
Benjamin Franzke authored
Treat site sets (#103439) as a default content rendering template, in order to load Extbase plugin registrations prior to site sets. Also add a possibility to opt out from being loaded globally in site sets in ExtensionManagementUtility::addTypoScriptSetup and ExtensionManagementUtility::addTypoScriptConstants in order to reduce global TypoScript in upcoming commits (#103556). Resolves: #103580 Related: #103439 Related: #103556 Releases: main Change-Id: Ib9297c775d89f1689410f83e83955d6be829d2e6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83722 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by:
-
Stefan Bürk authored
* Add variable names as dataprovider set array keys to increase readability. * Add dataset for double-quote parsing in default values. * Add a disabled dataset for single-quote parsing in default values with todo to enable it with the bugfix. Resolves: #103602 Releases: main, 12.4 Change-Id: Ie85deff13598238fc437f6781b6ccf8349801846 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83741 Reviewed-by:
-
Christian Kuhn authored
RootlineUtility uses RelationHandler to resolve relations attached to pages. The tests from #103598 show that relations which are set to deleted ("delete placeholder", t3ver_state=2) are not considered and still part of the result set. The patch adds a missing call to prevent these. Resolves: #103599 Related: #103598 Releases: main, 12.4 Change-Id: Ie580e4d9b64c477d8c9d6d4092114c18f43a2a70 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83738 Tested-by: -
Christian Kuhn authored
* Increase abstraction in imported CSV fixture to separate scenarios from each other. * Turn single tests into a single test powered by a data provider. * Add tests for pages['media'] relation resolving. * Point out a bug related to a deleted workspace relation. Resolves: #103598 Related: #103566 Releases: main, 12.4 Change-Id: I679534f1837a4dc73e1d875bf5ee26f45566889d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83735 Reviewed-by:
-
Andreas Kienast authored
This commit updates ckeditor to 41.3. See changelog at [1]. Executed commands: npm install --save \ @ckeditor/ckeditor5-alignment@^41.3.0 \ @ckeditor/ckeditor5-autoformat@^41.3.0 \ @ckeditor/ckeditor5-basic-styles@^41.3.0 \ @ckeditor/ckeditor5-block-quote@^41.3.0 \ @ckeditor/ckeditor5-clipboard@^41.3.0 \ @ckeditor/ckeditor5-code-block@^41.3.0 \ @ckeditor/ckeditor5-core@^41.3.0 \ @ckeditor/ckeditor5-editor-classic@^41.3.0 \ @ckeditor/ckeditor5-engine@^41.3.0 \ @ckeditor/ckeditor5-essentials@^41.3.0 \ @ckeditor/ckeditor5-find-and-replace@^41.3.0 \ @ckeditor/ckeditor5-font@^41.3.0 \ @ckeditor/ckeditor5-heading@^41.3.0 \ @ckeditor/ckeditor5-horizontal-line@^41.3.0 \ @ckeditor/ckeditor5-html-support@^41.3.0 \ @ckeditor/ckeditor5-indent@^41.3.0 \ @ckeditor/ckeditor5-link@^41.3.0 \ @ckeditor/ckeditor5-list@^41.3.0 \ @ckeditor/ckeditor5-paragraph@^41.3.0 \ @ckeditor/ckeditor5-paste-from-office@^41.3.0 \ @ckeditor/ckeditor5-remove-format@^41.3.0 \ @ckeditor/ckeditor5-show-blocks@^41.3.0 \ @ckeditor/ckeditor5-source-editing@^41.3.0 \ @ckeditor/ckeditor5-special-characters@^41.3.0 \ @ckeditor/ckeditor5-style@^41.3.0 \ @ckeditor/ckeditor5-table@^41.3.0 \ @ckeditor/ckeditor5-theme-lark@^41.3.0 \ @ckeditor/ckeditor5-ui@^41.3.0 \ @ckeditor/ckeditor5-undo@^41.3.0 \ @ckeditor/ckeditor5-utils@^41.3.0 \ @ckeditor/ckeditor5-word-count@^41.3.0 npm run build [1] https://github.com/ckeditor/ckeditor5/releases/tag/v41.3.0 Resolves: #103589 Releases: main, 12.4 Change-Id: Id24aac98727af0d0b9284e68dd8c4a4e138a6c15 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83730 Tested-by:
-
- Apr 10, 2024
-
-
Jasmina Ließmann authored
If no page has been selected in the "Indexing" backend module, an information is displayed. This text is now displayed in the typical infobox style instead of as a heading. Resolves: #103590 Releases: main, 12.4 Change-Id: I6e44c5ad8502eb7ecb71581cb11084543c3e13aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83732 Reviewed-by:
-
Stefan Bürk authored
Database default value configuration for TEXT, BLOB and JSON field types has been impossible to use in a cross database vendor manner due to lacking support from MySQL. Direct default values are still unsupported, but since `MySQL 8.0.13+` [1] it is possible to use a default value expression with a slightly different syntax. TYPO3 v13.0 already raised the minimal requirement to MySQL 8.0.17 paving the way to provide a compatible way to define default values on database level now. To align the TYPO3 Database Analyzer stack ... * the extended `MySQLSchemaManager` is modified to revert default value expression to concrete values to make them comparable. * default value expression are created for these field types by modifing the extended Doctrine MySQL platform classes using the `MySQLDefaultValueDeclarationSQLOverrideTrait`. This change now adds support for database level default values for TEXT, JSON and BLOB fields and is accompanied by additional tests. NOTE: This unblocks TCA type=input default schema management. [1] https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-13.html#mysqld-8-0-13-data-types Resolves: #103578 Releases: main Change-Id: I61c63335b6d0edc80608c246db2e2f6dbae88223 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83556 Tested-by:
-
Jasmina Ließmann authored
To better identify the different record types, the record icon is now displayed next to the record title and some unnecessary double quotes are removed. The actions are now displayed as badges. Also, in the h1 the table name and UID have been removed. Resolves: #103433 Related: #103291 Releases: main Change-Id: I5b09258ca688f0d4ecdd1737b00b8b5a156e6ace Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83528 Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
-
Jasmina Ließmann authored
To improve accessibility, labels have been added to various form fields in the "Full search" area. In this process, existing hard-coded label texts were moved to the corresponding XLF file and their names were partially updated. In the results list, all action buttons now have a link title. Form fields that previously ran across the entire screen width were limited in width to improve readability. Resolves: #103443 Releases: main Change-Id: I713d659a3d9ad4f00fb38cf60529fe24f81d8fd9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83552 Reviewed-by:
-
Oliver Bartsch authored
Provide the missing template record variable, used in the info box of the constant editor, in case no template is selected (special UID -1). Happens for sites using site sets and therefore having no sys_template record to be selected. Resolves: #103568 Related: #103439 Releases: main Change-Id: I59379fa565159257e062e04a538f29901cb3fbd5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83706 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
-
- Apr 09, 2024
-
-
Christian Kuhn authored
Brings a bugfix to improve dealing with .csv fixture files during import a bit better. > composer u typo3/testing-framework Resolves: #103575 Releases: main Change-Id: If1ae9202a9f43d707dc961504f5b40d5c223475c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83714 Reviewed-by:
-
- Apr 08, 2024
-
-
Stefan Bürk authored
This change adds additional tests to cover additional variants for `EXT:redirects` handling. Placing guards helps to avoid mitigating regressions for these cases. Resolves: #103564 Related: #103395 Related: #103555 Releases: main, 12.4 Change-Id: I4b6deb258610d1a3d416c16eec610aa2bfd9ef72 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83703 Tested-by:
-
Christian Kuhn authored
RootlineUtility is *the* performance bottleneck in FE. But we have a cunning plan for improvements :) The patch streamlines some details to prepare things. RootlineUtility: * Protect getCacheIdentifier() and isMountedPage(), which were only public to unit test them. * Throw an exception if TCA pages columns is not set, which would indicate a serious misuse in early bootstrap. * Simplify minor details. Tests: * Merge remaining unit tests into functional tests. * Switch from YAML based DB scenario creation to direct CSV import to gain more control in tests. * Test reference index integrity of import CSV. Spoiler alert: This will become more important later. * Move some not related fixtures to a more suitable directory. Resolves: #103566 Releases: main Change-Id: Ife5c2e115abfcf3f399ebc49dcf5759461812293 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83705 Reviewed-by:
-
Andreas Kienast authored
The method `HtmlParser->caseShift()` is used to normalize the casing of values that are about to get compared, depending on whether a case-sensitive comparison is wanted at all which isn't, by default [1]. Also, the method had a runtime cache that doesn't have a great benefit. Therefore, the method is removed and normalization is done at the former method calls. [1] https://docs.typo3.org/m/typo3/reference-typoscript/main/en-us/Functions/HtmlparserTags.html#fixattrib-attribute-casesensitivecomp Resolves: #103565 Releases: main Change-Id: I260daeaa677418e5f7a619176e1fae17e5f68bb2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83704 Tested-by:
-
Christian Kuhn authored
Switch a couple of classes to use more DI. Note class Lexer was instantiated with a 'poor man' and oldschool approach similar to XCLASS before, which is now switched to DI. This is not considered breaking since all involved classes are marked `@internal`, there is not a single TER extension that actually uses this 'EXTCONF' based Lexer override, the class does not even have a proper interface, and any override most likely broke with previous v13 patches already. Resolves: #103562 Releases: main Change-Id: I4a09967e8b2d0b9c1da6e8be0634b2ba6edd05c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83700 Tested-by:
-
Andreas Kienast authored
Similar to editing regular content elements, it is now possible to save scheduler tasks being edited via keyboard shortcuts as well. Resolves: #103563 Releases: main Change-Id: Ia159293670f3f3dc762f3c23da35e0e71d5541fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83702 Reviewed-by:
-
Stefan Bürk authored
`Build/Scripts/runTests.sh` is the monorepo main dispatcher of script and tools to ensure same working state across developer host system and installation by using well defined containers. This mitigates issues with missing dependencies or wrong version of tools on develper machines. Until now local installation of `node` and `npm` in the matching version was mandatory to work with the node ecosystem like manage dependencies, executing node based tools or the build chain for CSS and TypeScript/JavaScript. This change adds now a `npm` dispatcher to `runTests.sh` similar to the `composer` command dispatcher introduced with #103045 to allow executing npm commands and defined scripts in `package.json` in a well-defined environment and removes the hard-requirement of installing it locally for new contributors. Added `runTests.sh` suite: * ./Build/Scripts/runTests.sh -s npm -- <npm-command-arguments> which allows now to using npm commands always with the correct npm and node version defined for the mono-repository state. Some examples: ./Build/Scripts/runTests.sh -s npm -- audit ./Build/Scripts/runTests.sh -s npm -- ci ./Build/Scripts/runTests.sh -s npm -- run build ./Build/Scripts/runTests.sh -s npm -- run watch:build ./Build/Scripts/runTests.sh -s npm -- install \ --save bootstrap@^5.3.2 Resolves: #103552 Related: #103045 Releases: main, 12.4, 11.5 Change-Id: Ie9de71f24dfd4805a98be7dc1b1604e5d0146eec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83690 Tested-by:Thomas Hohn <tho@gyldendal.dk> Tested-by:
-
Stefan Bürk authored
`\TYPO3\CMS\Backend\RecordList\DatabaseRecordList` provides the ability to modify the QueryBuilder used for the record list representation with the PSR-14 `ModifyDatabaseQueryForRecordListingEvent`, after generic query information like default orderings and similar have been added. That is covered within the `getQueryBuilder()` method, which is used in other class methods, for example in `getTables()` where it is changed to a `COUNT()` query. MariaDB for example is picky about count queries using `order by`, `group by` or aggregation methods which are not reflected or added in the counter parts leading to a not so useful error like Mixing of GROUP columns (MIN(),MAX(),COUNT(),...) with no GROUP columns is illegal if there is no GROUP BY clause or similar variants. This error message can be missleading for the case a order by has been used along with a COUNT() query. Listener of the event do not get the information if order-by can be added or should be left out, therefore maybe adding sorting conditions for a count query. This change now resets any order statements for the count-query like other places in the TYPO3 core. Resolves: #103427 Releases: main, 12.4, 11.5 Change-Id: Ie421993a1890dd6682d02f54203d538e6ae1b76c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83523 Reviewed-by:
-
Simon Praetorius authored
This patch updates Fluid to the latest version. It also adds a RST file which describes the new ViewHelpers that were added with 2.11. Executed command: composer req typo3fluid/fluid:^2.11.0 Resolves: #103560 Releases: main Change-Id: Ic4d1e59d9eeca8352188dac4b28dad43217b5bde Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83699 Reviewed-by:
Simon Praetorius <simon@praetorius.me> Reviewed-by:
-
Christian Kuhn authored
There is an ancient, hidden and not documented hook in ext:lowlevel since "ever": $GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['t3lib_fullsearch'] used with "beforeResultTable" and "additionalButtons". Both calls are useless: "beforeResultTable" does not receive any useful information except $this->MOD_SETTINGS (which changed multiple times already without further notice), and "additionalButtons" only receives the current row. There is no further code to act on anything "additionalButtons" may have added. Considering this is within ext:lowlevel "only", only in the complex "DB check" module, and a TER search reveals not a single use ever, it seems to be fair to remove this code without further notice since it very most likely has zero impact to anyone. Resolves: #103549 Releases: main Change-Id: I751ce3b830dbef0b9faa389bbc61353939ccf9f6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83686 Tested-by:
-
Christian Kuhn authored
Did you know about $GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['indexed_search']['addRootLineFields']? No? Well, that's probably because *nobody* does! According to a TER search, it has never been used. Why? Well, it's an undocumented feature in a detail functionality of indexed_search, and last traces at more obvious places have been removed in v6.0. To use it, a developer not only needs to understand the details of 'rootline_uids' in indexed_search, it also needs to find that "hook", grasp it, add a database field in table index_section, and add FE rendering to deal with it. The patch removes this code without substitution: It has never been used in the wild, is not documented, is most likely broken if anyone actually tries to use it, there has never been a single issue in forge related to it, it is embedded in an area that is hard to understand in the first place, it could be resolved using an XCLASS more easily, and its naming collides with the well-known FE addRootLineFields, which is of course a totally different thing. Resolves: #103553 Releases: main Change-Id: I311e85e207cecc6457f66d0e3f26b7f4e256ddd3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83691 Tested-by:
-
Christian Kuhn authored
Argument $pageId is mandatory in saveStopwordsKeywordsAction() since #102914. The link to that action is created in a fluid section three times: Once with a proper pages uid, twice without. This leads to crashes when trying to "Save stopwords" in the indexed_search BE "detail" module in sections "Words by top count" and "Words by frequency". The patch adds the pages-uid argument for these two sections and simplifies the fluid template a bit along the way. Change-Id: I3819733be4937b56325e8871dde47b0d00a27742 Resolves: #103543 Related: #102914 Related: #103541 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83677 Tested-by:
-
Georg Ringer authored
The check for content_from_pid is wrong as it is not the raw database record and therefore the relation is an array. Resolves: #103405 Releases: main, 12.4 Change-Id: I31cfc584d9d1164ef96e1c3bec5ec75cc1619bd7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83494 Reviewed-by:
-
Christian Kuhn authored
The indexed_search class Lexer is used to split strings into words using some weird multibyte magic. It has a "debug" mode, enabled during indexing when ext_conf_template.txt debugMode is true. It then creates a HTML string in its main split2Words() method, which is later written to index_debug along with other debug information. That debug string is then output in the BE module when looking at indexing details, if given. The fun part is, this debug string is reset in-between multiple split2Words() calls, and any indexing always calls the method four times, with the last one being 'description', which is usually empty. This means there is in practice almost never any debug output to show in BE, and even if shown, it is only a fraction of the processed content. The patch removes this lexer debug handling. Resolves: #103550 Releases: main Change-Id: I406a621bc88fc320f348f2e4ba2cf7bc0882e421 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83687 Tested-by:
-
Christian Kuhn authored
The config label: "Deprecated! Max TTL (hours) for indexed page: The time in hours that is the maximum age of an indexed page before it will get indexed again. Usually the index is kept consistent, therefore you won't need this feature." This message is there since ... *doing some git archaeology* ... SVN id 2006 in year 2007! That's the Changelog entry: "Turn off maxAge setting as this "feature" seems to make no sense at all." Agreed: When content is changed in BE, an IS hook removes the page index, and it will be re-indexed with next call (or via crawler). It seems it's finally time to remove the option plus the attached code without further notice ;) Change-Id: Ia8031ca4bf58d7c8293c1b8eb3f672a1fac2266b Resolves: #103548 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83683 Tested-by:
-
Christian Kuhn authored
The indexed_search BE module links to word details. This link is broken in main and v12: * In main, the wordHash argument is a string, but the extbase target action expects an int. * In v12, the wordHash is an int, but is misinterpreted as pages-uid. The patch fixes this by switching from the argument name 'id' to 'wordHash' to suppress the pages-uid "convention" to kick in. In main, the target action argument is declared as string and both arguments are set non-optional. Resolves: #103547 Related: #102975 Related: #96797 Related: #103540 Releases: main, 12.4 Change-Id: Ibd4732d086f1af264ee317c7e7d4fe0f15a15aa4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83679 Reviewed-by:
-
Benjamin Franzke authored
The site sets example referenced TYPO3-provided sets that are not yet available, since the respective implementations (#103034, #103556) have not be merged yet. Use generic examples to avoid confusion. Resolves: #103557 Related: #103437 Releases: main Change-Id: I008d60167a692ec601b89683bf582233b228ab12 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83697 Tested-by:
-
