- Sep 07, 2023
-
-
Helmut Hummel authored
ContentObjectRenderer is now added as request attribute in certain cases. But since the signature of obtaining an attribute from a request correctly states, that the attribute can be null, consuming code should account for that and defensively fall back to defaults, when the object can not be obtained. Releases: 12.4, main Resolves: #101201 Change-Id: I3b3145794cafd8f5a8c1081e97599f9862be8b99 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80921 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
core-ci <typo3@b13.com>
-
Stefan Bürk authored
With #99221 the cli setup command has been introduced to setup a instance from the command line and improved with followup changes. This works pretty fine in composer mode installations. In non-composer mode installations the package state file is not created using the cli command whereas the web based installation process creates one. This change ensures that a package state file is created if none exists. If no file is found, it creates it based on default factory settings like the installer. Resolves: #101678 Related: #100719 Related: #99221 Releases: main, 12.4 Change-Id: I022c4300131d0eca82569ef0463d0c0078c53055 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80900 Tested-by:
-
Helmut Hummel authored
Only create one filesystem object, instead of always creating new ones where needed. Resolves: #101870 Releases: main, 12.4 Change-Id: I56a47f412fded7585425098f18f1d7090baf09d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80896 Reviewed-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
Stefan Bürk authored
This change uses a slighty modified httpd (apache2) image based on alpine along with a own php-fpm image to spawn up a webserver with php-fpm in two containers as a replacement for the `php -S` webserver used prior. Modification for the apache2 (httpd) image are minimal and gives us the ability to mount the project with the exact same path in the image as from outside. Further all required apache2 modules are loaded missing the official image. Due to moving away from the php webserver we now need to adjust some configurations: * Use port 80 instead of 8000 the for acceptance and acceptanceInstall tests webserver. * Use the acceptance test instance as DocumentRoot instead of the monorepo root. * Copy several `.htaccess` files to the acceptance test instance as we now have a real apache2. * Copy the favicon.ico to the test instance instead of the monorepo root. * Ensure that created frontend SiteConfiguration no longer uses the relative test instance path. Simply use `/`. * Use only the php-fpm image for cli and webserver fpm container. Resolves: #101827 Releases: main, 12.4 Change-Id: I25367dd30963958c303bb91cea39adf4099f8718 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80917 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Kevin Appelt authored
- Short description of the function - Hint that TYPO3 sets default values - Hint that setting a value will remove the page from the XML sitemap The behaviour can be changed by the integrator/developer of cause, but the label can be changed via TCA override in that case. Resolves: #101841 Releases: main, 12.4 Change-Id: Ic74e02fa4de4aa0a6708123caa596271b7b27561 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80899 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Andreas Fernandez authored
Submitting the paging form in the record list's single table view was broken as the "View webpage" button wasn't explictly defined as a button, which in fact made it a submit button that opened the first page in the record list in a new tab. This patch does two things: * The button element is now explicitly declared being a "dumb" button * The JavaScript building the URL is simplified to use the existing URL in the form, which makes the data attribute that holds the "template" obsolete Resolves: #101540 Related: #101276 Releases: main, 12.4 Change-Id: I9184b3871452aed0b130a32a1405434e0fb9a9db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80898 Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Benjamin Kott authored
Resolves: #101857 Releases: main, 12.4 Change-Id: I6ef205a00f0e6128c816e694ede60751e8d84966 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80897 Reviewed-by:
-
Andreas Fernandez authored
When triggering modals via the `.t3js-modal-trigger` class, it is now possible to configure a modal's size via the `data-size` attribute, accepting all modal sizes: * `small` * `default` * `medium` * `large` * `full` Resolves: #101867 Releases: main, 12.4 Change-Id: I3932c3b3d9ee23904077e21a7362667d831dafc7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80895 Tested-by:
-
Helmut Hummel authored
There is no downside in making the argument optional. Although the API is marked as internal, it is in use in third party code, which would break within a bugfix release. Logically the API makes total sense with the argument being optional. If the webserver type is not known or not provided, no additional file is created. Resolves: #101868 Releases: main, 12.4 Change-Id: Ie559b8685fc582681befe09ff769724f13639862 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80894 Reviewed-by:
-
Benjamin Franzke authored
The module components (like the iframe wrapper) are created asynchronously after their implementing module (e.g. <typo3-iframe-module>) is loaded. The router had a preparatory check that verified that existing module elements are reused, but missed to verifiy whether the element has been created in parallel while the module components javascript module was loaded. This happens when the module changes while the module component is loaded for the first time. That leads to a situation that the module componenent was created twice, which rendered two module frames into the backend. Also resolve a long overdue todo while at it. Resolves: #101851 Releases: main, 12.4, 11.5 Change-Id: I069f9e924d38b3abeb70c6d4e805d9c43a4f05e9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80893 Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
-
Andreas Fernandez authored
This patch updates `typescript` to 5.2 and `@typescript-eslint` packages to 6.6. Updating `@typescript-eslint` revealed a broken condition in the `@typo3/backend/viewport/navigation-container` module that is now removed. Executed command: npm install --save-dev \ @typescript-eslint/eslint-plugin@^6.6.0 \ @typescript-eslint/parser@^6.6.0 \ @typescript-eslint/typescript-estree@^6.6.0 \ typescript@~5.2.2 Resolves: #101864 Releases: main, 12.4 Change-Id: I7fd1e5997b6b19124d8fcac8402db79d3fd05f6d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80890 Tested-by: -
Sybille Peters authored
The possibility to mark broken links with the `data-rte-error` attribute and styling was removed in TYPO3 v12. This is now added again to allow for linkvalidator and other extensions to mark broken links which will then be visibly styled differently when editing in the RTE. This affects only the backend. The attribute data-rte-error is removed when persisting the content to the database. The logic for adding this attribute is still in place: The linkvalidator uses the event `BrokenLinkAnalysisEvent` which is dispatched in `RteHtmlParser`. A marked broken link may look like this: ```html <a href="t3://page?uid=42" data-rte-error="External link is broken">link</a> ``` Note that the functionality got disabled with the new ckeditor in #96874 while the implementing plugin "showbrokenlinks" was removed later with #98497. The CSS is therefore restored from the state as of before #98497. Resolves: #101357 Related: #96874 Related: #98497 Releases: main, 12.4 Change-Id: I898b1de1b9bb9bf334740dc3b7ec8eb70627bed4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80892 Tested-by:
-
Georg Ringer authored
Check if a field exists before accessing it. Resolves: #101852 Releases: main, 12.4, 11.5 Change-Id: I95d227d920975b1e348c95a1069a9ddddcddc900 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80850 Tested-by:
-
Benjamin Franzke authored
With the deprecation removal of regular expressions based EXT:form validators in #101070, the set of available validators for the form element type URL became empty. (See EXT:form/Configuration/Yaml/FormElements/Url.yaml) Instead of only removing the select element from the DOM, the entire form-group is now removed, in order to also hide the corresponding <label> tag, as such a stray label tag isn't helpful for an enduser and is therefore actually even invalid HTML (as the reference to an input element is missing). Resolves: #101749 Related: #101070 Releases: main, 12.4, 11.5 Change-Id: Ib0d34e94e2c3ba109133dac64374f04f7c91329b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80730 Tested-by:
-
Benjamin Franzke authored
All in-tree .js files have been migrated to TypeScript, so it's time to add a CI check to ensure no stray build files (see #101786) or non-updated JavaScript files (e.g. #101784, #101785, #101787) are present in the git tree. Resolves: #101783 Related: #101784 Related: #101785 Related: #101786 Related: #101787 Releases: main, 12.4 Change-Id: I02aeaaeaae7fa0df634f39cb151f4316240936ab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80869 Tested-by:
-
Stefan Bürk authored
This change raises the minimum version constraint for the `typo3/testing-framework` to ensure that required changes are available as preparation to backport the `apache2+php-fpm` based acceptance test execution. Used command(s): > composer require --dev typo3/testing-framework:^8.0.5 Resolves: #101863 Releases: 12.4 Change-Id: Ice125ef8fa93e84a01b3ad29ede6d6b0973f3e3c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80887 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- Sep 06, 2023
-
-
Benjamin Kott authored
Resolves: #101856 Releases: main, 12.4 Change-Id: I41d3c07b44b544cd88e56e137dc0fb20ca38cb18 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80849 Tested-by:
-
Stefan Bürk authored
With #101739 a bug has been reported, which is not correct. This change adds functional tests to `ext:redirects` to show and cover that: * regexp redirects with a pattern not covering params but query arguments are given in the request uri and "Respect GET Parameters" has been set do not redirect. * RegExp Redirects with a pattern not covering params and no GET arguments are given in the request uri but "Respect GET Parameters" has been set redirects to the target url. Resolves: #101739 Releases: main, 12.4, 11.5 Change-Id: I023889ba6fefe5a4b06b392e02dece4b6ac517c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80848 Tested-by:
-
Stefan Bürk authored
During the migration to the specific TCA type `link` with #97159 the allowed link types for the field in the siteConfiguration->static-routes have been added incorrectly. This change re-adds the file link-type as allowed link type to that field. Resolves: #101837 Related: #97159 Releases: main, 12.4 Change-Id: Iee40a86fe115749482c2aa0faa2c887adb4d025b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80847 Reviewed-by:
-
Andreas Fernandez authored
The TypeScript part of the FormEngine got the form element in a weird way all over again. To make the code a little bit cleaner, the form element is now accessed using a `FormEngine` getter property in order to ensure types are properly infered. Resolves: #101836 Releases: main, 12.4 Change-Id: I737287fc9a0b8fd94cc3bf915e7f1d2511c720ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80880 Tested-by:
-
Benjamin Kott authored
We are removing the obsolete .collapseIcon wrapper and replace the icons directly. Resolves: #101854 Releases: main, 12.4 Change-Id: I7c640eba173edc167910312087c46d6614d7f5c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80846 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by:
-
Benjamin Kott authored
The GenericButton requires a label to be set instead of a title. The title rendering falls back to the label if no dedicated title is provided. Resolves: #101853 Releases: main, 12.4 Change-Id: I41e835b44ee2bf1b33927811b8353f49ad725b42 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80878 Reviewed-by:
-
Stefan Bürk authored
Avoid native PHP warnings in FrontendBackendUserAuthentication because of invalid array key access. The places are now guarded using null coalescing operator with a suitable fallback value. Resolves: #101848 Resolves: #101847 Releases: main, 12.4, 11.5 Change-Id: Iaf747172b6ac04b9d2bdbf60519346ef7e3b3f2f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80844 Tested-by:
-
- Sep 05, 2023
-
-
Elias Häußler authored
This patch re-adds support for the `fieldExplanationText` property of form finisher checkboxes. It was removed with #95086, but is actually still used in some finishers, e.g. email finisher. Said patch also introduced wrong HTML for the checkbox label, which is fixed as well. Resolves: #101831 Related: #95086 Releases: main, 12.4 Change-Id: Ia1fe626ee5375f6d13adad8274b04be28345ed65 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80843 Tested-by:
-
Benjamin Kott authored
We also ensure that TYPO3.lang checks are correct when the modal is used in a context where TYPO3.lang is not defined. Resolves: #101844 Releases: main, 12.4, 11.5 Change-Id: I1e6e90ed86e72f483929429b8e2c833179b60f87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80867 Tested-by:
-
Benjamin Franzke authored
The parser originates from the original codemirror javascript-mode and therefore contains a lot of legacy and unneeded code. Code that is obviously unneded for TypoScript (like backticks (called "quasi") or function expressions are removed to reduce the amount of code that needs to be type-declared. Resolves: #101803 Related: #101783 Releases: main, 12.4 Change-Id: If048e8c914cad3953463e9af712908f0e84c5f8f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80852 Tested-by:
-
Andreas Fernandez authored
The image cropper component uses buttons to let a backend user toggle the currently active aspect ratio setting, indicated via an `active` class and a checkmark icon. With the removal of Font Awesome in #97877, some CSS was removed that was responsible for toggling the visibility of the checkmark icons. This patch adds the missing CSS again, including necessary adaptions to Core's Icon API. Resolves: #101788 Related: #97877 Releases: main, 12.4 Change-Id: I1daf428cafba3bc5f1e707c2763bf3f5dd6ba293 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80842 Tested-by:
-
Benjamin Kott authored
Resolves: #101845 Releases: main, 12.4 Change-Id: I1ba482f9f482a9579a6d0295cde161de83d5bebf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80864 Reviewed-by:
-
Benjamin Franzke authored
With #101782 eslint project configuration was overwritten to use a custom path. eslint read the relative project configuration based on the current execution folder instead of relative to the eslintrc file. This worked as long as eslint was executed from the Build/ folder (execution folder == eslintrc folder). As some tools execute eslint from the git root directory, the configuration is now adapted to always resolve the tsconfig file name as an absolute path based on the configurations directory name. Also overrideConfigFile is removed from Gruntfile.js as .eslintrc.[json|js] is read by default and no override is needed. Resolves: #101846 Related: #101782 Releases: main, 12.4 Change-Id: I58a6322a74d388efb0da28d1d8e7375f491c7aea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80841 Reviewed-by:
-
Anja Leichsenring authored
New ISO data has been published, so we update our set. Resolves: #101842 Releases: main, 12.4 Change-Id: If0a4663b91862615a8ddcfd5e0887efb03009ada Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80840 Tested-by:
-
Chris Müller authored
Twitter made the CSS framework Open Source in 2011, since then it is called only "Bootstrap". Resolves: #101840 Releases: main, 12.4, 11.5 Change-Id: I05c7d9ce3a197cb61058a5582918935d6720e371 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80838 Reviewed-by:
-
- Sep 04, 2023
-
-
Benjamin Franzke authored
Now that our build chain targets ESM modules, we can use our TypeScript toolchain to also build utility entry point scripts, allowing to make use of TypeScript checking and centralize asset management. Resolves: #101790 Related: #101783 Releases: main, 12.4 Change-Id: I2b4e89114022a611a0e061d16d012e4b389dc750 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80830 Tested-by:
-
Anja Leichsenring authored
New ISO data has been published, so we update our set. Resolves: #101832 Releases: main, 12.4 Change-Id: I029135f8e13f3337596b62d1ff954230c7b9536d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80837 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- Sep 03, 2023
-
-
Markus Klein authored
This supplements the other viewhelpers already equipped with this attribute. Resolves: #101775 Releases: main, 12.4, 11.5 Change-Id: Iadcdb1de591d9d9e56722623cacd1a5cf8fbe0af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80836 Reviewed-by:
-
- Sep 01, 2023
-
-
Benjamin Franzke authored
Resolves: #101795 Related: #101783 Releases: main, 12.4 Change-Id: Id881225a77fcbb0fa6dbd9a7e75caba4fbe05ab1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80821 Reviewed-by:
-
Friedemann Altrock authored
Only add implicit default paths (Resources/Private/X) when they are not explicitly configured via TypoScript, as they may have been configured as an overwrite for another base path. Resolves: #81099 Releases: main, 12.4, 11.5 Change-Id: I0fe4cb690aa253d5d9941fcfbe0a9c9063298547 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80834 Tested-by:
-
Christian Kuhn authored
We finally removed remaining usages with #101647 and can thus drop the info in about module. The domain is offline meanwhile, so we backport to v12 to avoid dead links in the backend. Resolves: #101823 Related: #101647 Releases: main, 12.4 Change-Id: Id925da8a2dc87ca840d65b750f5025ae00fee7f0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80818 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Friedemann Altrock authored
Before this fix, only the first RTE processing configuration would be taken into account when deciding which tags to keep in an HTML snippet. RteHtmlParser is a DI service and as such is treated as a singleton. Using multiple RTE processing configurations with potentially different sets of allowed tags should work as expected. Resolves: #101190 Releases: main, 12.4, 11.5 Change-Id: Ib0227872b542f53b30a16494aa2f979b8f601e07 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80832 Tested-by:
-
- Aug 31, 2023
-
-
Stefan Bürk authored
FormEngine sends some information as payload with the suggest wizard ajax request to the `SuggestWizardController` as context. The controller loads the record based on the tableName and the uid to determine the recordType to read the correct TCA field configuration, respecting special overrides like `columnsOverrides`. If a new record is created, there is no record uid available and passed to the controller. Therefore, the recordType is not properly determined. That leads to wrong record suggestions, if for example the `allowed` record table is overriden for specific recordTypes. This change adds the recordTypeValue as additional html data attribute to the suggest search field, reads and sends it along with the context payload in the ajax request to the suggest wizard controller, which now uses the passed value while keeping the record retrievement as fallback for now. Suggest records are now directly searched correctly respecting the full TCA configuration for the type, even for new records. Additionally, uid is send as null instead of the string "NaN". Used command(s): > Build/Scripts/runTests.sh -s buildJavascript Resolves: #101796 Releases: main, 12.4, 11.5 Change-Id: I3b814d37b7d4d3e9674ad6f2af882520c4f91413 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80773 Tested-by:
-
Christian Kuhn authored
To be an example of best practice, this patch changes all usages of "<INCLUDE_TYPOSCRIPT ..." to "@import". Tests are adapted as well, as long as they are not tailored to actually test INCLUDE_TYPOSCRIPT syntax. Resolves: #101813 Related: #97816 Releases: main, 12.4 Change-Id: I01c4eb19dfd0106c5577457cd0e1836865112d6a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80797 Tested-by:
-
