- Apr 23, 2024
-
-
Nikita Hovratov authored
It is possible that TCA items array is not set in DataHandler if 1. items is defined through types/*/columnsOverrides 2. DataHandler is triggered with context of another record type (e.g. by a translation request) This patch ensures we are always dealing with an array for items. Also, when passing it as parameter to `ItemProcessingService->getProcessingItems`. Resolves: #103472 Releases: main, 12.4 Change-Id: I364841982b7c2913e339bf5a504d811b3e050049 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83899 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
- Apr 22, 2024
-
-
Sybille Peters authored
The TSconfig configuration option mod.linkvalidator.searchFields is documented in the documentation. Previously, it was only possible to check within fields, if at least one softref was configured. This was changed to include fields with the type "link" (see LinkAnalyzer class). This change updates the documentation to reflect that. Resolves: #103477 Related: #83835 Releases: main, 12.4 Change-Id: I83ceafca206b2b1821e622bc36867eb13a9a5984 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83955 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Andreas Kienast authored
Executed commands: npm install --save \ lit@^3.1.3 \ lit-element@^4.0.5 \ lit-html@^3.1.3 npm run build Resolves: #103654 Releases: main, 12.4 Change-Id: Id250be2076f29d095cffed34bffe3f882feb223d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83952 Tested-by:Benjamin Franzke <ben@bnf.dev> Reviewed-by:
-
Willi Wehmeier authored
Add accessible aria-labels to the record icon located in the docheader component on the upper right. Additionally the record icon on the bottom right below the edit record form has got an aria-label now. Resolves: #103636 Releases: main, 12.4 Change-Id: I02a473e954f74c1b9fe8da765ca562a8a4ded290 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83900 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
- Apr 21, 2024
-
-
Chris Müller authored
When providing a custom submodule for the admin panel with JavaScript, the script tag does not have a nonce attribute attached. The $attributes argument of the getAdditionalResourcesForModules() method holds a "useNonce" configuration, which is now also passed to getAdditionalResourcesForModules(), like for other calls in this method. Resolves: #103673 Releases: main, 12.4 Change-Id: I135a263734b7273c2065429185f1dd7287bd19a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83898 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Stefan Bürk authored
The TYPO3 system extension `redirects` now fully supports the setting of relative links as the `target` URL, which is a documented feature. Previously, an issue arose when attempting to use path links with leading slashes as URLs. This issue has been addressed in #101083, marking the initial step toward resolving the problem of relative target links. Additionally, the fix now allows for linking to arbitrary resources, even those that do not currently exist in the File Abstraction Layer (FAL). The class `TYPO3\CMS\Core\LinkHandling\LegacyLinkNotationConverter` has been changed to limit the handling of arbitrary resources to the smallest scope to reuse existing code and to use them as `LinkService::TYPE_URL` links. The superflous outer catch block has been removed to remove dead code. In addition, a test for coverage has been added that covers DataHandler and the lower LinkHandling layer. Resolves: #103387 Related: #101083 Releases: main, 12.4 Change-Id: I51cad29e5551824a0ad8d4528aa43cff7e0f9da7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83946 Tested-by:
-
- Apr 20, 2024
-
-
Chris Müller authored
The main key is not "RTE" in YAML, but "editor". Resolves: #103678 Releases: main, 12.4 Change-Id: I3c09ac3f0071be70ba3fb6c130653b8b75dc98b4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83897 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
- Apr 19, 2024
-
-
Chris Müller authored
This patch streamlines some spellings, break long code lines, so so they are visible without horizontal scrolling and adds more context to the RTE configuration examples. Resolves: #103677 Releases: main, 12.4 Change-Id: I2366888a29b90ee59d76f1b8f6876eb600b730d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83941 Tested-by:
-
Andreas Kienast authored
This commit removes the import of `@typo3/backend/tabs.js` in the "New Content Element" wizard for two reasons: 1. the module is not required in this scope 2. the import is apparently defunct, no request is made for that file Resolves: #103684 Releases: main, 12.4 Change-Id: I1f9af422f6c2b14590b96a058bc2ed088d0853d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83896 Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
-
Oliver Bartsch authored
When resolving the first and last inline elements in the `FilesControlContainer` and `InlineControlContainer`, it is now properly checked, whether any children exist at all, preventing possible type errors. Additionally a fallback is added to prevent further warnings in the containers while trying to iterate over the children. Resolves: #103646 Releases: main, 12.4 Change-Id: I6f46ee5dc6d5553f3bd43c12447ef2390e1f941f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83895 Tested-by:
-
Oliver Bartsch authored
All pages rendered in the first column of the Localization Overview now display the correct record icon, which is wrapped with the context menu. Resolves: #103587 Releases: main, 12.4 Change-Id: I51d2ce07b91a47d01351f7c4fabac4868286e92d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83926 Tested-by:
Sybille Peters <sypets@gmx.de> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
-
Christian Rath-Ulrich authored
Add record titles to the record icon alt text. To make the alt text for record icons helpful, the title and type of the record is now added to the existing id=x. To implement this also for the pagetree, the method BackendUtility::titleAttribForPages() has got a new parameter to return the value unescaped. The JsonResponse in the TreeController already escapes the data and additionally the TemplateResult from lit also does escaping. Additionally BackendUtility::getRecordIconAltText() received a new parameter to make it possible to not escape string values. This is necessary to prevent values to get double encoded when used in the fluid context. Resolves: #102472 Releases: main, 12.4 Change-Id: I2476baccc4caf1ffaf27bbb3d5681cd53aea6052 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83877 Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
-
Oliver Bartsch authored
Using `options.folderTree.altElementBrowserMountPoints` it's possible to add additional mount points to the file / folder tree. Adding such entries does now properly work by adding the missing `identifier` key, which is required to add those entries to a storage in `StoragePermissionAspect`. Additionally, null coalescing operators are added at two places to prevent undefined array key errors. Resolves: #103609 Releases: main, 12.4 Change-Id: I275f51b5bb2d2a1583393a9e782366092d4f558a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83925 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
- Apr 18, 2024
-
-
Christian Weiske authored
Feature #89650 added support for newlines in TCA field descriptions, but palette descriptions were forgotten. This patch makes newlines in palette descriptions visible in the same way. Resolves: #103659 Related: #89650 Releases: main, 12.4 Change-Id: Ib505f476eb0f3efd0bf75bee7550b9e203ccda2b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83894 Tested-by:
-
Christian Kuhn authored
Calculation of reference index for workspace relations has a nasty bug in getListOfActiveWorkspaces(): It always returns only the first workspace id when there are multiple. This isn't good in v12 since it creates broken or missing index entries with MM. It is worse in v13, since refactorings of the class use the method for some additional operations. The patch fixes the broken helper method. Resolves: #103655 Related: #96067 Related: #103661 Releases: main, 12.4 Change-Id: I989b22f9c25b22f52030c3dbce742074d2e09f97 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83920 Tested-by:
-
Christian Kuhn authored
Resolving relations in RelationHandler for MM in workspaces is a two fold process: readMM() first finds all relation "candidates". A second step then filters live MM relations from the candidate list that have a workspace overlay. In general, it *should* be possible to combine this rather expensive operation into a single query. This however requires a bigger rewrite of the class, which absoletly needs to happen at some point, especially for performance considerations. There is however a significant bug the patch aims to solve now: The result set of MM relations tends to return relations not only of the workspace-uid that has been requested, but relations of other workspaces as well, due to an insufficient query with improper filter logic in the second part of the process. This patch is important for a bug fix within ReferenceIndex, which - when fixed - triggers the currently broken RelationHandler relation calculation. Resolves: #103661 Related: #103655 Releases: main, 12.4 Change-Id: If42c138321f0043bf9d8c363f0e20e61d649e1e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83918 Tested-by:
-
Andreas Kienast authored
Executed commands: npm install --save-dev flag-icons@^7.2.1 npm run build Resolves: #103656 Releases: main, 12.4 Change-Id: Ibebf001a8867104d616777adf47b7c0edaccbf9d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83893 Tested-by: -
Nikita Hovratov authored
In case of CLI context, normalized params are not available and as they are nullable, a guard condition is required before accessing methods. Note: The access via request object was added in #100047 along with a deprecation of using the ip() function in TSConfig. However, there is a special case, where plain TypoScript is loaded even in CLI context. For example this can happen when EXT:form listens to FlexForm data structure parsing event. Then it needs information from TypoScript on how to manipulate FlexForm based on YAML definitions. Resolves: #103644 Related: #100047 Releases: main, 12.4 Change-Id: Id2d166fd11794db9b7a8102677e5b9305fe18c59 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83892 Tested-by:
-
- Apr 17, 2024
-
-
Rafal Jania authored
Resolves: #103596 Related: #97548 Releases: main, 12.4 Change-Id: I2384d223202af1575a93497f81e6a69599ebbc3c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83873 Tested-by:
-
Christian Kuhn authored
When a TCA table has no 'ctrl' 'tstamp' field defined, the workspace module crashes with an undefined array access for records of this table. Sanitize this. Resolves: #103650 Releases: main, 12.4 Change-Id: I3f8c6a1788ec2f9e8f03eddaf9c2ed4df5d737e2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83849 Tested-by:
-
Nikita Hovratov authored
The $event parameter is now added and a superfluous parenthesis is removed in the condition. Also, the $tableName variable is used now. Resolves: #103645 Related: #98375 Releases: main, 12.4 Change-Id: I8f827ac7f6941ab03a6f5c67e9fb3525d1a79868 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83856 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
-
- Apr 16, 2024
-
-
Benjamin Kott authored
Resolves: #103638 Releases: main, 12.4 Change-Id: Ib5880f2ea62c8d9b54b7db6f6488fc6d5a479827 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83855 Tested-by:
-
Willi Wehmeier authored
Add proper focus styles to the nav links in the Link Browser modal window. Resolves: #103631 Releases: main, 12.4 Change-Id: I0abb597124e335c3955c73438ac3cd2f0dad93bf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83854 Tested-by:
-
Christian Rath-Ulrich authored
To trigger a search, usually an icon-only button is placed next to the search input field. To improve the accessibility of these icon-only buttons, a visually hidden label is added. Resolves: #102410 Releases: main, 12.4 Change-Id: Ifd7faee3d4c727dd2e86ad7304e19f970b61699e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83835 Reviewed-by:
Willi Wehmeier <wwwehmeier@gmail.com> Tested-by:
-
Lina Wolf authored
Remove excess bracket Releases: main, 12.4 Resolves: #103635 Change-Id: Ie9ea1f03457177eeb6be7abb788c05bd2bf64e8c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83853 Tested-by:
-
Torben Hansen authored
The new core `HashService` and the deprecated extbase `HashService` have the function `validateAndStripHmac` to validate and strip a given HMAC appended string. The function will throw an exception, if the given string is either too short or the appended HMAC in the string is not valid. In context of a TYPO3 extension, those exceptions are usually thrown, when a given HMAC appended string has been tampered. Logging those exceptions to sys_log or logfiles make no sense, since a TYPO3 site owner have no reasonable possibility to prevent a tampered HMAC appended string being passed to the `validateAndStripHmac` function. This change prevents logging of four exceptions caused by potential manipulated HMAC appended strings. Additionally, a note has been added to extbase `HashService`, that exception codes from that class must be removed in v14 in `AbstractExceptionHandler::IGNORED_HMAC_EXCEPTION_CODES`. Resolves: #103592 Releases: main, 12.4 Change-Id: I2870db815f3348cac2465b1caca711f4736f16db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83833 Reviewed-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
-
Oliver Bartsch authored
While introducing the new module registration API, the previously used page TSconfig options to hide modules has been replaced by an extended user TSconfig option. This change (page TSconfig -> user TSconfig) is now clarified in the corresponding changelog. Resolves: #103627 Releases: main, 12.4 Change-Id: Ic701cf0674c8ff1ed18273ad2629b2217947f7c9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83852 Tested-by:
Lina Wolf <112@linawolf.de> Tested-by:
-
- Apr 15, 2024
-
-
Oliver Bartsch authored
The search word is now properly kept on switching between advanced and normal search mode in EXT:indexed_search. Resolves: #103633 Releases: main, 12.4 Change-Id: Ic694e40da3a7bdeee3d76be2402fd4bf8e150e3c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83792 Tested-by:
-
Christian Kuhn authored
Backport of https://review.typo3.org/c/Packages/TYPO3.CMS/+/83155 to TYPO3 v12. PHPUnit 10.5.18 introduces deprecation warning due to use of non-matching parameter names with data providers, introduced by https://github.com/sebastianbergmann/phpunit/pull/5812. This patch backports changes that were made for PHPUnit v11 support, which also addresses these kind of deprecation warnings too. Resolves: #103634 Related: #103222 Releases: 12.4 Change-Id: Ia9a1f7c5d62894dc80b3d1f9b465fb488b3250fc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83788 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
- Apr 13, 2024
-
-
Jasmina Ließmann authored
The patch for #103615 added `resname` attributes to EXT:dashboard locallang files. An attribute was used twice, this is hereby corrected. Resolves: #103620 Related: #103615 Releases: main, 12.4 Change-Id: I4d813f29db0d64f486c1d5593bc8c2b955a8eafb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83761 Reviewed-by:
-
- Apr 12, 2024
-
-
Andreas Kienast authored
The patch for #103615 added `resname` attributes to EXT:dashboard locallang files, but one had a typo. It's fixed now. Resolves: #103616 Related: #103615 Releases: main, 12.4 Change-Id: I2e2ab733e5b7186193cd4f8482b4ff6c0a6e0b28 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83760 Tested-by:
-
Andreas Kienast authored
Resolves: #103615 Releases: main, 12.4, 11.5 Change-Id: I11f609625051f7dc6418596229bed49f282bc842 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83758 Tested-by:
-
Georg Ringer authored
`DateTimeImmutable::setTimestamp()` requires the timestamp to be an integer. Resolves: #103588 Related: #99627 Related: #98045 Releases: main, 12.4, 11.5 Change-Id: I2dba1b3836063872fa04ea38d58b5bd499a8f7d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83756 Tested-by:
-
Christian Kuhn authored
New version phpdocumentor/reflection-docblock:5.4.0 changed the signature of DocBlockFactory::createInstance(), which now points out a misuse in extbase. The patch changes the instantiation and avoids calling registerTagHandler() since this can and should be hand over to createInstance() directly. Resolves: #103614 Releases: main, 12.4 Change-Id: I344ef7df23dedd950c2775fe2fab93f7bb808786 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83751 Tested-by:
-
- Apr 11, 2024
-
-
Stefan Bürk authored
Test covering the SQL file parser has been streamlined and enriched with #103602, adding a disabled test with a todo to enable it when the SuT is fixed. Turns out the parser already handles the case well, the patch just enables the test. Resolves: #103605 Related: #103602 Releases: main, 12.4 Change-Id: I4b39dce5265c2504a9dc5f11a70dfe94702d0451 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83754 Tested-by:
-
Stefan Bürk authored
* Add variable names as dataprovider set array keys to increase readability. * Add dataset for double-quote parsing in default values. * Add a disabled dataset for single-quote parsing in default values with todo to enable it with the bugfix. Resolves: #103602 Releases: main, 12.4 Change-Id: Ie85deff13598238fc437f6781b6ccf8349801846 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83753 Reviewed-by:
-
Christian Kuhn authored
RootlineUtility uses RelationHandler to resolve relations attached to pages. The tests from #103598 show that relations which are set to deleted ("delete placeholder", t3ver_state=2) are not considered and still part of the result set. The patch adds a missing call to prevent these. Resolves: #103599 Related: #103598 Releases: main, 12.4 Change-Id: Ie580e4d9b64c477d8c9d6d4092114c18f43a2a70 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83739 Reviewed-by: -
Christian Kuhn authored
* Increase abstraction in imported CSV fixture to separate scenarios from each other. * Turn single tests into a single test powered by a data provider. * Add tests for pages['media'] relation resolving. * Point out a bug related to a deleted workspace relation. Resolves: #103598 Related: #103566 Releases: main, 12.4 Change-Id: I679534f1837a4dc73e1d875bf5ee26f45566889d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83736 Tested-by:
-
Andreas Kienast authored
This commit updates ckeditor to 41.3. See changelog at [1]. Executed commands: npm install --save \ @ckeditor/ckeditor5-alignment@^41.3.0 \ @ckeditor/ckeditor5-autoformat@^41.3.0 \ @ckeditor/ckeditor5-basic-styles@^41.3.0 \ @ckeditor/ckeditor5-block-quote@^41.3.0 \ @ckeditor/ckeditor5-clipboard@^41.3.0 \ @ckeditor/ckeditor5-code-block@^41.3.0 \ @ckeditor/ckeditor5-core@^41.3.0 \ @ckeditor/ckeditor5-editor-classic@^41.3.0 \ @ckeditor/ckeditor5-engine@^41.3.0 \ @ckeditor/ckeditor5-essentials@^41.3.0 \ @ckeditor/ckeditor5-find-and-replace@^41.3.0 \ @ckeditor/ckeditor5-font@^41.3.0 \ @ckeditor/ckeditor5-heading@^41.3.0 \ @ckeditor/ckeditor5-horizontal-line@^41.3.0 \ @ckeditor/ckeditor5-html-support@^41.3.0 \ @ckeditor/ckeditor5-indent@^41.3.0 \ @ckeditor/ckeditor5-link@^41.3.0 \ @ckeditor/ckeditor5-list@^41.3.0 \ @ckeditor/ckeditor5-paragraph@^41.3.0 \ @ckeditor/ckeditor5-paste-from-office@^41.3.0 \ @ckeditor/ckeditor5-remove-format@^41.3.0 \ @ckeditor/ckeditor5-show-blocks@^41.3.0 \ @ckeditor/ckeditor5-source-editing@^41.3.0 \ @ckeditor/ckeditor5-special-characters@^41.3.0 \ @ckeditor/ckeditor5-style@^41.3.0 \ @ckeditor/ckeditor5-table@^41.3.0 \ @ckeditor/ckeditor5-theme-lark@^41.3.0 \ @ckeditor/ckeditor5-ui@^41.3.0 \ @ckeditor/ckeditor5-undo@^41.3.0 \ @ckeditor/ckeditor5-utils@^41.3.0 \ @ckeditor/ckeditor5-word-count@^41.3.0 npm run build [1] https://github.com/ckeditor/ckeditor5/releases/tag/v41.3.0 Resolves: #103589 Releases: main, 12.4 Change-Id: Id24aac98727af0d0b9284e68dd8c4a4e138a6c15 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83737 Tested-by:
-
- Apr 10, 2024
-
-
Jasmina Ließmann authored
If no page has been selected in the "Indexing" backend module, an information is displayed. This text is now displayed in the typical infobox style instead of as a heading. Resolves: #103590 Releases: main, 12.4 Change-Id: I6e44c5ad8502eb7ecb71581cb11084543c3e13aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83752 Tested-by:
-
