- Jun 13, 2023
-
-
Thomas Hohn authored
Removed public methods: * \TYPO3\CMS\Backend\Utility\BackendUtility::getRecordToolTip Resolves: #101025 Related: #100963 Related: #100459 Releases: main Change-Id: I625050dbf06b76847de30883e0a0c164207efdd4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79310 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Nikita Hovratov authored
The core utility class ResourceUtility is a leftover from an old FAL implementation. In a refactoring in TYPO3 v7 this class was replaced with a direct implementation and has not been used in the core ever since. Resolves: #101024 Related: #97576 Related: #100963 Releases: main Change-Id: Ic2a3d74caca888e0ff50fe4f3b243f0a9b5e4cf3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79308 Tested-by:
Thomas Hohn <tho@gyldendal.dk> Tested-by:
-
Christian Kuhn authored
\TYPO3\CMS\Core\Utility\GeneralUtility->_GET \TYPO3\CMS\Core\Utility\GeneralUtility->_GP \TYPO3\CMS\Core\Utility\GeneralUtility->_GPmerged \TYPO3\CMS\Core\Utility\GeneralUtility->_POST Resolves: #101011 Related: #100963 Related: #100053 Related: #99615 Related: #100596 Related: #99633 Releases: main Change-Id: I16eae6358dba6d03407d0c6e5daf84a41742d9b0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79273 Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Christian Kuhn authored
A second patch with condition matcher details will follow, this one removes the old matcher classes. Resolves: #101020 Related: #100963 Related: #100047 Related: #100237 Releases: main Change-Id: Ib1fa6c2a4878dc07cf94ee45036b1aef6452cde2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79304 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Oliver Bartsch authored
Resolves: #101021 Related: #100963 Related: #99592 Releases: main Change-Id: I79cf6f1c786e472ea2b8b4a0b62669c4b6eadf54 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79305 Tested-by:
-
Oliver Bartsch authored
Resolves: #101014 Related: #100963 Related: #97201 Releases: main Change-Id: I3effb26b3c775fdf03a160382d6c7d6527d95a84 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79297 Tested-by:
-
Oliver Bartsch authored
Resolves: #101019 Related: #100963 Related: #97271 Releases: main Change-Id: Ib3a2966eaab0b252a8d7096c49d441b7de66f5a3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79303 Tested-by:
-
Christian Kuhn authored
TYPO3\CMS\Core\Utility\GeneralUtility::linkThisScript Resolves: #101018 Related: #100963 Related: #100584 Releases: main Change-Id: Id8fd44c381372707a0a6009e0b7db7df96b34221 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79302 Reviewed-by:
-
Oliver Bartsch authored
Resolves: #101015 Related: #100963 Related: #97217 Releases: main Change-Id: I501a61cabed41d94e8d7d136d86788d2c0945bb5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79298 Reviewed-by:
-
Oliver Bartsch authored
Resolves: #101016 Related: #100963 Related: #97231 Releases: main Change-Id: I6d4ff99abca1d0bbb11de57ed56b67eb9bf431d5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79299 Tested-by:
-
Benni Mack authored
Removed methods: * \TYPO3\CMS\Backend\Utility\BackendUtility::getThumbnailUrl * \TYPO3\CMS\Backend\Utility\BackendUtility::ADMCMD_previewCmds * \TYPO3\CMS\Backend\Utility\BackendUtility::getPreviewUrl * \TYPO3\CMS\Backend\Utility\BackendUtility::getLinkToDataHandlerAction * \TYPO3\CMS\Core\Domain\Repository\PageRepository->getExtURL Hooks: * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_befunc.php']['viewOnClickClass'] Resolves: #101010 Related: #100963 Related: #100597 Related: #97544 Related: #99558 Releases: main Change-Id: I96d2f4e1006ca0f741f17d977aac779f767f1127 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79272 Tested-by:
-
Thomas Hohn authored
Removed public methods: * \TYPO3\CMS\Core\FormProtection\FormProtectionFactory->get * \TYPO3\CMS\Core\FormProtection\FormProtectionFactory->purgeInstances Resolves: #101013 Related: #100963 Related: #99098 Releases: main Change-Id: I5b8b9a82382c0326271d25c763bb2ba52cf78441 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79300 Tested-by:
-
Benni Mack authored
Removed interfaces: * TYPO3\CMS\Frontend\ContentObject\Menu\AbstractMenuFilterPagesHookInterface * TYPO3\CMS\Frontend\ContentObject\TypolinkModifyLinkConfigForPageLinksHookInterface * TYPO3\CMS\Frontend\Http\UrlProcessorInterface Removed class alias: * TYPO3\CMS\Frontend\Typolink\LinkResultFactory Removed public properties: * TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer->lastTypoLinkUrl * TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer->lastTypoLinkTarget * TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer->lastTypoLinkLD Removed public methods: * TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer->getMailTo * TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer->getTreeList * TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer->getATagParams * TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer->getTypoLink * TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer->getTypoLink_URL * TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer->getUrlToCurrentLocation * TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer->getQueryArguments * TYPO3\CMS\Frontend\Typolink\LinkResultFactory->createFromUriString Resolves: #101006 Related: #100963 Related: #92508 Related: #87616 Related: #96641 Related: #96500 Related: #97027 Related: #96641 Related: #98488 Related: #97536 Related: #97549 Releases: main Change-Id: I02fcabba4c9a95adfdf36e07f710fd278f243818 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79269 Reviewed-by:
-
Oliver Bartsch authored
Resolves: #101007 Related: #100963 Related: #96733 Releases: main Change-Id: Ic1ac42873708a5bef91ab994c0e6f1c30adc74fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79268 Reviewed-by:
-
Christian Kuhn authored
Resolves: #101008 Related: #100963 Related: #100622 Releases: main Change-Id: Ib7c9c4c812622b4792ce947d0c9e2205202b5801 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79270 Tested-by:
-
- Jun 12, 2023
-
-
Christian Kuhn authored
Resolves: #101009 Related: #100963 Related: #100335 Releases: main Change-Id: I6400ec35c0140ab238c895bf604048bbc642b4eb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79271 Tested-by:
-
Stefan Bürk authored
Values for `like` expressions should be escaping the corresponding like wildcards ($ and _). TYPO3 core provides a `escapeLikeWildcards()` in `QueryBuilder` and on the `Connection`. Under the hood, the php `addcslashes()` method is used to escape wildcards in the value before appending/prepending wildcards. It has been assumed, that `\` as escape character is always the default character throughout all database server vendors and versions - which makes `addcslashes()` the one-shot to use. It has been recently discovered, that if values in the database contains one of these wildcards, for example the underscore `_` and a like expression is built using the escape method, the row cannot be matched in all databases. This relates to the fact, that the generated like expressions do not contains the `ESCAPE` keyword to define which escape character has been used. `doctrine/dbal` has added a corresponding argument to the doctrine/dbal query ExpressionBuilder like() and notLike() method, so this can be set. TYPO3 uses a custom ExpressionBuilder, not extending the doctrine ExpressionBuilder (which will change with upcoming doctrine/dbal v4). This change always adds the `ESCAPE` keyword to like and not like expressions with the hardcoded `\` escape character - except for PostgresSQL. PostgresSQL doesn't like it when ILIKE/NOT ILIKE is used, which the ExpressionBuilder does to mimic case insensitive LIKE/NOT LIKE similar to MySql. This can be made configurable in a dedicated patch and must be done for upgrading to doctrine/dbal 4.x anyway. Resolves: #100874 Releases: main, 12.4, 11.5 Change-Id: Id7eb891ef52e8c6988a605eaadd0afcbcf5176bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79027 Tested-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
-
Benni Mack authored
- config.spamProtectEmailAddresses = ascii - config.xhtmlDoctype - config.removePageCss - plugin.*._CSS_PAGE_STYLE - config.baseURL Resolves: #100996 Related: #100963 Related: #99170 Related: #90044 Related: #99416 Related: #99050 Releases: main Change-Id: Ib6153755e211e7a80ae17abc03493a205f718748 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79259 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Christian Kuhn authored
\TYPO3\CMS\Frontend\Plugin\AbstractPlugin Resolves: #101003 Related: #100963 Related: #100639 Releases: main Change-Id: I81ec99d4b9417e726b137c4eb15e217cdf0976d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79264 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
Christian Kuhn authored
Removal of b/w code from backend view refactorings in v12. Resolves: #101004 Related: #100963 Related: #96903 Related: #96730 Related: #97787 Releases: main Change-Id: Ic1d0556d40407198c163cd91b6dca4e040bc79af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79265 Reviewed-by:
-
Thomas Hohn authored
Removed classes: * BackendWorkspaceRestriction * FrontendWorkspaceRestriction Resolves: #101000 Related: #100963 Related: #98996 Releases: main Change-Id: I70e20ec8d90e982fdc0a9b640e1a9df937189518 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79262 Tested-by:
-
Christian Kuhn authored
* \TYPO3\CMS\Backend\Utility\BackendUtility::getDropdownMenu * \TYPO3\CMS\Backend\Utility\BackendUtility::getFuncCheck * \TYPO3\CMS\Backend\Utility\BackendUtility::getFuncMenu Resolves: #101002 Related: #100963 Related: #99519 Related: #99564 Related: #99579 Releases: main Change-Id: I37996c66d615643d3510093bea55d612de5d98f2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79263 Tested-by:
-
Christian Kuhn authored
Remove old TypoScriptParser, TemplateService and supporting classes. Resolves: #100998 Related: #100963 Related: #99075 Related: #97816 Related: #98503 Related: #99120 Releases: main Change-Id: Ide8a1d7c7a505cd13f9a87149f71d7985ecd1f40 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79261 Reviewed-by:
-
Thomas Hohn authored
Removed public methods: * Environment::getBackendPath Resolves: #100997 Relates: #100963 Releates: #99638 Releases: main Change-Id: I1a23c314f660b74836c0858e190c48090f195e62 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79260 Reviewed-by:
-
Benni Mack authored
Removed public properties: * TypoScriptFrontendController->intTarget * TypoScriptFrontendController->extTarget * TypoScriptFrontendController->fileTarget * TypoScriptFrontendController->spamProtectEmailAddresses * TypoScriptFrontendController->baseUrl * TypoScriptFrontendController->xhtmlDoctype * TypoScriptFrontendController->xhtmlVersion Changed visibility from public to protected: * TypoScriptFrontendController->type Removed public methods: * TypoScriptFrontendController->initUserGroups() * TypoScriptFrontendController->isUserOrGroupSet() * TypoScriptFrontendController->isBackendUserLoggedIn() * TypoScriptFrontendController->checkEnableFields() * TypoScriptFrontendController->baseUrlWrap() * TypoScriptFrontendController->doWorkspacePreview() * TypoScriptFrontendController->whichWorkspace() Resolves: #100994 Related: #100963 Related: #99416 Related: #97866 Related: #100405 Related: #96996 Related: #97531 Related: #99170 Releases: main Change-Id: I4ce4f5a57648e7ec22e88ab9bff1dfac294d1dca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79256 Tested-by:
-
Stefan Bürk authored
PHP8.3 changed return type for `\ArrayObject::asort()` from `bool` to `true` and will trigger a `E_DEPRECATED` notice since PHP8.3 for extending classes with incompatible signature. Regarding the documentation the return type changed in PHP8.2.0 already. It's not really clear why this has not been detected earlier. The documentation [1] states that this should have changed with PHP 8.2.0. However, the PHP 8.2 based testing we have in place did not pick that up yet. Further investigation show, that the corresponding change on the PHP source repository is only available on master and for the `PHP8.3.0alpha1` tag [2][3]. With that change the stub file and the argument information header file for this and other methods changed. The PHP source change targets more return types, but we did not hit yet others then the one case detected through unit tests. The return type can be only be changed when PHP8.3+ is the minimum php version. Therefore, we add the known attribute `#[\ReturnTypeWillChange]` to the method along with a a comment to change this when requirements are fullfilled. TYPO3 11.5 already have this attribute, so this issue occurs only with TYPO3 v12 and main. Reason for this is the fact, that with #98035 that attribute has been resolved by using compatible return types at that moment. This can be checked by executing unit tests with PHP8.3 with and without this change. Use-full command: > Build/Scripts/runTests.sh -p 8.3 -s unit [1] https://www.php.net/manual/en/arrayobject.asort.php#refsect1-arrayobject.asort-changelog [2] https://github.com/php/php-src/commit/85338569debd3f669ef5bc793822b2d9f3f1b1ea [3] https://github.com/php/php-src/pull/11200 Resolves: #100992 Related: #98035 Releases: main, 12.4 Change-Id: Ic3b8cacdcf387a2d23eaeaf66222de6078d54f2d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79251 Reviewed-by:
Elias Häußler <e.haeussler@familie-redlich.de> Tested-by:
-
Georg Ringer authored
Frontend and listing in the backend module allow form definitions within subdirectories but editing a definition throws an exception because of a too strict comparison. Resolves: #100892 Releases: main, 12.4, 11.5 Change-Id: Ib76ce20535286b7830183111af628c686d4b0506 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79062 Tested-by:
-
Simon Schaufelberger authored
Releases: main, 12.4, 11.5 Resolves: #100982 Change-Id: I3cfe29c8a3a3215c8a284681738b5bed152db14d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79244 Tested-by:
-
- Jun 11, 2023
-
-
Thomas Hohn authored
Speed up the SysLogSerializationUpdate migration wizard for trivial cases like a:0:{} and a:1:{i:0;s:0:"";}. Resolves: #100932 Releases: main, 12.4 Change-Id: I6dd35036f18778a1dac012362dbf6ee4fa614703 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79245 Tested-by:Markus Klein <markus.klein@typo3.org> Tested-by:
-
Nikita Hovratov authored
This fixes a possible call to the getReadablePath method on InaccessibleFolder by checking, whether the instance is of type Folder. Resolves: #100991 Releases: main, 12.4 Change-Id: I8161168c9d8facb314253cba5893e4296e76282b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79250 Tested-by:
-
Oliver Bartsch authored
Kickstart the deprecation removal .rst file with boilerplate entries. Resolves: #100963 Releases: main Change-Id: I81b51f3bf718bb19985972a47a0d133eee0ad7f3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79201 Tested-by:
-
Sybille Peters authored
A database query was executed when creating a scheduler task which fetched all optimizable tables. This was executed with the wrong type in createNamedParameter (string instead of string array) and resulted in exception in some scenarios (with MySQL, with additional table mappings). The problem is now fixed. Resolves: #100979 Releases: main, 12.4, 11.5 Change-Id: Id5119b9fb07c68baf33fdf4f48e584fec0284455 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79243 Tested-by:
-
- Jun 10, 2023
-
-
Helmut Hummel authored
Using the core cache for schema information comes with various drawbacks: 1. There is no way to flush single core cache entries, thus the complete core cache needs to be flushed when changing the database schema. 2. The PHP Frontend provides no benefit, when the to be cached information has to be serialized anyway. Therefore, a new cache is introduced that can be flushed individually after schema updates. Flushing the cache is now also moved altogether to SchemaMigrator, in order to avoid flushing the cache multiple times for multiple connections. For flushing the individual cache, the internal Bootstrap::createCache factory is used, which ensures a cache backend, which is not set to null backend, which happens with late boot methodology in install tool and replaces the previously used ClearCacheService, which is only meant to be used to flush all caches and boots the system for that. With doing so, the previously introduced argument to not boot the system can be removed again. As drive by change the SysLogChannel update is renovated a bit to not use deprecated Doctrine DBAL API. Releases: main, 12.4 Resolves: #100925 Change-Id: I0193501fec5d41edfcb65f07faefe30985629818 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79148 Reviewed-by:
-
- Jun 09, 2023
-
-
Stefan Bürk authored
This change adds basic support for PHP8.3 to `Build/Scripts/runTests.sh`. That is done to get an early chance to evaluate how the core is behaving against the upcoming PHP version. Note, no ci runs added for now. First current existing issues should be fixed first to make tests green before enabling it for CI runs. Resolves: #100984 Releases: main, 12.4, 11.5 Change-Id: Icefa0a83f860672ff0d688acb1968185e0bc3053 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79246 Tested-by:
-
Nikita Hovratov authored
Branching in `typo3/cms-styleguide` have been done some time after the core branched versions. That led to an invalid state in composer.json/lock and further issues, for example when using the composer lock file update command: `composer update --lock` This now leads to weird constellations. Therefore, we now require the correct version of styleguide to break that invalid cycle and have correct version in the `composer.json` and `composer.lock` files. Used command(s): > composer require --dev "typo3/cms-styleguide":"~13.0@dev" Resolves: #100989 Related: #96157 Releases: main Change-Id: I2eb768ba3a7e7a21762bf76c58c4bef3bafeadd3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79247 Tested-by:
-
- Jun 08, 2023
-
-
Johannes Sommer authored
Forwards the main template variables to the `HeaderAssets` and `FooterAssets` sections. Releases: main, 12.4 Resolves: #100879 Change-Id: I5336eb06b833d98e1605d1cb190b8be0a32c6aa5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79031 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Lina Wolf authored
Releases: main Resolves: #100875 Change-Id: Icf4f3bb92f3ab59de6a1790d3cd0925af42b5463 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79028 Tested-by:
-
Stefan Froemken authored
In CKEditor 4 the option "removeButtons" can also be a comma separated list of strings. CKEditor5Migrator now respects the old string value and converts it to an array before migrating the value. Resolves: #100826 Releases: main, 12.4 Change-Id: Id6da8ea7daad70c2dc1690b44e26e383e9d7d180 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78960 Tested-by:
-
Anja Leichsenring authored
Doctrine 4 will no longer provide access to SQL query parts, so we need to adjust our internal usages to cope with this change. The strategy by rule of thumb involves to not reuse queryBuilder instances, so no reset must happen anyway. Resolves: #100914 Releases: main Change-Id: Iac7232fa49f77eb27514a86350cf536e701ee9e5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79138 Tested-by:
-
Anja Leichsenring authored
Doctrine 4 will no longer provide access to SQL query parts, so we need to adjust our internal usages to cope with this change. The strategy by rule of thumb involves to not reuse queryBuilder instances, so no reset must happen anyway. Resolves: #100913 Releases: main Change-Id: I663f1701eef78b4804cd800fdc131e2b1709ad64 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79137 Tested-by:
-
