- Jul 29, 2024
-
-
Thomas Hohn authored
In the RestoreRegisterContentObject::render method a call to array_pop is performed. The result is assigned to the variable $frontendController->register which has type array. However array_pop can return null, this patch add's a null coalesce operator to ensure that correct type. Resolves: #104495 Releases: main, 12.4, 11.5 Change-Id: I46efce10e4322ff3cd39b5a0eeafd1f768644e38 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85404 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Astrid Haubold authored
These tests verify current l10n_mode=exclude behaviour for inline children of content elements. Resolves: #104489 Releases: main Change-Id: I28d238ca395858baf61ed0d16e9e30c50f3b2c95 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83496 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Eric Harrer <info@eric-harrer.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
André Buchmann <andy.schliesser@gmail.com> Reviewed-by:
Eric Harrer <info@eric-harrer.de> Reviewed-by:
André Buchmann <andy.schliesser@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- Jul 26, 2024
-
-
Christian Kuhn authored
PHP 8.4 support requires new guzzle versions. v13 sets requirements to PHP 8.4 compatible guzzle libraries versions, so v13 can not ship with libraries lower than that. This drops guzzle/promises v1 support, which has been re-added to v12 for backwards compatible reasons, and v13 inherited this. It should be fair to drop guzzle/promises v1 in v13 now. v12 and v11 will only "composer u" to the versions below, but not require them, so non-composer releases will package compatible library versions, while composer instances have the option to update when needed. > composer req guzzlehttp/guzzle:^7.9.2 guzzlehttp/promises:^2.0.3 guzzlehttp/psr7:^2.7.0 > composer req -d typo3/sysext/core --no-update guzzlehttp/guzzle:^7.9.2 > composer req -d typo3/sysext/core --no-update guzzlehttp/psr7:^2.7.0 > composer req -d typo3/sysext/install guzzlehttp/promises:^2.0.3 Resolves: #104488 Releases: main, 12.4, 11.5 Change-Id: I43a4e56f9fbb3bb00d77eb198161350e72a51da4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85393 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
Brings PHP 8.4 fixes. "composer req" in v13, "composer u" in v12 and v11. > composer req typo3/html-sanitizer:^2.2.0 > composer req -d typo3/sysext/core --no-update typo3/html-sanitizer:^2.2.0 Resolves: #104483 Releases: main, 12.4, 11.5 Change-Id: I3c5dfb7eb1b76bc13ef0d784e87138360bfbdd61 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85388 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Stefan Bürk authored
In some cases more complex database queries needs to be constructed to archieve a dedicated goal. This includes the ability to use conditional based statements. This change adds a cross database vendor compatible `if()` expression method to the TYPO3 ExpressionBuilder to support conditional based statement in database queries. Resolves: #104482 Related: #103309 Releases: main Change-Id: I1085ba2f7bb3a3faca1ceef88d8813834e3b0c28 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85372 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
- Jul 25, 2024
-
-
Christian Kuhn authored
This final class can declared readonly without further impact. Resolves: #104481 Releases: main Change-Id: I380460c25636b728d1d51bbef98bd9fb8211bd99 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85386 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
Stefan Bürk authored
This change raises the core-testing-php84 image version to use PHP 8.4.0 alpha2. [1] https://git.typo3.org/typo3/CI/testing-infrastructure/-/commit/abd0b88dd70d0053359b08584d66df17540f177d Resolves: #104480 Releases: main, 12.4, 11.5 Change-Id: Ife69d5fdb82f4243547fab5998b4a1ba0123bafc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85385 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
Christian Kuhn authored
Youngest patch levels add a finding. Fit it codewise and raise. > composer req --dev phpstan/phpstan:^1.11.8 Resolves: #104478 Releases: main, 12.4 Change-Id: I21830f4a36094dd6c279715a0571a2f2ad911afa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85382 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Garvin Hicking authored
In #102557 additional sprintf() placeholders were added, but were missing to be introduced to `DataStructureIdentifierListener`. This change propagates the needed identifier to the output, too. Resolves: #104433 Related: #102557 Releases: main, 12.4 Change-Id: Idb4f3f37f8fb347d77f3ca0038962a7280291930 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85344 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Spoo <mail@christian-spoo.info> Tested-by:
Christian Spoo <mail@christian-spoo.info>
-
Christian Kuhn authored
phpstan "bleeding edge config" enables a feature that reduces memory usage significantly. We don't switch to "bleeding edge" per se, but enable that single toggle for now. phpstan does not do this by default since it may be breaking for existing rules, which is not a problem in our case. > rm -rf .cache/phpstan/; Build/Scripts/runTests.sh -s phpstan Before locally: 10.99 GB After locally: 5.82 GB Before CI: 15.15 GB After CI: 9.49 GB Numbers vary depending mainly on available number of CPUs: My local machine has less CPUs than CI - we *may* tune phpstan a bit further in this area, later. Resolves: #104476 Related: #104475 Releases: main, 12.4, 11.5 Change-Id: I32ca9a36b752ad52e8ac5fd433c3f929f86843af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85375 Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Benni Mack authored
Resolves: #104396 Releases: main, 12.4 Change-Id: I28404ae44961918f372dd3b3c8e8de4e138e09c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85345 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Hannes Lau <office@hanneslau.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Hannes Lau <office@hanneslau.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Christian Kuhn authored
Extbase has some code within ExtbaseRequestParameters ->getControllerActionName() that fetches all methods from the given controller class to see if the previously set action name is in there. The comparison includes some case insensitivity magic and in the end tries to return an action name which is cased exactly as the method within the controller. This code has been added to flow3 back in 2010 and was back ported to extbase around that time. It was however never relevant in extbase: The extbase RequestBuilder has an earlier step where it compares the requested action with the list of allowed registered actions (via ConfigurationManager) and throws an exception if there is no (case sensitive!) match. The simplifies getControllerActionName() by removing this obsolete code. Resolves: #104472 Related: #104471 Releases: main Change-Id: I3219fb257923c298ac38393c53949af82e11ed19 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85347 Tested-by:
Simon Praetorius <simon@praetorius.me> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Simon Praetorius <simon@praetorius.me> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Benni Mack <benni@typo3.org>
-
Christian Kuhn authored
FluidTemplateContentObject has some magic to adapt the given request *if* the request is an extbase request already. This code is relatively obviously obsolete: Only extbase bootstrap creates extbase requests (and actually, the code *below* the lines changed by this patch in FluidTemplateContentObject, those will see a separate deprecation or removal patch, soon). So, when FluidTemplateContentObject is called for whatever reason with an extbase request, it has been created by a proper extbase bootstrap call, wich created a "correct" extbase request already. There is no need to tamper with this in FluidTemplateContentObject again. Note this wasn't the case with earlier TYPO3 versions where extbase requests were created within StandaloneView, a misuse we got rid off in v12. The patch removes these extbase request manipulations from FluidTemplateContentObject. Resolves: #104473 Related: #104472 Related: #104471 Related: #98377 Releases: main Change-Id: Id4fc202f140fe270e35259251ed052752c2c6ed0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85348 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Simon Praetorius <simon@praetorius.me> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Simon Praetorius <simon@praetorius.me> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
RenderingContext is *the* state object in fluid. Fluid was always bound to extbase. There was quite some magic between the two: For instance, when extbase calls action "myDetailAction" on "ListController", fluid looks for template "List/MyDetail.html". Fluid derived this from the old extbase request - A request implementation that existed before PSR-7 handling has been introduced to the core. With TYPO3 v11, the extbase request has been turned into a decorator of the PSR-7 object, and fluid has been changed to deal with a standard PSR-7 request. But lots of the fluid related magic tailored to the extbase request remained. Some blockers to relax this have been removed already, most notably the extbase ControllerContext vanished, and the StandaloneView no longer creates an extbase request in its constructor. We can now go a step further: The RenderingContext creates new requests when setControllerAction() and setControllerName(), even cross-triggered when setRequest() is called. This is insane: A rendering engine must never manipulate request itself, but must expect a proper request to hand over by the application. $controllerName and $controllerAction are still important within fluid - it still derives the template files from it if no direct template file is given. But there is no reason to also change the request. All this functionality is bound to the extbase request only. Extbase bootstrap *does* create a proper extbase request already. It can just be hand over as is. setControllerAction() and setControllerName() can be called by extbase abstract ActionController to init fluid properly, reading the values from extbase request itself. Magic within RenderingContext is no longer needed. Resolves: #104471 Related: #96183 Related: #98377 Releases: main Change-Id: I2090230cc37870c0f2a7107ca2af6370ab786175 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85346 Reviewed-by:
Simon Praetorius <simon@praetorius.me> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Simon Praetorius <simon@praetorius.me>
-
Markus Klein authored
* ext:form is FE an extbase plugin and operates with an extbase request created by extbase bootstrap (or by FluidTemplateContentObject, but that's a different story). * ConfirmationFinisher has option 'contentElementUid', which - when set - creates a ContentObjectRenderer to render specific content elements. * ContentObjectRenderer then often renders this content element using FluidTemplateContentObject. Various code within Fluid rendering then applies magic to create new requests, *if* an extbase request is given. This can lead to broken template resolving when rendering in FluidTemplateContentObject. This entire thing is quite messy. We're taking measures to resolve the underlying flaws in v13. To fix the situation in v12, the idea is like that: When ConfirmationFinisher calls ContentObjectRenderer and hands over its request, it should "free" that request from its own extbase context to not trigger pollution by code that does things if an extbase request is given. Note this was not an issue in v11 since only v12 started handing over the extbase request to ContentObjectRenderer, in v11 it was indirectly pulled from $GLOBALS['TYPO3_REQUEST'] within ContentObjectRenderer, which is the "original" request before it is turned into an extbase request by extbase plugin bootstrap. Resolves: #104462 Related: #100623 Related: #104472 Related: #104471 Related: #104473 Releases: main, 12.4 Change-Id: Id53bc9f159dc2575a8bedb63cd7e7a039864f92b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85336 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Simon Praetorius <simon@praetorius.me> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Simon Praetorius <simon@praetorius.me>
-
Anja Leichsenring authored
The was a wrong accumulation in place that made the checker report success while the output clearly stated exceptionCodeChecker found issues. Accumulation and final status report were fixed to properly report the checker failing in this case. Resolves: #104474 Releases: main Change-Id: I6c620a3509685797e2baf7f20da96f270c833455 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85350 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
core-ci <typo3@b13.com>
-
Christian Kuhn authored
phpstan can be very memory hungry. Option --verbose adds a line about 'peak memory' usage to the output. Add this to get a better feeling of the memory usage. Resolves: #104475 Releases: main, 12.4, 11.5 Change-Id: I3fdaf7ddee7e003e7a8e75a508dd69161c804c8d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85351 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
Oliver Bartsch <bo@cedev.de>
-
- Jul 24, 2024
-
-
Martin Adler authored
This patch seeks to further eliminate the usage of 'GU:makeInstance' for stateless services in the styleguide's 'TcaDataGenerator'. Resolves: #104458 Releases: main Change-Id: Ib227afffe40ccdf16b00adb1d357554226322637 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85328 Tested-by:
core-ci <typo3@b13.com> Tested-by:
André Buchmann <andy.schliesser@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
André Buchmann <andy.schliesser@gmail.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
Jasmina Ließmann authored
This patch standardizes the appearance of the cards in the "Reports overview" view with those from the "About" module and the "Admin Tools" area. Since this was the last occurrence where a card was used directly as a link, the corresponding CSS settings are also removed. Resolves: #104465 Releases: main Change-Id: I17800d9125d5f59053e82022d7d2d90eb6b75b98 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85340 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
Jasmina Ließmann authored
The new markup for examples, previously introduced on the Avatar component page, has been rolled out to all example pages within the "Styleguide" backend module. The component pages, as well as the styles pages, are expanded to include more application examples and color scheme examples. In this context the CodeViewHelper has been split into three individual ViewHelpers to make functionalities clearer. Resolves: #104464 Related: #104371 Releases: main Change-Id: I581e60b06eb0e9494895917495c3214fc014d0b4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85285 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com>
-
Christian Kuhn authored
$request is hand around already. There is no reason to assign it to $this. Resolves: #104467 Releases: main Change-Id: I27ab48eaafaec3f78f98ff627034f19a8ad33fb6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85342 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Andreas Nedbal <andy@pixelde.su> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Georg Ringer authored
Resolves: #99197 Releases: main, 12.4 Change-Id: I9ac78c5a7ef29f0390dbe7d5dd0004472382eea8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76827 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
Jasmina Ließmann authored
This patch ensures that all detail action views in the "Reports" backend module use a unique h1. In addition, the detail action view content now takes up the entire content width. Resolves: #104466 Releases: main Change-Id: I460c7c59af296785f32d5e9c4e6f5ec58e690a2f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85341 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Jasmina Ließmann authored
The report table contains broken links that exist in the system depending on the configuration. The information about these broken links can be varied and the previous view already provided essential information. With this patch the view has been expanded and the UX has been improved. Information about the link text, (location) path in the page tree and the record field that contains the broken link have been moved to a modal so that the table only contains the relevant information and further information can be viewed in the modal. The new modal is divided into an area with information about the link properties and an area with extensive information about the record itself. Furthermore a column has been added to the table that shows the language of the record that contains the broken link. Previously, the record icon was simply the standard icon of the table, now the actual record type is taken into account as the icon. A sorting function has also been added to the table with which the columns can be sorted alphabetically in ascending/descending order. Resolves: #104323 Releases: main Change-Id: Id7279080c8f851c1b8cb7d45f4e0116fa6a1fc49 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85088 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Garvin Hicking <gh@faktor-e.de>
-
Hannes Lau authored
TYPO3 v12 added a new ViewInterface to ext:core that allows implementing *any* view as long as it sticks to this interface. This interface has been put into use for all backend modules, combined with a factory that allows to set custom stuff per module. Extbase however has not been touched: Extbase is still tailored towards ext:fluid and Fluid standalone. The patch changes this by adapting the Extbase related views towards ext:core ViewInterface. This allows implementing "own" views not depending on Fluid standalone. The patch has to hop through quite some loops to allow this: ext:core FluidViewAdapter is a class implemented in v12 that is a facade between core views and Fluid. Unfortunatly, extbase uses some "specialities" like "renderPartial()" from Fluid, which ext:core ViewInterface does not implement. We can not get rid of those within extbase any time soon. As such, FluidViewAdapter now implements all the nasty details that Fluid provides: FluidViewAdapter is now the main class between extbase and Fluid views - it implements both the Fluid view interface, plus ext:core ViewInterface. FluidViewAdapter in itself is rather simple: It only holds the Fluid view instance. Historically, many further operations were possible on Fluid view classes, those were only wrappers around RenderingContext, though. To keep backwards compatibility, FluidViewAdapter now re-implements all these methods, but deprecates them. In addition to ext:core ViewInterface, FluidViewAdapter will continue to implement getRenderingContext(), setRenderingContext() (probably), renderSection() and renderPartial(). All other methods that are wrappers around details of RenderingContext are marked @deprecatded. Systems that need to work with details of Fluid, now need to test for an instance of FluidViewAdapter to manipulate setRenderingContext if needed. This strategy will allow us to phase out ext:fluid StandaloneView and ext:fluid TemplateView with further patches, which will further simplify the layer towards Fluid standalone. Within Extabse, the main view interface is now ext:core ViewInterface, which free's the dependency to Fluid. JsonView is now the primary example for a view that has no relation to Fluid anymore. TYPO3 v14 can continue with hardening various type hints related to views, those have been marked accordingly. Note the handling related to ServerRequestInterface will see some additional patches in this area as well. Resolves: #101559 Related: #96730 Related: #104463 Releases: main Change-Id: I4be3e6be191b8bce599523a1055fc6136a86a879 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80329 Tested-by:
Simon Praetorius <simon@praetorius.me> Reviewed-by:
Simon Praetorius <simon@praetorius.me> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Hannes Lau <office@hanneslau.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Jul 23, 2024
-
-
Lina Wolf authored
So that they can be properly linked in api.typo3.org and IDEs. Releases: main, 12.4 Resolves: #104439 Change-Id: Id01abd68ec8f8238a70aa900a17fd33917ffd67e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85309 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Chris Müller <typo3@brotkrueml.dev> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com>
-
Christian Kuhn authored
> composer req typo3fluid/fluid:^2.14.0 > composer req -d typo3/sysext/adminpanel --no-update typo3fluid/fluid:^2.14.0 > composer req -d typo3/sysext/core --no-update typo3fluid/fluid:^2.14.0 > composer req -d typo3/sysext/fluid --no-update typo3fluid/fluid:^2.14.0 > composer req -d typo3/sysext/redirects --no-update typo3fluid/fluid:^2.14.0 Notable changes: * Obsoletes VH overrideArgument() by allowing registerArgument() to override existing arguments without throwing an exception. * Fully b/w compatible changes to ViewInterface * New soft-deprecations in AbstractTemplateView Resolves: #104463 Releases: main Change-Id: I844bc31dc0ffa96ea337fcc207544b9cc45f4694 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85338 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Simon Praetorius <simon@praetorius.me> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Simon Praetorius <simon@praetorius.me> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Georg Ringer authored
Provide a new type of static routes `assets` to expose assets shipped by extensions. Resolves: #101472 Releases: main Change-Id: I46d5b8af795b1037c6a3e2554454df6a6e7174ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85268 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Garvin Hicking <gh@faktor-e.de>
-
- Jul 22, 2024
-
-
Oliver Bartsch authored
In case content elements exist in the database, having a CType for which no TCA exists, e.g. because an extension providing this CType has been deactivated, no more UndefinedSchemaException, is thrown. This allows an editor to properly handle the situation as before. Note: Such elements are displayed with an "INVALID VALUE ("INVALID_CTYPE")" badge. Resolves: #104448 Releases: main Change-Id: I94cd9c42040274536730b020ae29bf9ff13bb3f4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85322 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Georg Ringer <georg.ringer@gmail.com>
-
- Jul 21, 2024
-
-
Christian Kuhn authored
Fluid standalone AbstractTemplateView has method getTemplatePaths() which is just a wrapper around the same operation on RenderingContext. This method has been marked as deprecated in Fluid standalone 2.14, and will be removed in Fluid standalone v4. The patch avoids some last usages. Note this is a pre-patch to a bigger patch that will change view handling in extbase, which will come with proper deprecation notes. Resolves: #104446 Releases: main Change-Id: I495ceac71cd998550fb930b45d8f34513e7cce3a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85318 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Simon Praetorius <simon@praetorius.me> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Simon Praetorius <simon@praetorius.me>
-
Christian Kuhn authored
There is some ancient when a DI method is called 'injectSettings': DI ignores this. There is a single use for Fluid views in extbase, which calls injectSettings if it exists manually. However no Fluid view ever implemented this method. It is removed. Also, the DI magic to not call 'injectSettings' is removed, injectSettings can now be used as casual inject* method. This is considered a bugfix (for main only): It is unexpected and undocumented this handling exists. Resolves: #104445 Releases: main Change-Id: I6eb527bea048dd856f618b4caadb7e17d4ce6ad3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85317 Reviewed-by:
Simon Praetorius <simon@praetorius.me> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Simon Praetorius <simon@praetorius.me> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- Jul 20, 2024
-
-
Christian Kuhn authored
Method registerTagAttribute() has been soft-deprecated with Fluid 2.12. The patch removed usages and documents details. Resolves: #104443 Related: #103560 Related: #104412 Releases: main Change-Id: Id1c0f6d801a2a4898afca6a24e541ee1b2a9a694 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85310 Reviewed-by:
Simon Praetorius <simon@praetorius.me> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Simon Praetorius <simon@praetorius.me>
-
Stephan Großberndt authored
The usages of `PasswordViewHelper` now render `required="required"` instead of `required="true"`. ViewHelpers that do not register "required" as an argument (e.g. `PasswordViewHelper`) pass any value since Fluid v2.12.0 (see https://github.com/TYPO3/Fluid/pull/859). ViewHelpers that register "required" as an argument (e.g. `TextfieldViewHelper`) interpret the specified value as a bool and if true always render `required="required"` and omit the attribute if false. Resolves: #104441 Related: #104436 Releases: main Change-Id: Id3bef65e36a488ab35ac367b1722e05bfa1ba106 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85311 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- Jul 19, 2024
-
-
Oliver Bartsch authored
Resolves: #104425 Releases: main Change-Id: I76dea6700d5d51a1283e6c13f84ff97dbb0bd386 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85287 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Bartsch <bo@cedev.de>
-
Garvin Hicking authored
An example colorPalette picker is utilized for the new field `tx_styleguide_elements_basic.color_palpreset`. By default all defined colors available to palettes are used as a fallback, so every colorpicker will receive these palettes now. `color_palpreset` has a limited palette to showcase both fallback and specific choice of colors. A custom page.tsconfig is added, independent from the Site Set file, to apply this to the backend. Resolves: #103994 Related: #101843 Related: #98294 Releases: main Change-Id: I18c06ddcd7938ea0b0088e3ee3b56e02a26ed3f9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84521 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
core-ci <typo3@b13.com>
-
Sandra Erbel authored
Missing definition provided and wording corrected. Releases: main, 12.4 Resolves: #104429 Change-Id: I59bca54826557e7633ce837c73df6d38cda24742 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85294 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
Lina Wolf <112@linawolf.de> Tested-by:
core-ci <typo3@b13.com>
-
Stephan Großberndt authored
With Fluid v2.12.0 using `additionalAttributes` became obsolete in `TagBasedViewhelper` (see https://github.com/TYPO3/Fluid/pull/859). Resolves: #104436 Releases: main Change-Id: Iae48db75658bdb8b48da636c7145257629577460 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85304 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Stephan Großberndt authored
Disables spell checking in the changePassword form of EXT:felogin See issue #98492 for details. Resolves: #104437 Related: #98492 Related: #98504 Releases: main, 12.4 Change-Id: I4ec8056867ac55b00a542c1527f028c234a064c3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85305 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech>
-
Stephan Großberndt authored
Resolves: #104438 Releases: main, 12.4 Change-Id: I4ef127561e45d72c03beb9db08a2a081aa59ddca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85306 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
Stephan Großberndt authored
This patch corrects the optional last step of the initial setup process "Create default backend user groups" if EXT:dashboard is not installed. This may be the case for a composer based installation. Instead of silently failing the step due to the missing column "be_groups.availableWidgets" this permission is not written to the database. Resolves: #104434 Releases: main Change-Id: I20216cb9032a36ad36a862289ba98082249b0a26 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85300 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-