- May 29, 2020
-
-
Alexander Schnitzler authored
Releases: master Resolves: #91535 Related: #91473 Change-Id: I98db08e8fef297b47bd11fed13d3fe91af3ba1cd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64382 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
- Apr 15, 2020
-
-
Alexander Schnitzler authored
This patch has been created with rector and php-cs-fixer bin/rector process --set=php53 typo3/sysext/extbase/Classes bin/rector process --set=php53 typo3/sysext/extbase/Tests Releases: master Resolves: #91047 Change-Id: Idcd1e10e5bf6dd5fa504873e450e31a980fab9db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64180 Tested-by:Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
-
Alexander Schnitzler authored
With this patch, the header comment of php files is automatically added by the php-cs-fixer, which guarantees that its format and place of occurrence remain the same in all files. Files that are copied over from other projects are excluded. Furthermore, files that are kind of inspired by other projects also get the same header comment but may have a second, additional comment explaining its origin. Used command: bin/php-cs-fixer fix --config=Build/php-cs-fixer/header-comment.php Releases: master Resolves: #91024 Change-Id: I5a040517e0fbde6e5a27d589bf2f222078326dc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64159 Tested-by:Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
- Apr 14, 2020
-
-
Benni Mack authored
This change adds two changes 'blank_line_after_opening_tag' => true, 'single_trait_insert_per_statement' => true, to our PHP-CS Fixer configuration, adopting more rules related to PSR-12. Resolves: #91020 Releases: master Change-Id: I180b2cbceb077911bddeb42d9f131e5b32244ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64158 Tested-by:Josef Glatz <josefglatz@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
- Apr 13, 2020
-
-
Alexander Schnitzler authored
As a preparation to be compatible with PSR-12, all spaces in strict type declerations are removed. Releases: master Resolves: #91009 Change-Id: I2b7c2fda42b44168b5c4c6b21711eede2eadaf2e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62104 Tested-by:
-
- Dec 11, 2019
-
-
Alexander Schnitzler authored
As a prepatory work for a better static code analysis all ampersands have been removed from doc block params. The doc block must not reflect whether a variable is passed by value or reference. Releases: master Resolves: #89912 Change-Id: Ibead2ec2db6487e32bcd5fc271a6566bab46d255 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62594 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
-
- Oct 07, 2019
-
-
Christian Eßl authored
Make spelling in TYPO3 great again. Resolves: #89290 Releases: master Change-Id: I520840dd0774aa5d658ce6a45811aa6282c9e461 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61845 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
- Feb 05, 2019
-
-
Alexander Schnitzler authored
ObjectAccess had two kinds of runtime reflection calls: 1) To gather data about object properties and methods 2) To make non public properties accessible The first one is tackled by using class schema instances and by using the property accessor of symfony/property-access. The latter is tackled by deprecating all method arguments that trigger reflection to make properties accessible. In the future, gettable/settable properties need to be either public or have a getter (get*/has*/is*) or setter. Releases: master Resolves: #87332 Change-Id: I6ecef81de7aa4cc1244166d683874a1a87ac6bb7 Reviewed-on: https://review.typo3.org/59331 Reviewed-by:
André Schließer <andy.schliesser@gmail.com> Tested-by:
Andreas Wolf <andreas.wolf@typo3.org> Tested-by:
-
- Oct 01, 2018
-
-
Benni Mack authored
EXT:extbase uses @api and @internal phpDoc annotations. Going with a cleaner approach with marking code as just @internal, and everything not annotated as @internal is public, is the way to go, also the way PSR-5 is heading. For EXT:extbase: Every PHP class that had nothing marked, is now @internal, everything that was @api is now implicitly part of TYPO3 Core API. On top, all license headers and @license annotations have been streamlined. This means: - TYPO3 Core's PHP classes area all public API by default unless marked as @internal or an extension class - @api is not allowed anymore and will be restricted in the future from adding. - @internal should be used for everything that should not be explicitly exposed as public API in the future. - Everything under Tests/ is not part of TYPO3's Public API Resolves: #86521 Releases: master Change-Id: I83c5a27d9af001929142d2620600668ad0a84c92 Reviewed-on: https://review.typo3.org/58535 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
- Sep 02, 2018
-
-
Wouter Wolters authored
strpos will use only CPU resources, substr also needs memory allocation. Resolves: #85477 Releases: master Change-Id: Ic25c99986f7e2e7237c10acaa75be8d0f6289f13 Reviewed-on: https://review.typo3.org/57466 Reviewed-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
- Jul 06, 2018
-
-
Wouter Wolters authored
Resolves: #85480 Releases: master Change-Id: I0c666be36a30add9742fdba33d8211daf839fcf9 Reviewed-on: https://review.typo3.org/57469 Tested-by:
Rudy Gnodde <rgn@windinternet.nl> Reviewed-by:
-
- Oct 17, 2017
-
-
Alexander Schnitzler authored
Extbase came along with two main caches for reflection data. extbase_reflection and extbase_object. The latter mostly stored information that were relevant to the dependency injection, like inject methods and properties and constructor parameters. The information was gathered by actual reflection and by analysing doc blocks of properties and methods. extbase_reflection stored similar reflection and doc block data about objects but mainly for the parts outside dependency injection. For example, the validation resolver used it to identify @validate tags, the ActionController used it to identity which properties not to validate. The ORM also used it a lot to find annotated types via @var and so on. There were a few issues with these two approaches: - A lot of redundant data was fetched - Data was fetched multiple times at different locations - The extbase_reflection cache was stored each plugin seperately, resulting in a lot of redundant cache data for each plugin cache - At a lot of places, the reflection service was used to reflect objects, but the data wasn't cached or taken from a cache resulting in performance drawbacks This patch solves these issues with several approaches: - The extbase_object cache has been removed completely and all necessary information about objects, mainly @inject stuff, is now fetched from the ReflectionService as well. - The ReflectionService does still create ClassSchema instances but these were improved a lot. All necessary information is now gathered during the instantiation of ClassSchema instances. That means that all necessary data is fetched once and then it can be used everywhere making any further reflection superfluous. - As runtime reflection has been removed completey, along with it several reflection classes, that analyzed doc blocks, have been removed as well. These are no longer necessary. - The extbase_reflection cache is no longer plugin based and will no longer be stored in the database in the first place. Serialized ClassSchema instances will stored in typo3temp. Releases: master Resolves: #57594 Resolves: #55654 Change-Id: I93b905c85c4f28775f014ca8b585347bf6f1e7d3 Reviewed-on: https://review.typo3.org/54381 Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
- Aug 23, 2017
-
-
Wouter Wolters authored
Add 2 new rules * no_superfluous_elseif * no_useless_else Both rules only apply if the if-statement contains a return. If this is the case the obsolete else/elseif part is dropped. Resolves: #82183 Releases: master,8.7 Change-Id: I94dfa6b5b96cbc3e350bd778f1796dda1a4d955a Reviewed-on: https://review.typo3.org/53791 Tested-by:
-
- Jul 17, 2017
-
-
Daniel Goerz authored
The ObjectStorage Object passed to iterator_to_array() ends up with the pointer at the last item, so that any ongoing iteration through the ObjectStorage wrapping the call of ObjectAccess is interrupted. This patch ensures that the ObjectStorage is cloned before converted to an array so that the original object keeps it original iteration state. Resolves: #81597 Relates: #66995 Releases: master, 8.7 Change-Id: Ied025ff616e100cc5eb5dedd5b7b6a95293ddfcf Reviewed-on: https://review.typo3.org/53525 Tested-by:
Claus Due <claus@phpmind.net> Reviewed-by:
Sascha Rademacher <sascha.rademacher@gmail.com> Tested-by:
Benjamin Kluge <b.kluge@neusta.de> Tested-by:
-
- Jan 19, 2017
-
-
Nicole Cordes authored
In \TYPO3\CMS\Extbase\Reflection\ObjectAccess there is a method to get all available property names of an object. Currently all get/is/has methods are joined as they can be fetch from Extbase as well. But for those methods it is necessary to respect their arguments as Extbase calls those functions without any argument. This can trigger PHP warnings. The patch uses a class reflection to get public properties and inspect the method arguments. Only those functions without arguments or only optional arguments are considered as valid property name. Resolves: #78270 Releases: master, 7.6 Change-Id: Ie286dca2a249b73d3dc58f7388dda593a678db3d Reviewed-on: https://review.typo3.org/50197 Tested-by:
Philipp Gampe <philipp.gampe@typo3.org> Tested-by:
-
- Nov 07, 2016
-
-
Sascha Egerer authored
In #66995 the extbase ObjectAccess has been cleaned up and introduced a behavior where it is not possible anymore to call the getter of an object that implements \ArrayAccess. The problem is avoided by only using array-accessing if the offset is found to exist. If not, the instance is handled as any other object. Change-Id: Ie6b598d93fd7171d0b6c37259e424794861e31ed Resolves: #78589 Related: #66995 Releases: master Reviewed-on: https://review.typo3.org/50521 Reviewed-by:
-
- Oct 10, 2016
-
-
Christian Kuhn authored
* better regex finds more with less false positives * use grep instead of ack-grep * find exceptions without exception code * the script kills travis for unkown reasons and removed Change-Id: I6ae7c005bc9f493365d36f9602aebf389f1f7786 Resolves: #78221 Releases: master Reviewed-on: https://review.typo3.org/50150 Reviewed-by:
-
- Oct 07, 2016
-
-
Claus Due authored
This patch aims to clean up and improve the ObjectAccess class which currently does a *lot* of unnecessary operations, but is intended for use in many places especially with repeated use. Therefore, any even small optimisation in this class would be a benefit. * Uses more native PHP methods where reasonable * Uses fewer method calls where reasonable * Gets rid of a variable passed by reference * More cases return NULL rather than throw Exceptions * Fastest decisions and access methods come first * Reflection-based access isolated to edge cases and access with the "force" flag being TRUE. * Sacrifices ability to read objects of types other than persisted objects contained in an ObjectStorage or subclass of ObjectStorage. * Changes verdict from FALSE to TRUE when determining if a dynamically added property exists on an object (these are, by definition, publicly accessible). Change-Id: Ib17051a43f61bb73a1bd5a8a6c710f54eec8f769 Resolves: #66995 Releases: master Reviewed-on: https://review.typo3.org/39585 Tested-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
-
- Aug 30, 2016
-
-
Wouter Wolters authored
As decided during T3ACME we will use the short array syntax in master. The 7.6 branch will also be done to make backporting easier. Resolves: #77692 Releases: master,7.6 Change-Id: I37e9484b1012fc9161148257a842054c24d162ba Reviewed-on: https://review.typo3.org/49651 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- Oct 09, 2015
-
-
TYPO3 Release Team authored
In our efforts to achieve a better interoperability with other PHP projects, the PHP code base of the TYPO3 Core switches to the PHP coding guideline standard PSR-2. See http://www.php-fig.org/psr/psr-2/ for more information. Resolves: #70515 Releases: master Change-Id: I734c0d838af157003decfeb5fc0a11dddcb87bf5 Reviewed-on: http://review.typo3.org/43918 Reviewed-by:
TYPO3 Release Team <typo3cms@typo3.org> Tested-by:
-
- Jan 19, 2015
-
-
Simon Schaufelberger authored
Support calling object methods starting with 'has'. Change-Id: Iec4913203b07fee70e6f5bb3ea9d980d2febc5c9 Resolves: #56529 Releases: master Reviewed-on: http://review.typo3.org/28036 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- Dec 17, 2014
-
-
Roland Waldner authored
Most of TYPO3's PHP files have an empty line before a class' closing curly brace. This commit adds this empty line (if it is missing) before a class' closing curly brace. This is not part of the TYPO3 CMS CGL but increases consistency in this area. This regular expression was used to add the empty lines: Search: (}\n)(}) Replace: $1\n$2 Resolves: #63942 Release: master Change-Id: Icd6547322ac8b7310956d347fd73c90bde2bbfa7 Reviewed-on: http://review.typo3.org/35527 Reviewed-by:
-
- Dec 13, 2014
-
-
Roland Waldner authored
At the moment in some classes you can find an empty line between the copyright comment and the first use statement. In some (far less) other classes there is no such empty line. This commit adds an empty line between those comments if there is no empty line. This is not part of the TYPO3 CMS CGL but increases consistency in this area. This regular expression was used to add the empty lines: Search: ( \* The TYPO3 project - inspiring people to share!\n \*/\n)(use ) Replace: $1\n$2 Resolves: #63829 Releases: master Change-Id: I4b28a1cfcfc727016ac5d89b3988d236270f37e2 Reviewed-on: http://review.typo3.org/35391 Reviewed-by:
-
Roland Waldner authored
This regular expression was used to replace PHPDoc style comments with ordinary comments: Search: /\*\*(\n \* This file is part of the TYPO3 CMS project.) Replace with: /*$1 Resolves: #63328 Releases: master Change-Id: Ic8f11dbfefee94a19657c8fe8426c81d1cb435d8 Reviewed-on: http://review.typo3.org/35103 Reviewed-by:
-
- Oct 28, 2014
-
-
Wouter Wolters authored
* Use bool in @return * Use int in @return * Use bool in @param * Use int in @param * Remove extra tabs and spaces in @param Resolves: #62506 Releases: master Change-Id: I673888aa08855a1364150d0060d0f205fc1f83a2 Reviewed-on: http://review.typo3.org/33577 Reviewed-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
Frank Nägler <typo3@naegler.net> Tested-by:
-
- Oct 25, 2014
-
-
Wouter Wolters authored
Resolves: #62468 Releases: master Change-Id: I2790ca5817e16cfe0dc1c43151d2587ca796294a Reviewed-on: http://review.typo3.org/33523 Reviewed-by:
-
- Jul 03, 2014
-
-
Markus Klein authored
When enabling access to the content of ObjectStorages by integer number, it was overlooked that property access might be desired too, which has also been working before. Fix this by not aborting the access when addressing a non-integer property on ObjectStorages. Resolves: #59412 Releases: 6.3, 6.2 Change-Id: I59b83ed0bf0c965efcdf0aad9440d634953a221e Reviewed-on: https://review.typo3.org/30628 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Marcin Sągol Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
- Jul 01, 2014
-
-
Markus Klein authored
Remove unnessessary full qualified class names. Cleanup docheaders. Resolves: #57878 Releases: 6.3 Change-Id: I5bcdb80c27da1698fd1446a001907d83c6845507 Reviewed-on: https://review.typo3.org/29444 Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
- Jun 22, 2014
-
-
Michael Schams authored
This patch replaces the copyright/license header in PHP files with a new, simplified one. The new header does not show the year figure, nor an author name, and refers to the LICENSE.txt file for the full copyright information. License is: GPL2 or any later version. This is a multi-part commit due to the huge number of changed files. See issue #59784 for further details. Resolves: #59784 Releases: 6.3, 6.2 Change-Id: I1eacf9bf4537776e850d091d9d50bc72f8c2b20d Reviewed-on: https://review.typo3.org/31029 Reviewed-by: Krzysztof Adamczyk Tested-by: Krzysztof Adamczyk Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Jun 02, 2014
-
-
Helmut Hummel authored
ObjectAccess->getPropertyPath() does not work with ObjectStorage and numerical indexes, but it should be because without it form fluid fields cannot be properly handled as the value is always null. Fixing fetching objects from ObjectStorage by index will also enable shorter access of single objects in Fluid. Imagine you want to render the first image in your template. Previously you had to write this: <f:for each="{object.images}" as="image" iteration="iterator"> <f:if condition="{iterator.isFirst}"> <f:image image="{image}" alt="" width="50"/> </f:if> </f:for> Now you can just write: <f:image image="{object.images.0}" alt="" width="50"/> Resolves: #37126 Related: #37000 Releases: 6.2 Change-Id: I45122bd145b5a179ad3e9e3894520f9a614906c8 Reviewed-on: https://review.typo3.org/29923 Reviewed-by: Markus Klein Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Fabien Udriot Reviewed-by: Tymoteusz Motylewski Tested-by: Tymoteusz Motylewski Reviewed-by: Georg Ringer Tested-by: Georg Ringer
-
- Mar 24, 2014
-
-
Helmut Hummel authored
Trying to access a property if the subject is a string, causes the class loader to be triggered as is_callable is invoked. We can avoid that by checking if the subject is an object or array. We can neglect that is_scalar also returns false for resource types as this will not really happen in practice. Resolves: #56993 Releases: 6.2 Change-Id: I94754cd919acc857cd9a8b8e486080c0bf567112 Reviewed-on: https://review.typo3.org/28586 Reviewed-by: Alexander Opitz Tested-by: Alexander Opitz Reviewed-by: Christian Weiske Tested-by: Christian Weiske Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
- Jan 13, 2014
-
-
Roland Waldner authored
"textfile" will be replaced by "text file" Resolves: #54893 Releases: 6.2 Change-Id: Ic7ce106a016f242cc47c70539876ff9810954a9b Reviewed-on: https://review.typo3.org/26736 Reviewed-by: Michiel Roos Tested-by: Michiel Roos Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
- Oct 01, 2013
-
-
Christian Kuhn authored
Change-Id: Iaa92566c53301e49396fc9fb26b0b339c48d567b Resolves: #52360 Releases: 6.2 Reviewed-on: https://review.typo3.org/24212 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Ernesto Baschny Tested-by: Ernesto Baschny Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
- Apr 23, 2013
-
-
Alexander Schnitzler authored
* Remove whitespace after closing php tag * Fix PhpDocComments Releases: 6.1 Resolves: #47216 Change-Id: I8f35f9adb65c75cb11e1045bbade3d0b6708db86 Reviewed-on: https://review.typo3.org/19976 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Alexander Schnitzler Tested-by: Alexander Schnitzler
-
- Apr 01, 2013
-
-
Alexander Schnitzler authored
Changes "(c) 2010-2012" to "(c) 2010-2013" Releases: 6.1 Resolves: #46840 Change-Id: I0a26a9a05cfc5697eb536016aee946ad970d82b3 Reviewed-on: https://review.typo3.org/19494 Reviewed-by: Alexander Schnitzler Tested-by: Alexander Schnitzler
-
- Mar 06, 2013
-
-
Christian Kuhn authored
Feeding ObjectAccess->getPropertyPath() with an ObjectStorage raises warnings, that might flood the errorLog quickly. With the patch those warnings are prevented. Additionaly the patch delivers a test scenario explaining the missing ability to properly resolve the properny path, when it comes to ObjectStorages. Fixes: #37000 Releases: 6.1 Change-Id: I3acf5aef281894f06f1e35f45ac14ba692a90b3e Reviewed-on: https://review.typo3.org/18527 Reviewed-by: Wouter Wolters Reviewed-by: Pascal Dürsteler Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Tested-by: Wouter Wolters Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
- Dec 11, 2012
-
-
Alexander Schnitzler authored
Also adjusted some operators for jenkins Releases: 6.1 Resolves: #43887 Change-Id: I5e6ba540d7d828bd24417356b887182966fb581c Reviewed-on: https://review.typo3.org/17102 Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Alexander Schnitzler authored
All files should have the same file comment with the same copyright notice in it. Also there must not be an author any more. Instead the Extbase Team is mentioned as author from now on. Releases: 6.1 Fixes: #43883 Change-Id: Ib61859a2fa853a238907df314f948da51306d7e8 Reviewed-on: https://review.typo3.org/17099 Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
- Nov 20, 2012
-
-
Alexander Schnitzler authored
* whitespaces, tabs and blank line issues * bool -> boolean * int -> integer * remove @scope and @entity Fixes: #43146 Releases: 6.0 Change-Id: I0ffdde3c918920272e8b1e4d1eab199b7b3e90f3 Reviewed-on: http://review.typo3.org/16600 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
- Oct 29, 2012
-
-
Alexander Schnitzler authored
Releases: 6.0 Fixes: #42469 Change-Id: I004754cb05d06d2e3b91a41bde5657bb69d0f6b4 Reviewed-on: http://review.typo3.org/16004 Reviewed-by: Alexander Schnitzler Tested-by: Alexander Schnitzler
-
