Skip to content
  • Alexander Schnitzler's avatar
    [!!!][TASK] Replace ClassInfo with ClassSchema · 73b5e17d
    Alexander Schnitzler authored
    Extbase came along with two main caches for reflection data.
    extbase_reflection and extbase_object. The latter mostly stored
    information that were relevant to the dependency injection, like
    inject methods and properties and constructor parameters. The
    information was gathered by actual reflection and by analysing
    doc blocks of properties and methods.
    
    extbase_reflection stored similar reflection and doc block data
    about objects but mainly for the parts outside dependency injection.
    For example, the validation resolver used it to identify @validate
    tags, the ActionController used it to identity which properties not
    to validate. The ORM also used it a lot to find annotated types via
    @var and so on.
    
    There were a few issues with these two approaches:
    
    - A lot of redundant data was fetched
    - Data was fetched multiple times at different locations
    - The extbase_reflection cache was stored each plugin seperately,
      resulting in a lot of redundant cache data for each plugin cache
    - At a lot of places, the reflection service was used to reflect
      objects, but the data wasn't cached or taken from a cache resulting
      in performance drawbacks
    
    This patch solves these issues with several approaches:
    
    - The extbase_object cache has been removed completely and all
      necessary information about objects, mainly @inject stuff, is
      now fetched from the ReflectionService as well.
    - The ReflectionService does still create ClassSchema instances
      but these were improved a lot. All necessary information is now
      gathered during the instantiation of ClassSchema instances. That
      means that all necessary data is fetched once and then it can be
      used everywhere making any further reflection superfluous.
    - As runtime reflection has been removed completey, along with it
      several reflection classes, that analyzed doc blocks, have been
      removed as well. These are no longer necessary.
    - The extbase_reflection cache is no longer plugin based and will
      no longer be stored in the database in the first place. Serialized
      ClassSchema instances will stored in typo3temp.
    
    Releases: master
    Resolves: #57594
    Resolves: #55654
    Change-Id: I93b905c85c4f28775f014ca8b585347bf6f1e7d3
    Reviewed-on: https://review.typo3.org/54381
    
    
    Reviewed-by: default avatarBenni Mack <benni@typo3.org>
    Tested-by: default avatarBenni Mack <benni@typo3.org>
    Tested-by: default avatarTYPO3com <no-reply@typo3.com>
    Reviewed-by: default avatarSusanne Moog <susanne.moog@typo3.org>
    Tested-by: default avatarSusanne Moog <susanne.moog@typo3.org>
    73b5e17d