- Aug 17, 2020
-
-
Benni Mack authored
Page tree will fetch just 2 levels of pages plus pages which are expanded on the initial load. Next levels are fetched on demand via Ajax when expanding the node. Search works server side now. To clear search, click on "x" button. Change-Id: I2691c531b419398325989070c375a9ec0d08ae82 Releases: master, 10.4, 9.5 Resolves: #88943 Resolves: #88098 Resolves: #88259 Resolves: #91884 Resolves: #91753 Resolves: #91916 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65208 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Riny van Tiggelen <info@online-gamer.nl> Tested-by:
Uwe Trotzek <trotzek@citeq.de> Tested-by:
Marcus Schwemer <ms@schwemer.de> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
-
- Aug 16, 2020
-
-
Christian Kuhn authored
ext:styleguide got some love for v10 lately and is raised to a first v11 version with this patch. Next to a couple of bug fixes it now generates a proper site configuration when TCA records are generated. Resolves: #92026 Releases: master Change-Id: Ia1d886cd2fb145d0257197db0aa533b9442e59c7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65348 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
- Aug 15, 2020
-
-
Christian Kuhn authored
It can be hard for an admin to remember a workspace has to be set up on pid 0 to use workspaces. The patch adds an info box with a button to create a first workspace record to the workspace module. Resolves: #65249 Releases: master, 10.4 Change-Id: I6909c199936f79477de8fb3b48cbbe37c50d6bcc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65319 Tested-by:
-
Christian Kuhn authored
The workspace module has a restriction for non-admin users to show only the currently selected workspace as tab. This does not make much sense since all workspaces are listed in the toolbar, too. With the now decluttered interface no longer showing 'all workspaces' and 'live workspace' tabs, the restriction is lifted so all users see all workspaces as tabs they have access to. Resolves: #92013 Releases: master, 10.4 Change-Id: Ie32ae996ff97843b0b9ef6bca7978604b9c789bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65336 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
-
Markus Hoelzle authored
Backend search function lookup in field "slug" for "pages" table. To enable this, the file type "slug" has to be added in general to the search functions. Resolves: #91676 Releases: master, 10.4 Change-Id: Ied3153801c15830ed659bbe44b085d76daed48c3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64936 Tested-by:
-
Raphael Zschorsch authored
The ResourceCompressor should not hard-code the JS file type when concatenating JS files. Resolves: #91310 Releases: master, 10.4 Change-Id: I70f5428cb184aeee36467d0de5327acd167dca4e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64414 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Andreas Fernandez authored
The library cropper used in TYPO3 Core is rather old (2.3.x) while version 4.1.x is available, which is abandoned. The cropper library has been split into a core module and a jQuery adapter meanwhile, which makes "cropper" obsolete. Since changing the cropper library is mandatory anyway, this patch makes use of the core library "cropperjs" only. Resolves: #91958 Releases: master Change-Id: I0e961a358aa1d007413d664172db8cd8c48c399c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65228 Tested-by:
-
Oliver Hader authored
Resolves: #91820 Releases: master, 10.4 Change-Id: Ib556d58df7f1c8d4e62387eab2800da4c7e3d415 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65055 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by: Daniel Windloff Reviewed-by:
-
Daniel Windloff authored
The button list for single redirect rows in the redirect module is now aligned correctly, even if no preview button is available. Resolves: #92011 Releases: master, 10.4 Change-Id: I780915239fdf4022280ca9e1b6e3f8441bfc0050 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65333 Tested-by:
-
Christian Kuhn authored
With #89554 the extbase MVC class AbstractController has been deprecated. All methods have been moved to ActionController. Install tool extension scanner rules have been set up for both class usage and its methods. This leads to false positives when calling a parent method in extension classes that extend ActionController. It is enough to just scan for usages of AbstractControler classes to find affected extensions with a strong match for this deprecation. Resolves: #92007 Related: #89554 Releases: master, 10.4 Change-Id: Id758e7771576da033e8a048f37922a2c75063e69 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65328 Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
-
- Aug 14, 2020
-
-
Christian Kuhn authored
AbstractController has been removed in v11, the ignore is obsolete. Resolves: #92006 Related: #91527 Releases: master Change-Id: I4c672a739e21fce5217cca08c5dab599cfaa177c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65327 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Christian Kuhn authored
The patch for issue #88180 added basic HTML linting via grunt to the test suite. The patch adds 'grunt lintspaces' to runTests.sh to easily execute the test locally, too. Build/Scripts/runTests.sh -s lintHtml Resolves: #91998 Related: #88180 Releases: master, 10.4 Change-Id: I672d7b31f08b35ddbb8e034a5caf411c667a3325 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65320 Tested-by:
-
Christian Kuhn authored
When "All workspaces" has been integrated somewhere before v6, it was advertised as a view to see changes from all workspaces. This however never worked: When calling the workspace module, "All workspaces" is empty. If switching to a workspace and then selecting "All workspaces", the tab shows only the changes of the selected workspace - identical to the normal workspace tab. Tracing this back in time, this behavior exists at least since v7. There is not a single bug report in forge about this. Since this tab is broken for such a long time without any report, we assume the functionality is barely needed. A better solution would be to show the number of existing changes next to the workspace name in the tab list, so editors can quickly see which specific workspace needs attention, and then switch to the workspace in question. This should be done with another patch since non-admins currently see only one workspace tab at a time, which needs another preparation patch to fix. This patch drops the broken "All workspaces" tab for now, preparing further bugfixes to finally end up with a working solution. Resolves: #91999 Releases: master, 10.4 Change-Id: I33f3cdba117b68927eb10447b0541d8975ed0a63 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65322 Tested-by:
-
Helmut Hummel authored
Instead of looking at the mime type of the file, the configured image file extensions is checked to decide whether to extract width and height for sys_file_metadata. This allows pdf files to have their width and height to be extracted. While the exact pixel values do not matter much for a PDF, the ratio of width and height (landscape or portrait or even square) can be very useful to "know". Releases: master, 10.4, 9.5 Resolves: #91967 Change-Id: I354be4f07edf6e4c3b59748ccb87b67dd66caa8e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65277 Tested-by:
Tim Schreiner <schreiner.tim@gmail.com> Tested-by:
Simon Praetorius <simon@praetorius.me> Reviewed-by:
-
- Aug 13, 2020
-
-
Alexander Schnitzler authored
Updating phpstan to version 0.12.37 lets phpstan benefit from static reflection which does no longer come with the need to load analyzed classes and use the native reflection api of php. Instead, roave/better-reflection is used, which does a better job and reduces false positives. Since phpstan has been updated, the rules which have been copied over from the vendor package had to be updated as well. And since phpstan does find more errors now, a few rules had to be disabled again. Used commands: - composer require phpstan/phpstan:^0.12.37 --dev - composer require friendsoftypo3/phpstan-typo3:^0.4.0 --dev Releases: master Resolves: #91635 Change-Id: Ia6b68e7ed1428fbc40ae4d1b9eb3a13d212a3a5c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64851 Tested-by: -
Georg Ringer authored
Fix a typo in the variable name to show possible descriptions again. This is especially useful if a task failed because it contains the actual error message. It has been broken since the refactoring to fluid. Resolves: #91871 Releases: master, 10.4, 9.5 Change-Id: I8cd1ed8268e810ca505bc74728db62ac229c034f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65313 Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
- Aug 12, 2020
-
-
Christian Kuhn authored
If workspace records are present on deeply nested pages or have long titles the action buttons can not be reached. A vertical scroll bar will be the result. The patch uses existing server side crop methods. Change-Id: I0e6651ceab3c4b74aa3471ddecf56775a6e6be9c Resolves: #90918 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64041 Tested-by:
-
Christian Kuhn authored
The "LIVE workspace" tab of the workspace module always showed wrong records from other workspaces. This issue has been resolved with the pid=-1 removal in v10. Since then, this tab never shows records. The patch removes the tab from the interface. Users, including admins, now see a "Please select a workspace first" message when calling the module in online / live workspace. Resolves: #91983 Related: #89122 Related: #13056 Releases: master, 10.4 Change-Id: Ib1029253d53745d82786f31276283e5f88ebf9b4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65284 Tested-by:
Achim Fritz <af@achimfritz.de> Tested-by:
-
Oliver Hader authored
Canonical URL generation is tested using real requests to the website frontend instead of manually creating TSFE components. Resolves: #91982 Releases: master, 10.4, 9.5 Change-Id: I325af73d53af5ae9ccefd6a0c3d75776c4951893 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65281 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Benni Mack authored
The option "IPmaskMountGroups" allows to automatically assign usergroups to website visitors based on their incoming IP address / subnet. This feature is useful for intranets, but very limited in its functionality (e.g. auto-login for intranets is not possible, logging in from home with the same user does not show the information), where it is recommended to use more powerful third-party extensions instead. Resolves: #91974 Releases: master Change-Id: Idf219ba44242d37aca5212c50819aba964236a5f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65274 Tested-by:
-
- Aug 11, 2020
-
-
Andreas Fernandez authored
Due to recent changes in TypeScript builds, importing all modules into a single variable became obsolete for the used modules. However, two places were forgotten, which cause issues. The import statement are adjusted to ES6 style to fix issues with possibly (non-)existent default exports. Resolves: #91969 Related: #91954 Releases: master, 10.4 Change-Id: I3fc0e1a433521e5fc9b87dc11237e1a42e9e35f5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65272 Tested-by:
Richard Haeser <richard@maxserv.com> Reviewed-by:
-
- Aug 10, 2020
-
-
Georg Ringer authored
AssetRenderer A call to `GeneralUtility::createVersionNumberedFilename` is required to avoid using outdated files from browser cache. Resolves: #91889 Releases: master, 10.4 Change-Id: I0963e4e8f447eff111314a8165038fd55c422edc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65238 Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
-
Simon Gilli authored
Currently it is possible to add an invalid cache configuration with empty identifiers. This change avoids this behavior by checking the indentifiers while changing the cache configuration at the CacheManager. Resolves: #91959 Resolves: #91773 Releases: master, 10.4 Change-Id: Icfb25ab52418da166582dba4bca389250325097b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65229 Tested-by:
Daniel Haupt <mail@danielhaupt.de> Tested-by:
-
Christian Kuhn authored
When dealing with inline foreign field setups in workspaces and having a child table not workspace aware, the DataHandler still tries to create workspace copies of the not workspace aware child. In v9, it sets pid=-1 for those records, which succeeds if the pid db field is signed. In this case a dead record of the child is created. If the field is unsigned, the insertion fails and an error message is created. In v10 and master pid=-1 is gone and the real pid is set, the record is created and becomes a 1:1 duplicate in live workspace. The patch adds an according check to the DataHandler in workspace context to skip not workspace aware children. Resolves: #91680 Releases: master, 10.4, 9.5 Change-Id: Ifb8183f25e69a75ecc5b5ebac3c9a57c03265e7f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65230 Tested-by:
David Steeb <david.steeb@b13.com> Tested-by:
-
Benni Mack authored
Due to the logic being based around SiteLanguages and the "All" language not being one, it was excluded from being rendered in the content header. Resolves: #90854 Releases: master, 10.4 Change-Id: I5152cedc80e2b1fd45b6eb626fd635d9be78a29b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64125 Tested-by:
-
Oliver Bartsch authored
Calling ShowImageController with old links containing serialized parameters leads to PHP warnings as the json_decode doesn't return an array in this case. To prevent this warnings we now ensure that parameters is a valid array in any case, prior to calling the foreach. Resolves: #91882 Releases: master, 10.4, 9.5 Change-Id: If33068f4f69bd858ff130ca4f31970df8fa1d624 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65137 Tested-by:
Stefan P <spo@snk.de> Tested-by:
-
Daniel Siepmann authored
In case sqlite is used, the uid is not of type integer. Therefore it is explicitly casted before passing to strictly typed method call. Resolves: #91950 Releases: master, 10.4 Change-Id: I4d9f8e4e526f861fd06f08c90c21d8b25832cc26 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65222 Tested-by:
-
Benni Mack authored
This change moves the language evaluation of a page record much earlier in the frontend process. Before: * Resolve the page (determineId) based on permissions, visibility etc. * get TypoScript from Cache * Find a translation of the page and determine the content language Now: * Resolve the page based on permissions, visibility etc * Find the translation of the page * Get TypoScript from Cache This is a breaking change, as the hooks within settingLanguage() are now called at a different time of the processing logic for a frontend request, however it solves an issue that you can now use localized values for TypoScript conditions. Resolves: #23736 Releases: master Change-Id: Ia2db0233ce6680ae1cbcddb81574a41fa6333abf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65044 Tested-by:
-
Oliver Hader authored
The route configuration shown below using `ExtbaseEnhancer` is currently not evaluated anymore due to missing route variables in `routePath`. For this particular case in `ExtbaseEnhancer` the controller-action pair is implicitly defining variables. MyPlugin: type: Extbase extension: ... plugin: ... routes: - routePath: '/action' _controller: 'MyController::action' Resolves: #91880 Releases: master, 10.4, 9.5 Change-Id: Ib42f87c3c9f83acc7f2ceec4a93169d15777ed08 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65134 Tested-by:Marco Bresch <marco.bresch@starfinanz.de> Tested-by:
Georg Tiefenbrunn <georg.tiefenbrunn@gmail.com> Tested-by:
-
Christian Kuhn authored
A missing restriction in PageRenderer->getSubpagesForPages() leads to the workspace preview of a page changed in a workspace to render both live and workspace versions as menu items in multi level menus. Adapt the query to fetch the correct combination of live and overlay records. Resolves: #91943 Related: #89555 Releases: master, 10.4 Change-Id: I924803fc2997a9a5c990bc4cf8a628113aae0b22 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65212 Tested-by:
-
- Aug 09, 2020
-
-
Andreas Fernandez authored
jQuery 3.5 has been released a while ago, it's safe to update to the current version. However, as 3.5.0 introduced some deprecations, it should be updated in master only. Executed commands: yarn add jquery@^3.5.1 grunt build Resolves: #91953 Releases: master Change-Id: Ife43bc2679549757dede58b0b1fa92df9bce6d7f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65224 Tested-by:
-
- Aug 08, 2020
-
-
Andreas Fernandez authored
The event listener registration for AjaxDataHandler events is faulty which causes event stacking when a workspace gets deleted. The registration now happens at a central place to solve this issue. Resolves: #91955 Related: #91948 Releases: master Change-Id: Ifafd8171ce3da20883e39c43d8300f92366866b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65227 Tested-by:
-
Andreas Fernandez authored
This patch fixed a long existing issue regarding workspaces. If a workspace is either created, updated or deleted, the topbar menu gets reloaded to update the workspace menu now. Resolves: #91948 Releases: master, 10.4 Change-Id: I316994c209d3bebc0e72e8e7ad956c5cf30502c9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65221 Reviewed-by:
Claus Due <claus@phpmind.net> Reviewed-by:
-
Andreas Fernandez authored
Events sent via AjaxDataHandler are now broadcasted by using the Broadcast Service. This change allows e.g. the topbar to listen to these events and trigger a reload. Broadcasting has the nice side effect that the event is sent to all browser windows which allows multiple simultaneously opened backends (that share the same domain) to react on that event. To ease the integration of event listeners, the event payload sent via classic `dispatchEvent()` is adjusted to share the same structure with broadcasted messages. Resolves: #91947 Releases: master, 10.4 Change-Id: I04321f9ab3db309972890e037a1d3790d9b06f79 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65220 Tested-by:
-
Andreas Fernandez authored
This changes the configuration of the TypeScript compiler to resolve modules in "node" style, which allows using TypeScript declaration files (*.d.ts) shipped with npm packages. Additionally the option "esModuleInterop" is enabled which allows us to use CommonJS modules in AMD modules without fiddling with incompatible exports. As a negative side-effect, all JavaScript have to get recompiled to reflect these changes. Resolves: #91954 Releases: master, 10.4 Change-Id: If6386f5062bfbe439615bb947e94cd728dfd5b2b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65225 Tested-by:
-
- Aug 07, 2020
-
-
Benni Mack authored
This reverts commit fb61db41 as it contained various regressions, which should be fixed in the next iteration. Change-Id: I03b6ff9e63a1425fae3745f70bbd9b8a2a94c081 Releases: master, 10.4, 9.5 Resolves: #91949 Reverts: #88943 Reverts: #88098 Reverts: #88259 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65200 Tested-by:
Frank Nägler <frank.naegler@typo3.org> Tested-by:
-
Benni Mack authored
Classes without any special Extbase treatment (e.g. no injection) are migrated to GeneralUtility. This saves a bit performance, because ObjectManager in turn would call GeneralUtility as well for these classes. Areas in Extbase are not touched, as they will be migrated separately. Resolves: #91937 Releases: master, 10.4 Change-Id: I899af0d377f9d710621e2775f8a7f51887d130d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65189 Reviewed-by:
-
Oliver Hader authored
New `SecurityUtility. getRandomHexValue(20)` returns 20 hexadecimal characters provided by the Web Crypto API. see https://developer.mozilla.org/en-US/docs/Web/API/Web_Crypto_API Resolves: #91809 Releases: master, 10.4 Change-Id: Iaee1c7641b34e1316fccd069808c519d1c3ba2ab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65046 Tested-by:
-
Christian Kuhn authored
The clipboard has a 'move' and a 'copy' mode. This can be changed in the list module where the clipboard is rendered. Using 'cut' in context menu, the state is forced to 'move', using 'copy' in context menu, the state is forced to 'copy'. If there is an element in the clipboard, 'paste' icons in list and page module appear. Their title tag is always 'paste' or 'paste after' or similar. Only the modal in page module distinguishes between copy and paste and changes its wording 'Do you really want to move' vs. 'Do you really want to copy', while the modal title is always 'paste'. This is odd from an UX point of view: Users learned they either 'cut + paste' or 'copy + paste': The decision to cut or paste is the first step when selecting the element, it's then either cut-out and moved to clipboard, or a copy in the clipboard is added. The second step is then just 'paste here'. The patch changes the modal wording to always use 'paste' as second step, just like the icons already do. Resolves: #83566 Releases: master, 10.4 Change-Id: Ia7b4296bbcee1d21b2be0d0ddb9e1019c93e9b4a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65190 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
- Aug 06, 2020
-
-
Benni Mack authored
Previously, when using the "Split Preview" for comparing a workspace version, and a live workspace, in iframes, the workspace version received the GET Parameter "&ADMCMD_prev=1", and the live workspace the "ADMCMD_noBeUser=1" (= no backend user is logged in) for THESE requests. Navigating through the live workspace, the ADMCMD_* GET parameters are lost in both variants. This change replaces the ADMCMD_noBeUser=1 with ADMCMD_prev=LIVE making the options consistent naming-wise. In addition, when ADMCMD_prev=LIVE is set, the current BE_USER is kept but the workspace is set to "0" temporary (for this request), allowing for e.g. the admin panel to continue to work. When ADMCMD_prev=LIVE or ADMCMD_prev=IGNORE is set, the parameter is added to config.linkVars, allowing to keep using the ADMCMD_prev when browsing through the workspace and live versions in the iframes. Resolves: #34199 Releases: master, 10.4 Change-Id: Ifa732d56af1af1d6f01f00b6b4c035b6fdbc02ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65213 Tested-by:
-
