- Mar 18, 2020
-
-
Susanne Moog authored
Resolves: #86943 Releases: master, 9.5 Change-Id: I1092442a963d7ba6e2282ed8d4c4bce360be8afc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63614 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
- Mar 17, 2020
-
-
Christian Eßl authored
In some cases, the "dirty" field checks were still not working for both ckeditor and flexform fields. The following changes were made: - Flexform elements can use dots for html id attributes, which are not officially supported by the W3C CSS specification. So escape the corresponding element selectors to work with the validation. - When maximizing an RTE, ckeditor4 automatically removes all the classes from the connected html elements (and reapplies them once leaving the fullscreen mode), so the markFieldAsChanged() validation won't work here. In this case, apply an event for remembering the changes, once the user leaves fullscreen again. Resolves: #88978 Resolves: #88776 Releases: master, 9.5 Change-Id: Ib21d415766b67be8d6c6e9aae8b8e937d03850bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63730 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Guido Schmechel authored
Improve the privacy of users by using the no-cookie setting by default and set the do not track parameter to 1. Resolves: #89381 Releases: master, 9.5 Change-Id: I81d1a6aae802126f66765702417b7ffd350d8fb7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61948 Reviewed-by:
-
Markus Klein authored
This patch fixes three things: 1) SQLite can handle a primary key, the special handling can be removed. The field names must be quoted though. A lot of duplicate tests can be removed here. 2) The handcrafted arrays passed on to the TableDiff class need to be indexed by the column or index name, otherwise the SQLite driver fails to identify them correctly. 3) Allow only one column operation per table. Having multiple column adjustments (rename, removal) within one run generates wrong migration SQL. This is due to the possibility of the Install Tool to be able to select on a "per column" level. (Keep in mind that in SQLite one operation needs at least 5 SQL statements, contrary to other DMBS) Resolves: #90758 Resolves: #90754 Resolves: #90751 Releases: master, 9.5 Change-Id: I972346fae3cc97b877e20033b466345fa1c0a83d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63702 Tested-by:
Daniel Siepmann <coding@daniel-siepmann.de> Tested-by:
-
- Mar 16, 2020
-
-
Benni Mack authored
When accessing the editPanel, the option "onlyCurrentPid" allows to also check the permissions of the editable record to verify if the user is allowed to edit it. When checking for CONTENT_EDIT permissions, the "onlyCurrentPid" is also evaluated now, having "mayEdit" set to false by default, before evaluating the condition further. Resolves: #43429 Releases: master, 9.5 Change-Id: I47ed7a7b8c0d1c750cd5b13b485ed14b3aced2dd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63616 Tested-by:
-
Susanne Moog authored
Flushing the redirect cache before rebuilding is not necessary and may result in dead-locks if multiple processes try to do the same. As there is only a single entry for redirects which gets overwritten when the rebuilding is finished, there is also no need to tag the entry as the identifier is enough. Resolves: #90069 Releases: master, 9.5 Change-Id: I2bc7c5ce9d0f4a37a3b1c9f51df34de556b2f35f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63729 Tested-by:
-
- Mar 15, 2020
-
-
Christian Eßl authored
phpstan requires, that a @var PHPDoc comment is immediately followed by the variable in the next line. Resolves: #90765 Releases: master Change-Id: I4c11582dd4831b2a9433ffd0bb262ab34a7d4e33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63731 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
Tizian Schmidlin authored
There is a flaw in the way TYPO3 handle the rendering of the backend edit forms that leads to fields used as labels always being rendered. This may lead to an huge amount of html being generated and thrown away without ever being pushed to the browser. For most fields, this effort is negligible, since TYPO3 has to render i.e. the title field once per backend call anyway. For table using a relation as title, as does `sys_file_metadata`, this means generating a select with all files in the system that could be related to that record. What happens is, that since the label of the sys_file_metadata record is the field file, the FormDataProvider `TcaColumnsProcessRecordTitle` will add file to the columnsToProcess for the current record and the `TcaSelectItems` will happily work it's way through and generate the html for the select box. Bare in mind, that this is absolute and utter dead weight since nowhere in the TCA showItem definition of any type the file field is referenced. This would not be to big of a problem since in most systems there are no more than 10k files but in systems with 100'000+ the memory get's used up and it can lead to memory exhausted errors in PHP (even with as much as 512M memory_limit). Resolves: #82990 Releases: master, 9.5 Change-Id: I5da8e08b71dfacac0535e4c8e858099d7e307a3e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61970 Tested-by:
-
Alexander Schnitzler authored
This commit adds missing doc blocks and missing type hints to existing doc blocks to help static code analyzers like phpstan do a better job. Also, wrong type hints have been changed. Releases: master Resolves: #90661 Change-Id: I966884b15e33f5668498290d3fd80b67a7ddcba0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63561 Tested-by:
-
Benni Mack authored
Instead of using $GLOBALS['SOBE'] for this single usage, the constructor is modified when building the Position Tree now. Resolves: #84376 Releases: master Change-Id: I49f340e431656f76f6be3d8027cf6640c38f6ad3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63625 Tested-by:
-
Benjamin Gries authored
These changes in the Datahandler and the FormSlugAjaxController allow users to override slug fields with columnsOverrides. Typical usecases for this are custom doktypes which should have an individual url behaviour defined by their type. Resolves: #87364 Releases: master, 9.5 Change-Id: I4c08c38f541197166cac0d054e323bc94f82c192 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61416 Tested-by:
-
Markus Klein authored
We now make sure that JSON en- and decoding works flawlessly, otherwise we throw the usual exceptions instead of failing with PHP errors. Resolves: #90744 Releases: master, 9.5 Change-Id: I7f791a73906447f0879590bee6f51143b7089ba5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63713 Tested-by:
-
Benni Mack authored
Apache2 suexec support prefixes environment variables with HTTP_ in order to whitelist environment variables - this is what TYPO3 is using for TYPO3_CONTEXT. Resolves: #90145 Releases: master, 9.5 Change-Id: I069949578c2467436fca568504dcda84d16df8fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63627 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
Benni Mack authored
When a TCA field of dbType=date / dateTime is rendered, and the field is marked as read-only, the value is not evaluated, as it never ever modified as UNIX timestamp. Resolves: #88450 Resolves: #90413 Releases: master, 9.5 Change-Id: I29c1acda07f11729d84668f51efdfeff4a4d99c5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63626 Tested-by:
-
Andreas Fernandez authored
The trigger buttons of the "Analyze Database Structure" modal are now searched in the correct DOM container and can now get disabled again. Resolves: #90748 Releases: master Change-Id: I8f4f1289e833f36113687a60838756330604baea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63695 Tested-by:
Frank Nägler <frank.naegler@typo3.org> Tested-by:
-
Oliver Bartsch authored
The reasons why the translation wizard can't be used are: * Mixed mode in translated page * Disabled via Page TSConfig This adds the second reason (Page TSConfig) to the message. Also the label key was renamed to proper describe its content. Resolves: #90684 Releases: master Change-Id: Ib58de71f717e1ec32f91a8b60bf30840a7f70a76 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63631 Tested-by:
Jens Ulrich <jens.ulrich@snk.de> Tested-by:
-
Markus Klein authored
Executing the tests over midnight caused the changed tests to fail as those where comparing the "current date" from the test subject with the one gathered within the tests, those not necessarily are on the same day. As the DateViewHelper uses the date from the Context we safely can use the EXEC_TIME of the Core for the expectation. Resolves: #90752 Releases: master, 9.5 Change-Id: I3334f0fc5c3d956a4f6801a3bcd849f7f6585497 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63700 Tested-by:
-
Georg Ringer authored
Only add the type field to the search fields if it is found in the TCA columns configuration to avoid failed queries. The table 'sys_file_reference' uses as type 'uid_local:type' which is not a valid field and would break the query. Resolves: #90760 Releases: master Change-Id: I2ff0d43679176099bb304265a6afc456b92b56b7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63727 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Benni Mack authored
The setting TCEMAIN.clearCache_pageGrandParent clears the cache for the parent parent page when editing the page properties of a page. This now also flushes the cache for the parent page when editing page contents of a page. Resolves: #75294 Releases: master, 9.5 Change-Id: Iccde513901bd79e17fedf0d6a4c04ce887474121 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63619 Tested-by:
-
Chris Müller authored
The method StateUtility::isHiddenForUser must return a bool, but instead the User TSconfig setting admPanel.hide = 1 was returned unchanged as a string. This conflicts with the defined return type. Additionally, a check on the backend user is added to avoid another error when it is null. Furthermore, missing tests in StateUtility are added. Resolves: #90764 Related: #87231 Releases: master Change-Id: I677fe3a808d806a1b19b53f43803d6fcaae996df Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63728 Tested-by:
-
Benni Mack authored
If the TCA option "l10n_mode" is set to "exclude", the selected field in localised elements is wrong when using this option in conjunction with "l10n_display" => "defaultAsReadonly" in a select single element. In this case the variable $parameterArray['itemFormElValue'] seems to be a string, not an array as expected in SelectSingleElement.php. This patch adds a check for the array / string, as well as the same behaviour for the checkbox. Resolves: #76785 Resolves: #77257 Resolves: #84997 Resolves: #82843 Releases: master, 9.5 Change-Id: Ied0708dc378d73a8131791b28ebe1c61555c52aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63722 Tested-by:
-
Georg Ringer authored
The argument `optional="true"` must be added to the plain text layout as well - just as in the HTML version. Resolves: #90763 Releases: master Change-Id: I61ff71fd0780e2fdffba1c6b190fd60d1dc01581 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63726 Tested-by:
-
- Mar 14, 2020
-
-
Susanne Moog authored
The LocalDriver did not allow sorting folders by modification time. However, the property is available and can be used for sorting (for example in the file list). This has been adjusted so sorting by modification time is possible for both files and folders and the file list no longer displays folders in seemingly random order. Resolves: #76930 Releases: master, 9.5 Change-Id: Ib7711a6050ea220f015038b30607f7cac4ac8e14 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63673 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Riccardo De Contardi authored
Shows the correct labels for the dropdown options on the Linkvalidator interface (Show this level / Check this level) Resolves: #90762 Releases: master Change-Id: I1ba4889589357d6d39b3cc00bf31579bc2d29551 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63723 Tested-by:
-
Chris Müller authored
"Duplicated Entrypoints" instead of "Dupliated Entrypoints" Resolves: #90759 Releases: master Change-Id: Iddeeb06e6b55970c3d3b8f18a3ab59cd2837adf3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63717 Tested-by:
-
- Mar 13, 2020
-
-
Georg Ringer authored
The classes have been marked as internal and never contained any logic. Therefore and in order to streamline the codebase of Extbase, the files will be removed with TYPO3 11.0. Resolves: #90692 Releases: master Change-Id: I12398224f729672d6503285ba7d7e9dd10de1d18 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63641 Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
-
Christian Eßl authored
When dragging a page in the page tree, users would always see the red delete area, even if they do not have the permissions to delete the page. This is fixed now. Resolves: #83694 Releases: master, 9.5 Change-Id: Ibd8de52d529405ab57b022e854e361da69e4d3bc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63596 Reviewed-by:
-
Christian Eßl authored
Changing content in the 'source' mode textarea of ckeditor does not automatically trigger a change event for its parent textarea. Because of that, the field was never marked as "changed" in the FormEngine and the user would then not receive a warning modal when closing the form without saving first. This behaviour is now fixed. Resolves: #90621 Releases: master, 9.5 Change-Id: I4ecfee499ce5abda874c285a8babde29fb47c955 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63675 Tested-by:
-
Georg Ringer authored
Make a type cast for the argument additionalConfig as it might be that it is set as null. Even though the original cause might be in fluid standalone, it is easy to fix it in the meantime in our code base. Resolves: #89148 Releases: master, 9.5 Change-Id: If8c8a5addae1fa527a0d2b5fd01a6e6691d9af8b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63593 Reviewed-by:
Christian Eßl <indy.essl@gmail.com> Reviewed-by:
-
Georg Ringer authored
If an entrypoint URL is used more than once this will lead in errors and a warning will be shown in the site module. Resolves: #87533 Releases: master Change-Id: I2ed7e8859685ee28392599448b79107d3db2d6cc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63681 Tested-by:
-
Georg Ringer authored
The migration to Doctrine DBAL with #77455 missed additional parentheses for the or parts. Resolves: #85486 Releases: master, 9.5 Change-Id: Ie479e274f876c504c13ad7c14fbed4911d057e27 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63692 Tested-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
-
Andreas Fernandez authored
The Install Tool modals now fire up immediately after requesting a module. The spinners are now loaded in parallel and don't block the rendering of the modals anymore. Resolves: #90750 Releases: master, 9.5 Change-Id: I05ef7da7917fe2633598d2c533fd7ecbe0284221 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63698 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Andreas Fernandez authored
Resolves: #90580 Releases: master Change-Id: Ica10125976b2fe62f52ade05bbe3daf5f4a1dd7f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63484 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Torben Hansen authored
Fixes 2 usage examples for EditRecord- and NewRecordViewHelper Resolves: #90755 Releases: master, 9.5 Change-Id: I331934ce4049a5957469a958c27adb77c63a7b7d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63701 Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
Jöran Kurschatke <info@joerankurschatke.de> Reviewed-by:
-
- Mar 12, 2020
-
-
Georg Ringer authored
Adjust the check of the value to make it also possible to show the valid cell value '0' of content element table. Resolves: #83816 Releases: master, 9.5 Change-Id: Ie2f8d30b02deda5be88824cef334bf672d5cb35e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63684 Reviewed-by:
-
Andreas Fernandez authored
The search field was initialized twice which broke the clearable feature. Since we don't like redundancy we omit a second initialization and better do it right the first time. If the search field is emptied after querying the docs, the original state is recovered. All panels without exception are closed again. When panels get collapsed, only expanded panels are queried which improves the subjective performance of the process. An unavailable function `.contains` was used to filter changelogs by tags. Searching for a colon is now done via `String.prototype.includes()`. Any search action is now debounced to avoid massive DOM manipulations due to excessive typing in the search field. Resolves: #90737 Resolves: #85453 Resolves: #90738 Releases: master Change-Id: Ia3b4f2665c95e9c7e891feec73b57b869279d22b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63688 Tested-by:
-
- Mar 11, 2020
-
-
Andreas Fernandez authored
When a FormEngine document gets closed, the spinner now isn't rendered anymore. Resolves: #90723 Releases: master, 9.5 Change-Id: Id62c842335685a010bfbd918755b92fcd348f16c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63677 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Oliver Hader authored
Handling constructor arguments in extension scanner did not work since constructors are not directly called like a method would be called. Constructors are invoked instead using the `new` statement. Besides that `GeneratorClassResolver` only supported string class names (like `'Example\\MyClass'`) when being invoked using `GeneralUtility::makeInstance`. Scanner configurations related to `__construct` invocation (in terms of creating a new class instance) are now handled in a dedicated new `ConstructorArgumentMatcher`. Besides that, `GeneratorClassResolver` now supports `GeneralUtility::makeInstance(Example\MyClass::class, 123)` as well. `NameResolver` and `GeneratorClassesResolver` are executed in two consecutive `NodeTraverser` instances - otherwise class names cannot be resolved in a reliable way. Resolves: #90722 Releases: master, 9.5 Change-Id: I0154b04674d2637fda817d39a1136c2c8fa389d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63676 Tested-by:
-
Susanne Moog authored
The string "N/A" was hardcoded in BackendUtility and has now been made translatable. Resolves: #76361 Releases: master Change-Id: I465956999fbbbcdc45175b59c42a5f1a2b31d4dc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63672 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
Georg Ringer authored
The test `getParseTimeReturnsTotalParseTimeInMilliseconds` fails regularly and needs some improvement. Resolves: #90730 Releases: master Change-Id: I9fb0ce30180da03e633c764c33282ddf7fe83f7c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63679 Tested-by:
-
