- Jun 28, 2021
-
-
Benni Mack authored
In order to make TYPO3 Core compatible with doctrine/dbal 3.0, Core now requires doctrine/dbal 2.13 to allow to track all deprecations and use the forward-facing APIs. Used composer commands: * composer req doctrine/dbal:^2.13 * composer req doctrine/dbal:^2.13 -d typo3/sysext/core --no-update * composer req doctrine/dbal:^2.13 -d typo3/sysext/install --no-update * composer req doctrine/dbal:^2.13 -d typo3/sysext/redirects --no-update Resolves: #94423 Releases: master Change-Id: Ifede8ebdac0b47a0db0ba5d304878c91c3579f58 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69632 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Benni Mack authored
This change moves state for caching purposes from $GLOBALS[LANG] into the runtime cache allowing for further reducing the need to keep the LanguageService in a global state. Resolves: #94415 Releases: master Change-Id: Id8bc974fc65e630695d5f86a13ff0c137cd8f3ba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69551 Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Benjamin Franzke authored
Only the container entry – which acts as backend for GeneralUtility::makeInstance(LanguageService::class) is deprecated. The class is left as-is, but should be factored via LanguageServiceFactory. Therefore also all the factory methods are deprecated in order for the LanguageServiceFactory to be used instead. Resolves: #94414 Releases: master Change-Id: Iab0f713a5baf95c419338748e8df4102d46c37a4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69367 Tested-by:
-
Oliver Bartsch authored
Resolves: #94416 Releases: master Change-Id: Id11afdd6d7ba00cd9ed1712aa43543dfc85d7725 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69574 Tested-by:
-
- Jun 27, 2021
-
-
Simon Gilli authored
In the install tool context $GLOBALS['BE_USER'] is not available and any access must be avoided especially from PHP 8.0. Resolves: #94418 Releases: master Change-Id: I1df52aedd9ba1149e4009c9cc3a6707ba114c607 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69576 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Larry Garfield authored
Resolves: #94382 Related: #94315 Releases: master Change-Id: I250ccfa09863f7cdc48ad58bb7d9d5fc922d76c5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69523 Tested-by:
-
Benni Mack authored
In order to help support upgrade paths, some key information is kept until TYPO3 v12 (= not yet removed), so this documented properly now. Resolves: #94412 Releases: master, 10.4 Change-Id: I5ce94d24dfd57008374272e48ee9132974f6a562 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69572 Tested-by:
Riny van Tiggelen <info@online-gamer.nl> Tested-by:
-
Simon Gilli authored
A new TCA property "description" is available to be added to palette configurations. It allows to provide additional text, which will be rendered by FormEngine between the palette label and the corresponding fields. It is similar to the TCA field description, introduced in #85410. This will support editors as specific field usages can be clarified directly in the UI. In contrast to the palette label, the new description property can not be overwritten on a record type basis. Resolves: #89507 Releases: master Change-Id: I4390e13830d359d54c37a347b91960de5639da4c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62109 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
- Jun 26, 2021
-
-
Lina Wolf authored
Resolves: #94419 Releases: master Change-Id: I933abbda5a3420a11a4f1ac3fe6501acdc796727 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69592 Tested-by:
-
- Jun 25, 2021
-
-
Oliver Bartsch authored
This fixes "Undefined array key" warnings, triggered in recordlist and related areas. Resolves: #94401 Releases: master Change-Id: I34490cd8390fc3a2d0a9a40d666e2dc5a00e3e51 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69546 Tested-by:
-
- Jun 24, 2021
-
-
Benni Mack authored
For TYPO3 v10, in 81660b4c (see https://review.typo3.org/c/Packages/TYPO3.CMS/+/61385) the JavaScript global variable T3_THIS_LOCATION has been deprecated and successfully removed in TYPO3 v11.0. However a few places are left, so they are removed now. Relates: #88854 Resolves: #94410 Releases: master Change-Id: Id61eb1bd28c140415cca01cd1a21e2b9e6076425 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69549 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Jochen Roth authored
A click on inline fal ElementInformation button leads to Undefined array key "returnUrl". Fixed by adding empty string as fallback and add an acceptance test to make sure it will not appear again. Resolves: #94400 Releases: master Change-Id: I7e44b026f81b0d484e3b8a1af5522fece228d5d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69544 Tested-by:
-
Oliver Bartsch authored
This fixes a TypeError by type-casting the $pageId argument. Resolves: #94409 Related: #89700 Related: #94210 Releases: master Change-Id: I0840ace1fbcaf62e4a5d2883e1d50a511e949d81 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69548 Tested-by:
-
- Jun 22, 2021
-
-
Sybille Peters authored
In the select list in "Info > Page TSconfig" the technical representation of the terms (as they are used when setting TSconfig) is now shown in brackets, e.g. [RTE.]. This is consistent with showing the technical representation in other places in the backend, such as the page id in the page layout or page tree, the table fields and Flexform fields in the edit forms etc. Where there are descriptive terms, (such as "Module: Web>Page") a combination of the descriptive terms and the technical terms is used, such as "Module: Web>Page [mod.web_layout.]" The explanation "with overruling user settings" for mod is omitted. This would make the list more cluttered and visually distracting. If it is necessary to point this out, it might be added as a note in the results. Resolves: #94323 Related: #94322 Releases: master, 10.4 Change-Id: I728f3d6399f040356d7bee4e30c3f33baf9703d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69467 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Oliver Bartsch authored
Since the method has to return true in case the page translations should be displayed, the TCA "hideTable" check must be negated. This would otherwise lead to page translations not being displayed if the "hideTable" key is not defined in pages TCA. Furthermore, the TSconfig option "hideTable" also contains the `table.` key. Note: Only master is affected as backport was not yet merged and will therefore contain the correct check. Resolves: #94398 Related: #94386 Releases: master Change-Id: I96b2676b3acde6bfc3436fd16fc31ca76ba3d185 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69539 Tested-by:
-
Jochen Roth authored
When a user opens Info -> Page TSconfig it will throw an error "Undefined array key tsconf_alphaSort". Fixed by adding 0 as fallback to the array access. Another test was added which checks if modules in the toolbar dropdown are callable. Resolves: #94392 Releases: master Change-Id: I2e1f2e4b687155fa1d1c13791f46f10915c834f9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69536 Tested-by:
-
Christian Kuhn authored
Extbase Request setDispatched() and isDispatched() violate the PSR-7 'immutable' concept and need to fall. With the changes from #92502 where extbase actions usually return a ResponseInterface, together with the deprecation of StopActionException in #94351, we don't need this information in the Request anymore: It can be handled internally within the dispatcher, depending on the type of the response. The patch deprecates the two methods in extbase request and adapts usages towards an internal flag. We throw a deprecation warning since the flag is needed for b/w compat in v11, though. Resolves: #94394 Related: #94351 Related: #92502 Releases: master Change-Id: I1c70daa7f5b0c55e17e4b7c815d260ca68cef23c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69470 Tested-by:
-
Rico Sonntag authored
PHP Warning: array_key_exists() expects parameter 2 to be array, null given in ArrayUtility.php line 297, when an longer path than exists in given array is set. Releases: master, 10.4 Resolves: #94379 Change-Id: I9ef40d2cf82f777b3a289dfaa4f8cbfcc2a5bba5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69521 Tested-by:
crell <larry@garfieldtech.com> Reviewed-by:
-
Oliver Bartsch authored
Since #27471 it's possible to hide all or specific tables within the recordlist. However, the special "page translations" table did not respect those settings, making it impossible to hide this table. This is now fixed by respecting the corresponding settings. Resolves: #94386 Releases: master, 10.4 Change-Id: I33575624ade9ecf840b6fde713a7d3214d6506be Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69535 Tested-by:
-
- Jun 21, 2021
-
-
Benni Mack authored
This change replaces the "collapse-horizontal" functionality of the extended view icons into a dropdown from Bootstrap, allowing users to understand the icons better because the text is now also written next to the icon (similar to the Context Menu). The horizontal collapsing is removed as a UX improvement to a) give consistency around other areas in TYPO3 Backend b) was intended as a workaround to solve the Extended View rendering and to avoid button-hell c) avoid confusion around editors when buttons are visually moving horizontally d) the Extended View feature was unclear for editors when to enable it In addition the "View" link is now moved into the secondary button group. The Extended View checkbox is therefore removed as all secondary options are always available. Same functionality is also replaced in the File List module to use the "..." icon to show that there are more actions available. Side note: The dropdown needs a position-static due to overflow-x: auto - see https://github.com/twbs/bootstrap/issues/29313#issuecomment-758412385 Resolves: #94390 Releases: master Change-Id: I925aa7690068fbde3f3aa5217f3f5629a2a890d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67458 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Torben Hansen authored
Since the removal of the old pi-based plugin some of the old TypoScript constants in styles.content.loginform were left unassigned. With this patch, all TypoScript constants are assigned to their associated setup variables, so users updating from the pi-based plugin and mainly using constants for configuration can easily migrate to the Extbase version of the plugin. The following unused TypoScript constants are removed: * templateFile * feloginBaseURL The constants `pid` and `recursive` are mapped to the TypoScript setup `pages` and `recursive`. The TypoScript setup variable `replyTo` is removed, since it is unused in the extension and the settings has been replaced previously by `TYPO3_CONF_VARS.MAIL.defaultMailReplyToAddress` The documentation is adapted to match the current state of the extension and existing images have been replaced with current versions. Resolves: #94328 Releases: master Change-Id: I509201b1e2ce1194e70af3a618b42ba6c5d80ce3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69471 Tested-by:
-
Oliver Bartsch authored
A display bug is fixed by using the correct closing tag for a link inside a button group in recordlists' single table view. Resolves: #94391 Related: #92652 Releases: master Change-Id: I7634aa6566674a5d0ae9c0683e6b633c196006cb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69534 Tested-by:
-
Christian Kuhn authored
Finish ObjectManager removal / fallback works in ext:form. The validators are no issue since they have been postulated of not being autowire DI aware in v11.0 with #92238 already, so we can follow this. Resolves: #94384 Related: #90803 Related: #92238 Releases: master Change-Id: I1115d2eaa595fa5685f6549843b4f388d5d07c98 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69525 Tested-by:
-
Jochen Roth authored
Enables EXT:dashboard when running tests which required a few changes to wait for pageTree to be fully loaded Resolves: #94373 Releases: master Change-Id: If9f91626f03e9b95e0c26c4a3a264aa0f064d412 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69519 Tested-by:
-
Christian Kuhn authored
Core Configuration\TypoScript\ConditionMatching\AbstractCondition is an old TypoScript condition leftover, unused and can be removed without further notice: It has been added in with #61489 in v7 - own condition classes for TypoScript, superseded with #85829 in v9 - symfony expressions for TypoScript conditions, old syntax has been deprecated in v9 with #86068 and removed in v10 with #87607. Change-Id: I5283a06650d5bfa975685a4f91cb918d7653f460 Resolves: #94387 Related: #61489 Related: #63600 Related: #85829 Related: #86068 Related: #87607 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69533 Tested-by:
-
Kevin Appelt authored
You can now customise the template paths of felogin via TypoScript constants. Resolves: #90953 Releases: master Change-Id: I8bca313430f4f6c79735eb59a5710455a43a45cd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64080 Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
-
Benni Mack authored
When setting up permissions and a good folder structure, admins should be able to create new sys_filemounts from the context menu of a folder, so they do not have to use the list module (or the be_groups wizard) but can conventiently use the file list module OR the file tree. Resolves: #94374 Releases: master Change-Id: Idb9781136eb24cb266eb61cd9f3138ab9b91650e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69516 Tested-by:
-
Jochen Roth authored
Will fix creation/edit content as well as publishing workflow for workspaces and add a basic ac test for page change, switch workspace and publish Also EXT:workspaces is now enabled in test environment Resolves: #94361 Releases: master Change-Id: I9f85a4edaa90e77cbdfc5f988007917263ed51ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69508 Tested-by:
-
- Jun 19, 2021
-
-
Robert Vock authored
Some documentation files containted incorrect :issue:`#XXXX` links instead of :issue:`XXXX` (without #). Releases: master Resolves: #94385 Change-Id: I1946426e8c5464d890b62238cd863a314cc8a0e5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69532 Tested-by:
-
- Jun 18, 2021
-
-
Christian Kuhn authored
Most ObjectManager->get() calls in FormRuntime can be moved to makeInstance() directly without further impact. For FormFactoryInterface, a b/w compat layer is established, but shouldn't be problematic since this will be ArrayFormFactory in almost all cases. Change-Id: I354d582260307986cb386506fa5e006646ca816a Resolves: #94370 Related: #90803 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69515 Tested-by:
-
Benni Mack authored
This change moves the CSV Export in the header of each table within the record list. This contains multiple UX improvements: * CSV Exports are now possible in each list view, not just in single table view * CSV Export Buttons are visually connected to the actual records and the output * The CSV Button now has a proper label next to the icon instead of just an icon in the docheader In addition, the RecordListController is thinned out as all logic is separated and moved into a new RecordExportController. Resolves: #94366 Releases: master Change-Id: Ia64b513636799368a39b5028b6cad7ebac6fe835 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69512 Tested-by:
-
Oliver Bartsch authored
This change ensures that deleting selected records (when clipboard is activated) only happens for POST requests in the RecordListController. Also, the given "cmd" argument from the request is not longer overwritten by the DataHandler command array. Resolves: #94380 Releases: master Change-Id: I8c4c728469fd60b9a41dd48c63c46837c9c9dbf2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69522 Tested-by:
-
Christian Kuhn authored
When extbase has been changed to PSR-7 responses, class ReferringRequest has been nearly obsoleted: It is only used to be immediately turned into a ForwardResponse. To further prepare towards PSR-7 requests, usage of ReferringRequest which extends extbase Request is dropped and the class marked as deprecated. Change-Id: If16c09b0601792f6702fbacee064cd4d514c70c6 Resolves: #94367 Related: #92502 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69513 Tested-by:
-
Christian Kuhn authored
ObjectManager->getEmptyObject() is only used in extbase persistence DataMapper when domain objects are "thawed": An existing DB row is fetched and a model object is created from it. From extbase PoV, a domain object lifecycle is "creation" ("own a new car"), then eventually "freezing" it in DB, "thawing" it from DB to update it's state ("washed today, it's now clean"), and eventually deletion ("brought to scrapyard, don't own it anymore"). Extbase now says that "thawing" and "creation" are two different things and thus decided that programmatically, __construct() on thawed objects should NOT be called, because, well, it's not new, just thawed! Don't assume __wakeup() is called instead, though: It's not. Extbase of course has to hop through quite some loops to violate this PHP language construct. It even needs the 3rd party dependency doctrine/instantiator to achieve suppressing __construct() call, since the previous 'unserialize hack' broke somewhere during PHP 5 times. Additionally, even though extbase Domain Model objects *should* be plain old PHP objects, they still allow inject* methods and are dependency injection aware. This is a problem when moving away from ObjectManager towards symfony DI, because symfony does not support this creative extbase view of supressing __construct() when instantiating objects. We can't get rid of this easily in extbase, though. There is no good way to deprecation-log this behavior. A feature toggle seems to be overkill - probably not too many extbase devs are aware of this implementation detail in the first place, and the impact if __construct() is properly called when an object is thawed should be relatively small: First, models are usually relatively stupid in extbase (which is good, they should be), and if they have a __construct() method at all, chances are, everything that is done there is overriden during the following mapping process anyways. We thus decided against a feature toggle for this. Instead, we *keep* the current instantiation logic in v11, just mark the code places as deprecated, configure the extension scanner to look for additional getEmptyObject() calls in extensions, and add a depreation reST file pointing out the situation and stating __construct() will be called in v12 for thawed objects. Resolves: #94377 Related: #90803 Releases: master Change-Id: Ied3da8b9d885be2f635b9bc6c66b37fc9825decc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69520 Tested-by:Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
Oliver Bartsch authored
The FileProvider tries to retrieve the file / folder object on initialization. In case the requested folder or storage is temporarily offline, a ResourceDoesNotExistException is thrown. This is now fixed by catching the exception an setting the $record to NULL. This allows to still render the context menu with the remaining options, such as edit the storage record or display the records information. Resolves: #94372 Releases: master, 10.4 Change-Id: I2ef6437b0d6e22462d73c9536433d7dc1914f680 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69517 Tested-by:
-
Oliver Hader authored
Extracts TypoScript instruction handling to test trait, which enables to reuse corresponding methods. Resolves: #94354 Releases: master, 10.4, 9.5 Change-Id: I34f25070d926f1236b1f7bbd623e0060760b0819 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69501 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Oliver Bartsch authored
One warning was triggered by an inline JavaScript assignment, which is unused since at least v9. It's therefore removed. Resolves: #94364 Releases: master Change-Id: I8c680d393ce7449be17e68757aa1bc8698360667 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69511 Tested-by:
-
- Jun 17, 2021
-
-
Larry Garfield authored
The 'event:' tag in Services.yaml can be omitted since, the wiring is done automatically by reflecting the target method at compile-time. Resolves: #94345 Releases: master Change-Id: I58c9072efec3dd70c8d8768dc290cf1aa6543902 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69495 Tested-by:
-
Christian Kuhn authored
Finish the ObjectManager usages in ext:fluid. With #94285 we made the ViewHelperResolver a singleton service, which is not ok since it holds state: Namespaces are added at runtime and they additionally depend on request. The solution is similar to RenderingContext from #94285 though: Have a factory to create fresh instances for each parsing cycle for this failsafe mode enabled class. View helper instance prototypes itself are then retrieved using GeneralUtility::makeInstance(). Resolves: #94292 Related: #94285 Related: #90803 Releases: master Change-Id: I08018b57e3bd5b293be999d7c5415578604c7897 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69419 Tested-by:
-
Daniel Goerz authored
EXT:lowlevel EXT:recordlist EXT:recycler EXT:reports EXT:rte_ckeditor Resolves: #94265 Releases: master Change-Id: I4e5e94f3e9f041e4ee8bab93a7ced73077250ee9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69371 Tested-by:
-
