- Sep 08, 2017
-
-
Benni Mack authored
Before, the history module fetched info about "modified records" from sys_history+the authoritive user from a coupled sys_log entry. Info about "insert" and "delete" was fetched from sys_log solely. However, when using a scheduled cleanup task to truncate sys_log then all history information is useless (see bug report). The patch introduces a new RecordHistoryStore as an abstraction for adding history entries (currently done solely within DataHandler). It adds some additional, necessary SQL fields to sys_history to store all information in there and creates an update wizard to migrate all coupled sys_history/sys_log entries to a new sys_history entry itself. Additionally, the whole existing "RecordHistory" class is now only necessary for fetching the so-called ChangeLog, for a page or a specific record, and to do rollbacks, preparing the history records so they can be worked on. The whole logic for fetching the GET/POST parameters is moved into the "ElementHistoryController", everything that is only possible via Fluid is moved from the RecordHistory object and the ElementHistoryController into the view. Referencing from sys_log (Log module) into sys_history is now done the other way around, storing information about the corresponding history entry inside sys_log. As a side-effect, sys_log should load faster. Abstraction basis: - sys_history is the only source of truth about the history of a record - sys_log contains a reference to an history entry now (inside sys_log.log_data) to link from the backend log module - RecordHistoryStore exists for tracking changes to records - RecordHistory is for retrieving, compiling the history/changelog and rollbacks - ElementHistoryController is doing PSR-7 style request/response handling and preparing data for the view - Fluid is handling more view functionality now, removing the need for doing <f:format.raw> everywhere in the templates. Sidenotes: * Data within sys_history is now stored as JSON, not serialized anymore * Adding/deleting was previously stored in sys_log only, is now within sys_history * Moving records is now tracked (but not evaluated yet) * Highlight/Snapshot functionality within the Backend Module was removed This functionality is built so it can also be used within Extbase persistence and in FE in general in a future iteration. Resolves: #55298 Resolves: #71950 Releases: master Change-Id: I354317609099bac10c264b9932e331fa908c98be Reviewed-on: https://review.typo3.org/53195 Reviewed-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Joerg Kummer <typo3@enobe.de> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Daniel Lorenz authored
Catche YAML parsing errors and display this them alongside their form definition files in form module and plugin. Resolves: #82369 Releases: master, 8.7 Change-Id: Icf71027d21d0a8e30c238a51369676715de2e5c5 Reviewed-on: https://review.typo3.org/54014 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
Carlos Meyer <cm@davitec.de> Tested-by:
Bjoern Jacob <bjoern.jacob@tritum.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Benni Mack authored
The extension manager has the option to upload an extension into typo3/sysext/, which is no recommendation and should not be an option from the Backend UI itself, as it is heavily conflicting with core updates where typo3_src/ / sysext is exchanged. The option is removed without substitution, if somebody wants to play with typo3/sysext/ it's at the admins own risk, and should not be encouraged or mentioned neither in the install tool (All Configuration) nor Extension Manager. Resolves: #82377 Releases: master Change-Id: I19782a4960bb52bd2012b79e912e483610d297d8 Reviewed-on: https://review.typo3.org/54008 Reviewed-by:
-
Matthias Vogel authored
Resolves: #82385 Releases: master Change-Id: I7bbb7066e7097b56509bbaaeee3468723420af74 Reviewed-on: https://review.typo3.org/54023 Tested-by:
-
Andreas Steiger authored
Cleanup SCSS of Form Framework. Improve the usage of variables. Furthermore, optimize the structure tree spacings of Form Editor. Resolves: #82327 Releases: master Change-Id: Ia1088475e16e5a04999140cca5ee3ff7d713e661 Reviewed-on: https://review.typo3.org/53962 Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
Alexander Schnitzler authored
This commit migrates the command "lang:language:update" from an extbase command controller to a symfony console command. Also, the alias language:update will be flagged deprecated. Resolves: #82315 Releases: master Change-Id: If9fd08981ee8286bd8187fe5eaa5b36f625bd576 Reviewed-on: https://review.typo3.org/53928 Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
-
Matthias Vogel authored
In order to refactor the page module, list module, and the file module individually, the classes should become independent from each other. Resolves: #82334 Releases: master Change-Id: I2ca6aad28cbe4a88c03ef71f47fc11eb4b7649f7 Reviewed-on: https://review.typo3.org/53947 Tested-by:
-
Benni Mack authored
ErrorHandler should deal with the same severity for trigger_error() for E_USER_DEPRECATED as GeneralUtility::deprecationLog() when calling GeneralUtility::devLog(). Resolves: #82375 Releases: master, 8.7 Change-Id: Iaff5f96f5bd0a2d94bb3bc76d9d3fec2d019c901 Reviewed-on: https://review.typo3.org/54017 Tested-by:
-
Oliver Hader authored
The explicit allow/deny section of backend user groups (be_groups) render separators (--div--) in the backend which need to be skipped. Change-Id: Iac578d43a7a561618d095819b9d667c613621f2b Resolves: #82379 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/54009 Reviewed-by:
Simon Praetorius <simon@praetorius.me> Tested-by:
-
Markus Hoelzle authored
Fix link to configuration of distribution packages and redirect after saving this confiuration. Releases: master,8.7 Resolves: #82376 Change-Id: I7f054a32187260e102b30c097937d5348ec121a6 Reviewed-on: https://review.typo3.org/54005 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Benni Mack authored
ErrorHandler has a few minor quirks: 1. the protected property is an integer (bitwise-comparison) but initialized as array 2. small indention and repeatable string introduction 3. human-readable text for E_USER_DEPRECATED missing 4. error handling when no autoloader is available is obsolete. The patch fixes all these minor issues. Resolves: #82375 Releases: master, 8.7 Change-Id: Id6f9616602021e04ac6a50737438253a62da788c Reviewed-on: https://review.typo3.org/54002 Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
Christian Kuhn authored
This reverts commit 4bc4fb02. The patch turned a PHP \Error into \Exception, which adds no value, but can be misleading. Change-Id: I6cc32da6c0620cb0d717c930d10fa4338d6cefac Releases: master, 8.7 Resolves: #82131 Reverts: #82131 Reviewed-on: https://review.typo3.org/54004 Reviewed-by:
-
Daniel authored
Releases: master, 8.7 Resolves: #82362 Change-Id: I36a4341aea620027822af1b8714e9197ff4bcb00 Reviewed-on: https://review.typo3.org/53972 Reviewed-by:
-
Christoph Lehmann authored
Resolves: #82290 Releases: master,8.7 Change-Id: Ie988290ae4431f8a77dc2c38397429b9fa0c95ef Reviewed-on: https://review.typo3.org/53879 Reviewed-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
-
Stefan Neufeind authored
Resolves: #82321 Releases: master, 8.7 Change-Id: Idd47fbb0b7af3f5668d45a6aee545c794ec17a1a Reviewed-on: https://review.typo3.org/53937 Tested-by:
-
Andreas Fernandez authored
Fix a forgotten comment. Resolves: #82335 Releases: master Change-Id: Iff63f765fd741462cbed56e56543916f92b65444 Reviewed-on: https://review.typo3.org/53998 Reviewed-by:
-
Benni Mack authored
When TYPO3 v8.0 switched to Fluid standalone, the RootNode class was removed but the references were kept and done via class aliases. The Fluid standalone class should be used instead of the class alias. Resolves: #82335 Releases: master, 8.7 Change-Id: I50f74b71b86fcc347dc6bffbde052e6e2adbc842 Reviewed-on: https://review.typo3.org/53945 Reviewed-by:
-
Alexander Opitz authored
Resolves: #82322 Releases: master, 8.7, 7.6 Change-Id: I31f7bc2db61337e10be7ffd44ac294b77c44d07b Reviewed-on: https://review.typo3.org/53939 Tested-by:
-
Mathias Brodala authored
Resolves: #81805 Releases: master, 8.7 Change-Id: I8ee3582170db9812d7be2b9710cb4d46335ec86a Reviewed-on: https://review.typo3.org/53969 Tested-by:
Daniel Lorenz <daniel.lorenz@extco.de> Reviewed-by:
-
Mathias Brodala authored
Prevent selection of _cli_ user as system maintainer. Related: #82319 Resolves: #82367 Releases: master Change-Id: Ia1e67faea383817d4931c956a166525e1aa9e8e0 Reviewed-on: https://review.typo3.org/53981 Reviewed-by:
-
Ralf Zimmermann authored
Add a "renderingOptions" property called "_isHiddenFormElement" to prevent form elements from being shown within summary pages and emails. Resolves: #81770 Releases: master, 8.7 Change-Id: Iea3232879fc2be2cae00e5ed5cea565e68e192f3 Reviewed-on: https://review.typo3.org/53383 Reviewed-by:
-
Thomas Kieslich authored
Change language labels and move them to ext:form locallang.xlf. Change the icon to content-form. Resolves: #81650 Releases: master, 8.7 Change-Id: I1c497b78da92dc589ad9d7a47dde35c5aeba488a Reviewed-on: https://review.typo3.org/53957 Reviewed-by:
Ralf Zimmermann <ralf.zimmermann@tritum.de> Tested-by:
-
Matthias Vogel authored
Resolves: #82359 Releases: master Change-Id: Id439a0b04e6af11214d0df7b30cb20e7c94dd99c Reviewed-on: https://review.typo3.org/53971 Tested-by:
Markus Hölzle <typo3@markus-hoelzle.de> Reviewed-by:
-
Benni Mack authored
The global variable $GLOBAL['error'] is used only in ExtJS-context for ExtDirect (via ExtDirectDebug) however, but evaluates at every request. This is the first of a series of patches to remove ExtJS in total. The global methods debugBegin() and debugEnd() are removed as well. Resolves: #37180 Releases: master Change-Id: I00843d85660e85c213ac66059abdd84344c4fe3f Reviewed-on: https://review.typo3.org/53817 Reviewed-by:
-
- Sep 07, 2017
-
-
Christian Kuhn authored
Adds a card to the "Settings" menu to allow configuration of "System Maintainers" in the install tool writing SYS/systemMaintainers array to LocalConfiguration. Change-Id: I0219b60e9a261373befab7b846e55b61ea215e5e Resolves: #82319 Releases: master Reviewed-on: https://review.typo3.org/53931 Tested-by:
Matthias Vogel <typo3@kanti.de> Tested-by:
Łukasz Uznański <l.uznanski@macopedia.pl> Tested-by:
-
Ralf Zimmermann authored
Fix JavaScript errors if "properties.options" array keys contain dots. Resolves: #80197 Resolves: #82210 Resolves: #81961 Resolves: #82186 Releases: master, 8.7 Change-Id: Idfa976bca2ba5bbe08a72852f306c83d84b8eef0 Reviewed-on: https://review.typo3.org/53956 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
protos authored
Insert missing id attribute for image and file upload element. Resolves: #82223 Releases: master, 8.7 Change-Id: Ia88cda2db1eda1ce6dab0678052e089184d8b0cd Reviewed-on: https://review.typo3.org/53959 Reviewed-by:
-
protos authored
Change some wording for better understanding in frontend and backend. Resolves: #82326 Releases: master, 8.7 Change-Id: Idc43a1543a315f5d54fdaf6c575a2f7ef0084aae Reviewed-on: https://review.typo3.org/53951 Reviewed-by:
-
Ralf Zimmermann authored
It is now possible to add HTML5 elements with its needs. Resolves: #80130 Resolves: #80128 Resolves: #80127 Resolves: #80125 Resolves: #80126 Releases: master Change-Id: I1088d77c8ee52cca93878847a5d59c6b92faf1de Reviewed-on: https://review.typo3.org/52016 Reviewed-by:
-
Ralf Zimmermann authored
Fix JavaScript errors on page drag & drop within the form editor Resolves: #82337 Releases: master, 8.7 Change-Id: I6e67b05a68273f1ad2d6f851ed5dfa4781d7d5bb Reviewed-on: https://review.typo3.org/53949 Reviewed-by:
-
Susanne Moog authored
Extension configuration is now stored as plain array instead of serialized values. To ensure backwards- compatibility and stream-line core usage, the old values will still be stored and written in $GLOBALS['TYPO3_CONF_VARS']['EXT']['extConf'] whereas the new array will be stored in $GLOBALS['TYPO3_CONF_VARS']['EXTCONF']. As a second step we are going to introduce an API for retrieving extension configuration to remove the necessity for GLOBALS access in this case. Resolves: #82254 Releases: master Change-Id: I52ef7768491633e114e7e1b153a4ba63e07243ff Reviewed-on: https://review.typo3.org/53657 Reviewed-by:
Romain Canon <romain.hydrocanon@gmail.com> Tested-by:
-
Benni Mack authored
Currently calling the install tool modules from within the Backend does a simple redirect with adding GET variables. That's the reason why you need to re-authenticate again, and the context is handed over as a query parameter, which is simply not needed at all. Now, the redirect is removed, as the Backend entrypoint / request handler handles the authentication of the backend user, and the standalone entry point deals with the install tool password etc. The context parameter is now detected by the entry point (!) as well, allowing to get rid of quite some code. There are some more consequences: - Calling the install tool from the backend does not validate if you configuration is set up (= recovery necessary) -> since you're already in the backend we guess you're fine anyway. - Redirect functionality is almost not needed anymore in the regular request handler - routeParameters concept was removed again (which was introduced a couple of weeks ago) Additionally, the contextService could be replaced at a later stage with just a string. Resolves: #82306 Releases: master Change-Id: If7e4ddfaccf46cf93448d06c0ba9af81d5b9494c Reviewed-on: https://review.typo3.org/53860 Reviewed-by:
-
Daniel Lorenz authored
Properly render multiline form values in summary page and HTML emails. Resolves: #82026 Releases: master, 8.7 Change-Id: Ic0d9cca3712437cd4625a4644355f77db8f01587 Reviewed-on: https://review.typo3.org/53950 Reviewed-by:
-
Mathias Brodala authored
Use shorter file paths to reduce the risk of hitting the Windows file path limit. Resolves: #82336 Releases: master Change-Id: Ibbba15a71b6b69df52ccf009ebe298f09840d864 Reviewed-on: https://review.typo3.org/53946 Reviewed-by:
-
Tymoteusz Motylewski authored
Functional tests checking Extbase rendering of tt_content records with FAL images. Also fixes two typos in fixture data. Resolves: #82298 Releases: master, 8.7, 7.6 Change-Id: I2cddf81a99b08df46a7fd03dc0e54b41b10452e5 Reviewed-on: https://review.typo3.org/53921 Reviewed-by:
Nathan Boiron <nathan.boiron@gmail.com> Tested-by:
-
Susanne Moog authored
Usage of limit > 0 or offset in a count query do not make sense and result in broken pagination in the list module as the returned total count of items is always 0. Reset given offsets/limit for that exact query. Change-Id: I18b1964b860e51256a6d0a5f39fd4c40544bac85 Resolves: #82325 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53940 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Ralf Zimmermann authored
* Show messages within page module and form engine if the backend user does not have access to the selected form definition. * Show flash messages within page module and form engine if the ext:form configuration is invalid. Resolves: #80678 Resolves: #81113 Releases: master, 8.7 Change-Id: I9646b31ac44752b8871635c8f1a04547872e715d Reviewed-on: https://review.typo3.org/52701 Reviewed-by:
Frans Saris <franssaris@gmail.com> Tested-by:
-
Benni Mack authored
Defining all configuration options in TYPO3 Install Tool is now handled via a Yaml file which additionally specifies the "type" of the configuration option, allowing to use further render settings, one of them already introduced for "allowedValues". This moves the "All Configuration" to a more flexible output rendering of dropdowns for a specific type. Resolves: #82312 Releases: master Change-Id: Id23c6a8e57177a68659fe98cbe7278f8744c0c34 Reviewed-on: https://review.typo3.org/53923 Tested-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Tested-by:
-
Claus Due authored
This patch removes the previously introduced runtime cache and early returns from TemplatePaths, both of which were implemented in an attempt to prevent excessive TypoScript parsing - an issue which has since been solved by optimising the TypoScript parsing enough that a cache and early return is no longer necessary (no longer constitutes a significant performance increase). The early return and caching introduced regressions described in the related forge issues. Removing both solves those problems. In addition, the method resolving TypoScript paths is now covered by extensive unit tests confirming everything from merging to sorting of template paths. An average of 8 tests cover the method's lines. Each of the expected behaviors is now declared as specific test. Change-Id: Ia6d505dcec7d77ad7aaeea9094d7d85a58553c63 Resolves: #82196 Resolves: #82181 Related: #79662 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53917 Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
- Sep 06, 2017
-
-
Benni Mack authored
This brings PHP 7.2 support for guzzle functionality. Verified that guzzle still runs with PHP7.0 (min requirement for us) Resolves: #82313 Releases: master, 8.7 Change-Id: I65b27c41d49dcb8b740b6f276da305df864ff50e Reviewed-on: https://review.typo3.org/53924 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
