When an SQL error occurs, TCEforms shows the error message
 "This may indicate a table defined in tables.php is not
 existing in the database!"

The error can be caused by any schema mismatch, not only
missing table, so this is misleading.

The error message is now localizable and gives a hint to
run the database compare in the install tool.

Change-Id: I31bea64cf656c951bc63a89eff47fbeb893ae73f
Resolves: #16306
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/4764
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

For a page with translations, the clickmenu is not shown for these
translations in the page module, view "languages". This comes from a
missing table name in the clickmenu link generation call.

Change-Id: Ib153002ca39953e6c86803a6ed56d1495553fb8c
Resolves: #27052
Releases: 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/4661
Reviewed-by: Björn Pedersen
Reviewed-by: Xavier Perseguers
Reviewed-by: Stefan Neufeind
Tested-by: Xavier Perseguers

Commit d7580828 wrongly introduced
'null' value instead of 'NULL' as stated in our coding guidelines.

Change-Id: I94a96bca16a714bdaa1a5967ac510d8ac5c6154d
Related: #28297
Releases: 4.6
Reviewed-on: http://review.typo3.org/6253
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

Change-Id: Id529c54a98e036ed3e3597e61f058cef8a55b050
Resolves: #30768
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/5733
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

When suggest wizard is used in a form open from the wizard_edit
popup wizard, javascript cannot access to "top.TS.PATH_typo3" value.

Change-Id: I300d297713c92e6b3fba58bf92ae0198d5abafe2
Resolves: #28930
Related: #23789
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/4277
Reviewed-by: Björn Pedersen
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

When entering short numeric values in the Page Tree filter of a large
tree, a PHP Fatal Error can occur:
Call to a member function offsetExists() on a non-object.

Change-Id: I3734769a068e442359dc69d4262fd237f9384860
Resolves: #28297
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/5729
Reviewed-by: Benny Schimmer
Tested-by: Benny Schimmer
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Since TYPO3 4.6 ships with the requirement of IM6, the truecolor
processing on PNG files can be enabled by default.

Change-Id: I7be3cceeb92bc7dba6c3d59bec694bb4fc49940b
Resolves: #31159
Reviewed-on: http://review.typo3.org/6224
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

If a search expression matches an extension key, the result
should be listed at the 1st place.

For example searching for "templavoila" or "news" should have
the templavoila extension or news extension at the 1st place
and not on a random one.

Change-Id: Ib0abb290b810b903d9e277935f81d88cadc18f8a
Resolves: #31143
Releases: 4.6
Reviewed-on: http://review.typo3.org/6134
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Oliver Hader
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Change-Id: Ica15a5b3eb15394550756139eb685a8328ce10d8
Fixes: #31216
Releases: 4.6
Reviewed-on: http://review.typo3.org/6216
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Hidden input elements in the form wizard are not visualized at
all in the user interface. A dotted border is added to be able
to spot in the wizard.

Change-Id: Ic5d4f12427ba28cf56b4ee609b374aabb2c468b4
Fixes: #28620
Reviewed-on: http://review.typo3.org/6201
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

The behaviour that causes the error (translated elements are not deleted
when deleting parent) is fixed in recent TYPO3 versions; it is better to
do that additional check anyways (for old installations).

Change-Id: Id51afff4349a473f291ef50631b519942f45be13
Resolves: #17910
Releases: 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/4734
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Björn Pedersen
Reviewed-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf

Directory is moved from Resources/Private/Configuration -> Configuration
If the static TypoScript resource was already included in a template, it
needs to be updated manually again since this is a breaking change.

Change-Id: I018832f7320695a57297add2df911827caa5e04a
Fixes: #31196
Reviewed-on: http://review.typo3.org/6200
Reviewed-by: Xavier Perseguers
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

In case of no OpenSSL backend being available for rsaauth (e.g. after
moving to another server), the login silently fails.

Better throw an Exception and give useful hints, why no login is
possible and how to fix it.

Change-Id: I1b5d3f685a08699a2afdc62ec6eb71e6761966d9
Resolves: #30758
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/6204
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

Change-Id: I548e906f0845878f00b6136f388ab8500d109c03
Fixes: #30974
Releases: 4.6
Reviewed-on: http://review.typo3.org/5912
Reviewed-by: Xavier Perseguers
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

Due to a recente change (#27660), the Ext JS split bars, which act as
separators between module menu / navigation and navigation / content
container, are increased in width only for the Chrome browser.

This breaks the styling and makes it look lovelessly implemented, when
the selected page from the tree should have a visual connection to the
content frame.

Change-Id: Iacca368168d122e9d2df05a22590d21859f6b3cb
Resolves: #31186
Reviewed-on: http://review.typo3.org/6187
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

File NEWS.txt should reflect latest changes in TYPO3 4.6.

Change-Id: I13e0dbe1aab3de5b22fd5b5658acecf5826dccd9
Resolves: #31171
Releases: 4.6
Reviewed-on: http://review.typo3.org/6167
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Displaying the available services in the reports module is broken.
This is a regression due to cleaning up the global declarations for
services ($T3_SERVICES) in TYPO4 4.6.

Because of this method t3lib_extMgm::findService cannot be abused
into getting a service by its key explicitly. Hence a new method must
be introduced and used in the available services report.

This patch also introduces method t3lib_extMgm::isServiceAvailable
which refactors part of the services-related code to avoid
duplication.

Change-Id: I15fd7eecaafb52df0599598c5b700e458e63f0d9
Resolves: #30554
Releases: 4.6
Reviewed-on: http://review.typo3.org/5538
Reviewed-by: Lorenz Ulrich
Tested-by: Lorenz Ulrich
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

The confirmation message does not have any CSS at the moment.

Change-Id: Ic2e182cda9f5333e0c6d7aad4d4bb9f929ca0568
Fixes: #13214
Reviewed-on: http://review.typo3.org/6071
Reviewed-by: Xavier Perseguers
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

A new form element does not have any class settings. This issue
reintroduces stdWrap possibilites for the new form system extension.

Change-Id: Id0cff00892f2be0255d639f3bfbb7afe14ef6177
Fixes: #31120
Reviewed-on: http://review.typo3.org/6042
Reviewed-by: Steffen Ritter
Reviewed-by: Xavier Perseguers
Reviewed-by: Georg Ringer
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

The Scheduler's manual is updated with:

* description of the new tasks provided by default
  (table and fileadmin garbage collection)
* bug tracker references change to point to Forge
* hint added in the developer's section about usage of
  the save() method

Change-Id: I25b703d56db7c525b003e62d504676cbe270841c
Resolves: #27552
Releases: 4.6
Reviewed-on: http://review.typo3.org/6199
Reviewed-by: Francois Suter
Tested-by: Francois Suter

Changes included:
cb5fac3 [TASK] Prepare for release of TYPO3 4.6
22feb54 [BUGFIX] Pootle: Multi-line labels are not rendered
b4393ad [TASK] Fix version number of 4.6 branch
a195d11 [TASK] English XLIFF files should not contain target element
3b062e3 [TASK] Prepare merge for 4.6-RC1 (part 2)

Change-Id: I9144c82ffee4f94c5e7296cd54555215008a6e81
Resolves: #31201
Release: 4.6
Reviewed-on: http://review.typo3.org/6198
Reviewed-by: Philipp Gampe
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Change-Id: I9f5110ac9c0873a04fbc8845b126cfe477977f94
Resolves: #31062
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/6171
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

impexp sysext links to invalid Extension Manager path,
in order to install extension dependencies.

Change-Id: I9e31802b11bf67172cd327dda9be04305cf3620e
Resolves: #31173
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/6186
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

In case of no OpenSSL backend being available for rsaauth (e.g. after
moving to another server), the login silently fails.

Better throw an Exception and give useful hints, why no login is
possible and how to fix it.

Change-Id: I810ac4fe38e11e8b049ec747ac746e356fcd90ed
Resolves: #30758
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/5689
Reviewed-by: Andreas Wolf
Reviewed-by: Björn Pedersen
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Georg Ringer
Reviewed-by: Markus Klein
Reviewed-by: Oliver Klee
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

File INSTALL.txt should reflect latest changes in TYPO3 4.6.

Change-Id: Iee0348fd36ffc8cdd92b4b39269c03a0854d7b2c
Resolves: #31170
Releases: 4.6
Reviewed-on: http://review.typo3.org/6166
Reviewed-by: Oliver Klee
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

In some cases the access to a workspace is checked even
if EXT:workspaces is not installed. This should be avoided
whenever possible.

Change-Id: I2f16a630a8f02bf1aa9a5bd61a340b53b6fd1365
Fixes: #30870
Branches: 4.6, 4.5
Reviewed-on: http://review.typo3.org/6063
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

There are four places in the Extension Manager, when a JavaScript popup
is opened (not an ExtJS window).

These popups are created with
  window.open(..., width=650,height=500),
thus they have no scrollbars. While it is possible in most browsers to
scroll with a mouse wheel, this seems not to be possible with IE.

Change-Id: I71ed8393c24bc2a6e543b1e198ceb1bf240f1522
Resolves: #31184
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/6185
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

* Increase the maximum size in the default values
* Do not make the textareas flexible by default
* Do not apply the max height setting to manually resizable textareas

Change-Id: I49c836b101d116fcc2205c47d73e3f640415455f
Resolves: #30274
Releases: 4.6
Reviewed-on: http://review.typo3.org/5329
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

Checking if the superglobal $_SESSION is an array is not reliable.
Change the check to use session_id() which is an empty string 
if the session has not been started.


Change-Id: Iac913beee5af40d28c17ade6a8bfa17df4da2374
Resolves: #30270
Releases: 4.3, 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/5314
Reviewed-by: Oliver Klee
Reviewed-by: Jigal van Hemert
Reviewed-by: Zach Davis
Tested-by: Zach Davis
Tested-by: Jigal van Hemert

* dbal uses DBAL_1-3
* extbase uses extbase_1-4
* fluid uses fluid_1-4
* version uses 4.6
* workspaces uses 4.6

Change-Id: I40f364388b4940d3dcf501c8bb94fee7ee36101c
Reviewed-on: http://review.typo3.org/6183
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

In order to ensure that multi-line labels can be properly translated on Pootle or
any 3rd party tool, it turns out that an additional attribute xml:space="preserve"
should be added to each and every <trans-unit> tag in the localization files.

Change-Id: I74dbf92196b649b96023b329eb12ad98dac7be49
Fixes: #31141
Releases: 4.6
Reviewed-on: http://review.typo3.org/6121
Reviewed-by: Dominique Feyer
Tested-by: Dominique Feyer
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

The code of the available services report contains a number of
incomplete phpDoc blocks plus some small variables initialization
errors. This should be corrected before further work.

Change-Id: I02470e4daecfb8dd15e9477f33ba4023e0340c08
Resolves: #31174
Releases: 4.6
Reviewed-on: http://review.typo3.org/6170
Reviewed-by: Francois Suter
Tested-by: Francois Suter

The following PageTS options are unset by default:
* mod.wizards.newRecord.pages.show.pageInside
* mod.wizards.newRecord.pages.show.pageAfter
* mod.wizards.newRecord.pages.show.pageSelectPosition

However, PHP codes treats these unset values (empty string) as being
enabled, which can lead to confusions.

Set the default value to 1.

Change-Id: I272155a8fe0c4f09ef14a7723f3cad23fc527197
Related: #24616
Resolves: #31132
Releases: 4.6
Reviewed-on: http://review.typo3.org/6128
Reviewed-by: Markus Klein
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Francois Suter
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

According to the documentation, method link() returns an array with a
few keys. In case of error however, FALSE is returned which in turn
crashes PHP if the returned value is not post-processed and sent as
this to t3lib_div::implodeAttributes() which forces an array to be
passed as argument.

Change-Id: I7a593dd7eec2bee9e9f84415ccdd592f4d767caf
Fixes: #31079
Related: #17037
Releases: 4.6
Reviewed-on: http://review.typo3.org/6155
Reviewed-by: Philipp Gampe
Reviewed-by: Markus Klein
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

The update language package dialog in Extension Manager shows a list of
non-sorted extension keys and does not provide a way to sort them manually.
This makes it hard to find a specific extension.

Change-Id: I791dd173dc0f7da0f05941e2740aca5a49849fc1
Fixes: #31158
Releases: 4.6
Reviewed-on: http://review.typo3.org/6157
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Add space between buttons in ExtJS toolbars.

Each button has a 1px margin left and right now.

Change-Id: If77ac06c3e2ba79352d2caa4640d9419543dee5c
Resolves: #27596
Releases: 4.6
Reviewed-on: http://review.typo3.org/5039
Reviewed-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Adding tabs at the beginning of lines for multi-line labels breaks the output
when the label is used in a preformated environment such as an email template.

Change-Id: I31850fdff437b81f5b07a2e58ac2281d10a8d1c4
Fixes: #31109
Relates: #31035
Releases: 4.6
Reviewed-on: http://review.typo3.org/6062
Reviewed-by: Dominique Feyer
Tested-by: Dominique Feyer
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Some functions of the file have underscores as the first character
of the function name. This should be solved before 4.6 release
in order to keep interfaces stable later.

Change-Id: Id1460435d67874685c491d09a53e19e514f07740
Resolves: #31047
Releases: 4.6
Reviewed-on: http://review.typo3.org/5949
Reviewed-by: Björn Pedersen
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

The option "options.pageTree.showPathAboveMounts = 1" which shows the
rootline of each DB Mount in a line before is implemented in a
non-valid way.

This means, that a <div> tag is rendered within an <ul> tag right in
front of the <li> of the DB Mount node.

Change-Id: Ic715426b8d04220410bcb15bfba33a39e5fd47bc
Fixes: #31067
Releases: 4.6
Reviewed-on: http://review.typo3.org/5962
Reviewed-by: Xavier Perseguers
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Francois Suter
Tested-by: Francois Suter

Pootle uses the English XLIFF file has the template language and as such
it does not make sense to have "en" -> "en" translation files.

English XLIFF files are templates and should contain only a 'source', not
a 'target' element.

This commit contains:

- Remove of the target elements
- Remove target-language attribute
- Set the date attribute to the correct format
- Remove approved attribute

Change-Id: I84f4534f5ed595868c88f05816a73464a76f3f25
Resolves: #31035
Relates: #30916
Releases: 4.6
Reviewed-on: http://review.typo3.org/5916
Tested-by: Philipp Gampe
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers