Change-Id: Ib1c877c1353844dfac1955c39c864a0974bd6b78
Resolves: #55706
Releases: 6.2
Reviewed-on: https://review.typo3.org/27573
Reviewed-by: Stefano Kowalke
Reviewed-by: Jo Hasenau
Tested-by: Jo Hasenau
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Markus Klein
Tested-by: Markus Klein

The dimension settings in the source collections was overriden after
calculation. Now the result will not be overriden anymore.

Resolves: #53169
Releases: 6.2
Change-Id: I34b4dbab5e99b5cf3d790f92d06d11d31b9b8140
Reviewed-on: https://review.typo3.org/25077
Reviewed-by: Ingo Schmitt
Tested-by: Ingo Schmitt
Reviewed-by: Sebastian Fischer
Tested-by: Sebastian Fischer
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Execute unit tests first and lint last, since
the lint is las resort anyway and unlikely to fail.

Also use a simple printf instead of a php call.

Change-Id: I7471e4ac0b217e1a58d1324bd24fc7e2f517e17e
Reviewed-on: https://review.typo3.org/27564
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Add a test to check for mtime sorting capability of getFilesInDir().

Change-Id: I73082bcfd1f8d46b77a228b1ea7dabc1602d9d0a
Resolves: #55864
Releases: 6.2
Reviewed-on: https://review.typo3.org/27536
Reviewed-by: Oliver Klee
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

When importing the extension list from TER, each version of each
extension is one database record. For each extension key the EM
calculates the newest version and sets the column 'current_version'
to 1 for the corresponsing extension record.

The old implementation issued one database query for each extension
key, resulting in about 6k queries, taking a long time to execute
(several minutes on my machine). After applying this patch the same
thing is done in three queries, speeding up the process.

Resolves: #55820
Related: #52949
Releases: 6.2
Change-Id: I55d3699a63b13e7c07af4babbf57d0d06f367027
Reviewed-on: https://review.typo3.org/27496
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Jost Baron
Tested-by: Jost Baron
Reviewed-by: Oliver Klee
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Resolves: #49440
Releases: 6.2, 6,1
Change-Id: Iea20a7e9c637c2f1f13c39eebe406d07edc8a2c3
Reviewed-on: https://review.typo3.org/27453
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Karol Lamparski
Tested-by: Karol Lamparski
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Change-Id: I06bb7492146a9149917bc2fc9100fbdddd9b8d09
Resolves: #55871
Releases: 6.2
Reviewed-on: https://review.typo3.org/27539
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Replace strtolower and ternary operations with strcasecmp.

Change-Id: Ia962ef879c6ba1d91081db78f74fc577fa67c467
Resolves: #55899
Releases: 6.2
Reviewed-on: https://review.typo3.org/27559
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

The FormProtectionFactory can be initialized later.
Move the initialization to the point where it is needed.

Resolves: #55856
Releases: 6.2
Change-Id: Id83304341ddec4cc2d4d5c8a6bd40463277a37b5
Reviewed-on: https://review.typo3.org/27533
Reviewed-by: Benjamin Mack
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

If the config.cache_ClearAtMidnight is set, the current code of
TypoScriptFrontendController::get_cache_timeout() will not take
content's starttime/endtime into account. Thus if the content
(or other configured record) has start or end time before the
midnight, it will not be taken into account and the cache timeout
will be wrong.

Change-Id: I732da8f07270a86c62b7ce5028b12b630bb2e027
Resolves: #53028
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/24951
Reviewed-by: Wouter Wolters
Reviewed-by: Peter Foerger
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Adding composer packages to „Packages“ folder will cause a fatal error
This fix prevents the extension manager from handling not legacy packages

Resolves: #55754
Releases: 6.2
Change-Id: I3ac491c8566b14578f5d3a604c63dffc1310d042
Reviewed-on: https://review.typo3.org/27402
Reviewed-by: Thomas Maroschik
Reviewed-by: Marcin Sągol
Tested-by: Thomas Maroschik
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

When working on #55559 (refactoring class alias handling)
accidentally code was introduced to avoid more than
one alias for a class name.
Remove this code to make multiple aliases work again.

Fixes: #55897
Releases: 6.2
Change-Id: I8b4b721c57c52d117130947fe92c564d6ddcdd9b
Reviewed-on: https://review.typo3.org/27558
Reviewed-by: Claus Due
Tested-by: Claus Due
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

During the installation of packages via the extension
manager a fatal error can occur when the ext_localconf
and ext_tables are loaded and use classes from their own
package. This happens because the package is activated
but the class loader is not aware yet of the new package.

This patch adds the extension temporarily to the runtime
activated packages in the class loader.

Fixes: #53795
Releases: 6.2
Change-Id: I195b86284b9a288f4d7c102168ec18ed8683cb07
Reviewed-on: https://review.typo3.org/27544
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

If the root folder is used as folder identifier (/) no slash is appended
so that isFirstPartOfStr works correctly in the isWithin check in
LocalDriver.

Resolves: #55740
Releases: 6.2
Change-Id: I2af1cd3759656502ea84887828dfb222f0a07b64
Reviewed-on: https://review.typo3.org/27379
Reviewed-by: Markus Klein
Reviewed-by: Markus Kasten
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

During installation of extensions the Extension Manager does
not take the Category API into account. The code to do so is
present in the Install Tool in the Database Compare Tool. It is
cumbersome to switch to the install tool to update the database
in order to use the category fields. The install tool and extension
manager currently need to know which components manipulate
the table definitions and this is bad coupling of components
which shouldn't know each other.

This fix replaces the individual calls to the components by two
signals and thus a generic approach.

Fixes: #53016
Releases: 6.2
Change-Id: I7f99ad7cadc323d4f8b975de97e4c665a82647a5
Reviewed-on: https://review.typo3.org/26506
Reviewed-by: Fabien Udriot
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Different build environments have been set up
mainly to be able to execute lint, unit tests
and functional tests in parallel. However
setting up the build environment on travis
also takes quite some time, so that overall
build times are quite high.

This change cleans up the travis configuration,
reduces the number of builds to only the configured
PHP versions and executes lint, unit tests and
functional test in parallel using the command line
tool "parallel"

By doing so, the overall build time can be reduced
by at least 50%

This change also removes the installation of a
current git version which has been added to
fix temporary Travis service errors.

Releases: 6.2
Change-Id: Ic1591ed0b596df22a648a825639c1a2bbc7ffcc2
Reviewed-on: https://review.typo3.org/27540
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Issue #55549 added a wrong check for user uid.
As result the FE cookie gets deleted when you are
loggedin instead when your not.

This change inverses the check.

Resolves: #55845
Releases: 6.2
Change-Id: I0c59afb8c89e9f7887970eaf0a4079fe98280b2c
Reviewed-on: https://review.typo3.org/27525
Reviewed-by: Wouter Wolters
Reviewed-by: Markus Klein
Reviewed-by: Marcin Sągol
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

In order to provide the full functionality known from the
switch/case PHP function, a default case possibility is
introduced. Use it like:
<f:switch expression="{person.gender}">
  <f:case value="female">Mrs.</f:case>
  <f:case value="male">Mr.</f:case>
  <f:case default="TRUE">Mrs. or Mr.</f:case>
</f:switch>

Change-Id: Ib9468cdabd66fb8b484cb4d07520d5b529548dd1
Resolves: #49371
Documentation: #54283
Releases: 6.2
Reviewed-on: https://review.typo3.org/26058
Reviewed-by: Benjamin Kott
Tested-by: Benjamin Kott
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

If the given delimiter is not found in the given string
GeneralUtility::revExplode() will return an array with a single element
containing the unexploded string.

Resolves: #55838
Releases: 6.2
Change-Id: I1146552a625a8057be86b2745febf808638a290c
Reviewed-on: https://review.typo3.org/27524
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Running the whole unit test suite on cli can eat up a significant
amount of memory. Most of that can not be mitigated due to phpunit
itself, but we can at least hint the PHP garbage collection by
unsetting test class properties in tearDown().

The patch introduces a generic tearDown() method that reflects the
test class and unsets all temporary properties of the class. In
effect, tests do not need to take care of unsetting properties.

The patch removes all tearDown() methods that only unset() stuff
and keeps others that do additional things but adds a call to
parent::tearDown(). Private properties are changed to protected,
so parent::tearDown can reach them. The additional computing
effort of the reflection is insignificant, the suite is nearly as
fast as before.

Results:
php 5.3: 1056MB -> 851MB
php 5.4: 870MB -> 670MB
php 5.5.: 876MB -> 674MB

Resolves: #55850
Related: #51436
Releases: 6.2
Change-Id: Ie665c53a3ab35e4808677e483d2099e0511c393f
Reviewed-on: https://review.typo3.org/27528
Reviewed-by: Helmut Hummel
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change-Id: Icab8cd1d7f4b9a56f10ed7fc1f6e945ff50b295c
Reviewed-on: https://review.typo3.org/27529
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

All $GLOBALS are backed up by phpunit, no explicit backup
of $GLOBALS['TYPO3_DB'] is required.

Change-Id: I2859a5922d85a23fa8281382b1d78043ec7bd934
Resolves: #55846
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/27526
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

In order to be able to easier debug stuff and intercept database calls,
all queries are made through a central ``query()`` method in
``DatabaseConnection``.

Change-Id: I53cd98dbb837232765bcc24e30851f99d3cfdca0
Resolves: #55769
Releases: 6.2
Reviewed-on: https://review.typo3.org/27420
Reviewed-by: Stefan Neufeind
Reviewed-by: Pascal Dürsteler
Tested-by: Pascal Dürsteler
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

jumpUrl_transferSession adds some more parameters
to the URL, making the juHash invalid.
Simply add the check for the allowed redirection
before the jumpurl is internally modified.

Resolves: #46463
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I53fad094caca37b476e07cae953105623e038e85
Reviewed-on: https://review.typo3.org/19270
Reviewed-by: Helmut Hummel
Reviewed-by: Alexander Stehlik
Tested-by: Alexander Stehlik
Reviewed-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Reviewed-by: Marcin Sągol
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The function menu of info module API method can create
proper link targets without mentioning index.php. The
patch is a preparation for switching the entry point
of info module to mod.php.

Change-Id: I467e99ff50513033f887049e5b4a487f0ade645b
Resolves: #55797
Relates: #55672
Releases: 6.2
Reviewed-on: https://review.typo3.org/27482
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Calling stat() is cheaper than calling filemtime() AND filesize().

Change-Id: I8fc3cb46d934b3c49f6919f7f178e2b232fd62e1
Resolves: #55574
Releases: 6.2
Reviewed-on: https://review.typo3.org/27256
Reviewed-by: Marcin Sągol
Reviewed-by: Karol Lamparski
Reviewed-by: Michał Jankiewicz
Reviewed-by: Stefan Neufeind
Reviewed-by: Michiel Roos
Tested-by: Michiel Roos
Reviewed-by: Markus Klein
Tested-by: Markus Klein

protected LocalizationUtility::setLanguageKeys() is only
called from static initializeLocalization and needs to
be static, too.

Resolves: #47983
Releases: 6.2
Change-Id: I7d0a4f5e8fc09ee049a6a7af1be65d5d5e8bf5e4
Reviewed-on: https://review.typo3.org/27506
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Oliver Klee
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Bring standard styles for UL/OL html elements. Ordered
and unordered lists are styled with disc bullet and decimal.

Also overrides those new standard definition for non
standard "lists" like tabs or trees.

Resolves: #55819
Releases: 6.2
Change-Id: I6f4317d46d503f6d5737015710d19d9c2361b14c
Reviewed-on: https://review.typo3.org/27517
Reviewed-by: Marcin Sągol
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

The function menu of info module API method can create
proper link targets without mentioning index.php. The
patch is a preparation for switching the entry point
of info module to mod.php.

Resolves: #55796
Relates: #55672
Change-Id: Ida807864ea8d75a2737313c88d8f89b37bb816b6
Reviewed-on: https://review.typo3.org/27479
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change-Id: I40990623e3d53e70666438acafc27275ac36b621
Resolves: #55827
Releases: 6.2
Reviewed-on: https://review.typo3.org/27523
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Resolves: #55822
Releases: 6.2
Change-Id: I32dd5119a3580df3990997d1c812f33c062c39ba
Reviewed-on: https://review.typo3.org/27521
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Method Generalutility::htmlspecialchars_decode()
was replaced by htmlspecialchars_decode().
Also  Generalutility::htmlspecialchars_decode()
has been marked as deprecated

Resolves: #54777
Releases: 6.2
Change-Id: Idc9b12d8a1dc2746ee0f742c37c640118c9f69c3
Reviewed-on: https://review.typo3.org/27473
Reviewed-by: Oliver Klee
Reviewed-by: Karol Lamparski
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

There is no such icon in
typo3/sysext/backend/Resources/Public/gfx/

Usually the default-icon is overwritten in CSS
anyhow by specifying the icon to use, so the
bug does not show. But the path is still wrong.

Change-Id: Ie321cecfb888664a3ec782933e72cfa89e6f41ec
Resolves: #55799
Releases: 6.2
Reviewed-on: https://review.typo3.org/27494
Tested-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Two tests check getUrl() by calling some resource on typo3.org.
This smells funny and the tests are unstable if network, dns
or typo3.org is down or slow. Mocking is not easily possible
with the lowlevel nature of getUrl().
The tests are removed for now.

Change-Id: I85a83345404c833a67c2f532e820fd28bb7c08e7
Resolves: #55821
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/27518
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

getNumericTypo3Version() needs to be more flexible when converting
the defined version number into one that can be used by the EM.

Resolves: #23902
Releases: 6.2
Change-Id: Ie2ed54c1383e3c6ff9631608e2e9e471ef109952
Reviewed-on: https://review.typo3.org/27509
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Exception codes are unique now.

Resolves: #52294
Releases: 6.2
Change-Id: I4ad49b1ff0342ea36147b6ba0b01d270d9d9f3c5
Reviewed-on: https://review.typo3.org/27462
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

``GeneralUtility::revExplode()`` is implemented in a very
performance-intensive way: it always does a complete cycle with multiple
array operations, be it necessary or not.

To make the method more performant, it is split into different cases.
Currently, the only used value for the ``$count`` in the core is 2, but
we have to implement all others, too, of course. The performance
increase for $count=2 is greater than 50%; the others will at maximum be
as bad as the old implementation, plus a very tiny overhead for checking
the value of ``$count``.

Change-Id: I79d9a87b790935415c636ee87e6a6db952e0baa4
Resolves: #55564
Releases: 6.2
Reviewed-on: https://review.typo3.org/27255
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Brings the central table mark-up and style definition "t3-table"
to file_list backend module. Thanks to the unification few lines
of duplicated css definitions can be tossed.

Also moves the localization icons into the html table row. This
is a semantic clean-up and gives every file entry one table row.
-> Buttons can be added to title cell since cell is always visible.

Note: RequireJS module is moved to EXT: file_list.

By hiding the flag icons from within html right away there
is no flashing between render & ready (JS hide()).

Change-Id: Ic84450b8327c9533037ea21054799d6ad9d8d74b
Resolves: #55810
Releases: 6.2
Reviewed-on: https://review.typo3.org/27512
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Removes old class files from ext:openid except the two
current entry points for _eid and _return.

Change-Id: Ibdeca07881aad92af28c9f0e81c42a4ee1b600c2
Resolves: #55808
Related: #47756
Releases: 6.2
Reviewed-on: https://review.typo3.org/27507
Reviewed-by: Oliver Klee
Reviewed-by: Marcin Sągol
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Change-Id: I740b4f481f05ac7bb32028739d534dbb1c41864c
Resolves: #55762
Releases: 6.2
Reviewed-on: https://review.typo3.org/27410
Tested-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring