Skip to content
Snippets Groups Projects
  1. Jul 27, 2013
    • Christian Kuhn's avatar
      [TASK] Run phpLint and phpUnit in different travis builds · cae1c184
      Christian Kuhn authored
      phpLint checks php files for compilation errors in travis before
      the unit tests are executed. This takes quite some time.
      The patch configures travis to run phpLint and phpUnit in different
      builds to speed up the process. Additionally, phpLint environment
      does not clone phpunit and the introduction package and does no
      database initialization.
      
      Change-Id: Ie25ade5b6a8fcf4c4dc0752fc8662c433ea3c33c
      Resolves: #50492
      Releases: 6.2, 6.1, 6.0
      Reviewed-on: https://review.typo3.org/22624
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Susanne Moog
      Tested-by: Susanne Moog
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      cae1c184
    • Lars Peipmann's avatar
      [TASK] Adds fileReferenceUid to content rendering · d5bd8928
      Lars Peipmann authored
      FrontendContentAdapterService saves the file uid but not the
      file reference uid.
      
      This commits adds the file reference uid.
      
      Change-Id: I5af09521d5dadc194ec567aec24792def370aedc
      Resolves: #49535
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/21759
      Reviewed-by: Andreas Wolf
      Reviewed-by: Lars Peipmann
      Reviewed-by: Steffen Ritter
      Reviewed-by: Stefan Neufeind
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      d5bd8928
    • Ingo Pfennigstorf's avatar
      [BUGFIX] Fix disappearing table head in extension manager · ea13f035
      Ingo Pfennigstorf authored
      This is a sass recompilation of the extension manager scss that fixes
      the problem of disappearing table heads.
      
      Change-Id: I7b708f34798714170bed1cbf1b76599990c9dd6f
      Fixes: #50440
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/22611
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      ea13f035
    • Stefan Galinski's avatar
      [TASK] Provide information about import action in TCEmain to hooks · c4abdecd
      Stefan Galinski authored
      While importing T3D files the TCEmain currently fires the required
      processing on records just as if the editor is generating the records. If
      extensions hook into TCEmain, there is no way to differenciate this
      situation from the regular editing mode - which might provide unexpected
      results, i.e. wrong IRRE relations.
      
      Solution is to provide a boolean to indicate that TCEmain has been called
      during an import action which extensions could use to recognize this
      situation.
      
      Change-Id: I4fe429fb88f8ec24a7fda885f38ddfbdb4a642f5
      Resolves: #36031
      Releases: 4.5, 4.7, 6.0, 6.1, 6.2
      Reviewed-on: https://review.typo3.org/10515
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      c4abdecd
    • Ingo Pfennigstorf's avatar
      [TASK] Use @inject annotation in extensionmanager · 7f584d6c
      Ingo Pfennigstorf authored
      This patch removes all occurences of injectFooBar methods from the
      extensionmanager sysext and replaces them with the @inject
      annotation.
      
      Releases: 6.2
      Fixes: #50482
      Change-Id: Idc55d15e3a4d6086529864e4013478983b9c45e7
      Reviewed-on: https://review.typo3.org/22619
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      7f584d6c
    • Kasper Ligaard's avatar
      [BUGFIX] Make BackendUtility::viewOnClick honor doc · 82b30861
      Kasper Ligaard authored
      Make parameter $alternativeUrl work as documented in the docblock
      and also as it worked until #22157.
      This patch preserves the hook and basically just puts in an
      if-statement. Also adding a unit test.
      
      Change-Id: I7d67af438b0a0af51ca7662b3f8286aeec827c77
      Fixes: #41165
      Releases: 6.2, 6.1, 6.0
      Reviewed-on: https://review.typo3.org/14826
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Kasper Ligaard
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      82b30861
  2. Jul 26, 2013
    • Christian Kuhn's avatar
      [TASK] Remove empty .gitmodules file · 643f2e9c
      Christian Kuhn authored
      With removal of git submodules the .gitmodules file is empty
      and can be removed now.
      
      Change-Id: I453f63c0852825b46e9ea62f87385d9eace25134
      Resolves: #50480
      Releases: 6.2, 6.1, 6.0, 4.7, 4.5
      Reviewed-on: https://review.typo3.org/22613
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      643f2e9c
    • Christian Kuhn's avatar
      [BUGFIX] Failures in em unit tests due to phpunit update · eab10d59
      Christian Kuhn authored
      Young phpunit versions seem to handle clones a bit differently,
      resulting in test failures in extension manager tests. The tests
      are adapted a bit to fix this.
      
      Change-Id: If70561743f68a62167e41ee4c23ae96b56f83ab9
      Resolves: #50478
      Releases: 6.2, 6.1, 6.0
      Reviewed-on: https://review.typo3.org/22604
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Anja Leichsenring
      Tested-by: Anja Leichsenring
      eab10d59
    • Christian Kuhn's avatar
      [BUGFIX] FAL wrong \RecursiveIteratorIterator usage · ef8204d6
      Christian Kuhn authored
      If using \RecursiveIteratorIterator on \RecursiveDirectoryIterator,
      flag SELF_FIRST must be used, otherwise only leaves (files) and not
      also directories are returned. This behavior is a bit dependent on
      the PHP version used, younger versions (> 5.3.3 seem to do it
      correctly).
      
      Furthermore, in copyFolderWithinStorage() $itemSubPath contains
      the "relative" path part and not only the node name, checking
      equality to "." or ".." fails then if handling sub directories.
      So, directories may be created multiple times, resulting in mkdir()
      warnings. This is fixed by getting the node name itself and using
      that for comparison.
      
      Resolves: #50476
      Releases: 6.2, 6.1, 6.0
      
      Change-Id: Ifac4b28f4e02ec8a9bf5891739cf66c1e1074af9
      Reviewed-on: https://review.typo3.org/22602
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Anja Leichsenring
      Tested-by: Anja Leichsenring
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      ef8204d6
    • Christian Kuhn's avatar
      [BUGFIX] FAL does not copy subfolders cleanly · b0f8bb0d
      Christian Kuhn authored
      If full structures with sub folders are copied around in FAL
      local driver, sub folders are not correctly created in the
      target directory.
      
      This is detected in unit tests after recent vfsStream updates in
      ext:phpunit.
      
      The patch adds a flag to the Iterator code to also include
      directories to fix the issue.
      
      Additionally, the existing two unit tests also tested multiple other
      methods of the local driver and are functional tests. The patch moves
      those two tests to the functional section and adds three simple unit
      tests with correct mocking instead.
      
      Change-Id: I30d3c8bd5c6538b3fe23405d97bcddff6c1ff405
      Releases: 6.2, 6.1, 6.0
      Resolves: #50472
      Reviewed-on: https://review.typo3.org/22596
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      b0f8bb0d
    • Wouter Wolters's avatar
      [TASK] Use real boolean value for getLL second param · f0a0b5e7
      Wouter Wolters authored
      Make use of boolean value TRUE as second parameter in
      getLL function.
      
      Change-Id: I15fe034159e4bb8ecb7c15f8f6e915975fca7c9b
      Resolves: #50393
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/22538
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      f0a0b5e7
    • Wouter Wolters's avatar
      [TASK] Use real boolean value for trimExplode third param · b9fc9478
      Wouter Wolters authored
      Make use of boolean value TRUE as third parameter in
      trimExplode function.
      
      Change-Id: Ied33efac6cddfc2e2798435fe9b1ef748c11905b
      Resolves: #50402
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/22542
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      b9fc9478
    • Anja Leichsenring's avatar
      [BUGFIX] Fix failing test · a085e54f
      Anja Leichsenring authored
      The test failes due to incorrect mocking, what leads to not claimed
      properties for the test.
      Additionally the expected call amounts where handled more strictly
      where fitting.
      
      Releases: 6.2, 6.1, 6.0
      Resolves: #50458
      Change-Id: I34214fb9ef9e9935892aa03518505b877538e128
      Reviewed-on: https://review.typo3.org/22584
      Reviewed-by: Stefan Froemken
      Tested-by: Stefan Froemken
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      a085e54f
    • Wouter Wolters's avatar
      [BUGFIX] Uninstall extension with dependency throws Exception · 7e651b7a
      Wouter Wolters authored
      Exception is thrown if uninstalling an extension with
      dependecies on that extension. Catch the exception and
      show a nice Flashmessage.
      
      Change-Id: I434a4e1e1d83f43a6f5d4c99a82433e35ddd92f9
      Resolves: #49722
      Releases: 6.2, 6.1, 6.0
      Reviewed-on: https://review.typo3.org/22162
      Reviewed-by: Alexander Opitz
      Tested-by: Alexander Opitz
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      7e651b7a
  3. Jul 25, 2013
  4. Jul 23, 2013
    • Kasper Ligaard's avatar
      [TASK] Make DiffUtility faster and much more scaleable. · 8ca3486f
      Kasper Ligaard authored
      The method DiffUtility->explodeStringIntoWords() calls array_merge()
      inside a loop. The cost of constantly doing a function invocation and
      merging arrays needlessly slows the method and the whole diff utility.
      Moving the array merging outside the loop, the method becomes faster
      and able to handle much larger input.
      
      Change-Id: I4c2d21cff9b18392e89e316fec9dc615e715a073
      Resolves: #50318
      Releases: 6.2, 6.1, 6.0
      Reviewed-on: https://review.typo3.org/22508
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Jigal van Hemert
      Tested-by: Jigal van Hemert
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      8ca3486f
  5. Jul 22, 2013
  6. Jul 21, 2013
  7. Jul 20, 2013
  8. Jul 19, 2013
  9. Jul 18, 2013
    • Michael Schams's avatar
      [TASK] Adhere enableDeprecationLog settings · 2a873bcd
      Michael Schams authored
      Refactoring of function deprecationLog() to prevent accidental
      activation of log file creation due to misconfiguration.
      Correct misleading configuration description (label in Install Tool).
      
      Resolves: #43900
      Releases: 6.2
      Change-Id: I04164270ea3359014b6637d6c68cf2d9348356b0
      Reviewed-on: https://review.typo3.org/18510
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Alexander Opitz
      Reviewed-by: Philipp Gampe
      Tested-by: Philipp Gampe
      2a873bcd
    • Georg Ringer's avatar
      [FEATURE] Registers for title & alt text fields in file links · 5daedc42
      Georg Ringer authored
      The file link element offers a description, title text and alternative
      label text for each file.
      Currently, it is only possible to access the description via a register.
      It would be desirable to also provide registers for the alt and title
      text fields, e.g., to only link the description and provide more
      in-depth info in the other fields.
      
      Change-Id: I7860a769e957c83691e48090ea1bbc94c9ebf9df
      Resolves: #44182
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/17705
      Reviewed-by: Alexander Opitz
      Reviewed-by: Georg Ringer
      Tested-by: Georg Ringer
      5daedc42
  10. Jul 17, 2013
    • Oliver Hader's avatar
      [BUGFIX] Faulty layout if row details are too long · b0671ec5
      Oliver Hader authored
      If the row details in in the workspaces difference view are too
      long, e.g. a string that does not contain white-spaces like e.g.
      a filename, the layout looks broken.
      The solution is to introduce a new classname for the content
      details and to force word breaking via CSS.
      
      Fixes: #50114
      Releases: 6.0, 6.1, 6.2
      Change-Id: I9a768aed1c9bb4ebdfea5ba79083b7e5dce262d9
      Reviewed-on: https://review.typo3.org/22381
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      b0671ec5
    • Alexander Schnitzler's avatar
      [BUGFIX] Undefined switchable controller actions must be removed · 48be7462
      Alexander Schnitzler authored
      Currently there is no check if switchable controller actions in
      pi_flexform are still present in the configuration flexform. So,
      when removing the flexforms in the configuration file, the
      switchable controller actions section is not deleted in pi_flexform.
      
      This change removes all occurences in the present pi_flexform, so
      if no switchable controller actions are defined any longer, they
      will be removed, else they are overwritten by the current flexform
      data.
      
      Releases: 6.2
      Resolves: #31198
      Change-Id: I6046b29dbf436d8c970593dbc6fd2c216f222c52
      Reviewed-on: https://review.typo3.org/22030
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Anja Leichsenring
      Tested-by: Anja Leichsenring
      48be7462
    • Georg Ringer's avatar
      [BUGFIX] Use correct url schema in MediaWizardProvider · 838a4e7d
      Georg Ringer authored
      If the media provider supports https, the video should be
      embedded using https instead of http.
      
      Change-Id: Id6f1677acfd82ba071c2425f345ea20b48de9cfe
      Resolves: #50041
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/22345
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      838a4e7d
    • Steffen Müller's avatar
      [FEATURE] Backport ApplicationContext from Flow · 8fdab46d
      Steffen Müller authored
      Flow has the notion of ApplicationContext which provides a unique
      API for handling contexts.
      
      This API allow us to provide default configuration sets for
      particular contexts. For example having decent logging in
      production context vs. full reports in development context.
      
      The context is set using the TYPO3_CONTEXT environment variable.
      If not set the context defaults to "Production".
      
      The context can be queried using:
      \TYPO3\CMS\Core\Core\Bootstrap::getInstance()->getContext();
      
      Resolves: #49988
      Releases: 6.2
      Change-Id: Id953052f2846c740f27a83931adfb64b0d8d9169
      Reviewed-on: https://review.typo3.org/22269
      Reviewed-by: Thomas Maroschik
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      8fdab46d
  11. Jul 16, 2013
    • Claus Due's avatar
      [TASK] Remove redundant try/catches in ResourceStorage of FAL · ab79dbbc
      Claus Due authored
      This change simply removes some try/catch statement which did
      nothing but re-throw the RuntimeException.
      
      Fixes: #49332
      Releases: 6.0, 6.1, 6.2
      Change-Id: I62d7e1b0312a16926b06e0bd5eb6fc8be0829d3c
      Reviewed-on: https://review.typo3.org/21575
      Reviewed-by: Wouter Wolters
      Reviewed-by: Philipp Gampe
      Reviewed-by: Ingo Pfennigstorf
      Tested-by: Ingo Pfennigstorf
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      ab79dbbc
    • Marc Wöhlken's avatar
      [BUGFIX] Category API does not consider multiple tables · 7c97fe9f
      Marc Wöhlken authored
      Using the Category API with multiple tables, leads to wrong
      results due to a missing check for the correct table.
      
      Resolves: #45332
      Releases: 6.2, 6.1, 6.0
      Change-Id: Iaf5b453acd434ab8d8f58932a2c96385a66abf37
      Reviewed-on: https://review.typo3.org/21963
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      7c97fe9f
    • Xavier Perseguers's avatar
      [TASK] Use extension's name in documentation · 91a8f60c
      Xavier Perseguers authored
      Settings.yml should reflect the name of the extension.
      
      Resolves: #50081
      Releases: 6.2
      Change-Id: Iac7573b0023609a8b9cf91b23623983cee7b67dd
      Reviewed-on: https://review.typo3.org/22361
      Reviewed-by: Francois Suter
      Tested-by: Francois Suter
      Reviewed-by: Georg Ringer
      Tested-by: Georg Ringer
      91a8f60c
    • Georg Ringer's avatar
      [TASK] Setting space before/after should use !important · 837fc261
      Georg Ringer authored
      If the setting space before/after is used, the generated styles
      should use !important to override possible CSS styles done somewhere else.
      
      Change-Id: Ib2cbef280e6d2ac9d1503448ebaede48cf9d159b
      Resolves: #50038
      Releases: 6.2,6.1,6.0
      Reviewed-on: https://review.typo3.org/22346
      Reviewed-by: Ralf-Rene Schroeder
      Tested-by: Ralf-Rene Schroeder
      Reviewed-by: Jo Hasenau
      Tested-by: Jo Hasenau
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      837fc261
    • Mario Rimann's avatar
      [BUGFIX] Links on external pages don't get indexed · 819b5be0
      Mario Rimann authored
      Allows the crawler to start indexing a specific file like
      www.domain.tld/foobar.html instead of just www.domain.tld/
      
      This is just about the comparison against the base URL and
      enables the Crawler to start crawling at e.g. a file that contains
      a manually generated list of links to follow. Before that change,
      even links to targets on the same domain were rejected by
      the checkUrl() method in case the base Url was pointing to some
      file instead of "/". This was because the base URL was then not
      part of the target URL.
      After stripping off any path from the base URL for this comparison
      this can now also be used to start crawling from a file.
      
      Change-Id: I2727a9a447754b88d2c279c24b32b5c3a2df26c0
      Resolves: #16534
      Releases: 6.2, 6.1, 6.0, 4.7, 4.5
      Reviewed-on: https://review.typo3.org/6990
      Reviewed-by: Michael Stucki
      Tested-by: Michael Stucki
      Reviewed-by: Georg Ringer
      Tested-by: Georg Ringer
      819b5be0
    • Stefan Galinski's avatar
      [BUGFIX] Missing/Wrong copy buttons if deflangBinding is disabled · 485c07f0
      Stefan Galinski authored
      Fixes: #49712
      Releases: 6.2, 6.1, 6.0
      Change-Id: If3aebb786ae6b3f23964704d5f3c13ea7b0fd0af
      Reviewed-on: https://review.typo3.org/22015
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Georg Ringer
      Tested-by: Georg Ringer
      485c07f0
    • Francois Suter's avatar
      [FEATURE] Migrate sysext manuals to reST · c8c0175c
      Francois Suter authored
      All system extension manuals are migrated to reStructured Text.
      All OpenOffice manuals are removed.
      
      Resolves: #50052
      Releases: 6.2
      Change-Id: I9d8d9ad433276e6105d9c38b9f2a3b34dc8749f6
      Reviewed-on: https://review.typo3.org/22337
      Tested-by: Wouter Wolters
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      Reviewed-by: Georg Ringer
      Tested-by: Georg Ringer
      c8c0175c