- Apr 20, 2020
-
-
Claus Due authored
Refactoring with the goal of: * Restoring entity-like nature of BackendLayout * Decreasing coupling between components of the page module processing and rendering. Implements a PageLayoutContext to hold all context-related objects and methods and passes the context to objects instead of passing the BackendLayout. Reduces number of methods on DrawingConfiguration so the configuration object only holds output- and behavior-related options and does not hold things like permission checks. Releases: master Resolves: #90882 Change-Id: I09f1d97a53a76ea96d6cbc18bb5549127b5a1a71 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64002 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- Apr 15, 2020
-
-
Alexander Schnitzler authored
With this patch, the header comment of php files is automatically added by the php-cs-fixer, which guarantees that its format and place of occurrence remain the same in all files. Files that are copied over from other projects are excluded. Furthermore, files that are kind of inspired by other projects also get the same header comment but may have a second, additional comment explaining its origin. Used command: bin/php-cs-fixer fix --config=Build/php-cs-fixer/header-comment.php Releases: master Resolves: #91024 Change-Id: I5a040517e0fbde6e5a27d589bf2f222078326dc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64159 Tested-by:Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
- Apr 14, 2020
-
-
Benni Mack authored
This change adds two changes 'blank_line_after_opening_tag' => true, 'single_trait_insert_per_statement' => true, to our PHP-CS Fixer configuration, adopting more rules related to PSR-12. Resolves: #91020 Releases: master Change-Id: I180b2cbceb077911bddeb42d9f131e5b32244ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64158 Tested-by:Josef Glatz <josefglatz@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
-
- Apr 13, 2020
-
-
Alexander Schnitzler authored
As a preparation to be compatible with PSR-12, all spaces in strict type declerations are removed. Releases: master Resolves: #91009 Change-Id: I2b7c2fda42b44168b5c4c6b21711eede2eadaf2e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62104 Tested-by:
-
- Apr 01, 2020
-
-
Benni Mack authored
The code that executes the drawItem hook must be called before the fluid-preview is rendered, in order to allow rendering of custom variables within the Fluid preview. This way, it behaves the same way as in the non-Fluidbased page module. Resolves: #90906 Releases: master Change-Id: Id7998446b211763da3d3b7be89a4d7016f2fb54f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64020 Tested-by:
Achim Fritz <af@achimfritz.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
- Mar 27, 2020
-
-
Benni Mack authored
PageLayoutView now builds a "Configuration" model for both variants PageLayoutView is not set up via the DrawingConfiguration object, which is now based on a factory method. PageLayoutController now injects all RequireJS modules in one place, and not in fluid anymore. Minor bugs regarding "getLanguageColumns" are fixed. The main "pageLayoutConfiguration" is now injected and used where it does not differ from the backend module configuration. Resolves: #90858 Releases: master Change-Id: I16925488e0bff75ec73f9dddbfd047cca3bd2da1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63938 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
- Mar 24, 2020
-
-
Benni Mack authored
The existing drawItem_* hooks modified the record data to include custom values to be used in previews. The GridColumnItem now needs to allow to set the record data again. Resolves: #90819 Releases: master Change-Id: I008cdeb8b3411cda7fd7cfa184ca827a8d955581 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63880 Tested-by:
-
- Mar 09, 2020
-
-
Oliver Bartsch authored
This fixes some missing or faulty checks related to the display and behaviour of the fluid based page module to bring it into alignment with the old PageLayoutView. * Correctly consider localization TSConfig settings * Add checks for content-editing allowed for user * Add check for presence of untranslated records * Pass all variables to record header/footer partial * Do not link preview content if user has no content edit access Resolves: #90559 Resolves: #90605 Related: #90608 Releases: master Change-Id: Ie2f200a280f60ed08b5850ead81644ee52508c1a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63615 Tested-by:
-
- Mar 01, 2020
-
-
Christian Eßl authored
The new StandardContentPreviewRenderer uses an emulated PageLayoutView for implementing "tt_content_drawItem" hooks. This patch makes sure both the member variables $CType_labels and $itemLabels are set for the emulated view as those properties may be accessed in a hook. Resolves: #90598 Releases: master Change-Id: Iec7bf473c526546587d5f762e9a5918d05d7a909 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63503 Tested-by:
-
- Feb 27, 2020
-
-
Daniel Goerz authored
Resolves: #90554 Releases: master Change-Id: I4cbdcadbec39766f87ca1561f6b2310e90c70ba5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63473 Tested-by:
-
- Feb 25, 2020
-
-
Georg Ringer authored
With #78450 the StandardContentPreviewRenderer creates an instance of the `PageLayoutView` to keep the existing hooks alive. However 2 more properties need to be filled to improve the compatibility. Resolves: #90528 Releases: master Change-Id: I0c56988bdc9d524f1cfa411ae0c62d00ad1789dd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63408 Reviewed-by:
Claus Due <claus@phpmind.net> Reviewed-by:
Christian Eßl <indy.essl@gmail.com> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Claus Due authored
This introduces a new approach to registering and rendering previews; for content elements initially but possible to apply to any record type, and possible to call from other contexts than the PageLayoutView, e.g. AJAX-based preview rendering. Basically, this turns the old hook approach into a proper pattern where preview renderers are registered for a specific CType and must implement proper interfaces. A Resolver pattern is also introduced with a standard implementation and a standard renderer is registered for backwards compatibility. Resolves: #78450 Releases: master Change-Id: Ibf85d9b50b7bc6506d72c1ee63078373eaf9e433 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/50389 Tested-by:
-
