- Aug 30, 2023
-
-
Christian Kuhn authored
Well, that functionality is hilarious: Sometimes, when the DataHandler updates or inserts database rows, it calls checkStoredRecord() which fetches the just written row to verify the row has actually been written correctly. * The implementation is inconsistent, DH does not do this for all update queries. * The default configuration is to fetch the row, but to *not* check the fields, rendering the entire thing useless, but still have the additional query. * *If* DH would actually find some collision, it will bury that information as entry in sys_log. * We fiddled with this in #79438 for v8 already to allow suppressing overhead via TYPO3_CONF_VARS. These toggles are widely unknown and most likely used very seldom. * Inserting invalid data a DB can not persist most likely raises doctrine exceptions, especially with many database instances being configured in "strict" mode nowadays. * With our current efforts to configure database columns automatically by auto-creating them from TCA, we further reduce the risk of columns not being configured correctly for given data. The patch: * Removes (@internal) DataHandler->checkStoredRecord() * Keeps two related DataHandler properties as b/w compat layer, but renders them unused. * Removes two related TYPO3_CONF_VARS. Resolves: #101793 Related: #79438 Related: #101553 Releases: main Change-Id: Ie93eddda48057b844067b654e327b8a371b197fc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80752 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Stefan B�rk <stefan@buerk.tech> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
-
Robert Kärner authored
This patch fixes two issues when generating symlinks to the public extension resources (Public/Resources) into the _assets folder during Composer installation. First, directory symlinks can't be created the same way on Windows as on Unix platforms. The creation requires elevated rights, and the required command is named differently as well. Junctions should be used on Windows instead, because they do not need elevated privileges to be created. When installing a TYPO3 extension via Composer, its Resources/Public folder is getting symlinked to the publicly accessible _assets folder. Until now, this process only used the Unix specific functions provided by Composer. It did not create any symlinks on Windows based installations, without generating any error message. This patch adds the same checks and platform-specific functions used by Composer when symlinking packages from a local path repository. The second issue that has been addressed is the naming of the symlinks themselves. When a Resources/Public directory is symlinked into the _assets folder, the symlink will be named using an md5 hash based on parts of the extension's installation path on the filesystem. During Composer installation, this relative path is derived from the absolute path provided by Composer. As Windows uses a different default path separator (backslash) compared to Unix (forward slash), the relative path will be different between both platforms, resulting in a different md5 hash being generated. Absolute path on Unix: /path/to/typo3/vendor/mycompany/myext Absolute path on Windows: C:\path\to\typo3\vendor/mycompany/myext Relative path to be used for the hash on Unix: /vendor/mycompany/myext Relative path to be used for the hash on Windows: \vendor/mycompany/myext If an uri into the _assets folder is to be generated in either frontend or backend, the md5 hash will be always be generated by using forward slashes, resulting in incorrect links on Windows installations. This difference has been solved by replacing all backslashes in the absolute extension installation path into forward slashes on Windows installations, so the symlink will be named correctly from the beginning. Resolves: #98434 Resolves: #98447 Releases: main, 12.4, 11.5 Change-Id: I221eb538312302a7af4f7c3010c9982922f1c6ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75867 Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
-
- Aug 29, 2023
-
-
Christian Kuhn authored
ext:core TsConfigTreeBuilder contains default User TSconfig of the adminpanel extension. This does not belong there. The patch extracts this as "defaultUserTSconfig" to ext:adminpanel. Resolves: #101791 Releases: main Change-Id: Ifeac81e33f612976cb98b4b721d403ff72702100 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80750 Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
-
Benjamin Franzke authored
@lezer/common – in contrast to other @lezer modules, is placed in dist/index.js instead of dist/index.es.js. Therefore we add a distinct copy rule. The sortablejs npm package recently changed to provide both, a UMD bundle and a native ESM module. As we actually failed to update the UMD bundle (due to a rename of the build output filename in sortablejs), we switch to the new ESM variant right away. muuri failed to update because dashboardToEs6 was missing in the npmcopy concurrent target. Resolves: #101784 Resolves: #101785 Resolves: #101787 Related: #101783 Releases: main, 12.4 Change-Id: I2ccf69847876edb55f089a4a5142ac388699fb54 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80741 Tested-by:
-
Nikita Hovratov authored
A small step towards streamlining Core code to use the recently introduced SelectItem API. Resolves: #101745 Releases: main Change-Id: Ib54abeee5b09b517e84baf7c7cb115bdb9a87295 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80665 Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Benjamin Franzke authored
IDEs like PhpSstorm complain about the same thing, so better we have that defined and checked via CI. Commands executed: node_modules/.bin/eslint --fix Sources/TypeScript/ Resolves: #101780 Releases: main, 12.4 Change-Id: I01e0289b671dfd4348319bca90dddaec085fbfe4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80736 Tested-by:
-
Benjamin Franzke authored
This helps to prevent hard-to-discover build failures, that only happen on clean installs (e.g. CI). This is because TypeScript will by default scan the entire source dictionary (Build/ in our case) for possible includes. We previously excluded /Build/composer in #95046, but it is actually much better to explicitly include the actually used source paths to also exclude build output (Build/JavaScript/) from being reinterpreted by subsequential eslint or tsc compile runs. Note that we also refactor the types/ directory in order to be a folder that conforms to the @types/* packages conventions, by being actually usable in the compilerOptions.types property. Note that our custom global type definitions (types/) were previously implicitly loaded as globally available sourcepaths. With the new `include` option we could add them back, but then we wouldn't notice if we do not add proper index.d.ts files (like we did until now). Therefore index.d.ts files are added in here. Now, with TypeScript being "clean", we need a another small adjustment in order for eslint to still being able to lint our types/ folder. Therefore tsconfig.json is extended to include the types directory. See [1] for more information on why eslint needs that. [1] https://typescript-eslint.io/linting/troubleshooting/#i-get-errors-telling-me-eslint-was-configured-to-run--however-that-tsconfig-does-not--none-of-those-tsconfigs-include-this-file Resolves: #101782 Related: #95046 Releases: main, 12.4 Change-Id: I3ab8b874192d25470bbd5e71cc5d99e853259f89 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80739 Tested-by:
-
Benjamin Franzke authored
This allows to drop a npm patch that had been applied to the TypeScript @types/jquery before, in order to achieve the same effect. With eslint we can additionally provide a good hint for the developer, what to use instead. Commands executed: npm remove patch-package npm install Resolves: #101697 Releases: main, 12.4 Change-Id: I77e15a4b4c2a18f8b72ec2a5f41c7e54a7966c30 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80562 Tested-by:
-
Benjamin Franzke authored
Remove unused files that have been forgotten to be removed when there respective TypeScript source files where removed. Resolves: #101786 Related: #101783 Releases: main, 12.4 Change-Id: I75a74996e9dc1f9f30fd3b2f08914e25452df06f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80740 Tested-by:
-
Andreas Fernandez authored
The Install Tool router attempts to build URLs manually by wild string replacements and manipulation, which is rather error-prone. This patch changes the approach to use the URL API instead. Resolves: #101789 Releases: main, 12.4 Change-Id: I07ee73764b4fc5167f732d67faf2843fef0db199 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80742 Reviewed-by:
-
Benjamin Franzke authored
…of a new form element, that has not yet been persisted. Tabbing through an elemenet is considered an "input" by the browser, which is why the "input" even is triggered. The result is an empty input element (as before), but an intent is made to delete the underlying property from the form element object model. When the object model is empty (remeber, it is a new element), and an input field refers to a nested property (e.g. properties.fluidAdditionalAttributes.placeholder) removing an element (e.g. 'placeholder') will fail when the parent has not yet been set (e.g. properties.fluidAdditionalAttributes) Resolves: #101750 Releases: main, 12.4, 11.5 Change-Id: I49a9ead343e671c3d0289bd6d969316b888d05eb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80671 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by:
-
- Aug 28, 2023
-
-
Christian Kuhn authored
The extbase ConfigurationManager is (unfortunately) a stateful singleton that we can not get rid of without a bigger rewrite. While stateful singletons are bad enough, the extbase LocalizationUtility makes this worse by parking an instance of ConfigurationManager in a static property, re-using it as a "cached" singleton. LocalizationUtility does this since it in itself is static, which makes this service just so convenient to use. When it comes to sub requests and similar, static state is doomed and we need to get rid of it, we've had a couple of patches in v12 dealing with similar things. Mid-term, extbase LocalizationUtility needs to vanish anyways, but in the meantime, we have to get rid of static state that kills sub request scope. The patch removes the static $configurationManager property and adapts functional tests that already showed the current solution was a hack. There are various upper and lower cache layers that ensure removing this "cache layer" won't make things more expensive in practice, which allows us to remove this static state without further fallback. In main, this needs a TF update: > composer u typo3/testing-framework In 12.4, this need a TF raise: > composer req --dev typo3/testing-framework:^8.0.3 Resolves: #101779 Releases: main, 12.4 Change-Id: Ie5db07b0475f612a996d369ab3417672b33fbb2d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80735 Reviewed-by:
Thomas Hohn <tho@gyldendal.dk> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
-
Torben Hansen authored
With #90002, all occurrences of the `list()` function have been migrated to the short list syntax. Our php-cs-fixer configuration does however not check the short list syntax usage, so we have one usage of `list()` in our codebase again. This change extends the php-cs-fixer configuration to ensure, that only the short list syntax is used. The new ruleset has been applied to the codebase and one usage of the `list()` function has been migrated. Resolves: #101777 Related: #90002 Releases: main, 12.4 Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: I30f5822e27a36515c2c77a19089a0754ff6fdcfd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80731 Tested-by:
-
Benjamin Franzke authored
Resolves: #101738 Related: #82577 Releases: main, 12.4 Change-Id: Id857430ae81322cf9197ba6df422780695f59f50 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80630 Tested-by:
-
Benjamin Franzke authored
Resolves: #101737 Related: #82577 Releases: main, 12.4 Change-Id: Ibc8ed8be6a8defc7dba4910e3f1df937809600aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80629 Tested-by:
-
Benjamin Franzke authored
Resolves: #101736 Related: #82577 Releases: main, 12.4 Change-Id: If77dc697ac23b5f1fb3f36dd15fe36cfb369700d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80628 Reviewed-by:
-
Benjamin Franzke authored
Resolves: #101735 Related: #82577 Releases: main, 12.4 Change-Id: I5584528f69fddba7a5f7f4b3592ca4bf9e83938c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80627 Tested-by:
-
Benjamin Franzke authored
Resolves: #101734 Related: #82577 Releases: main, 12.4 Change-Id: I0619297a3fbf3e2fd18b1aef1a0c82794a5ca714 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80626 Tested-by:
-
Benjamin Franzke authored
Resolves: #101733 Related: #82577 Releases: main, 12.4 Change-Id: I4d9f92287d9a2b69fa4421de2377f7bf9806147c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80624 Tested-by:
-
Benjamin Franzke authored
Resolves: #101717 Related: #82577 Releases: main, 12.4 Change-Id: I9e0a42954b387d34ded5ebd1bde533b9feb4e70e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80602 Tested-by:
-
Benjamin Franzke authored
Resolves: #101713 Related: #82577 Releases: main, 12.4 Change-Id: Ic7b41b79552a4c14d7395609e0ac3dda9c47b20f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80567 Tested-by:
-
Benjamin Franzke authored
Resolves: #101712 Related: #82577 Releases: main, 12.4 Change-Id: Id77b6cd93cff41c26220ca0b10b948813c1242be Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80598 Tested-by:
-
Benjamin Franzke authored
Resolves: #101702 Related: #82577 Releases: main, 12.4 Change-Id: I4ec165e645ee367d71404338e83ba6f40cb28494 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80505 Tested-by:
-
Benjamin Franzke authored
Resolves: #101634 Related: #82577 Releases: main, 12.4 Change-Id: Ia9ad4d39e925f671707ec62cd989bfca6dbf32ab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80467 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Christian Kuhn authored
Use the new v12 EXTBASEPLUGIN in TS setup to streamline frontend functional tests a bit. Resolves: #101773 Related: #100293 Releases: main, 12.4 Change-Id: I84e3cc93f617e3d8feeb76e6acf2c02bc4070a6d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80716 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Andreas Fernandez authored
When resetting the tag filter in "View Upgrade Documentation", the `hidden` class now gets removed, making previously filtered upgrade docs visible again. Resolves: #101771 Releases: main, 12.4 Change-Id: Ie8bc14cc20fed803ae9644308eeb7cf2daa15a09 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80713 Tested-by:
-
Achim Fritz authored
Resolves: #101754 Related: #100307 Releases: main, 12.4 Change-Id: I43c43f1635fd789e3f035e9840d37fb70528cb66 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80694 Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
Benjamin Kott authored
The `script` tag is defined to hold executable code or data and not template html markup. We are switching this to the `template` tag that is indended for this usecase. Resolves: #101769 Releases: main, 12.4 Change-Id: I0657e5cbce7e13770ce88918cb9e4137bf017590 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80711 Tested-by:
-
Benjamin Franzke authored
The ajax Icon API is currently not available during first install, therefore neither getIcon nor the icon web component may be used to render an icon. The icon markup is therefore now pre-rendered via fluid for both states and toggled via CSS. Resolves: #101765 Related: #98089 Releases: main, 12.4 Change-Id: Ib72c06e41f083e4dc7392845058fc86aae95af9c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80705 Reviewed-by:
-
Benjamin Kott authored
The `retrieveYamlFilesFromExtensionFolders` function returned the full path to the form configuration as key and the filename as value. The filename used to `loadMetaData` that resulted in that the file could not be found because it expects to get the full path here. We are adapting retrieveYamlFilesFromExtensionFolders so we only work on the values returned from that array to avoid confusions or misshaps like this in the future. Resolves: #101767 Releases: main Change-Id: If1b58eae8da7fd5ac913a6a89cfd0aa889a200ef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80709 Tested-by:
-
Oliver Klee authored
This fixes an issue in the acceptance tests where `null` is passed to `GeneralUtility::xml2array()` (which expects a `string`). Having an early check for an empty string also avoids pointless XML parsing (which should help performance a bit). Resolves: #101757 Releases: main, 12.4, 11.5 Change-Id: Ifc4406536c273baca9acdda7a0af7a91594f57bf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80698 Reviewed-by:
-
Mathias Bolt Lesniak authored
The constructor of `\TYPO3\CMS\Core\Http\Request` now correctly accepts resources of the type "stream" as $body argument. Resolves: #101764 Related: #97620 Releases: main, 12.4 Change-Id: I2e7000c11ef4a16334f3305142ef8fb7fe6c639f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80704 Tested-by:
-
Oliver Klee authored
`getMockForAbstractClass` has been (soft-)deprecated in PHPUnit 10.1: https://github.com/sebastianbergmann/phpunit/issues/5241 Hence, we should replace its usages to follow best practices and avoid deprecation warnings later with PHPUnit 11. We do this by creating dedicated fixture subclasses of the affected abstract classes. Resolves: #101661 Related: #101601 Releases: main Change-Id: I3b9ba4511620aebf125ff207428adc5483d47154 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80522 Tested-by:
-
Andreas Nedbal authored
This patch removes the jQuery usages from all Install Tool modules. It's done in one go because of the dependency of the modules on a abstract class that provides methods returning jQuery objects. The miration of the installer (the module that performs the initial setup) is left for another patch, as it is basically a distinct tool and out of scope for this patch. Also the jquery-based chosen-js library will be replaced separately. Resolves: #101655 Releases: main Change-Id: I6c7dc7e156bdd65fbf36d0cab6654e5efb06e7a9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80516 Tested-by:
-
Oliver Klee authored
The new versions find some more possible problems, and also improve performance. > composer req --dev phpstan/phpstan:^1.10.32 > composer req --dev phpstan/phpstan-phpunit:^1.3.14 > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #101756 Releases: main, 12.4, 11.5 Change-Id: I23429a98b25ce340405b8b9dc384869526c6f920 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80697 Reviewed-by:
-
- Aug 26, 2023
-
-
Torben Hansen authored
With CKEditor v38.0.0 a small "Powered by CKEditor" logo has been added to the bottom right of the editor component. The logo is visible as soon as the CKEditor component receives the focus. The current placement of the logo does however overlay the border of the editor component and the term "Powered by" does not suit well to the TYPO3 backend. With this change, the CKEditor configuration has been extended, so it is now possible to configure `config.ui.*` settings. The `Base.yaml` file has been extended with CKEditor UI specific settings, which remove the term "Powered by" from the logo and which optimize the logo placement, so it appears in the bottom right corner of the editor component without overlaying the border. Resolves: #101759 Releases: main, 12.4 Signed-off-by:
Jasmina Lie�mann <minapokhalo+typo3@gmail.com> Reviewed-by:
-
Torben Hansen authored
With this change, CPP is used in ModifyRecordListTableActionsEvent. Resolves: #101761 Releases: main Signed-off-by:
-
Torben Hansen authored
With this change, CPP is used in ModifyRecordListHeaderColumnsEvent. Additionally, 2 superfluous type declarations have been removed from the doc comments, since the setColumn() function already uses PHP native type parameters. Resolves: #101760 Releases: main Signed-off-by:
-
Torben Hansen authored
With this change, CPP is used in ModifyButtonBarEvent. Resolves: #101762 Releases: main Signed-off-by:
-
Garvin Hicking authored
Mostly those are formatting changes of bad spacing and missing colons. Code-blocks are used where applicable. Resolves: #101755 Releases: main Change-Id: I507b9c376108d45cb8123525dddb55a28a4e1949 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80696 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
