Skip to content
Snippets Groups Projects
Commit b97f50bc authored by Christian Kuhn's avatar Christian Kuhn
Browse files

[TASK] Remove DataHandler->checkStoredRecord()

Well, that functionality is hilarious: Sometimes,
when the DataHandler updates or inserts database
rows, it calls checkStoredRecord() which fetches
the just written row to verify the row has
actually been written correctly.

* The implementation is inconsistent, DH does
  not do this for all update queries.
* The default configuration is to fetch the row,
  but to *not* check the fields, rendering the
  entire thing useless, but still have the
  additional query.
* *If* DH would actually find some collision, it
  will bury that information as entry in sys_log.
* We fiddled with this in #79438 for v8 already to
  allow suppressing overhead via TYPO3_CONF_VARS.
  These toggles are widely unknown and most likely
  used very seldom.
* Inserting invalid data a DB can not persist most
  likely raises doctrine exceptions, especially with
  many database instances being configured in "strict"
  mode nowadays.
* With our current efforts to configure database
  columns automatically by auto-creating them from
  TCA, we further reduce the risk of columns not
  being configured correctly for given data.

The patch:

* Removes (@internal) DataHandler->checkStoredRecord()
* Keeps two related DataHandler properties as b/w
  compat layer, but renders them unused.
* Removes two related TYPO3_CONF_VARS.

Resolves: #101793
Related: #79438
Related: #101553
Releases: main
Change-Id: Ie93eddda48057b844067b654e327b8a371b197fc
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80752


Tested-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: default avatarAndreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: default avatarStefan B�rk <stefan@buerk.tech>
Tested-by: default avatarOliver Klee <typo3-coding@oliverklee.de>
Tested-by: default avatarcore-ci <typo3@b13.com>
Reviewed-by: default avatarOliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: default avatarStefan B�rk <stefan@buerk.tech>
parent d4d84685
Branches
Tags
No related merge requests found
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment