[TASK] Remove DataHandler->checkStoredRecord()
Well, that functionality is hilarious: Sometimes, when the DataHandler updates or inserts database rows, it calls checkStoredRecord() which fetches the just written row to verify the row has actually been written correctly. * The implementation is inconsistent, DH does not do this for all update queries. * The default configuration is to fetch the row, but to *not* check the fields, rendering the entire thing useless, but still have the additional query. * *If* DH would actually find some collision, it will bury that information as entry in sys_log. * We fiddled with this in #79438 for v8 already to allow suppressing overhead via TYPO3_CONF_VARS. These toggles are widely unknown and most likely used very seldom. * Inserting invalid data a DB can not persist most likely raises doctrine exceptions, especially with many database instances being configured in "strict" mode nowadays. * With our current efforts to configure database columns automatically by auto-creating them from TCA, we further reduce the risk of columns not being configured correctly for given data. The patch: * Removes (@internal) DataHandler->checkStoredRecord() * Keeps two related DataHandler properties as b/w compat layer, but renders them unused. * Removes two related TYPO3_CONF_VARS. Resolves: #101793 Related: #79438 Related: #101553 Releases: main Change-Id: Ie93eddda48057b844067b654e327b8a371b197fc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80752 Tested-by:Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Stefan B�rk <stefan@buerk.tech> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan B�rk <stefan@buerk.tech>
Showing
- typo3/sysext/core/Classes/DataHandling/DataHandler.php 6 additions, 106 deletionstypo3/sysext/core/Classes/DataHandling/DataHandler.php
- typo3/sysext/core/Configuration/DefaultConfiguration.php 0 additions, 2 deletionstypo3/sysext/core/Configuration/DefaultConfiguration.php
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml 0 additions, 6 deletions...t/core/Configuration/DefaultConfigurationDescription.yaml
- typo3/sysext/core/Documentation/Changelog/13.0/Deprecation-101793-DataHandlerCheckStoredRecordsProperties.rst 63 additions, 0 deletions...cation-101793-DataHandlerCheckStoredRecordsProperties.rst
- typo3/sysext/install/Classes/Service/SilentConfigurationUpgradeService.php 3 additions, 0 deletions...all/Classes/Service/SilentConfigurationUpgradeService.php
- typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyPublicMatcher.php 10 additions, 0 deletions...figuration/ExtensionScanner/Php/PropertyPublicMatcher.php
Please register or sign in to comment