- Aug 11, 2017
-
-
Helmut Hummel authored
When upgrading from older TYPO3 versions, composer installation from that version created a symlink to the typo3 folder. Before trying to remove typo3/sysext, we need to ensure to remove a potentially existing symlink to typo3 folder to not accidentally delete that sysext folder within the sources directory. Resolves: #82090 Releases: master Change-Id: I12ef27d6236a9dbe844803afce55247a23ee5358 Reviewed-on: https://review.typo3.org/53682 Reviewed-by:
Andreas Fernandez <typo3@scripting-base.de> Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
Susanne Moog authored
Translating content on MSSQL installations has been impossible due to SQL errors. The GROUP BY statements in page module and localizationRepository have been fixed. Change-Id: I20a4778e3c0858aca80060ba333ce6a47e42ce38 Resolves: #82085 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53679 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Jan Helke <typo3@helke.de> Tested-by:
-
Susanne Moog authored
The list module throws an exception on mssql as there is a COUNT(*) query done with an ORDER BY sorting. Sorting the count is pretty useless and has been removed. Change-Id: I8d94da2dc3dfecb7c20308180e9916b16b152b01 Resolves: #82084 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53677 Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
Susanne Moog authored
This patch introduces a bat file to run php-cs-fixer with TYPO3 core config on Windows. It does not disable xdebug like its linux counterpart. Change-Id: If4543cac0b5026a8eab469f16e234130f999ba78 Resolves: #81949 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53669 Reviewed-by:
Sascha Rademacher <sascha.rademacher+typo3@gmail.com> Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
Susanne Moog authored
Page module, view module and edit document selected data with an incomplete group by statement, missing the sorting column. This resulted in an error on mssql servers. The sorting field was added to the relevant queries. Change-Id: If1fb314542e0f27cdf18989fa2b8427c1e31e2d3 Resolves: #79298 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53674 Tested-by:
Joerg Boesche <typo3@joergboesche.de> Tested-by:
-
Mathias Brodala authored
This is a small step to unify exception handling in TYPO3 by ensuring no internal and 3rd party code is forced to catch the toplevel PHP exception. This change e.g. actually allows the FormPagePreviewRenderer to handle form loading errors. Resolves: #82052 Releases: master, 8.7 Change-Id: I5cb0b8f2c56a6bbbecc34d87474d6d8b3ad2015c Reviewed-on: https://review.typo3.org/53651 Reviewed-by:
Wolfgang Klinger <wolfgang@wazum.com> Tested-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
-
- Aug 09, 2017
-
-
Andreas Fernandez authored
New values created by AddController are now added again to the FlexForm value by fixing the value parsing. Additionally, the mixed up append/prepend values of `setValue` are fixed. Resolves: #82049 Resolves: #82050 Releases: master, 8.7 Change-Id: Ifc2a4bf4ddd39a1b004db9945f832ca6cf9d765d Reviewed-on: https://review.typo3.org/53646 Tested-by:
Sebastian Fischer <typo3@evoweb.de> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
Markus Hoelzle authored
Disallow backend users to edit pages which doktypes are not allowed via backend usergroup permissions. Resolves: #79954 Releases: master, 8.7, 7.6 Change-Id: I527602e71c62bc8e33b0886a5758c7c8040b4720 Reviewed-on: https://review.typo3.org/51796 Tested-by:
Matthias Vogel <typo3@kanti.de> Tested-by:
Josef Glatz <josef.glatz@typo3.org> Reviewed-by:
Henning Liebe <h.liebe@neusta.de> Tested-by:
-
Tomas Norre Mikkelsen authored
This allows the lowlevel lost_files cleaner to use customPaths as input too. Resolves: #72202 Releases: master,8.7 Change-Id: I1481d036c8c337eee54a97d8a192d6a39a6af404 Reviewed-on: https://review.typo3.org/45238 Tested-by:
Stefan Rotsch <stefan.rotsch@aoe.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- Aug 08, 2017
-
-
Johannes Kasberger authored
Make sure the meta data is updated whenever a file is added to a storage with DuplicationBehavior::REPLACE. This is important as otherwise the internally stored file size is wrong! Resolves: #78009 Releases: master, 8.7, 7.6 Change-Id: I93b0700afc62268f8c7a61eea7183f86a87a075e Reviewed-on: https://review.typo3.org/53653 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Helmut Hummel authored
With https://review.typo3.org/50879/ all TCA select fields are detected as relation to many, even when they are configured as simple static select. This leads to the row value to be pre-set as string (to hold comma separated values), which leads to an exception in MySQL Strict Mode when the select value field is defined as integer. Therefore only detect renderType === selectMultipleSideBySide as relational field Resolves: #81043 Releases: master, 8.7 Change-Id: I54effaace3eb19034d86a9a74bbd5cc207e867f1 Reviewed-on: https://review.typo3.org/53565 Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
- Aug 07, 2017
-
-
Sebastian Fischer authored
Changing the order of tablename and alias in method call properties makes if possible to get correct values from registered restrictions Resolves: #82046 Releases: master, 8.7 Change-Id: I17151c47c29fb48829ce0d3256ca99a4feadbf4a Reviewed-on: https://review.typo3.org/53645 Tested-by:
Daniel Goerz <ervaude@gmail.com> Tested-by:
-
- Aug 01, 2017
-
-
Christian Kuhn authored
The patch adds a new feature - the "extension scanner" - to the install tool. It is meant as a helper script for extension and project developers to quickly spot places in extension code that may need adaptions if upgrading to younger core versions. The scanner could later work with different languages, for now only scanning PHP files is supported. This is based on the great library nikic/php-parser which creates an AST from php source files and allows simple traversing. A series of matchers hooks into the traverser and scans for configured core deprecation or removals. Some additional matchers could be added if a core example evolves (for instance usage of dropped core constants). From now on, whenever the core deprecates or breaks existing core PHP API, an entry in one of the matcher configurations in ext:install/Configuration/ExtensionScanner/Php should be done. Since these API changes are documented via ReST files already, the configuration links to according ReST files. A bamboo integrity test script verifies those can be found. Furthermore, all Breaking-* and Deprecation-* ReST files since core version 9.x / master now need an additional Tag "FullyScanned", "PartiallyScanned" or "NotScanned". This is also checked by an integration test script in bamboo. The matcher configuration files are pretty straight forward and should be obvious if looking at ext:install/Configuration/ExtensionScanner/Php. This patch contains: * Add nikic/php-parser as dependency * New install tool gui to scan extensions in typo3conf/ext * Scanner infrastructure for PHP * Preparation and configuration for all current "master" / v9 ReST files * Mark ReST files which are tagged with "FullyScanned" as "not affected" in install tool "Upgrade analysis" if no match was found * Integration script testing referenced ReST files are found * Integration script verifying Breaking- and Deprecation- ReST file contain "FullyScanned", "PartiallyScanned" or "NotSCanned" keyword. More information on this feature can be found at https://docs.typo3.org/typo3cms/CoreApiReference/ExtensionScanner/Index.html Change-Id: I760e88f9d929fdd710655fa0d25cb26291a7ed2b Resolves: #82014 Releases: master Reviewed-on: https://review.typo3.org/53450 Tested-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Helmut Hummel authored
Since we introduce auto-generation of entry scripts, we must exclude them from the check. To do so, we must instruct php-cs-fixer to respect the configuration for files in the config file when calling it. Releases: master Change-Id: If1ae846f0b0a6539d2b5cc50a7c6d39043695849 Reviewed-on: https://review.typo3.org/53638 Reviewed-by:
-
Helmut Hummel authored
Related: #81951 Resolves: #82021 Releases: master Change-Id: I74b89a74b81b8ae6df73c92552857ca4a5c021a8 Reviewed-on: https://review.typo3.org/53637 Reviewed-by:
-
Helmut Hummel authored
Use the latest (and stable) versions of these packages. Composer commands: composer req typo3/cms-composer-installers ^1.4 composer update typo3/cms-cli Resolves: #82015 Releases: master Change-Id: I1969eaa3bb34675c6a1ae8d5471364a619081d96 Reviewed-on: https://review.typo3.org/53636 Tested-by:
-
- Jul 31, 2017
-
-
Helmut Hummel authored
Remove the bin definition in typo3/cms composer.json And require the package with the binary instead. Composer command: composer req typo3/cms-cli Resolves: #81980 Releases: master, 8.7 Change-Id: I504cbd08dd8d57e2b66d974d9f11150c38ab49c8 Reviewed-on: https://review.typo3.org/53601 Reviewed-by:
-
Achim Fritz authored
Use Page.Link ViewHelper in indexed_search Search Template for jump links Resolves: #79982 Releases: master, 8.7 Change-Id: I85a32714c4d098a1afc5b35ab90189e61ba16ea9 Reviewed-on: https://review.typo3.org/53496 Reviewed-by:
Ralf Merz <ralf@ralf-merz.de> Tested-by:
-
Markus Hoelzle authored
Catch the fatal database exceptions in installation progress "DatabaseSelect" and show a error message. Releases: 8.7, master Resolves: #81726 Change-Id: Id7edbdaafa97374451493d6bb9c9fdaabd2f2674 Reviewed-on: https://review.typo3.org/53498 Reviewed-by:
Philipp Gampe <philipp.gampe@typo3.org> Tested-by:
Jan Stockfisch <jan.stockfisch@googlemail.com> Reviewed-by:
-
Benni Mack authored
In order to streamline backend usage even further, the AJAX Request Handler is now using the "route" parameter the same way. This way, the RouteDispatcher does not have to distinguish between the BE calls anymore, and the Form Protections are streamlined. Resolves: #81899 Releases: master Change-Id: I48bf2406eaff2316d3f0fe5dc631a51067a570f6 Reviewed-on: https://review.typo3.org/53459 Tested-by:
-
Markus Hoelzle authored
Show a useful message if an empty install tool password is entered. Resolves: #81936 Releases: master, 8.7 Change-Id: I17aaf2aaeb5b31a68c8701cdaa560c00364bea1e Reviewed-on: https://review.typo3.org/53613 Tested-by:
Renzo Bauen <info@conpassione.ch> Reviewed-by:
Sascha Egerer <sascha@sascha-egerer.de> Tested-by:
-
Benjamin Kott authored
The view module was redesigned to provide a more modern and streamlined look and feel across the existing backend. With the introduction of named and categorized device presets we enable users to get a better idea of how the page will look like on a specific device. For even more easy testing, the orientation can now be changed without selecting a different device. Releases: master Resolves: #77576 Change-Id: Ie430db2a39a9bf6931ebde8109e62c12d9bae09b Reviewed-on: https://review.typo3.org/53061 Reviewed-by:
-
Helmut Hummel authored
With the new composer installers versions, the core package itself (in fact any composer package) can add scripts to be run on composer build time. Use this API to add scripts to TYPO3, that will create the entry scripts for frontend, backend and install tool We do this in a way, that also works if these system extensions are installed individually. This also has the benefit, that we can adapt the core with doing more things during composer build time (e.g. maybe publishing assets) in the future, or change the entry scripts to different locations, without touching the plugin any more. Resolves: #81981 Releases: master Change-Id: I3982bd5e73a14cdd54e83d0a7b3a1c93f2191efd Reviewed-on: https://review.typo3.org/53602 Reviewed-by:
-
- Jul 30, 2017
-
-
Markus Hoelzle authored
The 3rd parameter is optional, so the 4th parameter should be optional too. Resolves: #81965 Releases: master Change-Id: I4240824717a0a18c0aa669ef891ce3b42b2fbc7c Reviewed-on: https://review.typo3.org/53585 Tested-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Tested-by:
-
Nicole Cordes authored
If a wrong email address or URL is parsed and the domain cannot be converted, an exception is thrown by \Mso\IdnaConvert\IdnaConvert::encode(). This exception needs to be caught. Resolves: #81471 Releases: master, 8.7, 7.6 Change-Id: I76f9b8898655d9220e5176a60f388067a6c493b3 Reviewed-on: https://review.typo3.org/53121 Tested-by:
-
Helmut Hummel authored
Description, dependencies between core packages and core package versions are now in sync in ext_emconf.php and composer.json Now also added extension key information explicitly in composer.json What still should be done later is adding further dependencies to these files if required. This change was mostly automated using helhum/ext-tools with the command: typo3cms composerjson:sync 'typo3/sysext/*' Resolves: #82003 Releases: master, 8.7 Change-Id: Ife913038142e8ecc137d21d4d43e2cdf467fb0f9 Reviewed-on: https://review.typo3.org/53621 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
-
- Jul 29, 2017
-
-
Helmut Hummel authored
To streamline and unify the entry scripts, the install tool entry point is now moved to typo3/install.php Calling the old entry scripts and the shortcut typo3/install/ is deprecated. All access to public resources is changed to properly use the resource view helper, so that the path to the assets are not hard coded any more. Resolves: #81951 Releases: master Change-Id: Ia8827130bb041802e743767907d16269cda2fef0 Reviewed-on: https://review.typo3.org/53579 Reviewed-by:
-
- Jul 28, 2017
-
-
Helmut Hummel authored
Core extensions installed individually (from subtree split) must never be installed together with the typo3/cms package We can avoid this, by adding a conflict section in each composer.json Resolves: #81982 Releases: master, 8.7 Change-Id: Ia6a346227852237f58875a3e3216d3cad298f8bf Reviewed-on: https://review.typo3.org/53603 Tested-by:
-
- Jul 27, 2017
-
-
Christian Kuhn authored
Windows still has a relatively short max path length limitation in some situation which the core tends to violate. The patch introduces a test script activated in bamboo to test the relative path length does not exceed an arbitrary number and shortens some long path segments. This allows a statement "If your source / unpack location path prefix is not longer than x characters, you are fine". Change-Id: If182fd570c8aec28f1bab9687f2712fc3003b4ed Resolves: #81968 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53599 Reviewed-by:
-
Andreas Fernandez authored
If the AJAX request that fetches information for the System Information toolbar item fails for whatever reason, the spinner is now removed. This may happen when the session times out and the re-login modal is shown for a longer period. Resolves: #81984 Releases: master, 8.7 Change-Id: Ibe9566d29d403e64d55fd0f462d452413d863f0a Reviewed-on: https://review.typo3.org/53604 Tested-by:
-
- Jul 26, 2017
-
-
Helmut Hummel authored
To ease installation of master versions of system extensions from subtree splitted repos, we add a branch alias to all of them. Resolves: #81979 Releases: master Change-Id: Ic7f4aa4762286e4e881447d6ecdbead411e6635f Reviewed-on: https://review.typo3.org/53600 Tested-by:
-
- Jul 25, 2017
-
-
Johannes Schlier authored
Previously if the RteLinkBrowser was called from a CKEditor instance that is within an extra iframe, the CKEditor instance could not be found. Attaching it directly to the Modal fixes this. Resolves: #81929 Releases: master, 8.7 Change-Id: I384fc946ed671c12b1e82732f0418a347ee9f01e Reviewed-on: https://review.typo3.org/53555 Tested-by:
-
Erich Manser authored
Change-Id: I3ed07ead31d7f572615916be90ef4c3882360d8b Resolves: #81729 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53573 Tested-by:
Wittkiel Gruppe <ts@wittkiel-gruppe.com> Reviewed-by:
Xavier Perseguers <xavier@typo3.org> Tested-by:
-
- Jul 24, 2017
-
-
Oliver Hader authored
In case RelationHandler::readForeignField() is called with invalid UID values for a parent record (e.g. zero, or non-numeric values), all records might be selected if the database default value for a parent pointer field is set to zero instead of NULL. Besides that DataMapProcessor::synchronizeInlineRelations() uses the mentioned RelationHandler method to resolve suggested and actually persisted relations. The processing is adjusted to avoid invoking RelationHandler using non-numeric parent pointer values. Resolves: #81915 Releases: master, 8.7 Change-Id: I108501c69c9cdb732bb88526830f0f73f2d680af Reviewed-on: https://review.typo3.org/53544 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Xavier Perseguers authored
When checking for precondition in the request, HTTP 400 code should be returned whenever the client is responsible for having issued a bad request. HTTP 500 indicates an internal error on the server, which is not the case under such circumstance. Change-Id: Ib7e63428b1a84b63e1a2a0c9d95513972be83d33 Resolves: #81941 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53564 Tested-by:
-
Xavier Perseguers authored
Change-Id: I447274bc29d1a32745224b6cf5c2e2f76c7dfc2f Resolves: #81947 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53577 Reviewed-by:
-
Frank Naegler authored
QueryBuilder->quoteIdentifiersForSelect() now supports lowercase and mixedcase „as“ to detect alias names for fields. Resolves: #81946 Releases: master, 8.7 Change-Id: Ib79088e3dd677efd24674d7aa9f5c3f4c973ec8d Reviewed-on: https://review.typo3.org/53575 Reviewed-by:
-
Frank Naegler authored
Resolves: #38735 Releases: master Change-Id: I5339f7a031b1e365c1d70c6ccb079bcff827c09e Reviewed-on: https://review.typo3.org/53558 Tested-by:
-
Frans Saris authored
Resolves: #76440 Releases: master, 8.7, 7,6 Change-Id: I519641eadd3342369b66252da2d50ca54726aacb Reviewed-on: https://review.typo3.org/53418 Tested-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
-
Helmut Hummel authored
Unsetting file properties needs to happen AFTER the storage deleted the file, because the storage emits a signal, which passes the file object to the slots, which may need all file properties of the deleted file. Resolves: #81926 Related: #80359 Releases: master, 8.7, 7.6 Change-Id: Ie8e25b30dd99d1ed2afb8ca7b1cc83797887de98 Reviewed-on: https://review.typo3.org/53553 Reviewed-by:
-
