- Feb 28, 2020
-
-
Andreas Fernandez authored
This patch removes most of the jQuery usages from EXT:dashboard. It's kept at places where we can't refrain from using jQuery right now, as this is a limition in our API. Resolves: #90553 Releases: master Change-Id: Ib00a287099e412cea95c913c52c89441decffa15 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63451 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
Susanne Moog authored
Since columnsOverrides it is possible to overwrite TCA definitions for specific columns and type combinations. However, as there is no specific type definition for backend user sections, the default type (and its overrides) were used. Backend user section was the only undefined type. The type definition has now been added. Resolves: #90577 Releases: master, 9.5 Change-Id: Ifded3bd9642afd7fffbb8918c9181ef1e3c7b6ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63482 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
Alexander Schnitzler authored
This patch introduces a bootstrap file for phpstan to define missing constants phpstan would report otherwise. A dedicated config file phpstan.typo3.neon has been introduced because there are plans to release a seperate configuration package that not only the core uses but which is also useful for TYPO3 users that test their codebase with phpstan. Releases: master Resolves: #90575 Change-Id: I1c5bce558c882f9dd002e480d78405770bdf8cc0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63480 Tested-by:
-
Elias Häußler authored
This patch addds a basic keyboard navigation inside the multi-step wizard for new forms in backend. This improves handling forms with the multiple steps in this wizard. Additionally, most useful input elements, such as input fields and next step/finalize buttons are now focused by default when going to the next slide. Also the focus styles were added to these elements. Resolves: #90132 Releases: master Change-Id: Ia668b727bf4cdba0e04ae409484dc44492360a33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63154 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Jan Stockfisch authored
All felogin pibase hooks and classes are now deprecated. For each hook a replacement event is provided. Resolves: #88740 Releases: master Change-Id: I178f49d78c03a1fb9cd03990bebcbc1cf39b90d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62584 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Alexander Schnitzler authored
Releases: master Resolves: #90569 Change-Id: I6ed32592b2ad093800e5ebe98f31819a6b91b9ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63479 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
-
Susanne Moog authored
Optimize loop for rendering. Resolves: #90544 Releases: master Change-Id: I9775ac3e1d2f500f35c926dc3bfdc06df96c6b7c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63440 Tested-by:
-
Marco Pfeiffer authored
\TYPO3\CMS\Fluid\ViewHelpers\Form\SelectViewHelper::isSelected uses a strict type comparison but the OptionViewHelper does not. This resulted in funny results when the values were convertable to int like this: var_dump(in_array(1, ['1-2'])); // prints bool(true) The value is now converted to a string, just like in the SelectViewHelper, and then strictly compared. Releases: master Resolves: #90540 Change-Id: I6c28316ca306f5188141a0222b6f09a1d1fc108e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63439 Tested-by:
-
Andreas Fernandez authored
Resolves: #90557 Releases: master Change-Id: I9532ce47c1bee205fcf0b2afe941dc1be10e532a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63476 Tested-by:
-
Andreas Fernandez authored
This patch replaces jquery-ui/sortable with Sortable.js which has been introduced with the refactoring of the IRRE component. Additionally, some styling is added to improve the visual indication of a current sorting in progress. Resolves: #90561 Releases: master Change-Id: If2c15b16aa21ff9abbc91bdb00544a16b383a591 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63477 Reviewed-by:
-
Francois Suter authored
The ContentObjectRenderer checks whether it is relevant or not to apply the ifEmpty property before actually applying it. However the check does not use the same condition as ifEmpty itself (PHP empty() vs trim()). This patch ensures consistency while respecting the idea of the original fix (avoid a useless processing). NOTE: I have inverted the two conditions in the "if" statement following a recommendation by the Php Inspections plugin of PhpStorm which said that the condition about "ifBlank" was faster and should be executed first. Resolves: #90318 Releases: 9.5,master Change-Id: I654089f757d9339365e062dbd66948f71b8cdd93 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63175 Reviewed-by:
Wolfgang Klinger <wolfgang@wazum.com> Reviewed-by:
-
Stefan Froemken authored
When using only f:hidden fields for sub-properties of a domain model which has to be updated, no identity fields (__identity) are generated in HTML which results in creating new model instead of updating it. Resolves: #90331 Releases: master, 9.5 Change-Id: Ic14478a682a98bb96c27567da23b69da359cb726 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63177 Reviewed-by:
-
- Feb 27, 2020
-
-
Alexander Schnitzler authored
Releases: master Resolves: #90558 Change-Id: I9a02974eb3c4efc242d83f0610f7fc15764b30b7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63042 Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
-
Nikita Hovratov authored
The last time this css file was seen is in the old rtehtmlarea. Since it got replaced with the new ckeditor, the css was missing and the resize handles of the focusArea were lacking required styling. Resolves: #90437 Releases: master, 9.5, 8.7 Change-Id: I29cd6d255e7866d91a3480ed7ce40690cefd8c51 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63326 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Susanne Moog authored
When recreating a slug via the datahandler, the full record is present in the hook, whereas when recreating the same slug via the ajax request only a sub-set of values is sent. To ensure postModifiers are able to recreate and modify slugs based on the original record, the handling has been changed to always provide the record uid for further processing. Resolves: #89862 Releases: master, 9.5 Change-Id: Ib0d0b86be1c544d44c1b7420619b21afd5650988 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63447 Tested-by:
-
Alexander Schnitzler authored
Method getTypeOfChildProperty() of class ObjectConverter didn't throw an exception if the class schema didn't detect a type for the given child property. This could have led to the case where said method returned void and resulted in a type error exception. Releases: master, 9.5 Resolves: #90489 Change-Id: Iad0ec747a95fe9e64ee03ea4a8d2dc933e1d7361 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63372 Reviewed-by:
-
Daniel Goerz authored
Resolves: #90554 Releases: master Change-Id: I4cbdcadbec39766f87ca1561f6b2310e90c70ba5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63473 Tested-by:
-
Andreas Fernandez authored
The dependencies of the dashboard are now properly imported to fix loading issues. Resolves: #90546 Releases: master Change-Id: I9f86e9e9dc87082269cda777b373bc02df414153 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63472 Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
Franz Holzinger authored
Releases: master, 9.5 Resolves: #90552 Change-Id: Iece6f3a354419b6b48c704394d45ea94f4bf45d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63450 Tested-by:
-
Oliver Bartsch authored
To make examples more clear more meaningful terms are now used. Resolves: #90550 Releases: master, 9.5 Change-Id: Iee68811177fdee85b0f89f5ce120b217222039f9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63445 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Alexander Schnitzler authored
This is a followup patch for the introduction of Argon2id. https://review.typo3.org/c/Packages/TYPO3.CMS/+/63077 That commit introduced access to class constants that are only available through late static binding. This approach does not follow a contract and uses a bit of a magical approach instead. It's hard to read for the user, cannot be type checked and it is possibly unstable and may produce unforeseen issues when inheriting AbstractArgon2PasswordHash without defining said class constants. To have a clean architecture with a contract driven approach an interface is introduced which child classes of AbstractArgon2PasswordHash have to implement. This ensures that the algorithm in AbstractArgon2PasswordHash can reliably fetch necessary information from the child classes. Releases: master Resolves: #90508 Change-Id: I950da09762bcc859b5c03ad8ffeeefe46af2ed02 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63391 Reviewed-by:
-
Alexander Schnitzler authored
Passing a non object variable or non null value as third argument "$ref" into method GeneralUtility::callUserFunction has been deprecated. As of TYPO3 version 11.0 said method argument must be either null or of type object. Releases: master Resolves: #90377 Change-Id: I83d75c1c78d1d41d94b6e497b04644e704b902db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63075 Tested-by:
-
Manuel Munz authored
When 'Index Records immediately when saved?' is enabled in indexing configurations for records, then on saving the record the string 'null' is used for this indexingconfiguration and passed to SearchController::preparePageLink(), which expects an array and therefore throws an exception. This commit fixes this by checking if $this->conf['staticPageArguments'] is an array and only then json_decode that, else it sets the value to null. Resolves: #89816 Related: #86994 Releases: master, 9.5 Change-Id: I96d3fb963ecb508bc536967afece064ad12bb989 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63414 Tested-by:
-
Cypelt authored
make annotation comment of the isValid method from UrlValidator more clear Releases: master Resolves: #90549 Change-Id: I119ca5d586cff037d905e26189a460585d7e4725 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63444 Tested-by:
-
Georg Ringer authored
Remove the outdated note about using in unit tests only and set the method to internal as it used by the core but shouldn't be any public API. Resolves: #90516 Releases: master. 9.5 Change-Id: I422e3982844b06d34fbb66ab77b26ace48fd537b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63442 Tested-by:
Christian Eßl <indy.essl@gmail.com> Tested-by:
-
Georg Ringer authored
Once upon a time there was a doktype 5 for "not in menu" pages which has been moved to a checkbox since a long time. The outdated information can be removed. Resolves: #90472 Releases: master Change-Id: I8755a69cad778afe25527e90521963b5cb87de68 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63441 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
- Feb 26, 2020
-
-
Florian Schuhmann authored
The existing ProcessedFiles identifier check must be adjusted, since the default value is an empty string for entries that uses the original file. Resolves: #89716 Releases: master, 9.5 Change-Id: Iea68cfbc02da0872b14a5645d3a0d4d60263738c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62538 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Steffen Frese <steffenf14@gmail.com> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Sascha Rademacher <sascha.rademacher+typo3@gmail.com> Reviewed-by:
-
Helmut Hummel authored
AssetCollector is a singleton, but of course does not survive requests. Since uncached plugins should be able to access asset state from cached TypoScript or other uncached plugins, we must make sure this state is serialized in the cache (PageRenderer is serialized) and restored from cache. Releases: master Resolves: #90537 Change-Id: I6f954aecf0d83e0e81fca45167cdb31734af9e81 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63433 Tested-by:
-
Oliver Bartsch authored
The two new ViewHelpers `CssViewHelper` and `ScriptViewHelper` automatically render the content of their body if no source file is supplied in the ViewHelpers argument. However if the body is empty, NULL is passed to the AssetCollectors add inline code functions. This leads to a TypeError as these parameters are type hinted. Therefore the body content is now checked before the methods get called to prevent passing NULL or an empty string. Resolves: #90539 Releases: master Change-Id: I80feb9551f50e6ab8ac56740b605c4bbbfbe3069 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63437 Tested-by:
Jens Ulrich <jens.ulrich@snk.de> Tested-by:
-
Andreas Fernandez authored
The postMessage sent to IRRE when uploading a file via drag & drop missed the actionName, which resulted in ignoring the message. The actionName is now used and also streamlined to match the actual behavior. Resolves: #90534 Releases: master Change-Id: Ic56059762a6822e27ac64ea6fc07b5d37fc34c9a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63434 Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Tested-by:
Alexander Grein <alexander.grein@gmail.com> Tested-by:
-
Susanne Moog authored
Releases: master Resolves: #90538 Change-Id: I51038d26371577ee3795b9774814766f39f9cc1e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63436 Tested-by:
Daniel Siepmann <coding@daniel-siepmann.de> Tested-by:
-
- Feb 25, 2020
-
-
c.essl authored
This patch adds $TSkey labels to a few calls to cObjGetSingle() to improve the debugging experience with the TS tree in the AdminPanel and to avoid nondescriptive "__" strings as labels. It also improves the profiler output for cObjectViewHelper Resolves: #64906 Releases: master, 9.5 Change-Id: Iaf500390f0c6e329e15b2ff6677e8c3ebb54df5f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60820 Tested-by:
-
Oliver Hader authored
Change-Id: I0bdeb9a461dd2a6e5378075425412667f6126523 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63413 Tested-by:
-
Oliver Hader authored
Change-Id: I46bd52fe097a1c9d212bc4b23951efbb1cee18d3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63412 Tested-by:
-
Daniel Siepmann authored
The existing behaviour was changed when introducing the AssetCollector. The existing variable $imagesOnPage was overwritten with all information from collected media. Originally only specific information were added. Providing all information lead to closures ending up in serialization of information during storing in cache. This patch reverts back to original behaviour, only necessary information are added. Relates: #90522 Releases: master Change-Id: I22a34ad333d966c032386cc983a5f3205ba3ffe3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63411 Tested-by:
-
Benjamin Kott authored
Widget footer is now only rendered if the optional footer section for widgets is used and contains content. In addition, minor styling issues were resolved. Templates were cleaned up again. Some extra conditions were added to prevent empty tags. Resolves: #90530 Releases: master Change-Id: Idb4a6858395622a62448041fec3d510bec6fb271 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63410 Tested-by:
-
Anja Leichsenring authored
The upcoming release of TYPO3 10.3 requires all documentation to be placed into the version folder. Resolves: #90510 Releases: master Change-Id: Ieccc5fa1c71a3f2d0513a4a1e6d2f053a0bb0c3f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63393 Tested-by:
-
Georg Ringer authored
With #78450 the StandardContentPreviewRenderer creates an instance of the `PageLayoutView` to keep the existing hooks alive. However 2 more properties need to be filled to improve the compatibility. Resolves: #90528 Releases: master Change-Id: I0c56988bdc9d524f1cfa411ae0c62d00ad1789dd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63408 Reviewed-by:
Claus Due <claus@phpmind.net> Reviewed-by:
-
ochorocho authored
Add example for elements of type RadioButton/MultiCheckbox. Releases: master, 9.5 Resolves: #90520 Change-Id: Ifaeac0d2e3ef017aeb717aa52bc7c763ba16e8ef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63409 Tested-by:
-
Oliver Bartsch authored
Before the final release of the dashboard some clean up is done. Among others following tasks are performed: * Add missing PHPDocs * Remove unused methods * Remove superfluous properties * Unify namespace format * Fix some typos * Fix some formatting * Make closures static * NoDashboardAvailableException is removed as it is never be thrown * Extend documentation for missing widget groups Resolves: #90524 Releases: master Change-Id: Ia0f7d71def358bf0ee8ab42d97f012c14cdede1c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63407 Tested-by:
-
