Change-Id: I6e25181228d9c65bc4eee0b2309aed54ce24d181
Reviewed-on: https://review.typo3.org/29524
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team

Change-Id: I43e62cf514ffc35d05163fee8bf0f222f3a18df7
Reviewed-on: https://review.typo3.org/29523
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team

This patch changes the warnings to a notices if files or folders are
readable for anyone. This improves usability for users on
non-restrictive systems as 1und1 servers.

Resolves: #57354
Releases: 6.2
Change-Id: Ic9eba030647e837694331d394d45dc1553c0cdf5
Reviewed-on: https://review.typo3.org/28917
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny

On multiple places the new folder or filename is not sanitized
before the checks are done to see if the a folder of file with
that name already exists.

This patch makes sure the new names gets sanitized first and
also takes care that the name of the resultObject is passed to
the PostFolderMove, PostFolderCopy and PostFolderRename signals.

Resolves: #57681
Releases: 6.2
Change-Id: Id951ded531c9979e7cb4bdcd319f56a8f810fa96
Reviewed-on: https://review.typo3.org/29202
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Stefan Neufeind
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Francois Suter
Tested-by: Francois Suter

If the end of a result set is reached some drivers produce NULL.
This must be changed into FALSE to be compatible with the
non-DBAL version of these functions.

Resolves: #57957
Releases: 6.2, 6.1
Change-Id: I664dd10735f88754c74e20ecd5c07fad5ef2b78d
Reviewed-on: https://review.typo3.org/29502
Reviewed-by: Mathias Schreiber
Tested-by: Mathias Schreiber
Reviewed-by: Markus Klein
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

The TCA tree element fail to load inside IRRE, in some condition
(when the record is not loaded/opened)

Change-Id: Id077a71e2191b0cf91003611e11dc5aefafab0c9
Resolves: #39035
Releases: 6.2, 6.1
Reviewed-on: https://review.typo3.org/12850
Reviewed-by: Markus Klein
Reviewed-by: Laurent Cherpit
Reviewed-by: Dominique Feyer
Tested-by: Dominique Feyer
Reviewed-by: Fabien Udriot
Reviewed-by: Frans Saris
Tested-by: Frans Saris

The maxLevels in the TCA tree configuration is not set
by the CategoryRegistry. As a result only 4 levels are
shown.

This patch sets the maxLevels to 99 and also updates the
appearance settings of the sys_category:parent field
so these are inline with the other category tree fields.

Resolves: #57750
Releases: 6.2
Change-Id: I7c33b71d2af214cf1b2027e4769c1cc43a3c43d6
Reviewed-on: https://review.typo3.org/29297
Reviewed-by: Alexander Opitz
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Stefan Neufeind
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Frans Saris
Tested-by: Frans Saris

Fix a possible warning in the new method and simplify test
cases a bit.

Change-Id: Ie9ee3c1b52d3a692c23428f21e3fb7311da9cb2a
Resolves: #33499
Releases: 6.2
Reviewed-on: https://review.typo3.org/29492
Reviewed-by: Andreas Wolf
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

After successfully migrating a field, the field is not added to the list
of finished fields, due to a superfluous check.

Running wizard again finally adds the field to the finished list as the
condition is fulfilled, but the additional run does not
do any useful work anymore.

Fix this by adjusting the condition to safe the extra run.

Resolves: #57497
Releases: 6.2
Change-Id: I6bc15de6f5dbeb58151a1745a849e1b0581b2fbe
Reviewed-on: https://review.typo3.org/29033
Reviewed-by: Frans Saris
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Change-Id: I8606f5e0a1525cb98839a41271466a18b9f3cccf
Fixes: #33499
Releases: 6.2, 6.1
Reviewed-on: https://review.typo3.org/10448
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

This change adds the feature that php files in the
extension directory Configuration/TCA/Overrides/
will be executed right before building the cached
TCA. These files must *only* contain PHP code
that manipulate TCA (like addTCAColumns or
addToAllTCATypes).

The benefit in doing so is that we can move all code
manipulating the TCA that previously was in ext_tables.php
and therefore uncachable, can now be in a defined
location and is only executed when TCA is built
and after that cached.

This will give backend requests quite a performance
boost once extensions start using these files.

Category Registry changes will also be applied
after Configuration/TCA/Overrides/ has been processed
so that makeCategorizable calls can now also happen
in files in this locations and do not need to stay
in ext_localconf.php where they also would be executed
on every request.

For now only filemetadata extension TCA configuration
is moved. All other core extensions will follow later.

Resolves: #57942
Documentation: #57951
Releases: 6.2
Change-Id: Id7fdebac266bc0b4e85a45b64d73e4f4f3c59a36
Reviewed-on: https://review.typo3.org/29484
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

The category registry test and makeCategorizable
test of extension management utility are cleaned up
to use proper naming and actually test what
is in their scope.

Resolves: #57949
Releases: 6.2
Change-Id: I5dae812435d71b5188b4dc8ecf9dd2ce9d400658
Reviewed-on: https://review.typo3.org/29488
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

This reverts commit 2b4aeefc

This is reverted in favor of a better approach that makes
caching for every TCA additions or override possible.

Besides that, this change introduced a regression, as
database compare in install tool does not work properly any more.

Change-Id: I4fc0d3d76f28afd8ff82ae5537ff3b207fa53bae
Reviewed-on: https://review.typo3.org/29480
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Currently TCA changes of the category API are applied on every request
after the extTables files is included. This makes it impossible to
override the changes by third party extensions and also we do not
benefit from caching.

Instead we now use the introduced signal and apply the changes
right before caching.

With this change we also have a clear separation of
registering category field additions (in ext_localconf.php) and
applying the TCA changes while building the TCA cache.

Resolves: #57881
Releases: 6.2
Change-Id: I385c894fe13eb4cd4f8f2b4c82a9513b05308daa
Reviewed-on: https://review.typo3.org/29424
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

TYPO3 Fluid offers view helper TableListViewHelper to generate
records list in backend modules. When pagination is rendered
for this list all links (previous, next etc.) redirect to
List module but they should point to current backend module.
Reason of this behaviour is hardcoded module name in listURL()
function.

This patch replaces hardcoded module name with the M
parameter from GET array. Extbase modules require also
controller and action name in url's so all GET params
are merged with this defined in listURL() function. We are
using all GET params because module might require more
than controller and action name for other elements than
records list.

Resolves: #55314
Releases: 6.2
Change-Id: I706cf99838620c961e1b3f7af667d0c6ba447077
Reviewed-on: https://review.typo3.org/27049
Reviewed-by: Stefan Neufeind
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Markus Klein
Tested-by: Markus Klein

This changes adds some missing @throws annotations and improves the
readability of some comments.

Also fix a typo in an exception and reformat some exceptions for
better readability.

Moreover add some checks if the correct type is present
before calling undefined methods.

This change does not introduce any functional changes.

Releases: 6.2
Resolves: #57871
Change-Id: Iab4414bd480a05cc5ca3b29df0d12e719064b063
Reviewed-on: https://review.typo3.org/29439
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Upgrades prototype from 1.6.0.3 to 1.7.1 and scriptaculous
from 1.8.2 to 1.9.0.

Solves the problem with sorting IRRE elements in IE9+, for example.

Resolves: #51768
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I5ea11b2e926ae0f23d1c6d85a0ff5ba24995eebb
Reviewed-on: https://review.typo3.org/27090
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Resolves: #57921
Releases: 6.2
Change-Id: I5342f0d4f78831605c24b3354c1fbb7316738ca4
Reviewed-on: https://review.typo3.org/29470
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Instead reset them to a default value.

Resolves: #57920
Releases: 6.2
Change-Id: I900cbd46b5573a84133efe1cf9fbf29d483e8096
Reviewed-on: https://review.typo3.org/29469
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

To improve performance in backend context, final
TCA should be cached in contrast to only parts of it.

To be able to cache the complete TCA, we need to introduce a signal
after building the cached TCA from files.

#57862 describes further steps, which are not in scope of this change.

This is a completely non breaking change, it only
adds new API which extension authors can also
use to benefit from the resulting performance gain.

Resolves: #57863
Documentation: #57895
Releases: 6.2
Change-Id: I1174b68b59f2ebc5b8c0c227ac13102366c2136a
Reviewed-on: https://review.typo3.org/29433
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

There are 3 issues in the admin panel currently which slipped through.

* CSRF protection is not working in the FE even though
  there is a BE_USER provided
* Wrong title is used for the link of "record history" link
* Incorrect usage of htmlspecialchars-conversion
  (don't escape title for calls to getSpriteIcon, ...)

Resolves: #57579
Releases: 6.2
Change-Id: I613b67e78789d479435f561a27252550c42b4452
Reviewed-on: https://review.typo3.org/29095
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

The core still ships jQuery 1.9.1 within the contrib folder,
but the list of available versions in PageRenderer does not
contain that version.

Lets just add it.

Resolves: #57466
Releases: 6.2
Change-Id: I10f8e1d24b0c8a8864187c2fe3641cce4303fb5c
Reviewed-on: https://review.typo3.org/29449
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Resolves: #57873
Releases: 6.2
Change-Id: I6f622c32429143bd55ffe9286a26a920d791ea5b
Reviewed-on: https://review.typo3.org/29443
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

This patch introduces FAL support in impexp for the import of
exports done in version 4.x by using a legacy mode. Related images
from uploads/ (tt_content:images and pages:media) are moved to
the folder /_imported/ below users default storage.
Linked files and RTE images are moved to the original folder
structure below the folder /_imported/ below users default storage.

Also the images additional information, like titleTexts and links are
migrated to the new created file reference record.

These scenarios are covered with functional tests:
* pages media
* pages_language_overlay media
* tt_content images
* links to files
* links to files in RTE
* images in RTE
* other records using fields of type "group" internal_type "file"
  or "file_reference" in TCA and FlexForm fields.

Resolves: #52593
Releases: 6.2
Change-Id: I170ec20827af255f85ddc0fd51ffe30df7ef6b4e
Reviewed-on: https://review.typo3.org/22939
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Builds error regularily because our scripts
need to output something at least every 10 minutes.

This might not happen as the complete functional test
suite takes longer than that.

To avoid these issues, only execute unit tests and lint
in parallel and each functional test suite.

By doing so, each functional test suite can take
up to 10 minutes which is for now a limit we do not
reach.

Releases: 6.2
Change-Id: I74cac706748cc03388f814f09e799a8705a26bca
Reviewed-on: https://review.typo3.org/29133
Reviewed-by: Markus Klein
Reviewed-by: Stefan Neufeind
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

vfsStream was namespaced a while ago. While ext:phpunit still has
a Migration to map non namespaced classes to the namespaced ones,
they should not be used any longer.

Change-Id: I44dcda6707cf6410125f01552c995a27113b3cc2
Resolves: #57872
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/29440
Reviewed-by: Oliver Klee
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Like the Web\RequestBuilder the Cli\RequestBuilder is a service
object for the RequestHandler. It gets injected and has no
internal state, thus it should be a Singleton.

Resolves: #57591
Releases: 6.2
Change-Id: I959fcfdbc4182cd86cd38d438a0ff7f0de1845f1
Reviewed-on: https://review.typo3.org/29112
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Admin user records still process earlier defined mounts which leads
to a cluttered page tree or filelist tree, respectively.

Resolves: #57587
Releases: 6.2
Change-Id: I9cae20da90f4f796db8a8831a09e5f4d029ae249
Reviewed-on: https://review.typo3.org/29110
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Removes "Define visibility" @todo annotations in
phpdoc blocks of public variables and methods which
are used in index_ts.php and have therefore be public.

Resolves: #57865
Releases: 6.2
Change-Id: Ide7190fcabb802bf5f4706c916f2e3ac0ee53be7
Reviewed-on: https://review.typo3.org/29434
Reviewed-by: Oliver Klee
Reviewed-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Introduce getters for global objects

Resolves: #57855
Releases: 6.2
Change-Id: I08d37c8934a4b89ef92d31d96073c293a89f04e1
Reviewed-on: https://review.typo3.org/29411
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Oliver Klee
Reviewed-by: Stefan Neufeind
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Extend the PHP_SAPI check with "srv" to match the interface between
the webserver and PHP also for Facebook's HHVM and set the paths
correctly for HHVM hostings.

Resolves: #57785
Releases: 6.2
Change-Id: Ie9e302f9ce606158f5e70af1930eda778a8a5a34
Reviewed-on: https://review.typo3.org/29335
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Resolves: #57814
Releases: 6.2
Change-Id: I0f92a0695f5897eb0311f68bfd21ebb40d9303d8
Reviewed-on: https://review.typo3.org/29355
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Oliver Klee
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

This patch improves the update process as it removes the hard stop after
an SQL error occurred. All queries should get executed and errors should
be reported at the end. Sometimes it gets necessary that the updater is
called more that once - a notice to the user is added.

Besides the index length is reduced by 1 to ensure the index is set
with limitation in the database and all fields can be updated in the
second step.

Resolves: #57421
Releases: 6.2
Change-Id: I2f830a8a62b8dff3fbe949d40de8ddc30f3dfb9a
Reviewed-on: https://review.typo3.org/28945
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

* fix comment line lengths to improve readability and meet the CGL
* add some additional line breaks in comments to improve readability
* add missing @throws annotations in phpdoc blocks
* add missing @var annotations in phpdoc blocks

Resolves: #57859
Releases: 6.2
Change-Id: I311c6c858c8810b4a8906918378629aef5e1ebc8
Reviewed-on: https://review.typo3.org/29425
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Resolves: #57819
Releases: 6.2
Change-Id: I24a860dda49504e8745fe195f74c519a73a22991
Reviewed-on: https://review.typo3.org/29376
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Markus Klein
Tested-by: Markus Klein

* fixes CGL issues in annotations,
* fixes wrong annotations,
* introduces use statements

Resolves: #57661
Releases: 6.2
Change-Id: I41363888c523aedd13a795572d8c66430c0f34e3
Reviewed-on: https://review.typo3.org/29178
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

On detaching related objects the foreign_match_fields needs
to be cleared.

Resolves: #47694
Relates: #45337
Releases: 6.2, 6.1
Change-Id: I6d74201afc437a2b0e2a73022bc71ed0cd1dd2d4
Reviewed-on: https://review.typo3.org/26694
Reviewed-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

With the introduction of the file abstraction layer,
the filemount functionality was deprecated in 6.0
but wasn't removed.

However, the usage of addFileMount() in  rtehtmlarea and
EXT:recordlist is now removed, since the added filemounts
are never read anywhere, so this is only dead code.

The functionality needs to be re-implemented.

Releases: 6.2
Resolves: #56772
Change-Id: I20ec66f46f15a785f5014cb625dabef711fae0a1
Reviewed-on: https://review.typo3.org/28265
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Oliver Klee
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Clean up the source code of the authentication classes.
This patch does not change any functionality.
It serves as a basis for further improvements.

Resolves: #57788
Releases: 6.2
Change-Id: I555456c28da6697398a15ad9718a162f98aef61a
Reviewed-on: https://review.typo3.org/29322
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

processIncludes() is run "mandatory" from the stack ->start()
->runThroughTemplates() and doing all the work that needs to be done.

Resolves: #54903
Releases: 6.2
Change-Id: Id2be1a25aa23a05849297315c74358a9ef4ff9bb
Reviewed-on: https://review.typo3.org/26748
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Oliver Klee
Reviewed-by: Markus Klein
Tested-by: Markus Klein