Skip to content
Snippets Groups Projects
Commit a7d1f8cd authored by Markus Klein's avatar Markus Klein Committed by Stefan Neufeind
Browse files

[BUGFIX] TceformsUpdateWizard shows up too often

After successfully migrating a field, the field is not added to the list
of finished fields, due to a superfluous check.

Running wizard again finally adds the field to the finished list as the
condition is fulfilled, but the additional run does not
do any useful work anymore.

Fix this by adjusting the condition to safe the extra run.

Resolves: #57497
Releases: 6.2
Change-Id: I6bc15de6f5dbeb58151a1745a849e1b0581b2fbe
Reviewed-on: https://review.typo3.org/29033
Reviewed-by: Frans Saris
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
parent f8896e10
Branches
Tags
No related merge requests found
......@@ -192,9 +192,8 @@ class TceformsUpdateWizard extends AbstractUpdate {
}
} while (count($records) === self::RECORDS_PER_QUERY);
// add the field to the "finished fields"
// this can only be done
if (is_array($records) && count($records) === 0) {
// add the field to the "finished fields" if things didn't fail above
if (is_array($records)) {
$finishedFields[] = $fieldKey;
}
}
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment