- Jun 30, 2024
-
-
Kevin Appelt authored
Use #[AutowireLocator] instead. Resolves: #104262 Related: #103437 Releases: main Change-Id: Iee77653ec3a1cf8ba1513439239834561043e240 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85011 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null type to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104265 Releases: main, 12.4, 11.5 Change-Id: Ifb6887a9fc77bc74c2d287b34a6876cc5da477da Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85019 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Mogens Fiebrandt <mogens.fiebrandt@googlemail.com>
-
Garvin Hicking authored
In the Admin Tools > Settings > Extension Configuration module, extensions can provide a ext_config_template.txt file. Comments inside that file dictate where and in which order a configuration option is listed. The syntax is: ``` # cat=SomeCategory//0; type=boolean; label=some config bar = 0 # cat=SomeCategory//1; type=boolean; label=other config baz = 0 ``` The parsing routine however could not properly deal with "0" entries for the input element order because checking this was using an "falsy" statement instead of allowing also "0" as a string. In this case, such a zero-based config element was not displayed. This is fixed, and an example is added to the EXT:styleguide extension configuration. Note that the error would not cause problems when either: * Another category assignment of another input element took place before, thus properly initializing the sort ordering. * The key did not use "0" as a sorting index, but anything non-falsy. * The string "cat=SomeCategory//0" was replaced with "cat=SomeCategory/0" (thus having an unset sorting key). Resolves: #102760 Related: #97816 Releases: main, 12.4 Change-Id: I6954bcf8f840d9e45372fc8fa8099381ce2b8b76 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84912 Reviewed-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null type to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104266 Releases: main, 12.4, 11.5 Change-Id: I731d63dbbb13df6b3e0b6f40641ac0a98e92519f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85022 Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null type to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104264 Releases: main, 12.4, 11.5 Change-Id: I64badf36faf69bc84f622cc9e7d5c1949c928ff1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85016 Tested-by:
-
David Mellen authored
This commit allows to use environment variables in YAML keys as well. Resolves: #99889 Releases: main, 12.4 Change-Id: I1e0272aade1188a483089412156c18e291d1ffbc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84891 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
- Jun 29, 2024
-
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null type to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104250 Releases: main, 12.4, 11.5 Change-Id: Ic0842784b1a647fbde6e0472a8efef934ce03663 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85004 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Jasmina Ließmann authored
With #103493 a new link was introduced to edit the full record that contains a broken link. In doing so, the existing link variable was renamed, which caused the link stored on the record title to no longer work. This patch now sets the correct variable for this link again. Resolves: #104261 Related: #103493 Releases: main Change-Id: Id5087c0b92539a5ff03feb212bdabdb2bb106a0f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85010 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
-
Garvin Hicking authored
When the TCA type "group" or "folder" is rendered in FormEngine, under certain circumstances the HTML structure would close add `<div>` elements without opening those first. This will lead to a record not being editable, because variables are wrongly transferred due to the browser-rendering of wrong HTML nesting levels. This behaviour is an edge case and only happens with this TCA configuration: * either `config[hideMoveIcons]` is set to `true` * or `config[hideDeleteIcon]` is set to `true` Resolves: #98436 Releases: main, 12.4, 11.5 Change-Id: Ibb28c6130051b3dae92b3285df0831e84634e210 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84897 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
Torben Hansen authored
With #102762, `GeneralUtility::hmac()` has been deprecated. The change also added a method call match for the extension scanner, which however refers to the wrong RST file. This change fixes the wrong RST reference. Resolves: #104260 Related: #102762 Releases: main Change-Id: I7e0fd8a871198bc66ffa13a1adb994a2c3c4ed48 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85009 Reviewed-by:
-
Stefan Bürk authored
This change adds a test to ensure that an `BIGINT AUTO_INCREMENT PRIMARY KEY` field works across all databases up to the lowest maximal value across all databases: POSTGRES INTEGER 9223372036854775807 TYPO3 SQL Parser is tested also with this test along with the Doctrine DBAL baked database migration. Resolves: #104259 Releases: main Change-Id: Ie9ecdf2a5ca5fed46db3097a59b7004fe20044e2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85007 Tested-by: -
Christian Kuhn authored
A rather small change to insert all relation rows at once per handled source row. This gives the database options to optimize insert operations, reduces network overhead and number of queries. My tiny dev setup on an empty sys_refindex table with a local DB gives a performance gain of about 5% with referenceindex:update, other instances will vary, but it won't be slower. This is good especially with first v13 instance upgrade, since refindex basically needs a full rebuild on first run due to the recently introduces new fields. Resolves: #104258 Related: #103748 Releases: main Change-Id: I02bac730847631dbc446110c58a625e6d9fdc030 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85003 Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
-
Albrecht Koehnlein authored
Add a configuration option to customize the environment check in the Install Tool for a list of `disable_functions` which are then reported as warning instead of error. With this new configuration option, a system maintainer is able to add function names to this list. Thus, the Install Tool and monitoring systems based on the environment check will not trigger errors for these functions anymore. Since a warning will still be emitted, the fact of a "special configuration" itself will not be lost. Resolves: #91783 Releases: main Change-Id: I50332c53fceda04d003ab0b67bf0a640c5c82866 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65032 Tested-by:
Jochen Roth <rothjochen@gmail.com> Tested-by:
-
- Jun 28, 2024
-
-
Christian Kuhn authored
With DataHandler being DI aware, it's now rather simple to make peripheral classes DI aware. The patch uses new TcaSchemaFactory for TCA information and switches other service dependencies to DI as well. Resolves: #104257 Related: #104002 Related: #104253 Related: #104240 Releases: main Change-Id: I354769cee0925a4c5075cbabf662c123cb247668 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84981 Tested-by:
-
Stefan Bürk authored
The SchemaMigratorTest currently works on a fully populated database, which makes the tests more brittle than they should be. The patch uses a preparation in testing-framework to let TF create a database, but not populate it with tables, which stabilizes the tests. > composer u typo3/testing-framework Resolves: #104256 Releases: main Change-Id: I6699d0e4e831bc72468afd453a83886133e124b2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84942 Reviewed-by:
-
Torben Hansen authored
With symfony property-info 7.1.2, the type resolving for collections has been hardened. https://github.com/symfony/property-info/commit/d0bbc495f11ab99a1e2cbf04699331b88b3c1293 Our extbase ObjectConverter test for collections uses an anonymous class with an ObjectStorage property. The annotation for the property as well as the native property type is however not a FQCN. So the anonymous class has no information about, what FQCN the `ObjectStorage` class is. The change adds the FQCN for the ObjectStorage in the anonymous class, which resolves the failing test, and adds a test with a non-anymous class to test short namespaces still work. Resolves: #104254 Releases: main, 12.4, 11.5 Change-Id: Idc64e2533e0bc6d2dccc9724643247772f4f5d11 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85000 Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
-
Christian Kuhn authored
DataHandler is now DI aware and gets a bunch of services injected. We're not injecting any potentially possible service blindly - we're omitting stateful ones, and declare some common classes readonly along the way to make this more clear. The DataHandler unit test receives a slightly bigger update to deal with this properly. This needs a raise of TF, which had a `new DataHandler()` in one place: > composer u typo3/testing-framework Resolves: #104253 Related: #104245 Related: #104241 Related: #104240 Releases: main Change-Id: Ie1e296b9884d8299ce699ed525fdd2b69d460ebd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84993 Tested-by:
-
Christian Kuhn authored
Resolves: #104249 Releases: main, 12.4 Change-Id: I2e56c967ab27ddc855261ff53f654d5916f3dce6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84997 Reviewed-by:
-
Christian Kuhn authored
filter() retrieves 'DataHandler|DatabaseRecordList $dataHandler' as argument to call $dataHandler->deleteAction on it. DatabaseRecordList and extending classes have no such method. Resolves: #104248 Related: #98479 Releases: main Change-Id: I2fd425c5503a546e6cbf8ed3dae94145e2cb85d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84994 Reviewed-by:
-
Oliver Bartsch authored
Instead of calling the PageDoktypeRegistry in the TcaFactory, the PageDoktypeRegistry does now initialize the TCA for registering the allowed record types for the default doktype on-demand. Resolves: #104234 Releases: main Change-Id: Iefe400fe24e890af8a748d0894aa3f914eec4ad5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84945 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
-
Philipp Kuhlmay authored
This adds an example on how to use a custom icon inside the Infobox Fluid-Viewhelper. Resolves: #104123 Releases: main Change-Id: Ie1fd9f2c13fb426f7c3d3243fe29ebcc8921f046 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84929 Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null tyype to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104247 Releases: main, 12.4, 11.5 Change-Id: I71d8f59eaba6dd22b00f8eb7400f2b49d748e430 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84990 Reviewed-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null tyype to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104246 Releases: main, 12.4, 11.5 Change-Id: Id7713c10014da20bcd4e7976e64434c71d319bda Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84987 Reviewed-by:
-
Oliver Bartsch authored
Resolves: #104244 Releases: main Change-Id: I9619e380bc32f7966ff6804390207312f9e7da3e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84986 Reviewed-by:
-
Christian Kuhn authored
PagePermissionAssembler is a DataHandler related helper that calculates the permission fields of page records. The patch removes pollution of __construct() by manual arguments: $GLOBALS['TYPO3_CONF_VARS'] is runtime static and can just be used when needed. This avoids a class property, making the class stateless. Minor further clean ups, an improved comment, and an @todo that we should consider changing the API. Resolves: #104245 Releases: main Change-Id: I85d125612af02b54627a4c9efd525d4349ce868c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84985 Reviewed-by:
-
Oliver Bartsch authored
This unifies the paths to backend modules below "system", such as "webhooks" or "scheduler". Additionally, the module identifier of the "Backend Log" module is changed to "system_log", matching the usual naming convention. A corresponding module alias is in place and usages are adjusted. Resolves: #104165 Releases: main Change-Id: Idc4f86eb03943e68c3f4c896e42524edffdc7696 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84806 Tested-by:
-
Oliver Bartsch authored
Some FormEngine related JS components, e.g. the slug element rely on input and text fields to have the field name set via either the special `data-formengine-input-name` - if pointing to a hidden input field - or via the standard `name` attribute. All those FormEngine elements support the readonly state, which renders only the field with the `disabled` attribute set by omitting any JS functionality. For this use case no `name` attribute is required. However, to use them in combination with other fields, e.g. as generator field for TCA type slug, the field name is now added as `name` attribute in readonly state. Resolves: #104178 Releases: main, 12.4 Change-Id: Ibd28c563c8184078805a64aa123f86d538077180 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84910 Reviewed-by:
-
Christian Kuhn authored
ReferenceIndexUpdater as established with #92356 is a stateful object designed to "gather" refindex update jobs and perform them in DH "outer most instance". An object like this is not something that should be injectable via DI, but should be hand over at runtime. DataHandler already has a (clumsy) solution to hand over state: method start(). The patch switches from handing ReferenceIndexUpdater over as constructor argument to start() instead. This essentially frees DH::__construct() for DI, which is a great benefit for this class and will be used with further patches. Note DH tends to create 'sub instances'. API calls work on the 'outer most instance' only. The patch is not considered breaking since the API of 'outer most instance' does not change: The additional argument to start() is optional, and used only internally for sub instances. Resolves: #104240 Related: #92356 Releases: main Change-Id: Iffb42eb7582d2d6c1ab1024ffd13dd3347e54e0f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84982 Reviewed-by:
-
Christian Kuhn authored
Get more state in DH periphery right: DataMapProcessor is an `@internal` construct of DataHandler. It has a static instance() method, used once. The patch removes __construct() with it's current arguments to free it towards DI in upcoming patches. State is set explicitly after object instantiation. Note ReferenceIndexUpdater is no longer optional. Resolves: #104241 Related: #104240 Releases: main Change-Id: I6cb2e9ccc86552bf569d3d05ba8ccb703643ab11 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84983 Reviewed-by:
-
Jasmina Ließmann authored
The display of the table in the recycler module has been slightly revised. To improve clarity, the page UID information has been moved to its own table column. The table column for the last edit has been moved to the position in front of the action column. Previously, the two table columns "Record" and "Page Title" took up as much space as their content allowed, which could lead to unwanted horizontal scrolling. This patch sets a maximum width for these fields. The background color of the opened accordion has been changed to make it easier to distinguish between the individual table rows. In addition, its content has been rearranged for better readability. If available, the real name of the backend user is now displayed in addition to the user name. Longer, connected path information could also lead to unwanted horizontal scrolling. This patch inserts word breaks when necessary. Minor label adjustments were also made in the process. Resolves: #104239 Releases: main Change-Id: I5b3bfa0ccadd620532a4a0e0f328657c9c7a4042 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84979 Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null tyype to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104238 Releases: main, 12.4, 11.5 Change-Id: I340f35379b74d1ca05527a6950eab5ba66ffaae6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84976 Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null tyype to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104237 Releases: main, 12.4, 11.5 Change-Id: Ieb8d05b2e44dc448f7a2142c5ad6a91e68cf98c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84973 Tested-by:
-
Oliver Bartsch authored
Also adds the type to the corresponding test. Resolves: #104230 Releases: main, 12.4 Change-Id: Ica9e6b63d5a2fe52cc775642562cf8f9036db081 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84940 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
-
Georg Ringer authored
Provide an additional test to check for correct usage of numeric keys. Resolves: #94852 Releases: main, 12.4 Change-Id: I01c73fb3e1aa0f4d458e9d349484856cb416387d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84980 Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null tyype to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104236 Releases: main, 12.4, 11.5 Change-Id: Iba5e99b526ca37d7bb36044cd6ee1027b6c5245a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84950 Tested-by:
-
Garvin Hicking authored
Currently only `siteLanguage` was documented as usable, now also `site` is explained with the most common public getter methods and an example. Resolves: #99723 Releases: main, 12.4 Change-Id: I8cb6de70b481322c31bd6fa7b3319c74f8af517a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84896 Tested-by:
-
- Jun 27, 2024
-
-
Garvin Hicking authored
The migration wizard BackendGroupsExplicitAllowDeny ('Migrate backend groups "explicit_allowdeny" field to simplified format') returns Symfony formatted error messages for specific single rows. Before this patch, it was still reported as a successful migration, and the success message is formatted with "everything is great" green background, so that errors may not receive attention. This patch changes the wizard to return a failure state. This will then return the messages formatted as errors. Since the wizard migrates all rows (even the faulty ones), the wizard can then be re-executed to be marked as "done". This is not ideal, but because of the way Symfony output streams cannot reveal if they contain an error when the stream is retrieved, there is little other choice. Otherwise the Wizard API would need to receive a breaking API change to allow to carry additional meta information about "warnings" rather than just errors, which is beyond scope for current development state. Resolves: #104208 Related: #104225 Releases: main, 12.4 Change-Id: Ibde1d977bc8747a053da1360aea6c0e3f8b77f7f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84933 Tested-by: -
Georg Ringer authored
Resolves: #104216 Releases: main, 12.4 Change-Id: Ifbd5499fe8c50661cec4ec198b479978bd839084 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84938 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
-
Jasmina Ließmann authored
The "Owner" information in "Recycler" backend module is broken and never shows a valid value. This patch ensures that the correct owner information such as user name and UID is now displayed. Resolves: #104228 Releases: main, 12.4 Change-Id: Ib1ddd570e1bfe2fe86e114e946cb57413a766692 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84937 Reviewed-by:
-
Garvin Hicking authored
The CKEditor YAML files support a lot of configuration options to adjust the Link Browser appearance, adding additional CSS class selection, link-target selection, title attribute and others. The Link Browser configuration is mostly revealed through TCA configuration, but the YAML format was not documented yet. The documentation is updated to reflect all configuration options, and an example YAML file `EXT:rte_ckeditor/Configuration/RTE/Editor/LinkBrowser.yaml` has been added. Resolves: #104157 Resolves: #101711 Releases: main, 12.4 Change-Id: Iffed9f87a35038c01d43947e6e57a0c363cf7c1a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84921 Tested-by:
Lina Wolf <112@linawolf.de> Tested-by:
-
