- Apr 20, 2020
-
-
Georg Ringer authored
This reverts commit 47e63fc3 because of regressions. Resolves: #89989 Reverts: #88344 Releases: master, 9.5 Change-Id: I1f43d0f343484366e81581435bdb418cfebf317a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64151 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Benni Mack authored
This patch prevents throwing and spamming the logs with 500 server errors. Resolves: #91145 Releases: master, 9.5 Change-Id: I9385a9c0a2a665cedb1340cc8397740b0bd6255e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64150 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Xavier Perseguers authored
Resolves: #91130 Related: #82990 Releases: master, 9.5 Change-Id: I8337f8d24fff67ac2c8f05f16de642f46e86cfd5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64148 Tested-by:
Xavier Perseguers <xavier@typo3.org> Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
Josef Glatz authored
This change adds a human readable and meaningful main title for the documentation of ext:rte_ckeditor. Resolves: #91136 Releases: master, 9.5 Change-Id: I01804d2d4c700af6c2a72d74596cf20b04505eb8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64147 Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
-
- Apr 19, 2020
-
-
Tymoteusz Motylewski authored
Do not calculate permissions for every page, as we're limiting the pages through SQL query constraints. Fetch sys_language_uid and l10n_parent from db as they are required for isInWebMount to prevent it from fetching row from db again. Pass full row to isInWebMount in calcPerms instead of just uid. isInWebMount has logic to handle translated records. Resolves: #91037 Related: #90105 Releases: 9.5, master Change-Id: I56dbaf3daa15aa8b6f0fc5e09b212aa34203a0b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64141 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
-
Josef Glatz authored
This patch takes the changes of the new documentation theme into account. Releases: master, 9.5 Resolves: #91102 Change-Id: I3308819227dc4a66f0571e4b5afdc49939f19026 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64145 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
- Apr 17, 2020
-
-
Helmut Hummel authored
All commands that are added via Configuration/Commands.php are instantiated and prepared when the "scheduler:run" command is executed. This preparation includes setting the Application object. If this Application object is present in an Command object, calling the run method of the command will cause a merge of the application's arguments with command arguments. Since command objects in symfony/console and TYPO3 are more or less singletons, these merged arguments will stay merged on a second "instantiation" of the command through when scheduler executes the second task with the same command. Therefore we must SKIP the validation of the new Input object we create and pass to the command's run method, so that this validation does not fail due to the missing command argument. It also does not matter that we skip validation, because validation happens implicitly when calling the run method on the command object. Only Symfony code is "smart" enough to set the command argument, when it was not present before. Resolves: #87312 Releases: master,9.5 Change-Id: I75677493216961fd7559a923e94e7831e07921bf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64143 Tested-by:
Richard Haeser <richard@maxserv.com> Reviewed-by:
-
- Apr 16, 2020
-
-
Patrick Broens authored
When having a multisite setup using the same slugs pointing to the same or other different mounted pages, the PageSlugCandidateProvider will always fetch the information of the first page found in the database which complies with the slug. In some cases this will be the right page, but in other cases will be a page which is not part of the requested website. In the last case this will result in a 404. This patch fixes this by checking if the slug is from the site being called. Resolves: #90469 Releases: master, 9.5 Change-Id: I333bfdfeb37ffa13b86697c4597cbda6e315b590 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64057 Tested-by:
Patrick Broens <patrick@patrickbroens.nl> Tested-by:
-
Markus Klein authored
Fix the condition whether a page is linkable in the requested language or not. Resolves: #90850 Releases: master, 9.5, 8.7 Change-Id: I720c09cc1f938b5000980bcba20786a5cf41f98d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64058 Tested-by:
Christian Eßl <indy.essl@gmail.com> Reviewed-by:
-
Josef Glatz authored
The icon path of an extension is only returned if the icon can be found. This prevents the JavaScript from rendering a broken extension icon. Resolves: #91038 Releases: master, 9.5 Change-Id: Ic0a4fb874215408c1781b3acb29e9ec4769150fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64140 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
- Apr 15, 2020
-
-
Oliver Hader authored
See https://review.typo3.org/c/Packages/TYPO3.CMS/+/43870/ + typo3/sysext/beuser/Resources/Private/Layouts/Default.html + module import was accidentally removed in #70360 Resolves: #91046 Releases: master, 9.5 Change-Id: I04e0be82c4f16b84b951a157c5618722cdf7577f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64185 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Benni Mack authored
The third-party library algo26-matthias/idna-convert is not compatible with PHP 7.4 (used for providing IDNA conversions for umlaut domains). The classes from v1 are copied in order to have them still available, but we maintain the code ourselves and reduce the usage to a minimum. composer remove "algo26-matthias/idna-convert:" See https://idnaconv.net/docs.html for detailed upgrade changes. Resolves: #90911 Releases: 9.5 Change-Id: I7ac14348677b8b60f92cb8bfa26e26d16a01abee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64011 Tested-by:
Manuel Selbach <manuel_selbach@yahoo.de> Tested-by:
Frank Nägler <frank.naegler@typo3.org> Reviewed-by:
-
Ronald Kools authored
In order to prevent Doctrine\Common\Annotations\AnnotationException s o TYPO3, the unneeded comments in GeneralUtility are adapted. Releases: 9.5 Resolves: #91034 Relates: #88986 Change-Id: I05cc36cf98e01492ff57f77f863fb79777206487 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64170 Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
-
Oliver Hader authored
Files that just have been deleted in filelist module need to be removed from current clipboard state - otherwise the rendering process will throw ResourceDoesNotExistException due to obviously missing files. Resolves: #91039 Releases: master, 9.5 Change-Id: Ic03cd8775ee4db40996e1152f4f0b1660323780f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64178 Tested-by:
-
Tymoteusz Motylewski authored
Add test for TreeController, so we're safe when refactoring or doing performance optimizations. Besides that moved pages in a workspace were not considered when calculating permissions on the rootline due to missing workspace overlays. Resolves: #90831 Releases: 9.5, master Change-Id: Ic3ab08d2502e8c9a3f08e737552c2e1d2a56a66c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64107 Tested-by:
-
- Apr 14, 2020
-
-
Oliver Klee authored
For images that cannot be loaded (e.g., when the extension is outside the document root), the extension name will be printed twice, which looks ugly and also breaks the layout. As the extension icon is purely decorative, the alt attribute should be an empty string. Resolves: #91031 Releases: master, 9.5 Change-Id: I71be7978cc3245f127d864586dd5d54c1a6aae10 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64168 Tested-by:
-
Tymoteusz Motylewski authored
The old TS Conditions syntax with two blocks combined with && is deprecated so it should not be used as an example in the changelog. It was deprecated in: https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/9.5/Deprecation-86068-OldConditionSyntax.html Releases: master, 9.5 Resolves: #91017 Change-Id: I60d2fc7c26d8a72f75c82355d4c0d64cf27827c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64139 Tested-by:
-
Manuel Selbach authored
With this change all field will be cast to a datatype, that is searchable with `like` to prevent errors. Before that change e.g. for table `sys_file_reference` the field `uid_local` is configured as label field. The query that is built, will then try to do a like search on that field, which breaks on certain DBMS. Resolves: #81802 Resolves: #82837 Releases: master, 9.5 Change-Id: I65cc11e6c6388919a34b45a8738d8e1c64881983 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63885 Tested-by:
-
- Apr 13, 2020
-
-
Timo Poppinga authored
Add the HTTP methods 'PURGE' and 'BAN' to $supportedMethods, to support clear cache requests for proxy caches like varnish. Resolves: #90968 Releases: master, 9.5 Change-Id: I2d4737319d23b362af689eadd21b6c3134a894e4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64138 Tested-by:
-
Benni Mack authored
The link to the extension file scanner is removed to avoid any exception when running a scan if no extension is available at all. Visually, it's grayed out like the disabled "Update TYPO3 Core" card in composer mode and the link is removed. Releases: master, 9.5 Resolves: #90981 Change-Id: I53d41111b51ed74d142894c56a4378fc9d958e8d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64135 Tested-by:
-
- Apr 12, 2020
-
-
Andreas Fernandez authored
Navigating in the RteLinkBrowser by e.g. switching tabs or browsing the file tree now recovers the selections of the underlying ckeditor. This allows to invoke a browser search, navigate within the link browser and place a link afterwards. Resolves: #91006 Related: #90952 Releases: master, 9.5 Change-Id: If2d943f0b2a8b86babead8c1397d6222b0c0da7d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64122 Tested-by:
-
Christian Eßl authored
When copying a tt_content record in list module, the DataHandler would internally look up the 'copyAfterDuplFields' settings in TCA and ensure, that those fields are copied from its new neighboring record. In TYPO3 core, the 'copyAfterDuplFields' settings are only used by the table tt_content with 'colPos,sys_language_uid' as its values. This makes sense for copying records, but the same behaviour, that stems from TYPO3s very early days, was also used when records where moved around with the DataHandler. When an editor changes the position of a tt_content record in the list module, the record would then always automatically adopt the colPos/sys_language_uid of its new neighbour, which is usually not expected or desired, and often leads to much confusion and broken content grids. The code responsible for 'copyAfterDuplFields' is now removed from DataHandler::moveRecord_raw(), while retaining the behaviour for DataHandler::copyRecord(). Moving around tt_content records in the page module to different columns or languages is not affected by this change, as the colPos/sys_language_uid changes there are set in a separate update statement. Resolves: #72988 Resolves: #59901 Resolves: #39798 Resolves: #25216 Resolves: #14873 Releases: master, 9.5 Change-Id: Ic9c57fe2712b0996bc7b53cce4bcdc275c2820cb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64137 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Anja Leichsenring authored
The test have been disabled due to flakiness, let's give them another chance to prove themselves valuable. Resolves: #79730 Releases: master, 9.5 Change-Id: I8f0f64971438effb4b8baa62819d44c2920742de Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64136 Tested-by:
-
- Apr 11, 2020
-
-
Tobi Kretschmann authored
Using mm tables, the value that is stored in the database does not represent the uid of the selected item. Much rather it is the amount of selected items. If three items are selected the value within the database field is "3". Whereas using multiple select without mm table, it is stored as a comma-separated list of uids. Releases: master, 9.5 Resolves: #90925 Change-Id: I110cbf0fd19fab1135958c445a846a1af9c24510 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64134 Tested-by:
-
- Apr 10, 2020
-
-
Georg Ringer authored
The message of the exception introduced with #89857 needs some improvements. Resolves: #90996 Releases: master, 9.5 Change-Id: If0bc77ac8bcdab44a6468dc7bd1eb3543673e7a8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64133 Tested-by:
-
Volker Diels-Grabsch authored
This commit fixes a string-with-boolean comparison in a switch case. Instead, this complex case is moved down to the default case where all other complex cases are handled as well. Resolves: #90992 Related: #89857 Related: #72053 Releases: master, 9.5 Change-Id: I43730176e1a46a2bc63ea4d45bcf4511c1970aab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64132 Tested-by:
-
- Apr 08, 2020
-
-
Christian Eßl authored
Resolves: #90976 Releases: master, 9.5 Change-Id: I3827e0796f7dc016b3095b5e8917905b85523712 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63991 Tested-by:
-
Andreas Fernandez authored
This patch updates the Docker configuration to use mssql 2019 as mssql 2017 images don't get updates anymore. Additionally to the mssql update, the shuffled chunking to 50 jobs is reverted as it didn't bring any benefit but even more hassle as the stages failed earlier and more often. Instead, the jobs are now grouped by PHP version which allows smaller chunks and reduced the probability to clog the build queue. To workaround errors thrown by Gerrit on heavy load, the cherry-pick command is now executed up to five times, with a short sleep between each execution. Last but not least we check whether there is actually a dangling Docker container instead of hard killing non-existent containers which pollutes our log. Resolves: #90965 Releases: master, 9.5 Change-Id: Ied60297127b86c3375d310759bf441ad9e10aeed Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63990 Tested-by:
-
- Apr 07, 2020
-
-
Benni Mack authored
In order to reduce the amount of data fetched, the PageTree loaded for editors will only fetch pages that the editor actually sees, reducing the actual amount of pages to fetch. If a pagetree has 80.000 pages, but the editor can only see 50, the tree only loads these 50 pages. Resolves: #90880 Releases: master, 9.5 Change-Id: I57985484ace07fbfb919573351c210b291697ae3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63983 Tested-by:
-
Patrick Broens authored
When a logged in backend user is entering the history/undo functionality for a certain page, which contains a deleted one, the backend user authentication will throw an error. This is due to the fact the pid field is not taken into account when fetching the pages to check if they are deleted. This pid field will be used to calculate the page access, but is now done with the value null. This patch will add the pid field when fetching the subpages which will be checked if they are deleted. Resolves: #90963 Releases: master, 9.5 Change-Id: I1b78d4a71fea35b5d55a1d8989e586f01e7d9280 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63989 Tested-by:
-
Josef Glatz authored
Add related links for each upgrade documentation file at the end: - link to forge issue - link to rendered rST document This makes it possible to - read the documentation as rendered html with on click - easily share an upgrade document with others - open the related forge issue Resolves: #90923 Releases: master, 9.5 Change-Id: Iedf874e31b7026a55275d6073d645e875dab1b6c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63988 Tested-by:
-
- Apr 06, 2020
-
-
Markus Klein authored
If the pageIdSelector feature is enabled for the RTE the entered page UID needs to be formatted with correct link syntax. Resolves: #82942 Releases: master, 9.5 Change-Id: I93bc583ba279d0bde549582388791fc48150d933 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63987 Tested-by:
-
Markus Klein authored
TCEMAIN.linkHandler.page.configuration.pageIdSelector.enabled = 1 This configuration is adhered again and the pageIdSelector shows up. Resolves: #83056 Releases: master, 9.5 Change-Id: I1e03bfa180601a46c85e3c3b92ba9c7e980a4b8b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63986 Tested-by:
-
- Apr 05, 2020
-
-
Andreas Fernandez authored
When the RteLinkBrowser is opened, any active ranges are now backed up and reused later when an element gets linked. This fixes clashes with the browser's internal search feature that overrides the `Selection` object. Resolves: #90952 Releases: master, 9.5 Change-Id: I155157e808370cd5ff05076a6c82f09da3b0cb3c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63985 Tested-by:
-
Anja Leichsenring authored
The accessibleMockForAbstractClasses is a discouraged concept anyways, and in this case the constructor definition in the interface caused a test failure. Moving the tests to concrete classes solves the failure and also gets rid of the abstract class mock. Resolves: #90942 Releases: master, 9.5 Change-Id: I902cabd3290761c1525b128eb18822199f337cb5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64079 Tested-by:
-
- Apr 04, 2020
-
-
Georg Ringer authored
The Install Tool module "Manage Language Packs" is improved by the following changes: * If all language packs of an extension are available, the download icon is still shown to make downloads of a single language pack per extension possible. * The icon itself changed from refresh to download as there is no refresh possible. There is no lock on a specific date or version to reload language packs. Every download can contain new or changed translations. Resolves: #86535 Releases: master, 9.5 Change-Id: I130c169b933b6e4b13c533928a46984bcb93979e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63982 Tested-by:
-
Andreas Fernandez authored
The patch for #88720 added a new entry in MethodArgumentRequiredMatcher to cover changes in the class AspectFactory. The entry misses the affected method name which broke the extension scanner. This patch declares the missing affected method. Resolves: #90950 Related: #88720 Releases: master, 9.5 Change-Id: Id7df9b3f75eef0bb67781d0b67e68dad330da495 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63984 Tested-by:
-
- Apr 02, 2020
-
-
Markus Klein authored
Resolves: #90905 Releases: master, 9.5, 8.7 Change-Id: Idfd98f3bb97484769cc15786c8fbe5f53cd4908c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63980 Tested-by:
-
Oliver Hader authored
When a slug is unique in site, we need to check whether the slug found in the database is part of the current site, otherwise it must be discarded. Resolves: #88720 Releases: master, 9.5 Change-Id: I469d7b853f75eec09463bb809b795c4732753cff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61586 Tested-by:
-
Benni Mack authored
Ensure that extension developers know where to look when accessing an inaccessible action from a backend module. Resolves: #88185 Releases: master, 9.5 Change-Id: I054a93b4162f5b3f2e1dafaf100ed3f9846e4df9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63979 Tested-by:
-
