- Apr 14, 2019
-
-
Alexander Schnitzler authored
This patch removes support for the configuration of persistence related classes via typoscript. This is done as typoscript is too variable, i.e. the configuration may change depending on the day, the hour and whatever possibility typoscript has when it comes to conditions. The functionality must not vanish completely, but the configuration should be immutable and predictable at an early stage of the runtime. To achieve this, the configuration has to be added to files like EXT:Configuration/Extbase/Persistence/Classes.php This patch is considered breaking as the configuration via typoscript stops working immediately and the configuration syntax slightly changed. The easiest way to migrate to the new syntax is to have a look at configuration files in core extensions. Releases: master Resolves: #87623 Change-Id: Id1ceceafd10ec647507bca8078ebf62fe1b02d2a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59570 Tested-by: TYPO3com <norepl...
-
Benni Mack authored
There is a copy/paste typo in LocalCropScaleMaskHelper, which was introduced in TYPO3 v8. The setting $TYPO3_CONF_VARS[GFX][processor_stripColorProfileCommand] is the correct one. Resolves: #87548 Releases: master, 9.5 Change-Id: I4f9e4f3f62e1b577a986c96a31d4438da1bc7f74 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60465 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
Benni Mack authored
As part of using the SiteBased translation model instead of the legacy TypoScript settings, another test suite is added which mimics the exact same settings and results as in TypoScript for Extbase. Resolves: #88142 Releases: master, 9.5 Change-Id: Ieaa2e0d6cb510e6e00555e848020d89e8e1f5670 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60461 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- Apr 13, 2019
-
-
Andreas Fernandez authored
This patch migrates FormEngine's SelectElementTree to TypeScript. Also, a terrible hack that puts the local tree initialitation callback into global scope has been removed. Resolves: #87987 Releases: master Change-Id: Ib34ae7fe4ac1e197af2183b8890cc72e13a900e9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60316 Tested-by:
Steffen Frese <steffenf14@gmail.com> Tested-by:
Frank Naegler <frank.naegler@typo3.org> Reviewed-by:
-
- Apr 12, 2019
-
-
Julian Wundrak authored
If there are e.g., records that have no translation, the HrefLangGenerator outputs the site-base URL. Expected is that the entry for this page is suppressed. Change-Id: I6fbd4dd00955906dff13c0e5aceea6804c52dd1b Resolves: #88032 Releases: master, 9.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60350 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Richard Haeser <richard@maxserv.com> Reviewed-by:
-
Benni Mack authored
If page.includeCSS.myfile.import = 1 is used, but no "media" is set, a TypeError is thrown, which is now caught and properly checked. Resolves: #88059 Releases: master, 9.5 Change-Id: I0951688bb9ee779329ebe5c7fad698862d73f6c3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60420 Tested-by:
Julian Geils <j_geils@web.de> Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Benni Mack authored
This "feature" solves a lot of issues, but I really wanted to make sure to cover the generic issues around this topic. In order to understand this, we need to understand the different logic when talking about "language fallbacks", but I don't want to warm up how it was before. This is how it works: - fallbackChain: defines which page translation should be checked when linking or resolving a page in a specific language - fallbackType: Now that we covered all relevant cases, the naming could be better, but here we go, it's actually defining the logic for fetching content. - fallbackType="strict" -> only show the content that is viable in the target language but this is based on "overlays". Fetch all "language=0" records, do overlays and remove the ones that have no overlays. However, take the ones that have no language parent and render them as well ("includeWithoutDefaultTranlsation") This is what we call "do overlays with floating". This is recommended to do in most classic translation cases, with different languages - fallbackType="fallback" -> Do overlays: Fetch all "language=0" records, do overlays but KEEP the ones that have no overlays. However, take the ones that have no language parent and render them as well ("includeWithoutDefaultTranlsation") This is what we call "do overlays in mixed mode". Useful if your translation is Swiss-German but your default language is "German" - fallbackType="free" - Do not do overlays, just fetch all records of the target language Could be seen as "free mode" as we do it in TYPO3 Page module. The new free option is therefore new, also the "fallback" functionality is actually showing more content than before (thus, different, but maybe we could fix that!) as we have the "mixed" mode back. Also the "language fallback" is now possible for any fallbackType. Now, what's still missing - but out of scope - is actually a way to fetch content with multiple possibilities for overlaying. I call this "forward language overlays" however, this is a feature that is theoretically possible but not in v9 anymore. This patch restores the max. types of use cases back for TYPO3 Core. The following things that are really gone for good now and won't come back: - config.sys_language_mode = ignore - config.sys_language_mode = - Option includeRecordsWithoutDefaultTranslation (= always enabled) is not needed anymore Also, there are no ways anymore to use inconsistent multiple TypoScript settings which do not make sense depending if the translated page does not exist (l18n_cfg) but still using TypoScript conditions for that. Resolves: #86762 Resolves: #86712 Releases: master, 9.5 Change-Id: I8b3144410f7d7ed1d705d42f16a46f190275387a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60367 Tested-by:Nikolaj Wojtkowiak-Pfänder <nwp@dr-bock.com> Tested-by: Steven Hilgendorff Tested-by:
Ralf Merz <mail@merzilla.de> Tested-by:
-
Benni Mack authored
In order to see the current behaviour in workspaces when modifying pages, the slug field is added to the existing "Regular" DataHandler tests within workspaces. Resolves: #87904 Releases: master, 9.5 Change-Id: Ie2432fb078f2b04515a24de7b525b1c151186b05 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60242 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Frank Naegler authored
Resolves: #88040 Releases: master Change-Id: I5408c30fef735fe52a4b58bda3fb5b4d3b8e002e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60353 Tested-by:
-
Frank Naegler authored
Resolves: #87915 Releases: master Change-Id: I4a7fa727c47b85bfae728f0a1dab0e6e833063ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60250 Tested-by:
-
Frank Naegler authored
Resolves: #88038 Releases: master Change-Id: I0441df6756bb4950b7875c74eed0e5bfff7625a7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60352 Tested-by:
-
Benni Mack authored
The existing TypoScript functionality config.cache.all = ... allows a list of tables and PIDs to take into account other records for the current page caches. The cache lifetime of page 42 takes starttime and endtime of news records of page 15 and addresses of page 16 into account: config.cache.42 = tt_news:15,tt_address:16 A new functionality used with "current" allows to take records of the current page into account as well. config.cache.all = fe_users:current Resolves: #83734 Releases: master Change-Id: Ib2063cc89e2c1549b7609b77948243e983d14c1b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60419 Tested-by:
Fabien Udriot <fudriot@omic.ch> Reviewed-by:
-
Benni Mack authored
<f:form.select.option> uses the FQDN::class syntax, so late static binding (LSB) is leading to side effects when extending <f:form.select>. Using the self::class syntax in <f:form.select> solves the issue. Resolves: #88017 Releases: master, 9.5 Change-Id: Ic060267cdff06856d1aa0f76980124ecfc0967a5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60436 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- Apr 11, 2019
-
-
Helmut Hummel authored
The cli binary path is changed to be located in TYPO3_PATH_WEB instead of TYPO3_PATH_ROOT. Releases: 9.5, master Resolves: #88088 Change-Id: I96587254d121149b58f35b0abb0084a89a31b0c7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60371 Tested-by:
-
- Apr 10, 2019
-
-
Benni Mack authored
When building JOINs with TypoScript of tt_content or any localized table, using "LEFTJOIN tt_content table2" the language restriction check is not using a prefix for the "l10n_parent" field. The "sys_language_uid" field already has the same prefix built in the same method. This error existed in v8 already, but in TYPO3 v9, the "includeRecordsWithoutDefaultTranslation" option is enabled by default (via LanguageAspect), therefore it's more prominent. Resolves: #87521 Releases: master, 9.5 Change-Id: I1a3ee4f1f84d64a5d56cf63607a7aed83fdd13fc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60430 Tested-by:
-
Stefan Frömken authored
Releases: master Resolves: #88117 Change-Id: I5fa5da8f6697a74eda785c4655203f9d63c7b632 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60424 Tested-by:
-
Benni Mack authored
Although the documentation and the internal code allows File and FileReference, the functionality requires a FileReference. FileInterface is more appropriate and $cObj->imageLinkWrap() can deal with File and FileReference. Resolves: #82101 Releases: master, 9.5 Change-Id: I37e4f091fe0598509eef050cb811ad7627f16c21 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60435 Tested-by:
-
Jan Stockfisch authored
Move all TypoScript and TSconfig from ext_localconf into separate files. Resolves: #88105 Releases: master Change-Id: I4b04352942f9ecc603c05072ec674340a7d73c25 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60414 Tested-by:
Henning Liebe <h.liebe@neusta.de> Tested-by:
-
Jonas Schwabe authored
The value of indexedDocTitle was not updated when a title had been generated by the PageTitle API. This simply writes the generated page title to indexedDocTitle so that it can be used in the indexed hook. Resolves: #88041 Releases: master, 9.5 Change-Id: I8ac1fd8295447aafa7e175fb09fa11f565442019 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60354 Reviewed-by:
-
Benni Mack authored
When e.g. a corrupt Database Connection is available (MySQL down) and no connection is established, the Runtime Exception should be caught as well. In addition, the $message is more generic to avoid any additional output for the end-users. Resolves: #87993 Releases: master, 9.5 Change-Id: I2495426930d3fab841ff1632d778a945e73b521d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60421 Tested-by:
-
Thorsten Griebenow authored
Releases: master, 9.5, 8.7 Resolves: #88115 Change-Id: Ia1ab566ef3ebeff69a680b750b8e2ab4e8c9aba6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60423 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Ralf Zimmermann <ralf.zimmermann@tritum.de> Reviewed-by:
-
- Apr 09, 2019
-
-
Daniel Gohlke authored
Use array_merge instead of union (+=) in order to correctly handle overriding the menu configuration of the LanguageMenuProcessor. Resolves: #88123 Releases: master, 9.5 Change-Id: I1f382c11b2f24c052b97af2b7d62a6e0712e10e9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60432 Tested-by:
-
- Apr 08, 2019
-
-
Koen Wouters authored
Dropdown fields will now stay next to each other for responsive views. Resolves: #88065 Releases: master, 9.5 Change-Id: I1990dc87dd69fd6c5470197277dc86c84f6c29de Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60368 Tested-by:
André Schließer <andy.schliesser@gmail.com> Tested-by:
-
Frank Naegler authored
Resolves: #87920 Releases: master Change-Id: Ibb3d28e85b6beddfd4bacca8303cca51c46ac6b3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60255 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
Jan Helke authored
This regression fix reenables the setting mod.web_list.hideTranslations to enable administrators to hide translations in the list view. This behaviour is already described under https://docs.typo3.org/typo3cms/TSconfigReference/PageTsconfig/Mod.html Resolves: #88084 Releases: master, 9.5 Change-Id: I8bc0ce072a44c78564889325c888eb26fdb23a1c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60372 Tested-by:
Sebastian Rosskopf <sebastian.rosskopf@gmx.de> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Raphael Thanner <r.thanner@zeroseven.de> Tested-by:
-
- Apr 05, 2019
-
-
Andreas Fernandez authored
TypeScript: Due to issues with upcoming TypeScript versions, the TypeScript sources are moved into the Build directory before building JavaScript. The unused Grunt task `tsdev` has been removed. Additionally, some type defintions have been installed: yarn add --dev \ @types/bootstrap-slider \ @types/datatables.net \ @types/chosen-js Sass: The Sass sources have been moved into the common "Sources" directory. Those source files are moved to have a less cluttered Build directory. Note: With this patch, all TypeScript files must be placed into `Build/Sources/TypeScript` to be compiled by tsc again. Resolves: #88043 Releases: master Change-Id: I4d3e5f69564c38a35bf083652ea7262f5b85e4f3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60335 Tested-by: -
Andreas Fernandez authored
This commit fixes a usage of the null coalesce operator within a condition. Resolves: #88092 Related: #84375 Releases: master, 9.5 Change-Id: Ic34fb492e66eb224d0e617405e8ae2be69a16aa4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60400 Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Reviewed-by:
-
Benni Mack authored
Although not used in TYPO3 Core directly, the identify command by ImageMagick now delivers the file extension from IM plus the file type identified by IM as well. This saves some regexp magic, and a foreach() loop, as the "-format" output delivers proper IM results. As this functionality is not actually fixing a core bug, but rather a small improvement and correction in the identified usage, the change is targeted to master-only. Resolves: #23348 Releases: master Change-Id: Ia380ee34dbbef7f9f763ecc088ee0c9b83167ce6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60311 Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
Henrik Elsner authored
Exception is thrown when changing the operator from an array handling one to a string handling. ("is in list" to "equals") Also the selection is not set properly after changing. Resolves: #88010 Releases: master, 9.5 Change-Id: Ibf7f607a51ac92d2c45dbfe16384f71c959e6c1f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60342 Tested-by: -
Markus Klein authored
Resolves: #88091 Releases: master, 9.5 Change-Id: I3261190c1214dece4dce5d208a54af2b14b3aa0e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60399 Tested-by:
-
Georg Ringer authored
The SiteFinder must be used instead of only fetching all languages from sys_language. Resolves: #87999 Releases: master, 9.5 Change-Id: I95432c6221a8ee06d1fbb45a6780b0ec7c80ddf4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60337 Tested-by:
-
Christoph Lehmann authored
Currently there is no way to determine the error level of a previously registered error handler. The commit helps chaining error handlers and prevents unnecessary extra work. Resolves: #87281 Releases: master, 9.5 Change-Id: Ib6cc32eeb4714cae1dd16aa5382683c374615d38 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59287 Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
Georg Ringer authored
EXT:viewpage must use the SiteMatcher to get the available languages. The join functionality has been removed as well to let users view a page in a fallback language. Resolves: #88001 Releaes: master, 9.5 Change-Id: Ibd0be7b2d169a7e8fb029905e3221fdd3ee5d69c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60338 Tested-by:
-
Guido Schmechel authored
With this change, there are no more restrictions in TCA within the be_groups. Resolves: #87967 Releases: master, 9.5 Change-Id: Ifc1cf2b41c15c43dd5a1e314c0cb0a418753455a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60301 Tested-by:
-
Kevin Meckl authored
Correct example TYPO3_CONF_VARS configuration for custom route enhancers registration. Releases: master, 9.5 Resolves: #88067 Change-Id: I0870498781f496d9c00331af126b96fd77eee70d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60369 Tested-by:
-
Chau kar authored
Removed the absolute positioning of the error page to avoid unexpected behavior when rendered in an encapsulated component, e.g. panels in the Install Tool. Resolves: #88064 Resolves: #87382 Releases: master, 9.5 Change-Id: I5cefeacc0f753ab57c8c1e95dffa39eb55f5950e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60377 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Helmut Hummel authored
Instead of hard coding the path, the ConfigurationManager API ist now used. Resolves: #88089 Releases: master, 9.5 Change-Id: I51b6c75583e54f00535538d6afdcb617d86f6079 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60374 Tested-by:
Wolf-Peter Utz <wpu@hotmail.de> Tested-by:
Xavier Perseguers <xavier@typo3.org> Reviewed-by:
-
Manuel Selbach authored
The property lastModifiedDate was remove by some browsers, thus with this change if will be checked and the proper property is used to parse the timestamp in the replace dialog. Resolves: #88081 Releases: master, 9.5, 8.7 Change-Id: I4ae812267ef81c4db5c86d2d6dd814f83bebeb00 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60373 Tested-by:
Felix Herrmann <herrmann@riconet.de> Tested-by:
-
- Apr 03, 2019
-
-
Markus Klein authored
The fifth parameter to Datahandler::insertDB() is used in one place without properly checking for the existence of the array element. In general this parameter is only used for imp/exp extension and works for admins only. Resolves: #88025 Releases: master, 9.5 Change-Id: Iba5656857b1b16fb601a3c6af424a6477edc6956 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60348 Tested-by:
-
Benni Mack authored
Some test functionality regarding Site Handling is now sorted out in order to add more tests. - SiteConfiguration setup for tests is moved into a separate Trait. - Code which is also used (in the future) for EXT:core and not just frontend is moved to EXT:core - LocalizedFrontendPages now have a slug field as well. - Regular Frontend JsonRenderer now also renders values from SiteLanguage config + context aspect Resolves: #88060 Releases: master, 9.5 Change-Id: If859da89e4fcec16e3d1c2abb934eef040d4f386 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60363 Tested-by:
-
