- Jul 25, 2014
-
-
Sascha Egerer authored
Currently the importer expects that an imported t3d file contains data for fal. This is not the case if the t3d file comes from a TYPO3 4.5 installation. As a result a fatal error is caused because fread is called with a length of 0. Resolves: #60540 Releases: 6.3, 6.2 Change-Id: Ib112200c2b6cba0252440cd370d57a6ccd048bf2 Reviewed-on: http://review.typo3.org/31767 Reviewed-by:
Susanne Moog <typo3@susannemoog.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Steffen Müller authored
The interface \TYPO3\CMS\Core\Log\LogManagerInterface enables you to ship an alternative 3rd party LogManager instance. Having dependency injection in place, you could replace the core Logger without touching a single line of code. Releases: 6.3 Resolves: #60551 Change-Id: I2bf125f93599dee9a08e6c6b6fa7c369a7680d8d Reviewed-on: http://review.typo3.org/31791 Reviewed-by:
Sascha Egerer <sascha@sascha-egerer.de> Tested-by:
-
Sascha Egerer authored
A wrapper function for GeneralUtility::getIndpEnv() is required to mock these static calls in unit tests. Resolves: #60549 Releases: 6.3, 6.2 Change-Id: I47b565f5a5bd9b2445847d38447c01cfa20954c7 Reviewed-on: http://review.typo3.org/31788 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Markus Klein <klein.t3@reelworx.at> Tested-by:
-
- Jul 24, 2014
-
-
Peter Niederlag authored
Function isPackagKeyValid on PackageManeger is not a static function and must be called on an object instance. Resolves: #59619 Releases: 6.3, 6.2 Change-Id: I03b068db00ccdf76b6e8658721e630b7de6ebfd8 Reviewed-on: http://review.typo3.org/31749 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Peter Niederlag authored
Function isOnSymmetricSide of RelationHandler is used as static function all the time so we properly turn the function declaration into a static one. Resolves: #60516 Releases: 6.3, 6.2 Change-Id: I72a922596e69dca26e173dad5b42da76e0949865 Reviewed-on: http://review.typo3.org/31748 Reviewed-by:
-
Markus Klein authored
Introduce a sort operation of the packages before determining the loading order. This way the number of changes made to the PackageStates.php file are reduced. This is only a first step, further improvements have to be made to finally resolve #56362. Resolves: #56362 Releases: 6.3, 6.2 Change-Id: Id6cc4cc2d3f4d9f00e90f355bdede1afe20f57af Reviewed-on: http://review.typo3.org/27932 Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Reviewed-by:
-
Markus Klein authored
Currently the title of the "Edit metadata" link in filelist is hardcoded. Add a label to make it translatable. Resolves: #60410 Releases: 6.3, 6.2 Change-Id: Id618dfcd96ae3b4558cf9d529e0cc7c3ae220f9a Reviewed-on: http://review.typo3.org/31696 Reviewed-by:
Helmut Hummel <helmut.hummel@typo3.org> Reviewed-by:
-
Tymoteusz Motylewski authored
in t3skin/icons/ext there are plenty of really old icons for e.g. tt_guest or tt_calender We should remove them as they are not used. Resolves: #59792 Releases: 6.3 Change-Id: I8d6a91e2a1c1aa6da04ee2da961c2f6c919de2c3 Reviewed-on: http://review.typo3.org/31040 Reviewed-by:
-
Christian Kuhn authored
Utility/File/ExtendedFileUtilityTest.php contains some old FAL related tests that are not maintained for quite some time, broken and skipped. Functional tests for FAL should be re-written if needed from scratch so these tests are removed for now. Resolves: #60541 Releases: 6.3, 6.2 Change-Id: Ib703f5c4bbd5d52ef5c67f0fc2f2387772c315fd Reviewed-on: http://review.typo3.org/31768 Reviewed-by:
-
Benjamin Mack authored
Several browser hacks in backend CSS files can now be removed as browser don't need to use -moz or -webkit. Also, several filter and IE7 star hacks can be removed. Resolves: #60526 Releases: 6.3 Change-Id: I45aa45a51abe5ab0a6986f1bf0bfd324a23ccd12 Reviewed-on: http://review.typo3.org/31759 Reviewed-by:
-
Benjamin Mack authored
There are some places where there is special treatment for IE7 and below which can now be removed safely. Resolves: #60528 Releases: 6.3 Change-Id: Ic942a499d1663672a6ac80966621010705e755be Reviewed-on: http://review.typo3.org/31761 Reviewed-by:
-
Eric Chavaillaz authored
Resolves: #59812 Releases: 6.3, 6.2 Change-Id: I3ccfbdd496af2fca9a72d2675393537eafffd075 Reviewed-on: http://review.typo3.org/31083 Reviewed-by:
-
Anja Leichsenring authored
Change #60506 introduced a new specific exception in case a file reference can not be resolved. This new exception now needs to be catched on the right places. Change-Id: I545f4eb98386918903380cc3d0b34796a0917b3f Resolves: #60529 Relates: #60506 Releases: 6.3, 6.2 Reviewed-on: http://review.typo3.org/31762 Reviewed-by:
-
Helmut Hummel authored
When rendering the FILES content object, exceptions due to missing file references and missing collections are meant to be caught. However they are not, because InvalidArgumentException and RuntimeException are thrown instead of ResourceDoesNotExistException Throw the appropriate exceptions instead and also fix a wrong check in RecordCollection Repository, where the return type is checked against NULL while the DB call returns FALSE when no record is found. Resolves: #60506 Releases: 6.2, 6.3 Change-Id: I9cea492d814850f75549d280c2de0defc8b91548 Reviewed-on: http://review.typo3.org/31743 Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
Gernot Schulmeister authored
Although permalogin is enabled we set a session cookie. This happens because setSessionCookie is called too early and we do not know yet whether the session should be permanent and an according cookie shall be set or not. Solution is to set $this->dontSetCookie = FALSE which triggers setting the cookie at an appropriate time. Resolves: #60264 Releases: 6.3, 6.2 Change-Id: Iad5ce8597f90c4a607a43ea4d3368d117fa6b4ed Reviewed-on: http://review.typo3.org/31607 Reviewed-by:
Pierrick Caillon <pierrick.caillon@plan-net.fr> Reviewed-by:
Alexander Opitz <opitz.alexander@googlemail.com> Tested-by:
Jan Schreier <jan-hendrik.schreier@bits-iserlohn.de> Reviewed-by:
-
Stefan Neufeind authored
Regular INT limits filesize to 2GB. Change-Id: I525bd53bff6495630bd5880c8ef8789a1d9bbf26 Resolves: #60327 Releases: 6.3, 6.2 Reviewed-on: http://review.typo3.org/31737 Reviewed-by:
-
Markus Guenther authored
While creating frontend groups via extbase without any subgroup set, the record will have the value NULL in the database for the property subgroup. This leads to an exception. This patch only defines TSconfig, subgroups and description not to accept NULL and to be consistent the tx_extbase_type gets the default value 0. Resolves: #60245 Releases: 6.3, 6.2 Change-Id: Ie402d4c47058755efe40cc762f4220ba7dc6b781 Reviewed-on: http://review.typo3.org/31560 Reviewed-by:
-
Helmut Hummel authored
The RteHtmlParser checks for valid links by trying to retrieve a file or folder object. The FAL API will throw exceptions if anything goes wrong with the given path. Catch all these exceptions to ignore the invalid link and act the same for invalid paths as for not found files/ folders Releases: 6.2, 6.3 Resolves: #60316 Change-Id: I0752678eb8ed2b596c3a88536d957ec35c172d7b Reviewed-on: http://review.typo3.org/31619 Reviewed-by:
Alexander Schnitzler <typo3@alexanderschnitzler.de> Tested-by:
-
- Jul 23, 2014
-
-
Oliver Hader authored
Workspace actions using the DataHandler trigger a reprocessing of the reference index. However, it happened that index entries of the live workspace have been deleted or modified. The reason for that is a missing SQL statement to limit those actions to the current workspace only. The result can be seen in e.g. the workspace module after having deleted an IRRE child record and how the nesting could not be determined correctly for that particular record. Resolves: #59874 Releases: 6.2, 6.3 Change-Id: I850e2fe88999ce8db280d4ef426e43c85fff06da Reviewed-on: https://review.typo3.org/31590 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Stefan Neufeind authored
The default userAgent is for example TYPO3/6.2.4 Change-Id: I2412b901a3a42938a433e7d8a414de24587011a3 Resolves: #60365 Releases: 6.3, 6.2 Reviewed-on: https://review.typo3.org/31641 Reviewed-by:
-
Michael Schams authored
A new header in PHP files has been introduced with #59535. This patch updates the copyright/license header of one file, which still uses the old, outdated information. Resolves: #60482 Releases: 6.3, 6.2 Change-Id: I642a4ce13331e2aadbd362988b963a8a5c576a29 Reviewed-on: https://review.typo3.org/31731 Reviewed-by:
-
- Jul 22, 2014
-
-
Stefano Kowalke authored
In case of success the current implementation returns the result of $res->free(). Unfortunately free() doesn't return anything. That causes sql_free_result() to return NULL, which eventually evaluates to FALSE. Make sure the return value is correct and return TRUE in case of success. Resolves: #60457 Releases: 6.2, 6.3 Change-Id: I8756d4d2a321adc88738b9ac418207c63b312c86 Reviewed-on: https://review.typo3.org/31718 Reviewed-by:
-
- Jul 21, 2014
-
-
Helmut Hummel authored
The bootstrap for frontend functional tests has some minor issues, that are now fixed: * json_decode returns null not false when not successfull * Properly set the SERVER_PORT * Use correct array key in error message * Avoid notices with relative URLs Releases: 6.2, 6.3 Resolves: #60413 Change-Id: I3ff07f01729d3403374759edbaa5ddcccd2e889a Reviewed-on: https://review.typo3.org/31695 Reviewed-by:
-
- Jul 20, 2014
-
-
Wouter Wolters authored
Set sys_collection_entries to varchar(64). This is the max table name length on MySQL. Resolves: #60180 Releases: 6.3,6.2 Change-Id: I253e6eb6cb35db9e6d13a716bfc5c8d89db4ca7e Reviewed-on: https://review.typo3.org/31571 Reviewed-by:
Ernesto Baschny <ernst@cron-it.de> Reviewed-by:
-
- Jul 19, 2014
-
-
Markus Klein authored
TypoScriptFrontendController throws a PHP warning on access to $BE_USER->user['uid'] which might not be set. Fix this by simply adding an empty() check. Resolves: #60126 Releases: 6.3, 6.2 Change-Id: I7005baf73bce55d862b4b6b61697c2aa0a877c7b Reviewed-on: https://review.typo3.org/31472 Reviewed-by:
Marcin Sągol <marcin@soee.pl> Reviewed-by:
-
Wouter Wolters authored
Explicitly set the format of the email body to text/html. Resolves: #60251 Releases: 6.3, 6.2 Change-Id: I350b0f4cb9e69cd20dbd439647f56cd9c641b501 Reviewed-on: https://review.typo3.org/31578 Reviewed-by:
Pascal Dürsteler <pascal.duersteler@gmail.com> Reviewed-by:
-
Tomita Militaru authored
Checks for ATagParams & access key code before adding empty spaces between anchor parameters. Resolves: #50566 Releases: 6.3, 6.2, 6.1 Change-Id: I57a2a2a06a97fc1eda6e0438bfdc6e210437e5bb Reviewed-on: https://review.typo3.org/25322 Reviewed-by:
-
- Jul 18, 2014
-
-
Wouter Wolters authored
Resolves: #60227 Releases: 6.3 Change-Id: Ic137136005f117ac491cd8897e702f81169a1c0a Reviewed-on: https://review.typo3.org/31572 Reviewed-by:
Michael Bakonyi <m.bakonyi@civit.de> Tested-by:
-
- Jul 15, 2014
-
-
Helmut Hummel authored
Some of the files still miss the die statement in the first line. To be consistent, add it to every file. One file had a check for TYPO3_MODE === BE which is wrong in these files because the result is cached. If the first hit with empty cache is done in a FE request, a wrong result would be cached. Releases: 6.2, 6.3 Resolves: #60317 Change-Id: I839499100da28ba11d5dcbf81fde87b30b61de81 Reviewed-on: https://review.typo3.org/31621 Reviewed-by:
Markus Klein <klein.t3@mfc-linz.at> Tested-by:
-
- Jul 11, 2014
-
-
Andreas Wolf authored
This is an automatic reformat performed by PhpStorm, to get rid of some ugly constructs like one-line inline methods. Change-Id: Id24666c673b3822916f9c5233c0b34ce7d38e7aa Related: #58475 Releases: 6.3 Reviewed-on: https://review.typo3.org/29833 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Andreas Wolf Tested-by: Andreas Wolf
-
Oliver Hader authored
* add third tt_content element with localization in live context * add new tt_content delete placeholder in different workspace * populate changes to all scenarios in live and workspace context Releases: 6.2, 6.3 Resolves: #59881 Change-Id: I644e264048a5c33c0a613d5f8440975cabd40721 Reviewed-on: https://review.typo3.org/31141 Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
- Jul 10, 2014
-
-
Helmut Hummel authored
The package cache writes paths to extension directories (TYPO3_LOADED_EXT) into the cache. This will result in wrong caches when the same TYPO3 instance is called from a different absolute directory e.g. from a different mount or symlink. To avoid this, the cache identifier now includes PATH_site which is the current absolute path of the TYPO3 instance. Additionally we now only include the modification time of the package states file instead of the md5 of the complete content into account, which should be much faster and also enough. Resolves: #58288 Releases: 6.2, 6.3 Change-Id: I7c8de41c608beab282f2b8bbeab39f257a9a6a6f Reviewed-on: https://review.typo3.org/31565 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
Helmut Hummel authored
Add verbosity to the exception message to make it more clear what is going wrong. Releases: 6.2, 6.3 Resolves: #60225 Change-Id: I7bb4a16ff94d05b8b97633383d42c61aa600b1cf Reviewed-on: https://review.typo3.org/31556 Reviewed-by: Christian Kuhn Reviewed-by: Markus Klein Reviewed-by: Wouter Wolters Tested-by: Christian Kuhn Reviewed-by: Alexander Opitz Tested-by: Alexander Opitz Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
- Jul 09, 2014
-
-
Tomita Militaru authored
Change in height of table header row for Languages view. Resolves: #56714 Releases: 6.3, 6.2 Change-Id: Ic6bab8a99695798ecfc115209aec41e241870925 Reviewed-on: https://review.typo3.org/31498 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Wouter Wolters authored
Resolves: #60192 Releases: 6.3,6.2 Change-Id: I4bacce041ca3be3dce4cae1a7407ab3fdf301ff0 Reviewed-on: https://review.typo3.org/31524 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Sascha Egerer Tested-by: Sascha Egerer Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
- Jul 08, 2014
-
-
Marc Bastian Heinrichs authored
Errors are only logged if no pages are created on initial data.t3d import. They should be logged generally. Resolves: #58798 Releases: 6.3, 6.2 Change-Id: Ia859d12ec567a1b64bb9b65dd41f5ba996de3139 Reviewed-on: https://review.typo3.org/30101 Reviewed-by: Nicole Cordes Tested-by: Nicole Cordes Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Markus Klein authored
Re-add a missing use statement that vanished during rebase. Resolves: #59587 Releases: 6.3, 6.2, 6.1 Change-Id: I16ac1b9d5a00c4300202eaef493de43fc988a81d Reviewed-on: https://review.typo3.org/31520 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Alexander Opitz authored
This applies to Apc/Memcached/Wincache/Xcache backends. After an array_merge the values aren't unique. This leads to duplicate tags per identifier. This patch changes that and also moves the findTagsByIdentifier call out of the foreach loop. Resolves: #59587 Releases: 6.3, 6.2, 6.1 Change-Id: Id31e16fa4bba11038ba692a483fb9a33808d95fa Reviewed-on: https://review.typo3.org/30767 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Markus Klein authored
Fix a wrong type hint for the second parameter in InstallUtility::emitAfterExtensionT3DImportSignal(). The parameter is of type integer and not array. Resolves: #60179 Releases: 6.3, 6.2 Change-Id: Iccfb7445bd374edaecfd3408380034dbec82e539 Reviewed-on: https://review.typo3.org/31503 Reviewed-by: Wouter Wolters Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
Oliver Hader authored
On copying a page in the backend there are lots of superfluous SQL queries containing "... WHERE uid=0". The reason for that is, that DataHandler::recordInfo() is called for each field which then tries to fetch the database record for the given uid "NEW...". Casting the new record placeholder to an integer value ends up with the "uid=0" condition. In a test with copying a page with some sub-pages, there was a total of about 1300 SQL queries, 300 of them have been those superfluous "uid=0" SELECT statements. Change-Id: Ib7006a7ceb52376032df8eaefaa918407718a482 Resolves: #58357 Releases: 6.2, 6.3 Reviewed-on: https://review.typo3.org/31310 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Sascha Egerer Tested-by: Sascha Egerer Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
