Skip to content
Snippets Groups Projects
  1. Jul 15, 2013
    • Stefan Neufeind's avatar
      [TASK] require-statements should use absolute paths · ad59f964
      Stefan Neufeind authored
      require-statements relying on the current working-
      directory and/or a certain include-path setting
      can cause unexpected behaviour.
      A path is added for those cases. For the current
      working-directory simply using __DIR__ is okay.
      
      Change-Id: I959c8f4a1d25ca1403e7dcecb0bc20826c7c5059
      Resolves: #49991
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/22270
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      Reviewed-by: Anja Leichsenring
      Tested-by: Anja Leichsenring
      ad59f964
    • Markus Klein's avatar
      [BUGFIX] Fix PHP warning trigged in initFEuser · a662010b
      Markus Klein authored
      TypoScriptFrontendController::initFEuser() calls
      $GLOBALS['TYPO3_DB']->cleanIntList() with a possible NULL argument.
      This leads to a PHP warning in GeneralUtility::trimExplode().
      
      Resolves: #42921
      Releases: 6.2, 6.1, 6.0, 4.7, 4.5
      Change-Id: Id33ee8fe5e4177716af6ce8c9084e098b86c280c
      Reviewed-on: https://review.typo3.org/22327
      Reviewed-by: Thorsten Kahler
      Tested-by: Thorsten Kahler
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      a662010b
    • Mario Rimann's avatar
      [BUGFIX] Indexing files does not store the language · 85ea7bf9
      Mario Rimann authored
      While indexing externals (e.g. PDF files) the language of the page
      being rendered is not stored with the indexed file content. Thus
      the file is shown/not shown in the wrong situations.
      
      See detailed description in bug-report regarding the "situations".
      
      Change-Id: I69eb1e222eb186b052eba93eaa9d5a80dd1e87ab
      Resolves: #46261
      Releases: 4.7, 6.0, 6.1, 6.2
      Reviewed-on: https://review.typo3.org/18899
      Reviewed-by: Henrik Ziegenhain
      Tested-by: Henrik Ziegenhain
      Reviewed-by: Georg Ringer
      Tested-by: Georg Ringer
      85ea7bf9
    • Wouter Wolters's avatar
      [TASK] Cleanup entry classes in typo3/ part2 · d9e0a02f
      Wouter Wolters authored
      Cleanup the entry classes inside typo3/ with the following
      changes:
      
      * Move language include to constructor
      * Remove not needed doc-comments
      * Make class available in $GLOBALS['SOBE']
      
      Change-Id: Ie5bcf1f6f09a070a946a021d41d4809567ff6229
      Resolves: #49454
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/21669
      Reviewed-by: Alexander Opitz
      Reviewed-by: Markus Klein
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      d9e0a02f
    • Markus Klein's avatar
      [TASK] Fix usage of functions, which are deprecated in PHP 5.5 · ebe1573b
      Markus Klein authored
      Fixes a call to preg_replace with /e modifier,
      which is deprecated in PHP 5.5 now.
      
      Resolves: #49300
      Releases: 6.2, 6.1
      Change-Id: I6bd4b57d64801be912e0050772420a684b1aa237
      Reviewed-on: https://review.typo3.org/21556
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      ebe1573b
    • Wouter Wolters's avatar
      [BUGFIX] requestUpdate sensitive to spaces · afa9cdfa
      Wouter Wolters authored
      The TCA property "requestUpdate" is sensitive to spaces, although this
      is documented nowhere. Indeed "foo1, foo2" will not work whereas
      "foo1,foo2" does. This patch strips spaces from the "requestUpdate"
      string before testing it.
      
      Resolves: #49872
      Related: #42789
      Releases: 6.2, 6.1, 6.0, 4.7, 4.5
      Change-Id: I44410007503443843a3ecbff15f4738cd857b73c
      Reviewed-on: https://review.typo3.org/22314
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      afa9cdfa
    • Markus Klein's avatar
      Revert "[BUGFIX] requestUpdate sensitive to spaces" · b04b92b5
      Markus Klein authored
      This reverts commit acd257b5
      
      The code has a wrong parentheses order.
      Backports are fixed, only master (6.2) affected.
      
      Releases: 6.2
      Change-Id: I605730841fa8c86eb275d3d925c5a917049f386b
      Reviewed-on: https://review.typo3.org/22311
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      b04b92b5
  2. Jul 14, 2013
    • Wouter Wolters's avatar
      [BUGFIX] requestUpdate sensitive to spaces · acd257b5
      Wouter Wolters authored
      The TCA property "requestUpdate" is sensitive to spaces, although this
      is documented nowhere. Indeed "foo1, foo2" will not work whereas
      "foo1,foo2" does. This patch strips spaces from the "requestUpdate"
      string before testing it.
      
      Change-Id: Ifbb1fe5be59077207316e48204d65a978592f878
      Resolves: #49872
      Related: #42789
      Releases: 6.2, 6.1, 6.0, 4.7, 4.5
      Reviewed-on: https://review.typo3.org/22283
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      Reviewed-by: Frans Saris
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      acd257b5
    • Dmitry Dulepov's avatar
      [BUGFIX] Exceptions if EXT:context_help is not installed · 7c4e668f
      Dmitry Dulepov authored
      If the extension 'context_help' is not installed, the web
      server's error log sometimes shows exceptions like "Class
      'TYPO3\CMS\ContextHelp\ExtDirect\ContextHelpDataProvider'
      not found" and "Invalid argument supplied for foreach()".
      This happens because the class in question is registered
      to ExtDirect without checking if the corresponding
      extension is loaded.
      
      Change-Id: Ic773cff2822912aac7841955be2f09d77169fdb9
      Resolves: #48394
      Releases: 6.0, 6.1, 6.2
      Reviewed-on: https://review.typo3.org/20929
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Felix Kopp
      Reviewed-by: Stefan Neufeind
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      7c4e668f
    • Max Roesch's avatar
      [BUGFIX] Use new paths for tstemplate classes · 0ff4e231
      Max Roesch authored
      TsTemplate classes have been moved into a central directory.
      All uses of the classes now have the right new directory.
      
      Resolves: #49993
      Releases: 6.2
      Change-Id: I3b3168b0550d704ef2388304be30bac961e371f9
      Reviewed-on: https://review.typo3.org/22273
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Max Roesch
      Tested-by: Max Roesch
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      0ff4e231
    • Wouter Wolters's avatar
      [BUGFIX] be_users:usergroup_cached_list to small · 7b0665d6
      Wouter Wolters authored
      The field usergroup_cached_list in be_users table
      is to small. Make it a text field.
      
      Change-Id: I45afa0880da20323329694073777a51dcfc2db4d
      Resolves: #49962
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/22284
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      7b0665d6
    • Jigal van Hemert's avatar
      [BUGFIX] Use correct class in T3Editor save hook · 3c3fa701
      Jigal van Hemert authored
      After merging the Template related sysexts the save hook in T3Editor
      needs to refer to the new class.
      
      Change-Id: I6eb4eef2d703b9e50246b7faef808985f609cb7f
      Resolves: #50013
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/22289
      Reviewed-by: Jigal van Hemert
      Tested-by: Jigal van Hemert
      3c3fa701
  3. Jul 13, 2013
    • Stefan Neufeind's avatar
      [BUGFIX] Make DBgetDelete() update tstamp on delete by update · 1eaeab88
      Stefan Neufeind authored
      If told to do so by TCA ContentObjectRenderer::DBgetDelete()
      will not immediately delete a row but mark it as deleted.
      This change updates the tstamp (if that column is configured)
      for that "updated" row as well, like on a regular update.
      
      Fixes: #47354
      Releases: 6.2, 6.1
      Change-Id: I61b9ce7d8608b73cfb974e79d2f9f59e6dc3547a
      Reviewed-on: https://review.typo3.org/20024
      Tested-by: Dmitry Dulepov
      Reviewed-by: Dmitry Dulepov
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      1eaeab88
    • Francois Suter's avatar
      [BUGIFX] RTEmagic upgrade wizard: missing attributes · a51b9691
      Francois Suter authored
      When the RTE creates a magic images it uses data-* attributes
      to keep a reference to the original FAL record. The upgrade
      wizard migrates the images, creates the sys_file entries but
      does not add the data-* attributes.
      
      Resolves: #49733
      Releases: 6.1, 6.2
      Change-Id: Ib483355336d1331892920ada847850a61c35a3af
      Reviewed-on: https://review.typo3.org/22019
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Stefan Neufeind
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      a51b9691
    • Wouter Wolters's avatar
      [BUGFIX] Remove gap underneath Linkvalidator tabs · 79f9f3b7
      Wouter Wolters authored
      In Linkvalidator backend module the gap between tabs
      and table is removed.
      
      Change-Id: Icaed87594cb7e9833810709fd3ae9acf40b963f7
      Resolves: #49997
      Related: #49133
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/22276
      Reviewed-by: Felix Kopp
      Tested-by: Felix Kopp
      79f9f3b7
    • Felix Kopp's avatar
      [BUGFIX] Remove gap underneath Workspace tabs · e929ca05
      Felix Kopp authored
      In Workspace backend module the gap between tabs
      and table is removed.
      
      Change-Id: I1031c1a8eed43a23bc87cf7415972b5bd1cd6055
      Resolves: #49133
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/22274
      Reviewed-by: Max Roesch
      Tested-by: Max Roesch
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      e929ca05
  4. Jul 11, 2013
  5. Jul 10, 2013
    • Francois Suter's avatar
      [BUGFIX] requestUpdate sensitive to spaces · b89d6f23
      Francois Suter authored
      The TCA property "requestUpdate" is sensitive to spaces, although this
      is documented nowhere. Indeed "foo1, foo2" will not work whereas
      "foo1,foo2" does. This patch strips spaces from the "requestUpdate"
      string before testing it.
      
      Resolves: #42789
      Releases: 6.2, 6.1, 6.0, 4.7, 4.5
      Change-Id: I340090e93e7b8645493f8db0c8c374cb1227f684
      Reviewed-on: https://review.typo3.org/22174
      Reviewed-by: Xavier Perseguers
      Tested-by: Xavier Perseguers
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      Reviewed-by: Francois Suter
      Tested-by: Francois Suter
      b89d6f23
    • Georg Ringer's avatar
      [TASK] Make uid,pid selectable by users in list view · 3940786f
      Georg Ringer authored
      There is no reason to hide those 2 fields in list view
      => extended view > fields and make them admin only
      
      Change-Id: I390e2b0ac974098edb53d7e36681d6f3df0124eb
      Resolves: #49810
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/22157
      Reviewed-by: Georg Ringer
      Tested-by: Georg Ringer
      3940786f
    • Wouter Wolters's avatar
      [TASK] Move language include to .xlf · 36b5914f
      Wouter Wolters authored
      Move all old language includes (php,xml) in the core to .xlf
      
      Change-Id: I804b5970a360cbfdc2940736632c55c535ccbd40
      Resolves: #49832
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/22167
      Reviewed-by: Markus Klein
      Reviewed-by: Georg Ringer
      Tested-by: Georg Ringer
      36b5914f
  6. Jul 09, 2013
    • Robert Vock's avatar
      [BUGFIX] Logging PHP errors to sys_log table does not work · 151b56f4
      Robert Vock authored
      Logging PHP errors stopped working after changeset
      3e309294 when the  DatabaseConnection
      class was changed.
      The changed line tries to determine, if a database connection is
      available and only writes the log entry if the connection was
      already established.
      
      Resolves: #49645
      Releases: 6.1, 6.2
      Change-Id: Idee413ed911a8c2d23f034ceadd17c955c98a337
      Reviewed-on: https://review.typo3.org/22166
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Jigal van Hemert
      Tested-by: Jigal van Hemert
      151b56f4
    • Ingo Renner's avatar
      [BUGFIX] Cannot load css_styled_content TS using INCLUDE_TYPOSCRIPT · 5adfc5f4
      Ingo Renner authored
      When installing extensions they may register plugins in ext_localconf.php.
      By doing so some default TypoScript is generated in
      Extensionutility::configurePlugin() that is then added using
      ExtensionManagementUtility::addTypoScript().
      
      Parts of the generated TypoScript are stored in
      $TYPO3_CONF_VARS['FE']['contentRenderingTemplates']* and are loaded later
      during TypoScript parsing after including the content rendering template.
      
      These TS parts are used to resolve which classes and methods to call when
      a plugin needs to be rendered on a page. You can find them in
      tt_content.list.20.*
      
      "content default" used to be the old content rendering template with uid
      43, today we use css_styled_content instead. The part in the TypoScript
      processing chain to load these generated snippets -
      TemplateService::includeStaticTypoScriptSources() - is only executed when
      loading the content rendering templates using the "Include static (from
      extensions)" field in template records.
      
      In return this means if you try to move as much TS to files as possible
      you will still have to include css_styled_content through the Template
      records in the backend. In other words when actually trying to include
      css_styled_content TS from a file, the generated snippets for
      tt_content.list.20.* will not be loaded and thus no plugin can be
      executed.
      
      Resolves: #49461
      Resolves: #44983
      Releases: 6.2, 6.1, 6.0
      Change-Id: I77c0d64759fa0b5b27cac0ae1acd55e9abefe7f8
      Reviewed-on: https://review.typo3.org/21679
      Reviewed-by: Markus Klein
      Reviewed-by: Marc Bastian Heinrichs
      Tested-by: Marc Bastian Heinrichs
      Reviewed-by: Ingo Renner
      Tested-by: Ingo Renner
      5adfc5f4
    • Francois Suter's avatar
      [BUGIFX] Missing update wizard for RTE file links · 6b4d7dc8
      Francois Suter authored
      File links made inside a RTE-enabled field are currently not
      migrated to FAL references. This patch adds such an update
      wizard.
      
      Resolves: #49233
      Releases: 6.1, 6.2
      Change-Id: I12b6d9da87b734c0a9d5f884d5067e3c9b08efc3
      Reviewed-on: https://review.typo3.org/22002
      Reviewed-by: Nico de Haen
      Tested-by: Nico de Haen
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Sebastian Michaelsen
      Tested-by: Sebastian Michaelsen
      Reviewed-by: Francois Suter
      Tested-by: Francois Suter
      6b4d7dc8
  7. Jul 08, 2013
    • Alexander Schnitzler's avatar
      [TASK] Replace inject methods with @inject · e83fa716
      Alexander Schnitzler authored
      Currently we are using inject methods like:
      
      /*
       * @param $foo Foo
       */
      public function injectFoo(Foo $foo) {
      	$this->foo = $foo;
      }
      
      This patch removes these methods and introduces
      property annotations:
      
      /**
       * @var Foo
       * @inject
       */
      protected $foo;
      
      Change-Id: I5b6f1aae29f95c31b9dd69629f05d8451fe30261
      Releases: 6.2
      Resolves: #46598
      Reviewed-on: https://review.typo3.org/22006
      Reviewed-by: Alexander Schnitzler
      Tested-by: Alexander Schnitzler
      Reviewed-by: Marc Bastian Heinrichs
      Tested-by: Marc Bastian Heinrichs
      Reviewed-by: Stefan Neufeind
      Reviewed-by: Anja Leichsenring
      Tested-by: Anja Leichsenring
      e83fa716
    • Andreas Wolf's avatar
      [TASK] Make comments in DataHandler real docblocks · b28734fe
      Andreas Wolf authored
      Change-Id: I8ae556930bd378a3756edbaa9ab86530f159f0da
      Relases: 6.2
      Resolves: #49784
      Reviewed-on: https://review.typo3.org/22119
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      b28734fe
  8. Jul 07, 2013
  9. Jul 06, 2013
    • Stefan Neufeind's avatar
      [BUGFIX] Files with unclean path indexed multiple times · 2219d228
      Stefan Neufeind authored
      When adding a file or requesting a file by an identifier
      cleanup any . and .. in the path before handing off
      to the driver so files are not indexed multiple times.
      
      Change-Id: I324c4637621165a56470fb95864eeff1254f62dc
      Fixes: #46989
      Releases: 6.2, 6.1, 6.0
      Reviewed-on: https://review.typo3.org/19684
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      2219d228
    • Felix Kopp's avatar
      [TASK] Move typo3/stylesheets to EXT: backend · f299f88a
      Felix Kopp authored
      In order to decouple extensions from each other and to
      fasten bonding between files to specific extensions the
      folder typo3/stylesheets should be moved to EXT: backend.
      
      Change-Id: I2ecf68e9c8d412c1c9b097db63743bde518f52b0
      Resolves: #49747
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/22048
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      Reviewed-by: Jigal van Hemert
      Tested-by: Jigal van Hemert
      f299f88a
    • Steffen Ritter's avatar
      [BUGFIX] sys_file record doesn't get flagged as delete · 18bb6574
      Steffen Ritter authored
      File is deleted by driver and deleted property of FileObject is set by
      ResourceStorage but new state is not persisted.
      Update deleted property in updateProperties array in FileObject and
      persist change.
      
      Reintroduced after fixing tests in f3778d8c.
      
      Change-Id: I0784c84af4bfb8021c648139c2feee577f3e9dc1
      Fixes: #48336
      Releases: 6.2, 6.1, 6.0
      Reviewed-on: https://review.typo3.org/22056
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      18bb6574