- Nov 25, 2023
-
-
Andreas Kienast authored
This patch merges the "t3editor" extension into EXT:backend. The overall benefit is a globally available syntax highlighting at various places, without the need to have an extra extension installed. Another benefit it the removal of installation checks of EXT:t3editor and fallbacks if the "soft requirement" is not fulfilled, reducing soft-cross-dependencies. Resolves: #102440 Releases: main Change-Id: I76301c9cff08f61a5721fa34f4e3e950687b67b0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81799 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
-
Oliver Klee authored
Resolves: #102486 Releases: main Change-Id: I2e8d8cdeb603b8c83aed76193d649e3e01ef94df Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80278 Tested-by:
-
Oliver Bartsch authored
Avoid the $GLOBALS['TYPO3_REQUEST fallback and use the class variable directly. Resolves: #102513 Releases: main Change-Id: Ib753448923fb7baa04ea6694a3fd779af79b0d3d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81957 Tested-by:
-
- Nov 24, 2023
-
-
Oliver Hader authored
In favor of applying content security policies, inline JavaScript is dropped when navigating back to the previous form step. Resolves: #102460 Releases: main, 12.4 Change-Id: I2822067968f9b35b2f41598787b0ff6b52f20c72 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81878 Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
Jasmina Ließmann authored
In the "References from this item" area of the "Element Information" modal, there is s preview link for references of type page. In #101276 a problem with the preview links was solved but another one introduced so that the preview links were now always deactivated. This patch now sets the correct variable in the fluid template. Resolves: #102515 Related: #101276 Releases: main, 12.4 Change-Id: I4e129c98a067e015c7dd4e56af9eb006044bab83 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81959 Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Jasmina Ließmann authored
The “Element information” modal displays, among other things, references to and from the selected record. In the "References from this item" area, the icon of the current data record was incorrectly always displayed. With this patch, the appropriate icon of the referenced record is now always displayed. Resolves: #102514 Releases: main, 12.4 Change-Id: I707f2c73d7d94cf02311868cbef480ff6e3cd121 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81958 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Andreas Kienast authored
Use promises instead. Also adapt the type declarations to denote the actually resolved type, which is void. This was an uncaught declaration mistake before. Resolves: #102508 Releases: main Change-Id: Ia3557fcdf0b46b8b5b5456e44c0a0da71719fe8f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81644 Tested-by:
-
Oliver Bartsch authored
In some cases the element might not be available, making the data attributes not accessible. To prevent type errors, proper checks are added. Resolves: #102510 Releases: main, 12.4 Change-Id: I061fcb3fe4f153ff45230a86ed11edf1dfb76cd8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81954 Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Jochen Roth <rothjochen@gmail.com> Reviewed-by:
-
Stefan Bürk authored
Used command(s): > composer u typo3/testing-framework Resolves: #102506 Releases: main Change-Id: Ib0ca2770420cdcb7ff4464a785f44e01bf02e192 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81913 Reviewed-by:
-
Elias Häußler authored
When downloading or updating extension using extension manager, the resulting extensions are now properly iterated using `Object.keys`. This is necessary since the extensions are provided as objects instead of simple arrays. In addition, the relevant methods in ExtensionManagementService now have proper type declarations and annotations. Resolves: #101430 Releases: main, 12.4 Change-Id: I112d59326ed5cb788bad919a7b556f7ee95b2b41 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80128 Tested-by:
-
Benni Mack authored
The UserTSconfig setting options.overridePageModule was introduced in TYPO3 v4, to run TemplaVoila and "regular" page module in parallel. However, this feature was never rolled out completely throughout the TYPO3 Backend, but only used in a few places, and now it is only used in a few places (mainly workspaces). Since TYPO3 v12, it is much easier to actually override the page module through the Module API to replace either the endpoint or to add a new module with an alias to "web_layout", which should be used instead. Resolves: #102499 Releases: main Change-Id: Ibfd4efa221a780f72200364c4e5fd65dc64e3be7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81812 Reviewed-by:
-
Andreas Nedbal authored
Resolves: #102418 Releases: main Change-Id: Idb5f0e3224971d79c28ad4ae9e07a6df17beea4a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81810 Tested-by:
Andreas Nedbal <andy@pixelde.su> Tested-by:
-
Stefan Bürk authored
This reverts commit 3bac9e44. #102495 ensured that the `ext_tables.sql` scanning using the own sql parser set column comments to an empty string instead of using the default of null. This has been done as a preparation for the next Doctrine DBAL major version upgrade. Due to the fact that the doctrine `Column` does not contain the "string" enforcement this now means that empty comments are detected as changes for PostgreSQL. It does not make sense to extend and replace all the classes of doctrine to reflect the upcoming changes, therefore this change is reverted. The original intention needs to be included with the major Doctrine DBAL upgrade. Change-Id: Ia92a8955951525e6c7a04bd9544f7d14c8be2e8e Resolves: #102503 Reverts: #102495 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81902 Tested-by:
-
Andreas Kienast authored
This reverts commit 2a05d284. The proposed and merged solution decreases the overall usability in the TYPO3 backend as users are now forced to press the <TAB> key twice to actually switch the focus to another field. One could also argue that the change that is reverted is not suitable for the target group that mostly uses keyboard navigation as said users were already able to clear fields previously. Once we have a solution that satisfies both target groups, another patch will be pushed. Change-Id: I58acdd89a61f3df258e755c893389fe960985b8f Resolves: #102504 Reverts: #102372 Releases: main, 12.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81904 Reviewed-by:
-
Benjamin Franzke authored
Bash hashtables are not supported in bash v4, so we rather use a lookup function. Resolves: #102502 Related: #102450 Releases: main, 12.4, 11.5 Change-Id: Id5c875b78ec655e15d225914626769720bbc3a81 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81950 Tested-by:
-
Oliver Bartsch authored
This follows #100227, which outsourced common multi record selection actions into dedicated JS components to be reusable in the different backend modules. This is now also done for the template part, which is therefore outsourced into a partial, coupled with a dedicated new Action object component. Resolves: #102493 Related: #100227 Releases: main, 12.4 Change-Id: I57de98240ea7479f1ab00d46a964463b9a4d1eda Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81940 Tested-by:
-
- Nov 23, 2023
-
-
Stefan Bürk authored
The doctrine team enforced types on a couple of classes to not-nullable strings [1], for examle: * `Column->setComment(string $comment)` * `Column->getComment(): string The `\TYPO3\CMS\Core\Database\Schema\Parser\TableBuilder` is modified to ensure that a string is set by using a simple string cast. [1] https://github.com/doctrine/dbal/pull/3949 Resolves: #102495 Releases: main Change-Id: Ic13f25958bd67a3dbc931eb0bf59ddfbf2028888 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81944 Reviewed-by:
-
Stefan Bürk authored
Doctrine DBAL deprecated the support for integer type values based on the php-pdo `\PDO::PARAM_*` constants as preparation to replace them with native php enums `ParameterType|ArrayParameterType` with the next major version. Due to this fact, it's not possible to have an null value for an type to fallback to `ParameterType::PARAM_STR`. This change sets for undefined types (null) the `Connection::PARAM_STR` to prepare for `doctrine/dbal 4.x` upgrade. Note: With the `doctrine/dbal 4.x` the `Connection::PARAM_*` constants will be replaced with the `ParameterType` and `ArrayParameterType` enums. [1] https://github.com/doctrine/dbal/blob/3.7.x/UPGRADE.md#bc-break-the-pdo-symbols-are-no-longer-part-of-the-dbal-api [2] https://github.com/doctrine/dbal/blob/4.0.x/UPGRADE.md#bc-break-removed-support-for-using-null-as-prepared-statement-parameter-type Resolves: #102494 Releases: main Change-Id: Iacda7e6d14a485896fa7e0f62b9f1a88e8e7966a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81942 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Benni Mack authored
When a hidden page is previewed in the Backend, the PreviewSimulator has a valid BE_USER object in place. However, when a preview link is generated, the PreviewUser does not have a group, thus the PreviewSimulator is not activated. For this reason, the check if the PreviewSimulator is active, needs to consider if we are in an offline workspace Resolves: #102216 Releases: main, 12.4 Change-Id: I95aadaad1de69ce6eed91acd82f4d42171a6500d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81499 Tested-by:
Andreas Wolf <andreas.wolf@typo3.org> Reviewed-by:
-
moveDaniel authored
Releases: main, 12.4 Resolves: #102489 Change-Id: I2e0c190366bd052fdafa2d8b3e91ff7064c2465a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81931 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
-
Stefan Bürk authored
The doctrine team deprecated within `doctrine/dbal 3.x` the `Platform->getStringLiteralQuoteCharacter()`, postulating that this is a implementation detail and not a public required information [1][2]. TYPO3 extends a couple of classes to provide some advanced abilities to help extension author's avoiding casual safety traps and additional features. The `ExpressionBuilder` is one of these classes. Extended methods quotes values per default, and therefore requires to unquote values at some points to avoid double quoting of values. This change removes the call to the deprecated method on the platform and directly replaces it with the value, as all supported platforms will return the same quoting char. Tests are adjusted accordingly. [1] https://github.com/doctrine/dbal/blob/3.7.x/UPGRADE.md#deprecated-abstractplatform-methods-exposing-quote-characters [2] https://github.com/doctrine/dbal/pull/5388 Resolves: #102491 Releases: main Change-Id: I02e0c7dfe5394461f2dded4ec78c4e8e27b0cfd6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81934 Tested-by:
-
Oliver Bartsch authored
By constructing a correct command object, it's now possible to delete multiple records using multi record selection in the backend modules, using the corresponding JavaScript component, which are currently redirects, reactions and webhooks. Resolves: #102475 Releases: main, 12.4 Change-Id: Iee0a88e062df042f5835ecc8e984532b3ca940d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81935 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
-
Stefan Bürk authored
Doctrine DBAL depreated a couple of `AbstractPlatform methods [1] producing SQL fragments which does not vary between platforms. Following methods from the deprecated list are in use: * `AbstractPlatform->getSqlCommentStartString()` * `AbstractPlatform->getSqlCommentEndString()` * `AbstractPlatform->getCountExpression()` This change replace the occurances with the plain values. Resolves: #102492 Releases: main Change-Id: I2a9b703c07180827c3fbfbe644a4511690e27ee9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81939 Tested-by:
-
Benjamin Franzke authored
Allows to auto-update local images for feature-updates simply by raising them in runTests.sh (like we do for external images as well). That means `runTests.sh -u` is only needed in case patch updates are desired or needed. Resolves: #102450 Releases: main, 12.4, 11.5 Change-Id: Id9bdd679e430d57794e5d9e48f18ea67ed17d46c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81829 Tested-by:
-
Andreas Nedbal authored
Resolves: #102415 Releases: main Change-Id: I7d8ed50bc775b4ee1bef251f6cbcf87fc95cdcf7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81807 Tested-by:
-
Stefan Bürk authored
Resolves: #102482 Releases: main, 12.4 Change-Id: Id1b92d3b42f52a48e657dc6f53fcf6cef403841e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81919 Reviewed-by:
-
Benjamin Franzke authored
Removing all containers will remove their dangling volumes automatically and we can drop the manual cleanup. Parameters have been applied via: sed -i '/CONTAINER_COMMON_PARAMS/!s/\${CONTAINER_BIN} run/& --rm/' \ Build/Scripts/runTests.sh Resolves: #102449 Releases: main, 12.4, 11.5 Change-Id: I77b4166cbad427afef5c87173428433881e9eb85 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81852 Tested-by: -
Stefan Bürk authored
The php namespace integrity check uses a symfony finder to determine which files should be checked. The used pattern to ignore extension configuration folder `Configuration` excluded every file, which has `Configuration` in the path or filename. This change avoids using the nifty magic `exclude()` finder method and replace it with a more reliable `notPath()` configuration. Resolves: #102483 Releases: main, 12.4, 11.5 Change-Id: Ic0ae6eaae736b86412f8a430f11ea5b0a8e9dca9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81921 Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
-
Jasmina Ließmann authored
In the "LinkValidator" scheduler task, you need to select a start page. The button to select this page does not match the FormEngine markup. which is fixed with this patch. Resolves: #102462 Releases: main, 12.4 Change-Id: I213fde08a8a13bee462cdc3371514ce27c9e3e97 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81866 Tested-by:
-
Torben Hansen authored
The TCA ext_tables.php check in install tool refers to a conceptual change in TYPO3 6.2 and explains, why TCA overrides should be used in favor to TCA modifications in `ext_tables.php`. This change removes the explanation about the conceptual change in TYPO3 6.2 and adds a brief overview of required changes. Additionally, all file- and folder-names are now surrounded with the HTML code tag to add proper visual code highlighting. Resolves: #102477 Releases: main Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: I750b5a7c0f56c5b3b4bb009cc8f5aaed14dcf3a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81888 Tested-by:
-
Stefan Bürk authored
The environment variable `COMPOSER_ALLOW_SUPERUSER` has been set for composer command runs to avoid the warning that you are root in the container. It has been added to the core-testing-phpXY images so it is now superflous to set it explicitly on container invocation and can be removed. Resolves: #102466 Releases: main, 12.4 Change-Id: Ib91bf883385c524a756b8d2af0fcd80b3d42bc5b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81870 Reviewed-by:
Stephan Großberndt <stephan.grossberndt@typo3.org> Reviewed-by:
-
Chris Müller authored
The page doktype "recycler" has been removed. So, we don't need to exclude it anymore in the default TypoScript constants configuration in `plugin.tx_seo.settings.xmlSitemap.sitemaps.pages.excludedDoktypes`. Resolves: #102474 Related: #101137 Releases: main Change-Id: I5b1b369a825e3c0d245c3f1e17b4f03068315d60 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81884 Reviewed-by:
-
Christian Kuhn authored
Avoid a second fetch of TS 'setup include tree' in TypoScriptFrontendController when it just has been calculated a couple of lines before. Resolves: #97816 Releases: main, 12.4 Change-Id: If93d796158ffd51b02eefe68ff102fbf0834821f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81874 Tested-by:
-
Markus A authored
With #99048 the site settings API has been introduced and reading parts modified. However, the `ext:redirects` related site settings for auto-redirect creation missed to adjust the nested settings name for the http status code. This change uses the correct settings identifier path to retrieve the http status code used for created auto redirects again. Resolves: #102476 Related: #99048 Releases: main, 12.4 Change-Id: I6763523cdbd9f10ed41a9f03d646c08f707178de Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81923 Reviewed-by:
-
Oliver Bartsch authored
This adds the missing multi record selection with basic functionality (edit and delete records) to the redirects module. Resolves: #99567 Releases: main, 12.4 Change-Id: Id6cfef8c7e03701b47f8cc77095fe2c3f79e219c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81880 Tested-by:
Annett Jähnichen <mcmietz@web.de> Reviewed-by:
-
Christian Kuhn authored
Having TCA creation related code within static ExtensionManagementUtility is unflexible and no good architecture. The patch extracts TCA creation to a factory used by bootstrap for the different scopes. Resolves: #102471 Releases: main Change-Id: I683600db1b3bd0d3750a7ab8b3cfd72f6548d8dd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81600 Tested-by:
-
Nikita Hovratov authored
Resolves: #102473 Releases: main, 12.4 Change-Id: Iac4b1884e5a4c4f49c3e346b96795366f5bccdd1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81882 Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
- Nov 22, 2023
-
-
Nikita Hovratov authored
$tokenizedContent could be null and would already cause an undefined array key warning. When passed to the strlen method, this even causes an exception. This patch adds a null coalesce operator with an empty string as default and replaces the odd strlen bool expression with a strict comparison to an empty string. Resolves: #102461 Releases: main, 12.4 Change-Id: I88464956395240990a51bdb334502cd58da347bf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81864 Reviewed-by:
-
Andreas Kienast authored
When deleting a main record in the record list, only the first translated record was removed from the list. This affects the visual representation only. This commit changes the code to take all translated records into consideration. Resolves: #102454 Related: #101569 Releases: main, 12.4 Change-Id: I5f31ebd6e1bc9bc2bae23dbb1f7ecb49d12144bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81857 Tested-by:
Sascha Nowak <sascha.nowak@netlogix.de> Reviewed-by:
-
Jochen Roth authored
In #102417 the cli tests were moved to functional tests. This leads to (unwanted) additional on top of the dot output in the functional tests. This has been fixed by using proc_open to catch the output of the progressbar and friends. Also the args argument is fixed to allow for multiple arguments to be used in the data provider. Resolves: #102453 Releases: main, 12.4 Change-Id: I94ba8a187b5a86aaafeade44b92f9fa88a9b3aba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81856 Tested-by:
-
