Skip to content
Snippets Groups Projects
  1. Jul 09, 2024
  2. Jul 08, 2024
  3. Jul 07, 2024
  4. Jul 05, 2024
  5. Jul 04, 2024
  6. Jul 03, 2024
    • Garvin Hicking's avatar
      [BUGFIX] Prevent multiple FlexContainers of same name · dbfb29f0
      Garvin Hicking authored
      It is possible in Flexform containers to set a XML
      configuration that uses the same input field names,
      but within different sheets.
      
      The `FlexFormSectionContainer::render()` method used a
      HTML DOM id attribute that did not consider
      the Flexform sheet name, which has lead to the same id
      attribute being re-used. The JavaScript events (add
      and delete items from a container) would then
      fire only on the first instance, but as many times
      as there were wrongly regarded "duplicate" containers
      using the same id.
      
      This fix introduces another identifier section to the
      id attribute, containing the Flexform sheet name.
      This XML attribute is compatible
      with allowed CSS class names, so no further escaping is
      done with it, similar to the use of `$flexFormFieldName`.
      
      Resolves: #97042
      Related: #99947
      Releases: main, 12.4
      Change-Id: Ic1c81c658b090cb7b9c1a4230c0b4e75c12560dc
      Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85097
      
      
      Tested-by: default avatarOliver Bartsch <bo@cedev.de>
      Reviewed-by: default avatarOliver Bartsch <bo@cedev.de>
      Tested-by: default avatarcore-ci <typo3@b13.com>
      dbfb29f0
  7. Jul 02, 2024
  8. Jul 01, 2024
  9. Jun 30, 2024
  10. Jun 29, 2024
  11. Jun 28, 2024
  12. Jun 27, 2024
    • Garvin Hicking's avatar
      [BUGFIX] Make BackendGroupsExplicitAllowDeny wizard indicate errors · d45347cd
      Garvin Hicking authored
      The migration wizard BackendGroupsExplicitAllowDeny
      ('Migrate backend groups "explicit_allowdeny" field to
      simplified format') returns Symfony formatted error messages
      for specific single rows.
      
      Before this patch, it was still reported as a successful
      migration, and the success message is formatted with
      "everything is great" green background, so that errors
      may not receive attention.
      
      This patch changes the wizard to return a failure state.
      This will then return the messages formatted as errors.
      
      Since the wizard migrates all rows (even the faulty ones),
      the wizard can then be re-executed to be marked as "done".
      
      This is not ideal, but because of the way Symfony
      output streams cannot reveal if they contain an error
      when the stream is retrieved, there is little other choice.
      
      Otherwise the Wizard API would need to receive a breaking
      API change to allow to carry additional meta information
      about "warnings" rather than just errors, which is
      beyond scope for current development state.
      
      Resolves: #104208
      Related: #104225
      Releases: main, 12.4
      Change-Id: Ibde1d977bc8747a053da1360aea6c0e3f8b77f7f
      Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84955
      
      
      Reviewed-by: default avatarStefan Bürk <stefan@buerk.tech>
      Tested-by: default avatarcore-ci <typo3@b13.com>
      Tested-by: default avatarStefan Bürk <stefan@buerk.tech>
      d45347cd