- Jul 09, 2024
-
-
Stefan Bürk authored
This change adds PHP8.4 as allowed version to the `Build/Scripts/runTests.sh` script as preparation to validate and check the Core and 3rd party libs with PHP8.4 locally. Note that unit tests already revealing deprecation and errors for 3rd party extension which can now be reported and for checked upstream updates. Resolves: #104337 Releases: main, 12.4, 11.5 Change-Id: I76d3e37b393c347173fcdbe874d6a0737fb76d33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85179 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
-
Daniel Siepmann authored
The menu generation must not reuse the page record from the current page but must use the data from the linked page. This got already fixed for #101883. But that fix didn't take into account that ->createLink() might throw an exception. This is now considered and the state is properly re- initialized also on exceptions. Resolves: #104335 Related: #103582 Related: #101883 Releases: main, 12.4 Change-Id: Ib4c1f1fba68a83dca32a9ffd7ee14c31cf60bab5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85177 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Oliver Hader authored
Change-Id: I72e06646233894cfbd8017bef8a5620e17caf32a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85174 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Oliver Hader authored
Change-Id: I20500c48221bf14b56baef7551a423571883c6a9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85173 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Andreas Kienast authored
This commit fixes the event binding on the "Close" action to trigger the correct actions when e.g. the icons within the buttons are clicked. Resolves: #104333 Releases: main, 12.4 Change-Id: I448c0b68de376a1b0e8517cc58c5bf2d2576b662 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85172 Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
-
- Jul 08, 2024
-
-
Georg Ringer authored
Version 7.15 officially supports TypeScript 5.5, which we use since #104189 and therefore eliminates a build-time warning. Also update TypeScript from 5.5.2 to 5.5.3, while at it. Executed commands: npm install --save-dev \ @typescript-eslint/eslint-plugin@^7.15 \ @typescript-eslint/parser@^7.15 \ @typescript-eslint/typescript-estree@^7.15 \ typescript@^5.5.3 npm run build-js Resolves: #104317 Related: #104189 Releases: main, 12.4 Change-Id: Ibe242b42ecf9c5e986217a85283174220ae18bc3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85151 Tested-by:Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Loek Hilgersom authored
Fixes exception in impexp when an extension does not have a value for TCA[tableName][ctrl][rootLevel] Resolves: #104308 Releases: main, 12.4, 11.5 Change-Id: Ia2b8095c35ba6b07827525a65e0dcbb6fa1d060e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85154 Tested-by:
-
- Jul 07, 2024
-
-
Garvin Hicking authored
Similar to #104228 there was another place where the 'actiontype' array key of a history record was checked for 'BE' context, instead of the proper 'usertype'. There should now be no more remaining instances of core usage for 'actiontype' with a 'BE' check. Resolves: #104314 Related: #104228 Related: #98024 Releases: main, 12.4 Change-Id: I1833929d16ecef937ba260fe498e9abdee94b9c9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85144 Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
-
- Jul 05, 2024
-
-
Oliver Bartsch authored
The debug information of each element in FormEngine now displays the correct field names for FlexForm fields in a container. Additionally, do the container elements itself display the correct (field) name now. Resolves: #104303 Releases: main, 12.4 Change-Id: Ic2a92bc0deea4b3165f4aa77103c56050cb3dc63 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85109 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
- Jul 04, 2024
-
-
Guido Schmechel authored
An example for the addition of multiple CSS classes to editor.config.style will be added to the existing RST files. Resolves: #104310 Releases: main, 12.4 Change-Id: I8a77aae8c402608857b3b7ea690da23f4f8134c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85113 Tested-by:
-
Georg Ringer authored
Use a local variable to remember the path of a file before it is moved and use that in the flash message and log. Resolves: #104194 Releases: main, 12.4 Change-Id: Ib13eb28e5d8674ce1fe3df0ab29a9cd5c3b72c78 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85112 Tested-by:
-
- Jul 03, 2024
-
-
Garvin Hicking authored
It is possible in Flexform containers to set a XML configuration that uses the same input field names, but within different sheets. The `FlexFormSectionContainer::render()` method used a HTML DOM id attribute that did not consider the Flexform sheet name, which has lead to the same id attribute being re-used. The JavaScript events (add and delete items from a container) would then fire only on the first instance, but as many times as there were wrongly regarded "duplicate" containers using the same id. This fix introduces another identifier section to the id attribute, containing the Flexform sheet name. This XML attribute is compatible with allowed CSS class names, so no further escaping is done with it, similar to the use of `$flexFormFieldName`. Resolves: #97042 Related: #99947 Releases: main, 12.4 Change-Id: Ic1c81c658b090cb7b9c1a4230c0b4e75c12560dc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85097 Tested-by:
-
- Jul 02, 2024
-
-
Stefan Bürk authored
This change modifies the `php-cs-fixer` ruleset and activate two rules related to nullable types. Following options are added: 'nullable_type_declaration' => [ 'syntax' => 'question_mark', ], 'nullable_type_declaration_for_default_null_value' => true, `nullable_type_declaration` ensures to use `?<type>` declaration instead of union type `<type>|null` as a convention for properties, method and return types. For already union types the nullable is added as additional null union type `ObjectOne|ObjectInterface|null`. `nullable_type_declaration_for_default_null_value` ensures to use nullable type declarations to mitigate implicitly nullable method arguments [1] which has been already fixed with a series of dedicated changes. Used command(s): Build/Scripts/runTests.sh -s cgl [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #103751 Releases: main, 12.4, 11.5 Change-Id: Ia790a6757c5fbe92da45298333037c5b5d36575d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85089 Tested-by: -
Georg Ringer authored
Instead of showing outdated versions above the listing of wizards, use the actual version. Resolves: #104289 Releases: main, 12.4 Change-Id: Ife6486978010a7e4b85238722125734abd9c6082 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85087 Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null type to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104284 Releases: main, 12.4, 11.5 Change-Id: Iadea4cde1d3b80962a47ffa4c183a885504bef6b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85053 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- Jul 01, 2024
-
-
Garvin Hicking authored
When multiple crop variants are defined (for example in EXT:styleguide "Form engine elements - imageManipulation" for "crop_5" with "mobile" and "desktop), the currently selected aspect ratio and the size of the cropping box was only computed based on the first crop variant. This patch uses a wrapping container for each variant and adjusts the JavaScript to operate on that context. The information for the current cropping box size is now also based on this context. Resolves: #103879 Releases: main, 12.4 Change-Id: I38e235ddb5ed5f7463a5f0931608944326097f9f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84963 Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null type to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104278 Releases: main, 12.4, 11.5 Change-Id: Ia3a4bc344b369b8697c88ed14ac06354dd988dce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85041 Tested-by:
-
Christian Reifenscheid authored
This commits adds the following hints: * module classes needs to be set to public * module classes needs to implement the ShortInfoProviderInterface * description on how to add custom page settings * description on how to add custom module settings Resolves: #104242 Releases: main, 12.4 Change-Id: Id495359e007bf09e38a80bc1097c95946f964217 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84962 Tested-by:
-
Stefan Bürk authored
Apply the latest rules of php-cs-fixer for both fixer (code and header-comment) also in the `Build/Scripts` folder. The Build folder is now added to the usual php-cs-fixer execution for code and header fixer scripts to avoid code style drifitng in this folder for the future. Used command(s): Build/Scripts/runTests.sh -s cgl ; \ Build/Scripts/runTests.sh -s cglHeader Resolves: #104274 Releases: main, 12.4, 11.5 Change-Id: I7977e2254b9e271c45b840c6696cd7600ab0b1aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85035 Reviewed-by:Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Christoph Lehmann authored
When the record does not exist anymore, then the FlexForm definition might also not exist anymore (imagine a removed plugin) and it results in an Exception. Resolves: #102656 Releases: main, 12.4 Change-Id: I3eac287a50366ae8ca66416080738634eb65ae97 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84643 Tested-by:
-
- Jun 30, 2024
-
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null type to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104263 Releases: main, 12.4, 11.5 Change-Id: I7f132b2d3f7df9ba620b26656bbfca7fd038f32a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85014 Reviewed-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null type to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104265 Releases: main, 12.4, 11.5 Change-Id: Ifb6887a9fc77bc74c2d287b34a6876cc5da477da Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85020 Reviewed-by:
Mogens Fiebrandt <mogens.fiebrandt@googlemail.com> Tested-by:
-
Garvin Hicking authored
In the Admin Tools > Settings > Extension Configuration module, extensions can provide a ext_config_template.txt file. Comments inside that file dictate where and in which order a configuration option is listed. The syntax is: ``` # cat=SomeCategory//0; type=boolean; label=some config bar = 0 # cat=SomeCategory//1; type=boolean; label=other config baz = 0 ``` The parsing routine however could not properly deal with "0" entries for the input element order because checking this was using an "falsy" statement instead of allowing also "0" as a string. In this case, such a zero-based config element was not displayed. This is fixed, and an example is added to the EXT:styleguide extension configuration. Note that the error would not cause problems when either: * Another category assignment of another input element took place before, thus properly initializing the sort ordering. * The key did not use "0" as a sorting index, but anything non-falsy. * The string "cat=SomeCategory//0" was replaced with "cat=SomeCategory/0" (thus having an unset sorting key). Resolves: #102760 Related: #97816 Releases: main, 12.4 Change-Id: I6954bcf8f840d9e45372fc8fa8099381ce2b8b76 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85027 Reviewed-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null type to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104266 Releases: main, 12.4, 11.5 Change-Id: I731d63dbbb13df6b3e0b6f40641ac0a98e92519f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85023 Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null type to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104264 Releases: main, 12.4, 11.5 Change-Id: I64badf36faf69bc84f622cc9e7d5c1949c928ff1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85017 Tested-by:
-
David Mellen authored
This commit allows to use environment variables in YAML keys as well. Resolves: #99889 Releases: main, 12.4 Change-Id: I1e0272aade1188a483089412156c18e291d1ffbc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84961 Tested-by:
-
- Jun 29, 2024
-
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null type to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104250 Releases: main, 12.4, 11.5 Change-Id: Ic0842784b1a647fbde6e0472a8efef934ce03663 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85005 Tested-by:
-
Garvin Hicking authored
When the TCA type "group" or "folder" is rendered in FormEngine, under certain circumstances the HTML structure would close add `<div>` elements without opening those first. This will lead to a record not being editable, because variables are wrongly transferred due to the browser-rendering of wrong HTML nesting levels. This behaviour is an edge case and only happens with this TCA configuration: * either `config[hideMoveIcons]` is set to `true` * or `config[hideDeleteIcon]` is set to `true` Resolves: #98436 Releases: main, 12.4, 11.5 Change-Id: Ibb28c6130051b3dae92b3285df0831e84634e210 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84960 Tested-by:
-
- Jun 28, 2024
-
-
Torben Hansen authored
With symfony property-info 7.1.2, the type resolving for collections has been hardened. https://github.com/symfony/property-info/commit/d0bbc495f11ab99a1e2cbf04699331b88b3c1293 Our extbase ObjectConverter test for collections uses an anonymous class with an ObjectStorage property. The annotation for the property as well as the native property type is however not a FQCN. So the anonymous class has no information about, what FQCN the `ObjectStorage` class is. The change adds the FQCN for the ObjectStorage in the anonymous class, which resolves the failing test, and adds a test with a non-anymous class to test short namespaces still work. Resolves: #104254 Releases: main, 12.4, 11.5 Change-Id: Idc64e2533e0bc6d2dccc9724643247772f4f5d11 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85001 Tested-by:
-
Christian Kuhn authored
Resolves: #104249 Releases: main, 12.4 Change-Id: I2e56c967ab27ddc855261ff53f654d5916f3dce6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84999 Reviewed-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null tyype to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104247 Releases: main, 12.4, 11.5 Change-Id: I71d8f59eaba6dd22b00f8eb7400f2b49d748e430 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84991 Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null tyype to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104246 Releases: main, 12.4, 11.5 Change-Id: Id7713c10014da20bcd4e7976e64434c71d319bda Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84988 Reviewed-by:
-
Oliver Bartsch authored
Also adds the type to the corresponding test. Resolves: #104230 Releases: main, 12.4 Change-Id: Ica9e6b63d5a2fe52cc775642562cf8f9036db081 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84958 Tested-by:
-
Oliver Bartsch authored
Some FormEngine related JS components, e.g. the slug element rely on input and text fields to have the field name set via either the special `data-formengine-input-name` - if pointing to a hidden input field - or via the standard `name` attribute. All those FormEngine elements support the readonly state, which renders only the field with the `disabled` attribute set by omitting any JS functionality. For this use case no `name` attribute is required. However, to use them in combination with other fields, e.g. as generator field for TCA type slug, the field name is now added as `name` attribute in readonly state. Resolves: #104178 Releases: main, 12.4 Change-Id: Ibd28c563c8184078805a64aa123f86d538077180 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84959 Reviewed-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null tyype to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104238 Releases: main, 12.4, 11.5 Change-Id: I340f35379b74d1ca05527a6950eab5ba66ffaae6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84977 Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null tyype to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104237 Releases: main, 12.4, 11.5 Change-Id: Ieb8d05b2e44dc448f7a2142c5ad6a91e68cf98c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84974 Tested-by:
-
Georg Ringer authored
Provide an additional test to check for correct usage of numeric keys. Resolves: #94852 Releases: main, 12.4 Change-Id: I01c73fb3e1aa0f4d458e9d349484856cb416387d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84957 Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null tyype to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104236 Releases: main, 12.4, 11.5 Change-Id: Iba5e99b526ca37d7bb36044cd6ee1027b6c5245a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84951 Tested-by:
-
Garvin Hicking authored
Currently only `siteLanguage` was documented as usable, now also `site` is explained with the most common public getter methods and an example. Resolves: #99723 Releases: main, 12.4 Change-Id: I8cb6de70b481322c31bd6fa7b3319c74f8af517a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84956 Reviewed-by:
-
- Jun 27, 2024
-
-
Garvin Hicking authored
The migration wizard BackendGroupsExplicitAllowDeny ('Migrate backend groups "explicit_allowdeny" field to simplified format') returns Symfony formatted error messages for specific single rows. Before this patch, it was still reported as a successful migration, and the success message is formatted with "everything is great" green background, so that errors may not receive attention. This patch changes the wizard to return a failure state. This will then return the messages formatted as errors. Since the wizard migrates all rows (even the faulty ones), the wizard can then be re-executed to be marked as "done". This is not ideal, but because of the way Symfony output streams cannot reveal if they contain an error when the stream is retrieved, there is little other choice. Otherwise the Wizard API would need to receive a breaking API change to allow to carry additional meta information about "warnings" rather than just errors, which is beyond scope for current development state. Resolves: #104208 Related: #104225 Releases: main, 12.4 Change-Id: Ibde1d977bc8747a053da1360aea6c0e3f8b77f7f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84955 Reviewed-by:
-
